From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8BE6C3F2CE for ; Tue, 17 Mar 2020 11:45:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D666206EC for ; Tue, 17 Mar 2020 11:45:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="t8oTFxnl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D666206EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3926D6B0005; Tue, 17 Mar 2020 07:45:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31B0D6B0006; Tue, 17 Mar 2020 07:45:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E30E6B0007; Tue, 17 Mar 2020 07:45:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 0240B6B0005 for ; Tue, 17 Mar 2020 07:45:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B564F824556B for ; Tue, 17 Mar 2020 11:45:55 +0000 (UTC) X-FDA: 76604675070.12.army08_50d30bdacd923 X-HE-Tag: army08_50d30bdacd923 X-Filterd-Recvd-Size: 3565 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Mar 2020 11:45:55 +0000 (UTC) Received: by mail-io1-f45.google.com with SMTP id h8so20614622iob.2 for ; Tue, 17 Mar 2020 04:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dUQX8mFk3gSlBbscD/fDRe/11PYGyXL/SKXh6MlIM2I=; b=t8oTFxnlKiNsNwIGO46DVvIsUdMcJk/CBjPchswlZgkJ+uCzem/a5y7p0j2X/O6zFN IH4qXVogDVQMS6CZy/Kc1B0gq9zQ/nNrkB6raK4JhJEyqqT/6qorhXtpj8KSnXgzyRRS hDIMroxkdnSjoousQu2w/GjfU0Hal+AG69C7L65s7NkTQuudHkfsqURN5Kx6ER7tZLGW 1cn2duSBVpNQJG/SS11I7ydlzOK0lNYZofRJuzLoCwrcPSPzh0jkO1tofwXdSsn+P7yu eDML9HrSIH17ztLFQasZS9se+aod8L6bPEh5CURXWfha6l6uhZpEKzFAl0inBwlBjCYl VdOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dUQX8mFk3gSlBbscD/fDRe/11PYGyXL/SKXh6MlIM2I=; b=PzwecC6qMr6PKo2i0okb0sTD4p4msm+BDn725E3NuvHXjB+Mv5Gjy9pdnwwEKyGA/b aQzaQozXFgmBgMCDvPepZ55tcPg4yW3O/iXdT55LIkBAIQvAohNO3YtR+B+PBmgPCtjm 1HR9NH19GVdBhv5luJ04ULS2sbJ86aAb2c9FswcxSNArKjeVXD6a+YACRhKluO1MkWU3 Q6DUeoMx+FIcUrwp9C1axBuEm/3FSxS7h3bIL7H/H6WkFs2yoU9QGZHssZoNLEkveTDW Fe447DlGhVqaaVRQp+B1brmekeRYrGPzRNYbANsymObDKn30Ecq9W7cN5eoULmR6VbsS mmFw== X-Gm-Message-State: ANhLgQ0zABKKrQTos9HM8ScZb8w4OA9rP1vvh40TK++xQdEbO5/Spfw1 AOWMYaH//sfCz7TIXMKuB82kQRSUFqJ8yt/XOxcU X-Google-Smtp-Source: ADFU+vshpj0Df//ICe0Enba/8npBTFZ/FxObABwKeNow8CH/ZtRVvf+L6Zfy7C8OdR9BcmQFkFFts3XslqikzrFUNNQ= X-Received: by 2002:a6b:c8d4:: with SMTP id y203mr3627684iof.111.1584445554704; Tue, 17 Mar 2020 04:45:54 -0700 (PDT) MIME-Version: 1.0 References: <1584333244-10480-1-git-send-email-kernelfans@gmail.com> <1584333244-10480-3-git-send-email-kernelfans@gmail.com> <20200316085536.GB1831@infradead.org> In-Reply-To: <20200316085536.GB1831@infradead.org> From: Pingfan Liu Date: Tue, 17 Mar 2020 19:45:42 +0800 Message-ID: Subject: Re: [PATCHv6 2/3] mm/gup: fix omission of check on FOLL_LONGTERM in gup fast path To: Christoph Hellwig Cc: Linux-MM , Ira Weiny , Andrew Morton , Mike Rapoport , Dan Williams , Matthew Wilcox , John Hubbard , "Aneesh Kumar K.V" , Shuah Khan , Jason Gunthorpe , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 4:55 PM Christoph Hellwig wrote: > [...] > > Wrong indentation. We either align two tabs for continuation > statements, or after the opening brace of the previous line. With a > likely or unlikely thrown in the former IMHO looks much better. E.g. > > if (unlikely(flags & FOLL_LONGTERM) && > is_migrate_cma_page(page)) > return NULL; > OK, thanks. I will send out V7 to fix it. Regards, Pingfan