From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9794EC433B4 for ; Tue, 13 Apr 2021 13:38:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D08560FDA for ; Tue, 13 Apr 2021 13:38:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D08560FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C0F406B0036; Tue, 13 Apr 2021 09:38:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBE506B006E; Tue, 13 Apr 2021 09:38:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A37D36B0070; Tue, 13 Apr 2021 09:38:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 863CA6B0036 for ; Tue, 13 Apr 2021 09:38:21 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 376FCC8CF7 for ; Tue, 13 Apr 2021 13:38:21 +0000 (UTC) X-FDA: 78027448002.29.AC42720 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf30.hostedemail.com (Postfix) with ESMTP id 22F09E000113 for ; Tue, 13 Apr 2021 13:38:11 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id lr1-20020a17090b4b81b02900ea0a3f38c1so1344102pjb.0 for ; Tue, 13 Apr 2021 06:38:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T4KQV/ILjRTEfyafvtEHPuCHBxuKBEtFSnUjDG/AUJY=; b=LRl/SL/aIqmiPGiXJhkTeFiqZl5rAFxiuuYnIo0o+91zpyoyM/3pk1WUq/ceE8wHVg Va3g4x5JTroA6yrSnk6k/bjlntw/rOpNf5pefyCNQxHhr646Uqm2x37fEnxUrc8ZJJEh DNh8ro49tB8qGhIhTlkAgRS9RawM8wpDRcfeAVhSxkN/NydR4gU6bA5+HTsLn/nK02Bf JQn9SwpukiFk3KMFuusMu7YxmPUIUU8p9x4Qloz1kof8YUuSuqRMO+ZiCEr4UDcH/EAf wa7afwROoSGs55fgqE/xIRyGjypmOp+ErShwWM3ltKGhEQ9zFGCi6RXajkd0yl70UZZB FJXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T4KQV/ILjRTEfyafvtEHPuCHBxuKBEtFSnUjDG/AUJY=; b=ZKEUJCvJEEj+g/YJheY2MsiN64c8tv/A8Zwu5ME8g48p8RcMiIqfwFyW86mvsxoXZh n5WsJN2wEb/FpCm0SNop2bVPOsPvW2xBFn2uG+fiQ3cLZzog/sN/NpZhcTOm+3dKTtfy MpgJFBeymo1XNBU3+1H+IGQiQCBXN5VA0SkB6+dsbj8p3XfVysuus7FFfbGc6mAJWIPv 6DWp6iR5TcK0w8LrhG8qeUxMytma+cJlkSrWhwLzvy4ZTZMUWyI+O+IWLEZbMa4Btjm3 kmqq/SSbjNbznCx/eE/yYScFZRZ0BQ4AFYF1eePe1pIyI20vzLRYw8Mhvkn3eut54/L2 281Q== X-Gm-Message-State: AOAM532AtS9fU8s5SGKTAM7C/77rPRNWHXNyWd91/kmZqS7TCy3ytdJi 7FQROthzgKoDwHyda51XqeNnoP8nYD8mJLpn7BMhjg== X-Google-Smtp-Source: ABdhPJy3erD4NrMg9buPu1C82No9WBmEROMMv5BZtjApOeMIRDJDDeVNReF/QbLgMHDfVo0FPcRzzXCv/SRDwqhLhKk= X-Received: by 2002:a17:90a:6a05:: with SMTP id t5mr115117pjj.20.1618321099705; Tue, 13 Apr 2021 06:38:19 -0700 (PDT) MIME-Version: 1.0 References: <20210413100747.4921-1-glittao@gmail.com> In-Reply-To: <20210413100747.4921-1-glittao@gmail.com> From: Brendan Higgins Date: Tue, 13 Apr 2021 06:38:08 -0700 Message-ID: Subject: Re: [PATCH v4 1/3] kunit: make test->lock irq safe To: glittao@gmail.com Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , KUnit Development , Linux Memory Management List , Marco Elver , Daniel Latypov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 22F09E000113 X-Stat-Signature: xdgihbxw55s7upbxp7sdr7ae8etdojie Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mail-pj1-f52.google.com; client-ip=209.85.216.52 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618321091-724706 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 13, 2021 at 3:07 AM wrote: > > From: Vlastimil Babka > > The upcoming SLUB kunit test will be calling kunit_find_named_resource() from > a context with disabled interrupts. That means kunit's test->lock needs to be > IRQ safe to avoid potential deadlocks and lockdep splats. > > This patch therefore changes the test->lock usage to spin_lock_irqsave() > and spin_unlock_irqrestore(). > > Signed-off-by: Vlastimil Babka > Signed-off-by: Oliver Glitta Reviewed-by: Brendan Higgins Thanks!