From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78112C433B4 for ; Fri, 2 Apr 2021 09:38:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D93B610A5 for ; Fri, 2 Apr 2021 09:38:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D93B610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 901D88D0002; Fri, 2 Apr 2021 05:38:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B1A36B0072; Fri, 2 Apr 2021 05:38:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7519C8D0002; Fri, 2 Apr 2021 05:38:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 527426B0071 for ; Fri, 2 Apr 2021 05:38:38 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0C66D1801C40F for ; Fri, 2 Apr 2021 09:38:38 +0000 (UTC) X-FDA: 77986927116.38.6174E1B Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf09.hostedemail.com (Postfix) with ESMTP id D0A5E6000109 for ; Fri, 2 Apr 2021 09:38:36 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id k8so3267001pgf.4 for ; Fri, 02 Apr 2021 02:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TCYt8AyoLESpC6wcEtE5CllNvHeSvHW195OfYbQzzA0=; b=OLoCUBIJIt5VGQ3Wvhu+rs3rDbrwCUr3Mvq24JYcmyXBl+lgICsY98zNmsJX7m95V4 AmYY7KAtHw63NvsBi0ksSAMueLw9ipOktRhmsdiCNPtBgZf5gymjSKmpZhRpN0TReI4M azYs2HFSaeItGRGWXzdpxUxABQ3myTngbNZ+9HhEFlsubLZNsqIAU2fRlsDTliLN5Rkz 1QuUMu+y6trQoykF7D6C3pp6MOM7Q/E0Zt49lgnvNujDydXsUv7jbyK8q+YUpPIp8ZHe 4ECJ8spVnR1STEifrdR3J3UI40q5BOx3mpagJuPSvxAgkZOujudUbYxA6SJw500ehK2x SP8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TCYt8AyoLESpC6wcEtE5CllNvHeSvHW195OfYbQzzA0=; b=h9MMD+4V3lOHgv/JyOJoBss1Hzy5uPZ1nMeRz5I6D+EHjBUCjEeLY6pfJT4bY/PYlH ckaTcJP/H2yIWDFdNpVnh5Yj3m7klTTfvG83e0aNnXJeI2MEMFdwCPgCvX5hc2MeIJzG iFi2hOBJ3s6DDWqwSYwxkQvU7Tn89ikS2mDxzU+B7JXklDa1+HT/atAlGRaVvRbF3xz9 n8PZQGqbwbqaJMMTDo+KmHzDWh/jIqz5efjSncvFjlfEpM8t0lxUy60DNoTUOri4IWRT HRha63V8UiVEma+DfTRyzoLdh2m4gIb4vXGGDJ4+QDF2SklY9uWXuVWaAFNgTuoMzCgA XT4g== X-Gm-Message-State: AOAM530yHJY1ldxX/ocZVSGLKK/5niTI4Sr95bR/19B50HigmJ36PwTt jUywRC5Gk/hTr1DWVB4XrouvQtYYdKX5PizyfQtaeA== X-Google-Smtp-Source: ABdhPJxuU4DZ10EV1TbNi6URByJ3kNd7ZsEQOL6TH6BdZr9sN1GV2yWW2N8hSiJGHsvrvdzzaezSPFwLRA2947Ypyyw= X-Received: by 2002:aa7:9619:0:b029:1fa:ed79:b724 with SMTP id q25-20020aa796190000b02901faed79b724mr11348345pfg.38.1617356316475; Fri, 02 Apr 2021 02:38:36 -0700 (PDT) MIME-Version: 1.0 References: <20210331085156.5028-1-glittao@gmail.com> In-Reply-To: From: Brendan Higgins Date: Fri, 2 Apr 2021 02:38:25 -0700 Message-ID: Subject: Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality To: Daniel Latypov Cc: Marco Elver , glittao@gmail.com, cl@linux.com, penberg@kernel.org, David Rientjes , iamjoonsoo.kim@lge.com, Andrew Morton , Vlastimil Babka , Linux Kernel Mailing List , linux-mm@kvack.org, KUnit Development Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D0A5E6000109 X-Stat-Signature: sj7s1im84fcqn1igw8tkes7egqjpo394 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-pg1-f172.google.com; client-ip=209.85.215.172 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617356316-167067 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 1, 2021 at 12:04 PM 'Daniel Latypov' via KUnit Development wrote: > > On Thu, Apr 1, 2021 at 2:16 AM 'Marco Elver' via KUnit Development > wrote: [...] > > #else > > static inline bool slab_add_kunit_errors(void) { return false; } > > #endif > > > > And anywhere you want to increase the error count, you'd call > > slab_add_kunit_errors(). > > > > Another benefit of this approach is that if KUnit is disabled, there is > > zero overhead and no additional code generated (vs. the current > > approach). > > The resource approach looks really good, but... > You'd be picking up a dependency on > https://lore.kernel.org/linux-kselftest/20210311152314.3814916-2-dlatypov@google.com/ > current->kunit_test will always be NULL unless CONFIG_KASAN=y && > CONFIG_KUNIT=y at the moment. > My patch drops the CONFIG_KASAN requirement and opens it up to all tests. > > At the moment, it's just waiting another look over from Brendan or David. > Any ETA on that, folks? :) I just gave a "Reviewed-by" and sent it off to Shuah. Should be available in 5.13. Cheers