From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B04DC433F5 for ; Thu, 10 Mar 2022 08:10:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7E848D0005; Thu, 10 Mar 2022 03:10:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B03618D0001; Thu, 10 Mar 2022 03:10:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F3178D0005; Thu, 10 Mar 2022 03:10:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 890BB8D0001 for ; Thu, 10 Mar 2022 03:10:34 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 760B01203C0 for ; Thu, 10 Mar 2022 08:10:34 +0000 (UTC) X-FDA: 79227754788.14.3559699 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf16.hostedemail.com (Postfix) with ESMTP id D5EF718000B for ; Thu, 10 Mar 2022 08:10:33 +0000 (UTC) Received: by mail-ej1-f47.google.com with SMTP id kt27so10427871ejb.0 for ; Thu, 10 Mar 2022 00:10:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ig5zBgV9456yZCmUhF8sBV7DGvRjdoa/kYWf35qIWfM=; b=gPCSxtOtkcm9lBcjKc3oEYW0bwIOPUjo/9v8mv6bIvRIKpp5KNbPSY1T5xU3ivvuVN k+xyt8opyuQ3TJKg2sQUmD4PPlOP3IT7LQammSIoRfwRLzXbtMlA2VGubvJPWKUES4Gg aAKRsund5DIxnpC/4Etq+A4zKMFKOcBjfGEdc0i5tlN9SpgaDe1HNoH9sXxEfXph7ajw 8K7xkbSrZj8vk3LWmiUuqrY2Omeu4u+mPdl/6uje+nXWagXWGflDpRpXvXDJvy9R+LXz x98cLR7hdd8fXjQy1/ZbXP7eLvEqR4tL+4apb5i8ArRvmDDNc7UYYskI0kXNcpZW+cI4 VKQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ig5zBgV9456yZCmUhF8sBV7DGvRjdoa/kYWf35qIWfM=; b=QLJgbqSCFg2wZtc+hOGxIL1RztffYzoxyqh48FTqxRERpgO5ejrxaXHQdGh/UJ3Vw0 SVUXj+l9/02bDeGHp3fEEndH8k8Cby7e9lSVYnl2P0Q0SfsHWRvW/cJHpIUsMCcpTGKJ UEBLwLynob2PTWFwC6N2sWTN58VMkorjEPDwV/Fi+E+0GR+sDl6kIZXkiDtn9JsdkLW5 6+g6IICtZEX8z3GOQAw3IUulvOEttyrOlHGsgwJHO30pK95vv7kl35gNjAliCFf1ryh8 PcA47OLzT+WWbFT6W0Ka/FUh9Y/5SGOje1y1PPhHa6jWt/UuWUuqYa/4LK0JKDbb+9SE AJ7g== X-Gm-Message-State: AOAM530LAnUm9hcAPgoM5l99S8eMfWTLlgztFIW8fmkL8U3+heKcUEdR 7Uo8JkRCrVB863ZZpOehCWw7n16Py++hd68UkFBZPw== X-Google-Smtp-Source: ABdhPJwWjyB4q5JB3+aDamJ9NuChwaNJ1qU/nXjWsKLHQQ+N2KuIi2D9W0C1teF+lT6fDaFrqnctNJAMDW7/NepL5GQ= X-Received: by 2002:a17:906:2899:b0:6d6:e479:1fe2 with SMTP id o25-20020a170906289900b006d6e4791fe2mr3156352ejd.394.1646899832564; Thu, 10 Mar 2022 00:10:32 -0800 (PST) MIME-Version: 1.0 References: <20220309083753.1561921-1-liupeng256@huawei.com> <20220309083753.1561921-3-liupeng256@huawei.com> In-Reply-To: <20220309083753.1561921-3-liupeng256@huawei.com> From: Brendan Higgins Date: Thu, 10 Mar 2022 03:10:21 -0500 Message-ID: Subject: Re: [PATCH v2 2/3] kunit: make kunit_test_timeout compatible with comment To: Peng Liu Cc: glider@google.com, elver@google.com, dvyukov@google.com, akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D5EF718000B X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=gPCSxtOt; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of brendanhiggins@google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=brendanhiggins@google.com X-Stat-Signature: icfjuw3g9pqwrq4uax5rb6gmccbkna6i X-HE-Tag: 1646899833-313995 X-Bogosity: Ham, tests=bogofilter, spamicity=0.096678, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 9, 2022 at 3:19 AM 'Peng Liu' via KUnit Development wrote: > > In function kunit_test_timeout, it is declared "300 * MSEC_PER_SEC" > represent 5min. However, it is wrong when dealing with arm64 whose > default HZ = 250, or some other situations. Use msecs_to_jiffies to > fix this, and kunit_test_timeout will work as desired. > > Fixes: 5f3e06208920 ("kunit: test: add support for test abort") > Signed-off-by: Peng Liu Reviewed-by: Brendan Higgins