From: Brendan Higgins <brendanhiggins@google.com>
To: Peng Liu <liupeng256@huawei.com>
Cc: glider@google.com, elver@google.com, dvyukov@google.com,
akpm@linux-foundation.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
wangkefeng.wang@huawei.com
Subject: Re: [PATCH v2 2/3] kunit: make kunit_test_timeout compatible with comment
Date: Thu, 10 Mar 2022 03:10:21 -0500 [thread overview]
Message-ID: <CAFd5g44MbyK1Dg1yc=tMys_GPri+kjLO+2Kahv0rYEcp=+JP0A@mail.gmail.com> (raw)
In-Reply-To: <20220309083753.1561921-3-liupeng256@huawei.com>
On Wed, Mar 9, 2022 at 3:19 AM 'Peng Liu' via KUnit Development
<kunit-dev@googlegroups.com> wrote:
>
> In function kunit_test_timeout, it is declared "300 * MSEC_PER_SEC"
> represent 5min. However, it is wrong when dealing with arm64 whose
> default HZ = 250, or some other situations. Use msecs_to_jiffies to
> fix this, and kunit_test_timeout will work as desired.
>
> Fixes: 5f3e06208920 ("kunit: test: add support for test abort")
> Signed-off-by: Peng Liu <liupeng256@huawei.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
next prev parent reply other threads:[~2022-03-10 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 8:37 [PATCH v2 0/3] kunit: fix a UAF bug and do some optimization Peng Liu
2022-03-09 8:37 ` [PATCH v2 1/3] kunit: fix UAF when run kfence test case test_gfpzero Peng Liu
2022-03-09 10:03 ` Marco Elver
2022-03-10 8:08 ` Brendan Higgins
2022-03-09 8:37 ` [PATCH v2 2/3] kunit: make kunit_test_timeout compatible with comment Peng Liu
2022-03-09 10:04 ` Marco Elver
2022-03-09 13:53 ` Daniel Latypov
2022-03-10 8:10 ` Brendan Higgins [this message]
2022-03-09 8:37 ` [PATCH v2 3/3] kfence: test: try to avoid test_gfpzero trigger rcu_stall Peng Liu
2022-03-09 8:31 ` Marco Elver
2022-03-10 8:07 ` [PATCH v2 0/3] kunit: fix a UAF bug and do some optimization Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd5g44MbyK1Dg1yc=tMys_GPri+kjLO+2Kahv0rYEcp=+JP0A@mail.gmail.com' \
--to=brendanhiggins@google.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liupeng256@huawei.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox