> On 7 Nov 2014, at 01:46, Jeff Moyer <jmoyer@redhat.com> wrote:
> Minor nit, but I'd rather read something that looks like this:
>
>       if (type == READ && (flags & RWF_NONBLOCK))
>               return -EAGAIN;
>       else if (type == WRITE && (flags & RWF_DSYNC))
>               return -EINVAL;

But your version is less logically efficient for the case where "type == READ" is true and "flags & RWF_NONBLOCK" is false because your version then has to do the "if (type == WRITE" check before discovering it does not need to take that branch either, whilst the original version does not have to do such a test at all.