From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EEF9C77B75 for ; Wed, 19 Apr 2023 11:28:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52E678E0002; Wed, 19 Apr 2023 07:28:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B7168E0001; Wed, 19 Apr 2023 07:28:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 357C98E0002; Wed, 19 Apr 2023 07:28:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1FFC08E0001 for ; Wed, 19 Apr 2023 07:28:10 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DE0CFA01F5 for ; Wed, 19 Apr 2023 11:28:09 +0000 (UTC) X-FDA: 80697916698.27.AAD85CA Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf25.hostedemail.com (Postfix) with ESMTP id CF15AA0011 for ; Wed, 19 Apr 2023 11:28:07 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linuxtx.org header.s=google header.b=h+3Tomy+; spf=pass (imf25.hostedemail.com: domain of jmforbes@linuxtx.org designates 209.85.218.47 as permitted sender) smtp.mailfrom=jmforbes@linuxtx.org; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=fedoraproject.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681903688; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8N99yfKqkNg/PzVluqPrnuo7/UXaVkUZ4pARZeRWAW0=; b=alhAYPRMLDCybyToy/VLtP+WfbNFk4erZgQcLsTg/9mBJaq0EwWqYp4YwovlI8SOUHEgVq 7Sl/xE1/mM/UDQnDETmchZYrVn3dY3bVaw9puIeu5YPQBn/4d7eEo9ktI7IwrAjpLnTVKZ TugvsR4/YJY8kLCWAKQXjpGbQt6X5zU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linuxtx.org header.s=google header.b=h+3Tomy+; spf=pass (imf25.hostedemail.com: domain of jmforbes@linuxtx.org designates 209.85.218.47 as permitted sender) smtp.mailfrom=jmforbes@linuxtx.org; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=fedoraproject.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681903688; a=rsa-sha256; cv=none; b=PKIjL2rtNecUolvsyi24Ss6KikB9ExRwBvfRJwuemJmGbq7shLVrVoijLGfy0WOfY4VF2y ZAVxwvsctyd3KwTppHRycNJ81m8rwLkiTiw79rQ7on5lYCRVrNkG90f//2xkmA4tU1RSLn qcwH8KICyT4zvKZrvBec/EsCUi0Yw0g= Received: by mail-ej1-f47.google.com with SMTP id dm2so80867237ejc.8 for ; Wed, 19 Apr 2023 04:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxtx.org; s=google; t=1681903685; x=1684495685; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:sender:from:to:cc:subject:date :message-id:reply-to; bh=8N99yfKqkNg/PzVluqPrnuo7/UXaVkUZ4pARZeRWAW0=; b=h+3Tomy+fZrVXH6RN/babMfjC3kI4c/tjjs+upF4u2X/jkiM2Y88CL0+Ndyv402wRA ZN8jK2RJQPiW1OrNQGOz0lJxhdDo0VxjNTL6Wi/rxTAXStbwCZ3oB5IF1CRRLFVGQxbQ T9gYcbmXuvxaBPI1B259kNHR7vtJA9q3ZKhrI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681903685; x=1684495685; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8N99yfKqkNg/PzVluqPrnuo7/UXaVkUZ4pARZeRWAW0=; b=IiQhspmhhkgZK43ic1KGhayZMyHwMdxiDqc2Vc7q1sez/E8xrLiM6WgrS9A3E203W9 32CTZcatI3Gl9G+ql0wANLRhZpKhDeMTfHWZTHznzjYFEr4KwNtzF0gRxsltJNEV922M ayAMRSYi7caLHciV0eyGgKS/WILpKLPSKxqZtEzqyrQByuCC36WUY9dEVJUOiYlWm+3l RLy7/einbu9PSu8dFIpkITpkBNrU00TirqNfXeTq8fnxxYjxGPc928b/sHXcvLLQFFSb XCIcliaPg7EZzY9QViMHM9jwLie0zeOnLFZs1WAyvp7hjcbvUL++UfpfRPgB6XEMT4nP HUdQ== X-Gm-Message-State: AAQBX9f7grDyxUgNa0HHszYAmDhvOHXSU//BIDbrSZ83lFap1p9aoL2X JAVRLTVo8czEVsgcCl/QKKtfoQb4nzgMNtfWGjG9NvIp X-Google-Smtp-Source: AKy350Z235t6hpXpf4EwnUxBO7rY+bjtpNprSDSRa4d5qn1CZLtGnyBacsAhAAZKOgoQ0iKbkAyoGg== X-Received: by 2002:a17:907:6d27:b0:94f:4102:25c8 with SMTP id sa39-20020a1709076d2700b0094f410225c8mr13373788ejc.61.1681903685516; Wed, 19 Apr 2023 04:28:05 -0700 (PDT) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com. [209.85.208.41]) by smtp.gmail.com with ESMTPSA id s13-20020a1709060c0d00b0094e729d333fsm9197379ejf.222.2023.04.19.04.28.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 04:28:05 -0700 (PDT) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5068e99960fso3536509a12.1 for ; Wed, 19 Apr 2023 04:28:04 -0700 (PDT) X-Received: by 2002:a2e:7012:0:b0:2a5:fe8f:b314 with SMTP id l18-20020a2e7012000000b002a5fe8fb314mr1874851ljc.5.1681903663880; Wed, 19 Apr 2023 04:27:43 -0700 (PDT) MIME-Version: 1.0 References: <20230325060828.2662773-1-rppt@kernel.org> <20230325060828.2662773-3-rppt@kernel.org> <20230418150557.ea8c87c96ec64c899c88ab08@linux-foundation.org> In-Reply-To: From: Justin Forbes Date: Wed, 19 Apr 2023 06:27:31 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 02/14] arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER To: Catalin Marinas Cc: Andrew Morton , Mike Rapoport , Arnd Bergmann , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , John Paul Adrian Glaubitz , "Kirill A. Shutemov" , Max Filippov , Michael Ellerman , Rich Felker , Russell King , Will Deacon , Yoshinori Sato , Zi Yan , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CF15AA0011 X-Stat-Signature: 8zj13xtgdjut61ueawzzryqm8a7pnrcz X-HE-Tag: 1681903687-486300 X-HE-Meta: U2FsdGVkX1/HYWS2vk4SY6TNvfWeNJGwP320qUQPTusyIFuEWXUA3C3Gse+XnCdrQGpeh+DNECvVXdKA5eNfXQoQTkSuYklXwFmg+wRVFzeaNoEET70iE3BbC31fXqrVLDbAh2Uni/+hCvmhMnX+ujkVeLAY4O9gQsOmuqG7/VX1RfFmoaruTA3uzFaTp7tDFAoA3fSQcZijIiDGaYnN6GnT1VPWswWzTYq8YPNfyLRv9QDbRKVW+X3FZ3L+4TkHuLG1wIvHIubnQDLDW+3a6EIsbpvwHZF/hJGHWyZg5mGUzgSC+QzpNiXVnvJuuMzfQsmu3DT9gFseJhM0PbaoWBx/P3rYay8w9v61Me4EnbvyfFw5zEa7pekfRkKTNeNaeM3HzXx7kMF6eE4N8CsnY8A+q5iL5xPCjUzrvYsFHBfUSH+GOKYKuB+JDsayUepySdu6fgjxXLsJY+L0zXsdplpDVtvzwenI0jHMySaldVTdjrVxnIh/4w1Aq22Zil0UZj7MDZCNZ1H6NOjbc0ujE2DidKnvMOTW36GJ8Bp1b2Ri3tpOpVNxQpOsyzR7S2dFN8Jg+OsQ9i8rn0P9sBtoBSnQPksYLhky26P1xG2vMpSk1pTfgERqyANSerkiaDVsGo1vWokSLs2i6VFhBxmWttgm1rhBmVppK6nEbu5Ling8yfujjkds1oK7JGXgQwtKdEJt7AVWZWZYlE7s3MBGRxvIGOjAf65p46pNOK0L11zVRaO2tmc6fBBye9CBvDccWO0N/OiklDjFiAPxLqJNVa339ww0fD7ALL4lZXsmWC8MGGVJl04dSzDr6w1uSvPraMNPJjuzm5Htt4LST3kod+MuNdqAY0mWGevO7GOfzlwtsqImNocqwNoZInwx6cxrm2HEdLOTT0EzcEq4FaD49StH54ennIyONEUKKHtk1+jw+WWHh5spz2M1zai/Md8tueocgQyy6KNZOtjcPI8 vGvD3zLR BL60D6g1pIyuQf5h69/01S/9iTUg5aGZQExrure4BYlwITA+4Yj7BE5le+XcjZsLOemeTUWslI9I8gXPKQjsgUzGnijzvPWZb2nFaeJNlHy6ifMOwfQHnPFSEeGzFCgFdW8LwRaSXFlVnjB82BElFY1wxKSaYJ5wXZsecBeQWOX7e0yJW0PDABvui3fF2aHn0CtYg7l+Dwid5zzNQ2MH4OfIMK7Zbww67oWvmDauOLHEl5mjoBKDfP7UgPVxVlfbVYno726LOqozCNF5h/NdTDTy6EmEtW8xWTIclOvkcUTvbayGH+JfDja+UYi6l+2Ht2xSvJdBku/ToUAtBE7C+PCU5fjkAqvXqq8gnEcx+CBy48oCG4snKE/AibW5ilQCskLA28ZeGRZJNQ5Or84XgQe9kZg8psCxELiDwQoZz0Ydx9Z+Q9wq6pPwNucHCtEK71ZacwDO0SaQyRepEy5zmgCGkhhOg5gu5fRxg2qbRiEpPKVyRfeD5QbYqClw6SKUStFaE/bLQLX2SCh3+3LprUakEOppmSHByQYxW4c1EHaMmAdl9dQvxusDIJtwNfhYcVYk3PqSLqwpULqqtVn6I1BBsGrhdp2YEx0Z3qyAs4jNVIurMvcITaOFgDXnmLfABp05yd6JDKGWerd9wXwRt9rypR4sEKTDGh8XCvWZvE1feqJEuNY5vA1SC2hf4pZsS0MSke+nXrgYRRQc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 19, 2023 at 6:12=E2=80=AFAM Catalin Marinas wrote: > > On Tue, Apr 18, 2023 at 03:05:57PM -0700, Andrew Morton wrote: > > On Wed, 12 Apr 2023 18:27:08 +0100 Catalin Marinas wrote: > > > > It sounds nice in theory. In practice. EXPERT hides too much. When = you > > > > flip expert, you expose over a 175ish new config options which are > > > > hidden behind EXPERT. You don't have to know what you are doing ju= st > > > > with the MAX_ORDER, but a whole bunch more as well. If everyone we= re > > > > already running 10, this might be less of a problem. At least Fedor= a > > > > and RHEL are running 13 for 4K pages on aarch64. This was not some > > > > accidental choice, we had to carry a patch to even allow it for a > > > > while. If this does go in as is, we will likely just carry a patch= to > > > > remove the "if EXPERT", but that is a bit of a disservice to users = who > > > > might be trying to debug something else upstream, bisecting upstrea= m > > > > kernels or testing a patch. In those cases, people tend to use > > > > pristine upstream sources without distro patches to verify, and the= y > > > > tend to use their existing configs. With this change, their MAX_ORD= ER > > > > will drop to 10 from 13 silently. That can look like a different > > > > issue enough to ruin a bisect or have them give bad feedback on a > > > > patch because it introduces a "regression" which is not a regressio= n > > > > at all, but a config change they couldn't see. > > > > > > If we remove EXPERT (as prior to this patch), I'd rather keep the ran= ges > > > and avoid having to explain to people why some random MAX_ORDER doesn= 't > > > build (keeping the range would also make sense for randconfig, not su= re > > > we got to any conclusion there). > > > > Well this doesn't seem to have got anywhere. I think I'll send the > > patchset into Linus for the next merge window as-is. Please let's take > > a look at this Kconfig presentation issue during the following -rc > > cycle. > > That's fine by me. I have a slight preference to drop EXPERT and keep > the ranges in, especially if it affects current distro kernels. Debian > seems to enable EXPERT already in their arm64 kernel config but I'm not > sure about the Fedora or other distro kernels. If they don't, we can > fix/revert this Kconfig entry once the merging window is closed. Fedora and RHEL do not enable EXPERT already. Justin