From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 668D4C25B45 for ; Mon, 23 Oct 2023 18:10:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEF296B013B; Mon, 23 Oct 2023 14:10:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9F426B013C; Mon, 23 Oct 2023 14:10:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3FCC6B013D; Mon, 23 Oct 2023 14:10:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 91CC56B013B for ; Mon, 23 Oct 2023 14:10:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 60751160435 for ; Mon, 23 Oct 2023 18:10:47 +0000 (UTC) X-FDA: 81377516934.13.F1B79D6 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf19.hostedemail.com (Postfix) with ESMTP id A48731A0011 for ; Mon, 23 Oct 2023 18:10:44 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gzltpZ4g; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of mimmocerasuolo@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=mimmocerasuolo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698084644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z4pSWvEBkX0Lu9RMg2D09cgpXGEBNyWtfX6YA9F1f3c=; b=dAwgxm+UM+ckE9+shGHNxuVSTk8wrmuGL6cV+0klKhW6d5w8M4Mm1DXz93bRXeU5JhACDP zx4BXWM58o8coxF7wLdoW+fdL0+bLJXeMnveV5053lrAToU5kWuYU04mUoN9Mv/ht+WL9g ViQiV644OA5AVsUxqMarpQcKbD7Ic8g= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gzltpZ4g; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of mimmocerasuolo@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=mimmocerasuolo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698084644; a=rsa-sha256; cv=none; b=hOWISYV+LsjHcc8bzEwhcbYNSmQOZAdf/oT3dlPzCUvLQzxCH9IuSFsCM4BS8LgByGMvWo UZ+5c1EeO8lPNAtz9nCeGf8QLcQu5X8Rko1F/ajcQ6T4y/gfcpckX3FaRtPE8Oh12WONIJ RUsmqaapM9f/F+Q6ywNEj5Eyhkg0ncA= Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-5a7d9d357faso36635547b3.0 for ; Mon, 23 Oct 2023 11:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698084644; x=1698689444; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=z4pSWvEBkX0Lu9RMg2D09cgpXGEBNyWtfX6YA9F1f3c=; b=gzltpZ4gM5xbW2cg1jhOYuKZQ7uu4Hki1s4Uo1IokhffJCf7hOxHdr+oB+HC2+we8G UgjBUh40kqIDhwyj38vLE+IDfVlNQt7/fOoFCTy6bs6P+ajMo/U/sZiNSjwUHBXcWIKq eduJjO5J80qZ58PZxuozgYoJQwJV6QaRtg2lhpOiK5Y9Gb9LFhi0eS7UuMukqGS/VQ4w 8GILJRyU755SDmHDO1wXS41V59D8vLpnPW0p+jjLpiEK1+P6Qp6HZDlJP0344phXnpEL 2NHQ8pLlRj0MKG65jhnMIJROff1snjnVrz9RfJcfd5YDrkYG01pdp7SCumpvbtMAYObC 4pVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698084644; x=1698689444; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z4pSWvEBkX0Lu9RMg2D09cgpXGEBNyWtfX6YA9F1f3c=; b=olV6JvTzvOWbpbG/zjHKnfqqr4gC3dY+BswtVcrqeJkGLJa2P7+MuafTnWCjmB7qHK NimpQ99P5eWVd9oICZUtvNPJDD4xYgPQ1/9xCoDgOmjXIyft7kSj1c3aAlgWom6RBMih zxu01wu49IndoaAfLqkZ06XTUytVkaYrpWvvVwULku/wXRgtxii3mefz1MqXfn5AoPwd laz0Rd21vJaCGUsgJ6T2t7eaLb6zlvMO/UrD4Aixu2+HBF85TAaTaJnAwN2I206eUKaP H+AUd8z5CMPje9Y/fYYPfAC6wQdMO3VyGVn2he0q/nKykF/MNgaVM3bWCzJoasxl2q1j 055A== X-Gm-Message-State: AOJu0Yz1xc4jrS4jpo3PmV4oR2GYNpuGAp77k3LhYMPIbf15Khqzv2Rm L2rEABbVjaXooisfyu6jbaae81Kq/9wh2fBNGjQ= X-Google-Smtp-Source: AGHT+IFsRHY0zS38L02VKh/tEUVDmXeCZ3H+/yDfWD2j2oKtRCBYtB+IIijgiM1XHpz12xkowAhmpAK//ZInfVGDhA0= X-Received: by 2002:a25:ef48:0:b0:d9a:c22a:6edc with SMTP id w8-20020a25ef48000000b00d9ac22a6edcmr9577336ybm.30.1698084643765; Mon, 23 Oct 2023 11:10:43 -0700 (PDT) MIME-Version: 1.0 References: <74e34633-6060-f5e3-aee-7040d43f2e93@google.com> <1738368e-bac0-fd11-ed7f-b87142a939fe@google.com> <20231023105331.311373ed33a0dfe78ddaa9e5@linux-foundation.org> In-Reply-To: <20231023105331.311373ed33a0dfe78ddaa9e5@linux-foundation.org> From: domenico cerasuolo Date: Mon, 23 Oct 2023 20:10:32 +0200 Message-ID: Subject: Re: [PATCH v3 10/12] mempolicy: alloc_pages_mpol() for NUMA policy without vma To: Andrew Morton Cc: Hugh Dickins , Andi Kleen , Christoph Lameter , Matthew Wilcox , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , "Huang, Ying" , Nhat Pham , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A48731A0011 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ykykddjy6fxbeux6ynzr6d6uc6bm6std X-HE-Tag: 1698084644-966231 X-HE-Meta: U2FsdGVkX18nmI9EEANyrIKulDK/4+om6Y2wFHnnfciRsUKL6Ew+d5QBAmzPQB+Z2EUko1MShxSq6HoF/6KYzz2Z37ILdi3Qdj0vD60HwP4wTZ61I8Emwrg398lZMjeZdUvaDR8XlJYrGzegrIm6YxDNFvx7ZB1v1DKOf2SAYpA9sje8KQ5IP0W71HEwxCLDSiVL3dwS5EW/FaAcIEkuXibEHKN5zgldGY3bMtTNUZOjenfR1SrSeiQ6VChsig6rtwroTu2XMC05iA1h3tbvjCvvbEba6cTkOhF8g0OoLVWxVfmXf4fM2ukoGQbAuGf5TOgf8TxcYRLAPNY0mkvSHbaxs1YuPVezfZbOmnTAWNdrGLpr7gXArSrW8ZtpnYoifriaicZFxFbT4hPBsJjAHa5HxCOU0X13N0YUFiwg7X4YjOHn13T/mE6YfuSdeyW1eoXJianqVqZO5U0I53EKceZdlYkZhyC/a+MEZTWuTMfPi5JvU+/PUuXfAjZHHxKQtuAGbTyoINT3yopNg5iaRDrqfUcVZ8zd2+lAtiJmX3hqF1o0cDRLnBBKOKE3bCQxipK/wpLwbwFz8LAqN7ovY4pAJWpHpxHrBmJMhCX7lQRYKZhgrND4LXuf2k5T8gA0vxWLs7Yu5J3eCvZPMhCb/0xSwh2uIWUe/4yup1bksb/PdtDahqWw6aysOvYRRuOY5Q17YuuQnwiJuyszd+jUtCgMxXRUdY/AsWRW2bTN9ODv0jznUnujU/t4380rkjJM4ysjANiKCkPcRpF6ntUBSJOZf5Z/+UxwrJmbfHIiVYaWAZenQe4cz5KfqcViFCiXLdJ6XDqRMepUybDLmiSCrdTlBSQx1fC2yQQHELzmBAVAn4WWAcbykkiopNLWwjnRxsFtsuSnqfwD6oS91qmdY36JD7uzLqk7EPP2bpoCG7T84pGeb++udbbSX//WgKIzjaTDU+TY+3lnbs2p0qk q2aDwsXc zTsRHwnvPoB3GoSIpoGPQEzZwcOjWY3Zz0ABnZcVe7Xg/hmtdn4hcBZ62v5Mj4ETrkfV5AZouSWs0QD+cnc/tijoG4H0nimUnAQQmxfr5CJ0h8cNQQ2AE5Q8tVO0if8x2DUEXU3XKGwcv0RJIkim50SDeBQsa3JF2eEkjeMWl9HWPnZdxOsUYNHVmQHAf5msi9du+M59lXN9ECs9JTgXIget79pWDwcHSvPykr1wYxIcU/1YEtSLZXqQk2ci3VVeQqjybXa+f+q1Mv1Y01798fw/939sPkhEAhWbqJ4AiBEuYNikEnFVm+CkCDFhYCb3uQMIoouioQrkFU4SfEExlRDArlWdhY4OM648IScu7bS4Sq/zAx/fBruXQxxLuorI5qo3/wlazd6qNwGCNMJ2XDPotkqHd3lH4HbnF9DPO0I7PcDDQyup+BjH4E7F34LxGNTl7Obt//eDDoJzbQkciRbcGigILtJJgHdms+lgKPHdd3Jg/y9tgqNaIuLS3KElugs3Ap2HHCgXNy+ftx5gioRJBTsiKT9lt7LYC/fQfR4ZYTpk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Il giorno lun 23 ott 2023 alle ore 19:53 Andrew Morton ha scritto: > > On Mon, 23 Oct 2023 18:53:26 +0200 domenico cerasuolo wrote: > > > > Rebased to mm.git's current mm-stable, to resolve with removal of > > > vma_policy() from include/linux/mempolicy.h, and temporary omission > > > of Nhat's ZSWAP mods from mm/swap_state.c: no other changes. > > > > Hi Hugh, > > > > not sure if it's the rebase, but I don't see an update to > > __read_swap_cache_async invocation in zswap.c at line 1078. Shouldn't we pass a > > mempolicy there too? > > No change needed. zswap_writeback_entry() was passing a NULL for arg > `vma' and it's now passing a NULL for arg `mpol'. Problem is that alloc_pages_mpol is dereferencing mpol, when I test the zswap writeback at 397148729f21edcf700ecb2a01749dbce955d09e it crashes, not sure if I'm missing something. >