From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 686FBC4332F for ; Sat, 11 Nov 2023 00:34:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C349B8D00FD; Fri, 10 Nov 2023 19:34:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE4AA8D0005; Fri, 10 Nov 2023 19:34:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAC588D00FD; Fri, 10 Nov 2023 19:34:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9AF038D0005 for ; Fri, 10 Nov 2023 19:34:37 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6A811160251 for ; Sat, 11 Nov 2023 00:34:37 +0000 (UTC) X-FDA: 81443802594.09.6B3B810 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf23.hostedemail.com (Postfix) with ESMTP id 944AF140014 for ; Sat, 11 Nov 2023 00:34:35 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fwi8fuSF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of hyeongtak.ji@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=hyeongtak.ji@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699662875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0C7o/f+L7uo4NWltZBaeo9zpZA8oTQ6ntV0FIDWJnuE=; b=4cwNphT70jAF4pkn5wSUjOskf9G0+Ns46lBRh7zFoBXBfOXBNnFGmd4Yb5rqYYu9++2Ltv VHjzslDPI8tD5lvj/vXrou5VjiQPTOOCWRGTsLHB3/R+0l1er2mG/mXR10/FFH1I9+63lM MNKGDw/AgCJU7SvNxW4F0kzb1D/dUnQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fwi8fuSF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of hyeongtak.ji@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=hyeongtak.ji@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699662875; a=rsa-sha256; cv=none; b=lBcQAU+RYbpaUr1/uNKymFn/AaE/8zNIUt4JUWJDWNSja+rQQcF1ixenKGEUzb1voYm33R /yyy+DHajhyqT2Q9u6HUZxcJq7DIu5dbUIiJEHrOV71eBR3W1uKpbcFcJ75HyRD7V20wLe qdiX3qwGDCsmS+ROeqpNuUAhKVR+k+Y= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-41cd4cc515fso16050451cf.1 for ; Fri, 10 Nov 2023 16:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699662874; x=1700267674; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0C7o/f+L7uo4NWltZBaeo9zpZA8oTQ6ntV0FIDWJnuE=; b=fwi8fuSFZtXSDn28Ciu16Gj0v93gYX+ggdqknfagRcczSZwNN3AW33wF4Mv2+fE0sy C71E+mSvONmLF8dxP0HlPl+JbWEzyyA1NPzXXypq4ILqgXnQ6GINO/Irwrs5IONfhLSH QlUHp8JmrZccUPlIem+CDpr/zvkISTTHbG34bbBTRBvpLSQA3YadwUZ5biXoP5hjoH3N l3NTx1AIZfRg2L3vtWNhNRh8CMPGR7AqOZ0NzLoACZ9F/8RiLcc9g/AKS1bh/OXIEtdM LbqsfZTXiYAm3i0IJL/WsR50WBY2Y0KbW5tAVivKLK33Z/00jOpAidhB9GxBcL6o8DUY UOmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699662874; x=1700267674; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0C7o/f+L7uo4NWltZBaeo9zpZA8oTQ6ntV0FIDWJnuE=; b=wZNRUnL9e39slck+Lk0JapIacS0r3AKreFn2A/6XbxhMu04BSjHL3osAjwWeHqdaYa j7eRVmwNXN2ozbrwh6dswFyxAHm5MHruLXh0mtIfHx11Pa8VKCmBX53DLfiN3+gtH2V4 4XzBP2hdE/zUpx1Vz9L4NlbksWsVfObJg3JckKFpTHc2Iq/pj2BNBkHBF145cEX2cW+J y3ngMgZ7G04m3caG4izHv6VMvzaPv1VUb7CtTYqkARY/4wzZlM75mxcyv5KQYOswBUwy 2cuIy4gT8lHnKB+mvd00uSZdYoV+M++i+Bf8VcmvP21BLuRZbMH8CllCt+0byPbaT9V9 h8lw== X-Gm-Message-State: AOJu0YzTt4FjFgML6Zu+5UcuMJJ1vybkVpS/VQMqGWHV7Gj58BeRt2h/ badPrdn7Ubd6QmlHDQtxJ1kJ41/+rFYPd6CwQhM= X-Google-Smtp-Source: AGHT+IHIh4UqMHAwsou0uBfJPV39V5EK2cOgk5wYssTsPnP1IxmFVRcptuEsKm9ZjEGxa7vIVMqs4/KdSxwhmNe4HUI= X-Received: by 2002:a0c:e805:0:b0:670:710f:2042 with SMTP id y5-20020a0ce805000000b00670710f2042mr939501qvn.15.1699662874672; Fri, 10 Nov 2023 16:34:34 -0800 (PST) MIME-Version: 1.0 References: <1699594629-3816-1-git-send-email-hyeongtak.ji@gmail.com> <20231110182240.65426-1-sj@kernel.org> <20231110103122.21d5fb5f3d60f1f4f5bd143f@linux-foundation.org> In-Reply-To: <20231110103122.21d5fb5f3d60f1f4f5bd143f@linux-foundation.org> From: Hyeongtak Ji Date: Sat, 11 Nov 2023 09:34:24 +0900 Message-ID: Subject: Re: [PATCH] mm/damon/core.c: avoid unintentional filtering out of schemes To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeongtak Ji Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 944AF140014 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: g8uety1k7wydxrjbn5m8cw8c3djxs1ci X-HE-Tag: 1699662875-767467 X-HE-Meta: U2FsdGVkX18leKKxfmIQvUw+/8TUiLOI74ynuVUTxoVSiNAU0hwI5sd90A7KBFAtsDhbdPlJN8ZV/iDHnW4AyEVZSuA3KXLRPUXeviIsPjVh0r0BtP1qT3A2bQA2P56jR2rcR++Al0CDLvuRkxDj9dTI9wJq9ibReYaUwFR1BUWHz1BgMGIc/iQQrpODebPaH0J7yMLuBFSUF8ADB5l48THXdltwdpHJTSH2of1O5XsEMg71MYBER8VqrWij7UmmFKBEe8UheQhRHEH/ezAicDu++baUSjVdd5W7Q084Ys2uwOaOBPUNYoWifKmpRv6JaN6S7CoF8LdCSRWcM8LTZ+HnEwuTWwrbb6d+0cr4zJv63TGNpGqzSLja7J9b9du4MB4FhDQqJ3zecjHtvp2UW8capQyOuEaTniHwYRGra49mJmeDVSIroza76CC2i105NtNBOgnaQUqyaUu3W8qYg9gEHVcP87Wt9DCldRKWlYIFd3eA9mV8X4EPPOUZKGJF4QeluhiAnyItQ21U1zfRg4+24QB24+Pgsgm6RifJ7QAPIko9ad+vrYsuohyZ/LIUyP2zaIc//dfc7G15GsHMhPN+8tN74V4sZ6BLcU/GhLiham9Ad0yFoy+CiqRRGNWgyGozYZnPpX0CUla68oKFCCrnFtK8Lde+W9bC5D/sRWIiTJnKzQF9MRQV5G0ItJWOnbkVvFc6ne9KqzR+E/so+mXFLPy0eEudzouFr1DpKA+47fQ3k8uPc9D3lIOj+JRO+GCywkcF7o/a1thpY4hq+7YC+8FY8QclBbUzXBc5dQtKOlxyOtMguIumMxWwWNQ5vhQoUW1fhKGDGz5+9ngqgjFHjb/LjXoDwYqljYz+L9NUysPj5pRzZs4Yi9R3UjDp4XqezfaHx3e9QjUCBbdlWib1DlC91GyTA4rnjrA78S4hsky8K9RIEqomNmbqzJnouTeHcO2NxuFiqusWBxk E2twfAD7 fKuCyU6CgpRigdDIQqEdX0j/bn6+dtVnmcQhr9NW8/ST37x+bW/HvDDmJMJAXfGcP8wWa3SKrgIv079FU23kf9YQqbmQczsThYWOJkxhqvpDLERcQz17JSSKUappsuW8w079Wa4zPcsHB52Dzi8NMtwNsinXrl6o5V/1pWzc1zJAm1lEy5qE29Tqz9HtFfaInGKWAgz97mGPvxWltzfiT1L9lrYSoK2GtIurLL4GnSKn8EyYlzCup0m2mU55ysLop8G3OqXwIT0o0oZjPk0VqzVJAmocU+OibNXz/KVYmceqz9UFLp1zF/guQ1jOV3eF1f1NA4NwjgburW4J6LW5YOjaULNvj+cbWpmvryjMWkhOg2Z1z3rKH7HH4NIhqbqKsNFYEDrGu2Wym7Ti0Tiz/mcYbGYcqASroLQa8xlbtEaoy3fPts5kyNsnGEQZSuhOhFsMneqQxmxhe1dpZGeF3knB8TFKZCSLdL9UafABCRpz8WHNm6aRS985wbZ+/GSVzhuXuEUXRqZ1WxO6O50psI8afms/F3LXaLa1U/bkgAlZsq6tKCEevf4Li0zT4FEUBlt8TCgGK7NGNNVzly6YkIcTuORx2ZntGna4FyXk3GlmbZCCK8v9S98cAZCesZ2GziRxs4mf/8lfNY/G3v1Kyjoa0HACGtA6Tc9f0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000121, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 11, 2023 at 3:31=E2=80=AFAM Andrew Morton wrote: > > On Fri, 10 Nov 2023 18:22:40 +0000 SeongJae Park wrote: > > > Hello Hyueongtak, > > > > On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji wrote: > > > > > The function '__damos_filter_out()' causes DAMON to always filter out > > > schemes whose filter type is anon or memcg if its matching value is s= et > > > to false. > > > > > > This commit addresses the issue by ensuring that '__damos_filter_out(= )' > > > no longer applies to filters whose type is 'anon' or 'memcg'. > > > > Nice catch, thank you! > > > > checkpatch.pl shows one warning, though: > > > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeong= tak Ji ' !=3D 'Signed-off-by: Hyeongtak Ji ' > > This can be addressed by including an explicit From: line at start of > changelog. Which should we use? Please use if it's possible. > > > > > > > Signed-off-by: Hyeongtak Ji > > > > Reviewed-by: SeongJae Park > > I'll add > > Fixes: ab9bda001b681 ("mm/damon/core: introduce address range type damos = filter") > Cc: >