From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 368BEC001DB for ; Tue, 8 Aug 2023 09:59:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C73496B0071; Tue, 8 Aug 2023 05:59:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C23936B0075; Tue, 8 Aug 2023 05:59:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B126F8D0001; Tue, 8 Aug 2023 05:59:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A34B56B0071 for ; Tue, 8 Aug 2023 05:59:28 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 727FF1A011A for ; Tue, 8 Aug 2023 09:59:28 +0000 (UTC) X-FDA: 81100490016.01.7F8CD8F Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf17.hostedemail.com (Postfix) with ESMTP id 9BA6B40010 for ; Tue, 8 Aug 2023 09:59:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=REfFB6xx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of hyeongtak.ji@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=hyeongtak.ji@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691488765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oj2ai9zvS+9QZOskCM8RXfhgWWD2kjSbmwS4f6JevAw=; b=Nu26UXmxdUzEeAj1siVUOt9CIxcQUiaRAxv5s+3LOrKvFgIucf+ogQOBY9+1ru6YSRKtAl EwhSGxhL111FPxjOBPQpURblFq5uSrhS6pcUbsW7TgOJhzcuqD9OsV3cPa0QoA8uV9XukI fOoDEYCj8wkYHM3KUagNU0ac9nI75GQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=REfFB6xx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of hyeongtak.ji@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=hyeongtak.ji@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691488765; a=rsa-sha256; cv=none; b=VwlmhLRbKIjBXF87VPDfLuO6ch8cbwSUlVX+byq4uVycv6usrGFRNtpvjqtr8enSPh79At zfkFVEN+c37fTGd2L37pj4XkKbBC4faoHVmvyj3ZTXlDxMeY1oCG/w6Z+IuSlMg0GgOaCS uNscgKtifK4dottpKvF+OhFEvTLTM4k= Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-51e429e1eabso7524586a12.2 for ; Tue, 08 Aug 2023 02:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691488764; x=1692093564; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oj2ai9zvS+9QZOskCM8RXfhgWWD2kjSbmwS4f6JevAw=; b=REfFB6xxXyunKIxjea/FR6SFY2a1L7wAPVaHVDbWmFulGyGx+Ri7avf/nbzBosqq7q FUmH05AE6N6ARunU/HUohq1g1KLoCqT13s8MvQ8NlbRSfEG8nZzHMHsMiW3tzQ9GG3d3 LNbp0tZ9h9HF7pzYfUGd0JnFDdFTidwI9FlVFbNPQmmZ5g6/WFN9zXZKf8ApoCA9rEqj 2Fmv4Ugj8+OPy/LrkVFSFS0v31r7l8ujkK2rmwAqWjdP07XMD8ZI+KHXlgm9yDmIO6PZ wJEt+jx/X762tXjSeCzOFN76OZeJqCuRsFUXZdKzBmLQ7AshXmjUO+/jDc5xAytH198K aMIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691488764; x=1692093564; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oj2ai9zvS+9QZOskCM8RXfhgWWD2kjSbmwS4f6JevAw=; b=GgVs635CsKrdUh1d35/8Quxuhk3gy/IbeMAZ9vwr3qsrrPnpUf2/x09JNmEjhhFp+n pKy6v3f2YonpG38S/C5xSUnBvOEnSqVHsHGQeJuV4wP6rPv/O2dY5xZytcrrMQk+o5KK ZXItyloLhTdaiS5WLGz5FJcko1I0qi9M45yP8XEkY2aLTHa/vtg81Yykwtyq0j9xyfx+ wOrN/2+igryouIQf04noKp528M2GMnTfl5dNUlOhw7CH/k9Hq+B3kPt5d0zwjO7luzJQ 2t5ckgASolzhsTUr+YLoGEgpcWdvwaINDHtJ9U25KC76H6j7CHf4/YYeaLd8TC3bVJz9 BQNw== X-Gm-Message-State: AOJu0YwhddW5YJumyE9tqVqNXO7ZFuCl/iRdiy1LQ2RV7yfSEWaE8baf hYJ9spsBQ1cD0Bu4OU+Ve6dVmSw1Krg+XqPb7aCSDZT7Ljo= X-Google-Smtp-Source: AGHT+IFfju5o1lWIv3wyfHE+qyETz1vJSnBk2q+GZQ6BY2VK2b4Baqqt+9vLWQ3xkBaRGglOIQJ0QqulvLM+5Af0FWA= X-Received: by 2002:a17:906:109b:b0:99b:d977:c00c with SMTP id u27-20020a170906109b00b0099bd977c00cmr10395304eju.45.1691488763617; Tue, 08 Aug 2023 02:59:23 -0700 (PDT) MIME-Version: 1.0 References: <1691401475-3796-1-git-send-email-hyeongtak.ji@gmail.com> <20230807181409.97310-1-sj@kernel.org> In-Reply-To: <20230807181409.97310-1-sj@kernel.org> From: =?UTF-8?B?7KeA7ZiV7YOB?= Date: Tue, 8 Aug 2023 18:59:13 +0900 Message-ID: Subject: Re: [PATCH] mm/damon: Prevent unnecessary age reset for regions To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeongtak Ji Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: zmhdhexk7kkj3jo637ptr4m5s7wpoo76 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9BA6B40010 X-HE-Tag: 1691488765-462818 X-HE-Meta: U2FsdGVkX19Wp2dpuZZIHpXlv6SxqNWsgAi3iFoZZg41P2FS86Kkq86ohc5WZKNQHaBms2AgfGwjCdbT0TxGCxxCsGOa0DA/SBWwvPXXwjSx/mCs0cetaZf/KMh0yJLFM/CVBGk9WmyfnhtY2EogMHEKfP1VFgdX5DB6i80jp/TGuIhioYVYJeeloVTdEIV5YjLFMvOR7yehe6Sw0CBZm3biEKjXyDSyWRHsZI0pLJ/UXzugnIXiBDfF2t3FHvqR/tINMdfCfbzfpw02n5uorkLTgteThmqoPea5K1awcwTUkNilTn3kHxmRz+fsIBxJ2tOOipVSsKjB0xQ+uay6MLKGcN45taztcvE4Kbp9GEiGj703AVZO/DmyVhu/bpwQs2eSRoDnJUabw7lSbLTswxfW6qnomCBCrlMlw+SUpX+elfTz+LK7u7xNTubFmytsd6SY61fibcwerxVOw7vQIl4+RwX1DfG/sEXueiMYSCmmUKYXIqRSGVHr+KqlVkRy+/62FuegAXa5IOzAL5HRuNR1tRJ23Nbxg6xpiEaoNnHdO+BdbonqQPc4DZNDWqDtWCJOKxk+yfw80YVSsQobwtlXQpJJJT9lcDr612IzQUb4xDO2TP8SI03bYhfZf9m+eGW9MXSLjqc2Au0EkjtzXv4f3N/KoJxZxEI/jXz3uPLx0lDDbZLFzjKAsIqCtfnfgRYUnRea7lupwJXRJZwxHoRuWta11KYKxuDB+ziWvuMC3wT9Mt/JuVhbrdpZ7xtn6yQbNdJDOQcmpn+IAkDwqANvnubHcPieowQotuEs3HOC2IexXHdVMPNdZ6yPLDo3m68nWMhPy7TZeiYWVr3NB9JnpypLnex5oXSn1IQWTIWJ1ak9rU5jWZZn4waIbSmTiBlSgFll6ciWz4Gl0FrII8qfzzW5dWdLZaathackvaDt0DCQrlzL4bEQKI7pYB5oNiGp14SZjeJhYaDQRuT AO6PelPy b6Kicl5FjzeRkpIpWeAGmFPewFa4LqKnraALbJegBxlAxdKRaMQeGhqggDirGeiwwu5HFUxCetqFVrhfe+CQ8i/1306FqGITJ9qMYDWTHi921gSoVggtQOlo0EwZ+kQhvnpB5XpsgNZ0rPS/lx94G1P1FfApkhJ734n7kn91b6Clzev3TDQDfRegqZNW46NUFeuQTrtyihmV0F+Mdsq3ruTMd23ONK7pvhQBFpFmHIEVvdCHoRlRI9B4BjIgdaSZGx4zTbFl85IDwmrqQbaCFb3xaKVLoghMMVVYMsupkYG2A37ItGjc1RwIZlQKMZr7DJCvWBbTW6Q20BCLRXmMzbEyaDvEaYOjZYZq6ObcCCFyXod98sAo9ldXAHRttFsxd79NnC4xupmsH0wbKNcynrJXNMfmwdtneddov0YVNMyNPnq+wJZ3dv7/zO3NNtVPsZmt7rBTeSzws14ZKMNrBAoTZ1ysQFUT6UW7joeQmtWdb4go= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001285, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, Thank you for your review. I really appreciate it. On Tue, Aug 8, 2023 at 3:14=E2=80=AFAM SeongJae Park wrote: > > Hi Hyeongtak, > > > Thank you for this patch! > > On Mon, 7 Aug 2023 18:44:35 +0900 Hyeongtak Ji w= rote: > > > DAMON resets the age of each region after applying each scheme, > > regardless of whether the scheme has been successfully applied. > > > > This patch adds a simple condition to prevent the age of regions from > > being reset when schemes have not been actually applied. > > We consider applying the action as making a change to the region, and hen= ce > reset the age to zero. Even if the action was not completely applied, > that might be enough to make some change to the region. The behavior is = also > to limit a scheme too repeatedly and frequently applied to a region. This is what I have totally overlooked. > > So, this is not a bug but an intended behavior, and I think this change m= ight > not what really necessary. Now I understand that this patch is not necessary. > > Is there a specific use case that this change is needed? If so, I think = we can > think about extending the interface to support the case. Not for now, but if I find any use cases for this situation, I will let you know. > > > Thanks, > SJ >