From: 지형탁 <hyeongtak.ji@gmail.com>
To: SeongJae Park <sj@kernel.org>
Cc: akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Hyeongtak Ji <hyeongtak.ji@sk.com>
Subject: Re: [PATCH] mm/damon: Prevent unnecessary age reset for regions
Date: Tue, 8 Aug 2023 18:59:13 +0900 [thread overview]
Message-ID: <CAFY0u4Q32yX+O57D+Eh_x6yVwQv2EcqvuxtQxG1msd8RqQy0zQ@mail.gmail.com> (raw)
In-Reply-To: <20230807181409.97310-1-sj@kernel.org>
Hello,
Thank you for your review. I really appreciate it.
On Tue, Aug 8, 2023 at 3:14 AM SeongJae Park <sj@kernel.org> wrote:
>
> Hi Hyeongtak,
>
>
> Thank you for this patch!
>
> On Mon, 7 Aug 2023 18:44:35 +0900 Hyeongtak Ji <hyeongtak.ji@gmail.com> wrote:
>
> > DAMON resets the age of each region after applying each scheme,
> > regardless of whether the scheme has been successfully applied.
> >
> > This patch adds a simple condition to prevent the age of regions from
> > being reset when schemes have not been actually applied.
>
> We consider applying the action as making a change to the region, and hence
> reset the age to zero. Even if the action was not completely applied,
> that might be enough to make some change to the region. The behavior is also
> to limit a scheme too repeatedly and frequently applied to a region.
This is what I have totally overlooked.
>
> So, this is not a bug but an intended behavior, and I think this change might
> not what really necessary.
Now I understand that this patch is not necessary.
>
> Is there a specific use case that this change is needed? If so, I think we can
> think about extending the interface to support the case.
Not for now, but if I find any use cases for this situation, I will
let you know.
>
>
> Thanks,
> SJ
>
prev parent reply other threads:[~2023-08-08 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 9:44 Hyeongtak Ji
2023-08-07 18:14 ` SeongJae Park
2023-08-08 9:59 ` 지형탁 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFY0u4Q32yX+O57D+Eh_x6yVwQv2EcqvuxtQxG1msd8RqQy0zQ@mail.gmail.com \
--to=hyeongtak.ji@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=hyeongtak.ji@sk.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox