From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F1CCD4F24 for ; Wed, 4 Sep 2024 19:46:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5C9C8D0006; Wed, 4 Sep 2024 15:46:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0C638D0005; Wed, 4 Sep 2024 15:46:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B866F8D0006; Wed, 4 Sep 2024 15:46:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 84E858D0005 for ; Wed, 4 Sep 2024 15:46:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2E85A1A064B for ; Wed, 4 Sep 2024 19:46:11 +0000 (UTC) X-FDA: 82528086942.15.44CD577 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 4580340029 for ; Wed, 4 Sep 2024 19:46:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fWdF2DP7; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of anna@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=anna@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725479091; a=rsa-sha256; cv=none; b=Qs/4uaaU99pGAST5HUjqPY+Owu5Z70eHsrwcPB78xf1mGqw3DQhEk1Vgp6cphjOVSPjGe4 nOBSLzr4geRnZTAY1oanr8nmY6ze+fRd1+t78tA+R49R7AHYiJaWcMpWKANzhFHfbgUwVm bStCaTtdDxHZ/ptZf1t0weLc5W7vkFs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fWdF2DP7; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of anna@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=anna@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725479091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LfNaCryiECcMG1nfPyagNg+5UQzh1Wm7UTlqcyfiMlc=; b=McehuP5l6blLUmrLXUmDeaK9qZVJF5BtocmXpGdgHdFhf43c/jJJKkt5MZJlZLBxubKoOn 13gx1ekl5ReZOsVQALhMgdknn9B0pCTFtaXTTLebX7V4aE+dlxJaCRGWUzU/T2zy8CKtdB v4vgD/lHq1E5u83AoOLByVJ0n4DYI0I= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0B4EE5C5871 for ; Wed, 4 Sep 2024 19:46:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEA37C4CED4 for ; Wed, 4 Sep 2024 19:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725479167; bh=QQsVnSzMJu9Xy6LVYw1rcBARePRY6Cy6vZiFgsTr2ig=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=fWdF2DP79Oz1wDdOdNmJmEFF+B692AQZ4875Bq6z1hg1xwLqlTNY1H+XTrfXMbVpS j9sAxC7eMnwXTd3wNHvjRWj8E5hmjvAylk5hK4Gv4aeWmNf1meqTnsLuu09jxp5IQ6 7M3ybSubPsXBmhx6wBiBOKJX/1fjvuOvzRpBPtiDQ+i7+l/luSJZ9/Di6SjL1Zxn8C EUvdYE0SCcmrKuzUMlV6Ukep+/CcDy//Ys7BNiUYeFzQ/QG4XV9j+jFT7/KBZiQtIZ 2KtRy5wbsaVhOufckq7FbWVUG9JdrwzD3kd6eZPTewykaW7TfO2EVgPzqOO3iubl79 1KjRL3qAlm8dg== Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4568e321224so36907731cf.2 for ; Wed, 04 Sep 2024 12:46:07 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX6NYW7mBgECUV5WaSxcQoncQCrUlPjs2uBVoS1vgs9zbU2pZTtRLjNz31q5lHDB0Y0yy31zyqWeA==@kvack.org X-Gm-Message-State: AOJu0Yy0O4oi7IzMZXG7yKjGNYSyU9TTIG5QO/ud3hmQfJQ/+iRRvohf Lrx1ITvmGwtr27kO5UiaFJUa+6IXn5kK0u/OypqaMlsec3XEYiGGcjgdSTjaZ63WWCRq55Nkt/s jGyqjbx4ii3gWdqub5+uKMHRNL0A= X-Google-Smtp-Source: AGHT+IEvCs/22u/q3u8HbVezM75pgSYQ+mtXLN/XwyBj7AvVgPLsxLtOdjUjVijcfKiU4aElyUiOX8rriF8t5qXs5jg= X-Received: by 2002:a05:622a:2610:b0:44f:d986:fe4c with SMTP id d75a77b69052e-4567f505b0bmr362111191cf.20.1725479166868; Wed, 04 Sep 2024 12:46:06 -0700 (PDT) MIME-Version: 1.0 References: <20240903033011.2870608-1-yukaixiong@huawei.com> <20240903033011.2870608-12-yukaixiong@huawei.com> In-Reply-To: <20240903033011.2870608-12-yukaixiong@huawei.com> From: Anna Schumaker Date: Wed, 4 Sep 2024 15:45:49 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 -next 11/15] sunrpc: use vfs_pressure_ratio() helper To: Kaixiong Yu Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, wangkefeng.wang@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4580340029 X-Stat-Signature: 3du17msyg7kwbpkbnqw4qp64sxomt5uf X-Rspam-User: X-HE-Tag: 1725479169-463483 X-HE-Meta: U2FsdGVkX1+e0x1b/X1ApFJzgWfgo6z2ZLiB/akS7QneAe7nya1ca+Lbr3673lCiWId8/EpsJGw1ZdR4ArVjsD0nmtwU2jREHJGOaYErljHLTy6K7jJxm31oXhoZzU58nMMeSfXqddv3OiowQ48uqpwWV4FTPekzuQ/Nl0qtuTQpmulKnAtjhFliUFuN49mb2aXBmSduiGn+2p1iUuBLWJNFtt68VSWzPuGm4yVUXS6yl11uEeYW1LJPrlxaRmeMs8Fj0n2T3o5Q940ZyxaT+nEZxQApH/vHKAgNrV1lrX/i4zDo7GUHykjdZKRzLRO0G/t77II/i/M0iyfElDgAq6kCYxX1rQg+MeV+zshHYBqBn3ngaG16fpyIGgEofhXHa4OITY8GHRh3kG68TR4vxhZ4bhvls8IQtjXRF1leAbtZ+5Qwk2ZNxx3noyT5mzaXuo9CtGAyLsax1GIxVX/03713Wm8NmjhTwq5siBdMdz+rFIcwXqqrGp9a6StnN8i2AkA5+G4zUskFvZ3sPrSJAawRFFHzcckF/lDA5o7E78oxEKNqE6i1AFAayxWEf8vFTJCTmrN4KjQQyaTZ8pQQUpoDPEzsxsC5v7VHzAnwxZqLe/xCqqLHkc4q+Ovtx0xSCaA3i2t/FxAh4nOPAn5Iz19oKmeyVMt2spwUIQY3omZAzJy4ZCEmN3xxtJE2kKmrcxWCKrx87z4QmPn//7+44jf8vPeErvP149oO0Mbf81HQUeUT/T5PtlKvGWp0bRHZZoxWNm7LUTD1266GCJcYu3GOgfntycLGwrmebTcJwJqWnAgy4impZtOB6VGWEH8dIgfLv8uywnYJGnHq0c5flHDQ6PlQUUtHoYSMUHDP8JYwztFpFA3xF7IP5FlOV3BtJRrXvXBKHqHj6TjmEISRELJFB+Jj8fnOK2RkCRZSy+vKW2LPYqSFY8KHkrvguMzKuMmDTNMbkeI1SLB/C2L daSwVUCq aN0MtBOsVABNJ2Xczh+d7d1f4XZbBnTdQZmCTQ1jmsqHKbVeVKQUbqnAlNPNbVQ/6CLx7+dIoVraW5GGSQhenWw1Wi8fZPttEmrsnIHhMHgK3utVPDEya2wteKCjowzxmhQ3gYYiLQ64CVVcJ2MPmqxbdTI7rxHCqyFzsmwgZv1K8hs9e2GgapWOvWc81ERJqSU+GJLAKXcPh4BDaFb4dqkQ9/k2QlW1/d92eAnd4tMXav1Sx9jXbYY6/+hi36+KAGdJyisesApfqMwfb+H6B79ZEZeDqEH2TINUAyjFn8yNz3pLX+ex/TyxOwkwMyXNBY/TlJB1htbm4Q284zblda5kx6rtWuaDLkbzTVX6aEi0qM0vEvtsJ4UM8O9sq2k4twFb4JyNOZZH/NDyl1EcMkKMvHOSVdv69Ewex X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 2, 2024 at 11:31=E2=80=AFPM Kaixiong Yu = wrote: > > Use vfs_pressure_ratio() to simplify code. > > Signed-off-by: Kaixiong Yu > Reviewed-by: Kees Cook > --- > net/sunrpc/auth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c > index 04534ea537c8..3d2b51d7e934 100644 > --- a/net/sunrpc/auth.c > +++ b/net/sunrpc/auth.c > @@ -489,7 +489,7 @@ static unsigned long > rpcauth_cache_shrink_count(struct shrinker *shrink, struct shrink_contro= l *sc) > > { > - return number_cred_unused * sysctl_vfs_cache_pressure / 100; > + return vfs_pressure_ratio(number_cred_unused); Looks fairly straightforward to me. Acked-by: Anna Schumaker > } > > static void > -- > 2.25.1 >