From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4385DC4167B for ; Tue, 5 Dec 2023 16:01:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9C896B0072; Tue, 5 Dec 2023 11:01:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4CD26B0074; Tue, 5 Dec 2023 11:01:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 914826B0075; Tue, 5 Dec 2023 11:01:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7D3706B0072 for ; Tue, 5 Dec 2023 11:01:14 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 496C21401B8 for ; Tue, 5 Dec 2023 16:01:14 +0000 (UTC) X-FDA: 81533228868.10.825439D Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf30.hostedemail.com (Postfix) with ESMTP id 7E4228004A for ; Tue, 5 Dec 2023 16:00:59 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=vimeo.com header.s=google header.b=UivVL8kW; dmarc=pass (policy=reject) header.from=vimeo.com; spf=pass (imf30.hostedemail.com: domain of davidf@vimeo.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=davidf@vimeo.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701792061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xlx3FgdhGHDUnh3L6/3hGq4qNfTS6+do/JBa+IYdpms=; b=6iEXmVSaihwehkhvG61rAwKQ5Gc9t9giS47gOctSvQzPG9xs8VGfGZ2l3uSdqLcN3qwZZz 9mEQfuz3Vak0u+UBovhWWrjhN6aOaaRUBqoH+3CaWBrqw0+y3SwWhxM2Xydz705HCUUH1n 3M7G6WcXLGaEE29O84PCd4oxXIAgZDk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=vimeo.com header.s=google header.b=UivVL8kW; dmarc=pass (policy=reject) header.from=vimeo.com; spf=pass (imf30.hostedemail.com: domain of davidf@vimeo.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=davidf@vimeo.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701792061; a=rsa-sha256; cv=none; b=b9WQpN4azG4gYM9tmAWixgtb0i3hn0tIRU9WBKeXad+UcP782or56choDl4TIONQZaZexB NH4RDmoBNpp20anMDZXC1yDh25K/Wn09pnI7UE1ddZWbfWdRVqwcrBIB72/1E4+bBoQ9Xd TEKFBszrMrCY85EK4fbhjaSrhmZ00xc= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6cdcef787ffso6078742b3a.0 for ; Tue, 05 Dec 2023 08:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vimeo.com; s=google; t=1701792059; x=1702396859; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xlx3FgdhGHDUnh3L6/3hGq4qNfTS6+do/JBa+IYdpms=; b=UivVL8kWxIPCitd1YD34K0iUbLSY6mAnXcQ9lBcehKqjA14KlnP5FSwVwFLl4KpN3C 7CuLhGw7HYvM8aOc1M8uyI28pt7hY59zbFetaXVhHQ2NMUBM9p2ZNI3sTlxvrWJYYQgf DXSkecrsjzGOKyN5SIvTPtVE9U4HvRi8Ut2vk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701792059; x=1702396859; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xlx3FgdhGHDUnh3L6/3hGq4qNfTS6+do/JBa+IYdpms=; b=nSfpCfvo3Y1n65j3SAeJG2laAabbxZuXvA9cwcfF/jvGj4Es//HABm4JGCcN727KJt Jj7qHGywSVpQftKNHcH3WmnMUlwqWa5rdsurHtnlkRAypNF9HCW1i/Gp4hlG6VIX4EaV gASpl/Qn5Je3CMQRu42SPNTvet5Ib7WLaK1isgHy95FXInKm+r1IyH8elsOn4jg3D0DL WwhfUmRIHS4vYzG88lAmIlhisGhssLlQUcnEv/sivJCksPoLz4zwEKpvVOSRAGOfKLFZ VWDZfAYp+PgXZv7Bx9P4pGXce8Qcfzfx8Gf0D+qQbwb9BlG3UwFl0PLvOyOzqTSzp3R4 FxQQ== X-Gm-Message-State: AOJu0Yz+SrMKSmo1xW2xTwXYlvdTxNM5YxqcZ0bZLrkfkJ4lWX8qqEDO dcfqTzwMPR6U+ONVZF8zCWow1n15uGHbWDM8IzPLqA== X-Google-Smtp-Source: AGHT+IFecjzlwZCWC9hGQmND+h9du15cUgm27Fh3OgcOXx0irs/362chWEHXRwdyodfBRyRJkY6F7AS9A/nDP477DRs= X-Received: by 2002:a05:6a00:2d89:b0:6cd:e8c3:f733 with SMTP id fb9-20020a056a002d8900b006cde8c3f733mr1974241pfb.3.1701792058636; Tue, 05 Dec 2023 08:00:58 -0800 (PST) MIME-Version: 1.0 References: <20231204194156.2411672-1-davidf@vimeo.com> In-Reply-To: From: David Finkel Date: Tue, 5 Dec 2023 11:00:47 -0500 Message-ID: Subject: Re: [PATCH] mm, memcg: cg2 memory{.swap,}.peak write handlers To: Michal Hocko Cc: Muchun Song , core-services@vimeo.com, Jonathan Corbet , Roman Gushchin , Shakeel Butt , Shuah Khan , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: b4bjsx617mi9y1y1r6zurgweqe6x4j1a X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7E4228004A X-HE-Tag: 1701792059-592597 X-HE-Meta: U2FsdGVkX1/znCWA4xzgE3KfXG2olB3VJSSXVKBgXnb1Twrjl0GwFKa2RDv+RDmEyh4ZmhL6/0rnTBVU6X/joSnADzYY2WC4ce/82iXMgPeYk2/q2dTqaeUAjTDqOrgXXlAJ4eXseJFj0iuILbEnhrLY3Ye2SJCUWY/1WeW59e/hU6Le7xLNjLmbV6BkcWy9jG+7hWCWZ25TyMHAxSXtFeNlj4u2SB/SpqHovJfF0AD5R8Xpy7awIsX38RcXGdwfdj+01P0GqKqbomxG0A4qyi9BjRGmA1cldmfJnvhra9eGbe+YbDZcTv/8n9/XYTPC74dkw9xLD/LpPgD4MvC9iEZGIl+yDfQxZY2fl8lFouKebMpExjA6QJ3QM1Bng7xFkt3mX4WNncJqSAv4tx23ZCGKOPmUhcTzXMSO410q0YXt/AwHnNrKGW9HoULwnEN5P8yul6l8w0hd8twOXr8/H28pTDrWy2CpOjQXgsChlUbhigYaW9ni0ewuu8NjAJhVx9GiNRV9Jrcf0lJ1Om3NyVnIQwRjDJP9a0h97Chv6+QoHvIDrsDLwUh5zllttZnn1H67rVBWiB8t6u/HFtnmBo+RBo96vw4vCzWRtnUxzoFq2PvziB3Qv0s3F6ynFPubjxV93gFHhoLD9PN/4FY3s99Zz/uEczH5FNoaZ07WoExwFc7rts62T2qjlDDQj/X9KIGWKU/wP8YqmqHGWBgwitOmgNGX4PlJTH1H0a0CS+eyxhtHvi8XK0NHZ+LVIfgUcsJeonzQKa1xh5WnlYAeE0552O0q8yqv4xTDRY/mOG1y+fXNv23PKYQReAHRDwWOAc75W3+vBhFD0sDvPspwci98UOM8crfO6UqTF3aZ9Pl6stLkCpwV9IASaqtZECSUg+Q1JgdNfeLk2nLHHqqXgur8zBvGifFNgm6dmiB/nZflL1a6pgof5W3Z9ES7nfM3QBbe/ET+oMjQrUJSkTm gZdRXTjL ZZLUaYUeYqL9k+i+jyQCycTlYvTGvAR2k/Qnz/5aeDWUo35xbY2kFAzemNo2MKsbLID6tpvgEfpsvmCKdGTDQh5iCkZrs8R3ZDmkviZOB2xE1A++fqQ+IP05ng9USrfj7DmmmuiN93pDBXy7Yt2Gj2MkTRJMxhQiib+mwp0YdXlV+/OVKKobmVtbaqcdkqxNbTj/4nVj+T/c7JuFuIeuM8OBvXJuliRq6GJT8wEtxdhAMj6ZTtokCH7qrP3VPKHfO0o+H3JWEEtwS5R69prFxpOLPwj37wyns/QlWe+Wuo6SFJYlfM8Wawtt9ZOTUrP9lrHQH5fLMeNFmkDI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000035, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 5, 2023 at 4:07=E2=80=AFAM Michal Hocko wrote= : > > This behavior is particularly useful for work scheduling systems that > > need to track memory usage of worker processes/cgroups per-work-item. > > Since memory can't be squeezed like CPU can (the OOM-killer has > > opinions), these systems need to track the peak memory usage to compute > > system/container fullness when binpacking workitems. > > I do not understand the OOM-killer reference here but I do understand > that your worker reuses a cgroup and you want a peak memory consumption > of a single run to better profile/configure the memcg configuration for > the specific worker type. Correct? To a certain extent, yes. At the moment, we're only using the inner memcg cgroups for accounting/profiling, and using a larger (k8s container) cgroup for enforcement. The OOM-killer is involved because we're not configuring any memory limits = on these individual "worker" cgroups, so we need to provision for multiple workloads using their peak memory at the same time to minimize OOM-killing. In case you're curious, this is the job/queue-work scheduling system we wrote in-house called Quickset that's mentioned in this blog post about our new transcoder system: https://medium.com/vimeo-engineering-blog/riding-the-dragon-e328a3dfd39d > > > Signed-off-by: David Finkel > > Makes sense to me > Acked-by: Michal Hocko > > Thanks! Thank you! --=20 David Finkel Senior Principal Software Engineer, Core Services