From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C3D1C4828D for ; Wed, 7 Feb 2024 21:06:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E54D56B0085; Wed, 7 Feb 2024 16:06:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E050F6B0087; Wed, 7 Feb 2024 16:06:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCD176B0089; Wed, 7 Feb 2024 16:06:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BAF296B0085 for ; Wed, 7 Feb 2024 16:06:40 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 88CE1140560 for ; Wed, 7 Feb 2024 21:06:40 +0000 (UTC) X-FDA: 81766241760.02.4359CD9 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by imf28.hostedemail.com (Postfix) with ESMTP id A9CB3C001E for ; Wed, 7 Feb 2024 21:06:38 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=vimeo.com header.s=google header.b="P/PAKcCH"; spf=pass (imf28.hostedemail.com: domain of davidf@vimeo.com designates 209.85.167.179 as permitted sender) smtp.mailfrom=davidf@vimeo.com; dmarc=pass (policy=reject) header.from=vimeo.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707339998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NchtCtztTYgLVk31R6XXB+U98ZPDL1AD+o55ip7WTnY=; b=LDag3+bsxfqcFNZWXzUbshgZ1a1tC2BFKHRsHGCf+bLPOYPpR6cb12+UA4eYKzwXmdWg8s XyecBgJB5ZHDLex8zARCgYajC2D8ngGFbpBTu0b9vfhjSjWXhfiiO6VSgKdNY+dvulCx/a NjmY78pcbmwqR0oAUC7kUj6uRKhJa6Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707339998; a=rsa-sha256; cv=none; b=UkOZ2GWnkhquaWpTpn9vLFK/DZtca+T7gPjnBUAw20PILAsZMxBEQifL4hmarzL820ntEf 4GN5/Y7soAfUTvEVBtwcGSJgAZRvJ15Z8MYEvZA9n1FPA1LDrxGh+7zHpDyZ5HAS/Hto4O XZ+LSyD8/2H+Sn5m9hjleo9wJWE1V/8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=vimeo.com header.s=google header.b="P/PAKcCH"; spf=pass (imf28.hostedemail.com: domain of davidf@vimeo.com designates 209.85.167.179 as permitted sender) smtp.mailfrom=davidf@vimeo.com; dmarc=pass (policy=reject) header.from=vimeo.com Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3be61772d9aso558064b6e.3 for ; Wed, 07 Feb 2024 13:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vimeo.com; s=google; t=1707339998; x=1707944798; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NchtCtztTYgLVk31R6XXB+U98ZPDL1AD+o55ip7WTnY=; b=P/PAKcCHmiP9vN5J7MOdUaoHriKkSC/kOXlQz6+D7ePET4JVfKnh4iHMQ6CbP5zQzq WWZPk9NWFqin9wCDhfPBSym+SJXW2OTOa7j0lryEDXNl4k1A3+oi2/fjyKy2jm5e7x8j +qauOB0mtZswJkM+n7ceYoTcOedyYrvzOxBBU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707339998; x=1707944798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NchtCtztTYgLVk31R6XXB+U98ZPDL1AD+o55ip7WTnY=; b=LtFWgxBk+HSUb/PgtYX7hPRLo6NygKp3IKb2LgSLEtqCgVU/uKN2i2kCjySoUjMJRP /wpxktYvuwKJcmn1l6QJOMjOTj+jPPW4/Ci4S9LZEMEDE76fjt0DNbZcP4tsI++uNFB/ BoPYlzlJjAXIdNt9QeWIkEdCobVSizPg/kOOpnSi/m/xWPzqGxWupufbbzYEKKYecxSD kii1WRbIkB0eSEeJ90SSC0mbXHg1l3ATyn6L47XfdoYVzRp/xN4HR7NW1jQ+eEgOAUGJ zNwzJSBS8ulK3lMDpy8KU0iJYJGjcW9UlBpIGLd+739g9DkSQ7W3tDdZceOdE4EGE60P glDg== X-Gm-Message-State: AOJu0YyUNw21SZCfJwYDoiin6yHPYzCgaA2IODCNIhraKfM3QcHdseab bjCXHhtNX4odQWceAMmJzJvjCrrXfINV/YJmL2YPSWGD6fFk2obaFYVqHmmLK+XZI2qeOeuNZVG f/TjHhp7LhzMD9j8vkeMiXMSmkAUkJUN2VIisFw== X-Google-Smtp-Source: AGHT+IFHJ8RzBy8kDruajhclKaKc5G+oGuGhBt6+ikiR1rVtLI1ZIksnvJc+jThp9pyXy+1XUd/hTd9KJKxiBGbCd0Y= X-Received: by 2002:a05:6358:d09b:b0:179:1f6:4775 with SMTP id jc27-20020a056358d09b00b0017901f64775mr3847995rwb.31.1707339997647; Wed, 07 Feb 2024 13:06:37 -0800 (PST) MIME-Version: 1.0 References: <20231204194156.2411672-1-davidf@vimeo.com> In-Reply-To: <20231204194156.2411672-1-davidf@vimeo.com> From: David Finkel Date: Wed, 7 Feb 2024 16:06:26 -0500 Message-ID: Subject: Re: [PATCH] mm, memcg: cg2 memory{.swap,}.peak write handlers To: Muchun Song Cc: core-services@vimeo.com, Jonathan Corbet , Michal Hocko , Roman Gushchin , Shakeel Butt , Shuah Khan , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A9CB3C001E X-Rspam-User: X-Stat-Signature: athc5ep1xyirz5ke8u9qn9y7ugab44ot X-Rspamd-Server: rspam03 X-HE-Tag: 1707339998-326106 X-HE-Meta: U2FsdGVkX18VxLe/Fyjz7ua9zf5UOo/79CtbZi18iNwv+UBK79I+7pBdgOwZs2qIXZYauXDh35U/yR+4M+E/4FBUtBdBJtCyQv3Rs4vMoPDi3wP2uIn4oa3xrDveZACFHiFl9BZRaFj8nEtqsysPWNu8TWY0o70XVga95FN9GFRebBbzJg5lTtL+s0JUhYE7/8VG/AMhKgoC6qzCYMuFS6MGU7zpVRv++kGE+SbEEUsQHtWwQAbI7aQImtp4PQJDaqCwsogIm140nbfj+UvBj0Y5r0NxR+oZdtL0G1z6ZTLQIi/roIhJJRIX3F5CjXBKjshGvldFKG8U2+DkKrQVNuzHI3NI828WPNEoGMT4au3BWABkqyaVpUc3yMZX+viPfqMjYuBTIjqAfFYMEnUHq6DyfX75HqKy5H+wOfH5ShUu0Ehh5Vge80RqeZLUg1mzsmgpOlG10BpOKFSjO0kRmaFUl4YKo6ybgb1YKGCfX8AA6/0CfOZOMwa96EqqN3ZS8C8/jbvimTEw+eo1/BgUBvYa7hj//xqWHNn7n5LT4rRDgseZVFVCBqsbKMKcb5bBQa1mwWYujDfOOHLS/WOsfarN8Mo6Nx6Q7SJngO53eSfKp+pCaShk9QLD3fpfCQwmOBFSsN09usAefqBv1e2y4IuN57jPL9fjmWTolB0wGYkKt3XmNAtfLY/6IU4MiNERWJW7rZrJKo2555hqk0ZmJ1LudbYESnzF0vnKquBSOvpb4TxyJF65hrD7uxiVY2/dz2fq21s+GP1rLEasXW+aMIi0ZXfrmGOY/OgqO8s6CLNNSytICDPZ1ZPt71fzxOy/FPcRjyP0JdXdfwwgEbsfSfIQFVWV6l+WIM7getz+vC9yi6/yFz4xqSZ5G9LsTckF4JymlJWVTqD6U2qe2zVck0Fy5fB/my4fVOanNlGhigYZzvVAFNbprJLL5Hlq8F08RFpsfLqhEBl9LEaN/rO 4LxIXcID nlIRlFDP9sBjC42dVw/ea0FYfl18jLa9vV0fZpcDVNAIQlcBmLzwE5jONINzu9/bMCZbpizF3eXr2MGb6Ax2qAcaTTgRJ3FOcsq1u7bLT9IiEvowY150UrESQsfp+gpAFqEQMs2l4pIlBQmpj7bIsEezCojO9GrtIcYcTzXUU0vVvpL+qhPUDOEbu68O5YD3DDsjA4WxC+tiaOxr3mfTWZIgAmM6RyHsZUSDk28PJt9+Qe3nV4Dk/tTu+oA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Did I miss a reviewer on this change? I've clearly missed the window for 6.8, but it would be nice to get this into a staging branch for 6.9. (I can definitely rebase and re-mail if necessary) Thanks, David Finkel On Mon, Dec 4, 2023 at 2:42=E2=80=AFPM David Finkel wrot= e: > > Other mechanisms for querying the peak memory usage of either a process > or v1 memory cgroup allow for resetting the high watermark. Restore > parity with those mechanisms. > > For example: > - Any write to memory.max_usage_in_bytes in a cgroup v1 mount resets > the high watermark. > - writing "5" to the clear_refs pseudo-file in a processes's proc > directory resets the peak RSS. > > This change copies the cgroup v1 behavior so any write to the > memory.peak and memory.swap.peak pseudo-files reset the high watermark > to the current usage. > > This behavior is particularly useful for work scheduling systems that > need to track memory usage of worker processes/cgroups per-work-item. > Since memory can't be squeezed like CPU can (the OOM-killer has > opinions), these systems need to track the peak memory usage to compute > system/container fullness when binpacking workitems. > > Signed-off-by: David Finkel > --- > Documentation/admin-guide/cgroup-v2.rst | 20 +++--- > mm/memcontrol.c | 23 ++++++ > .../selftests/cgroup/test_memcontrol.c | 72 ++++++++++++++++--- > 3 files changed, 99 insertions(+), 16 deletions(-) --=20 David Finkel Senior Principal Software Engineer, Core Services