From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1D50C3DA4A for ; Mon, 29 Jul 2024 13:37:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 391F06B009D; Mon, 29 Jul 2024 09:37:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 341346B009E; Mon, 29 Jul 2024 09:37:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22FDF6B009F; Mon, 29 Jul 2024 09:37:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 05C346B009D for ; Mon, 29 Jul 2024 09:37:51 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 761FDC03D7 for ; Mon, 29 Jul 2024 13:37:51 +0000 (UTC) X-FDA: 82392893142.25.5765E44 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf21.hostedemail.com (Postfix) with ESMTP id A3DE91C000B for ; Mon, 29 Jul 2024 13:37:49 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=vimeo.com header.s=google header.b=htuq0fmi; dmarc=pass (policy=reject) header.from=vimeo.com; spf=pass (imf21.hostedemail.com: domain of davidf@vimeo.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=davidf@vimeo.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722260266; a=rsa-sha256; cv=none; b=R/ceAa/FPtKS/qAvB7OnanmwIxjnR4iQBPN6X0Yos3vvN7F4hvF6SPsm3Q7/LrRwm1p/Xh p+0FjjXHOJ6JDTRfyp5bmEkPr3q4Bc2nFA4ThLEQRcbWhfTH2a4V75bRxIvXKL8nCOjnpk 6LpHqrgk0KihmwhUwSV/dtfJAuzdZAk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=vimeo.com header.s=google header.b=htuq0fmi; dmarc=pass (policy=reject) header.from=vimeo.com; spf=pass (imf21.hostedemail.com: domain of davidf@vimeo.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=davidf@vimeo.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722260266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sVlA1fdRbUzGUAt+y6uU46luMcytNgyhT35LNSCEVFI=; b=aI8WfRj1YF5idffVmb8Mbr5AQYaALQkcFpkkWUZHdG5ctCJ+Fd8zDehZm9cBvTkRLNKIFq tQJ0pEAFSV9Ueh3oyQF6u5AK7wKVgIaMcg+fQrlAN7Toz6g3qdk47QtBvyh/JMFK7PNFSi swuSg5mJQfkYoPTv48R66MbXRvsFrjw= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-70ef732ff95so170687b3a.0 for ; Mon, 29 Jul 2024 06:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vimeo.com; s=google; t=1722260268; x=1722865068; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sVlA1fdRbUzGUAt+y6uU46luMcytNgyhT35LNSCEVFI=; b=htuq0fmixqbCR6a5Hc7YbXSPWyAIZ26c1pXEabmzCgCe0G500PJ9Ng7rgx/HXMJoyf JuDzhTnQtSSr7V7bH4azv2ojoWh0xYStdNLTwCkxGtdDi4S/5Jg4FsLKGzJlbkZbUT1E rPpMVeR/2xU+rtFSKl5um7DiI0DMKphjJpCYg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722260268; x=1722865068; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sVlA1fdRbUzGUAt+y6uU46luMcytNgyhT35LNSCEVFI=; b=eWr9I+mWMla+qKk9H1HB5v4t+uiV/65IK6DeVrUzI7Ybjc+cipquI0S03OfvxM1Bny 3IK8MQpCBXvqi5gpClgDc7tn4SvehnUiRkKJRnoK3Yz6tXVUv+ujsRR+jGzlhwishhqV +L9s7zeEjhzulneI38UxKMj3Vk61tm9QLgqHyUMrd4crtMuvol4stVM9O1inDom+C7fC VTDB3z/w/GCNNlL5dBXCB0IdvAsVFaSTY2p7R2TeE4JzVp0PmW+9dkOvpmT9Jv3S5Qh1 fS5ZtVLJwkqrKx/yEwyBW+Puuy+o2Fz94eUURFiKP992hZvhsUtDz5k0Vi8gb+HDYdjR V8JA== X-Forwarded-Encrypted: i=1; AJvYcCVGgbVzjuOM78JJJ12xCdiNTljK8dAoUQo7fQDW1l73tEuBD19FYMR9wurKxqJour/WpHgkzZaKbRgNxgdC5BoPgX0= X-Gm-Message-State: AOJu0YzETJYss2m/Ib1aFmXOYp3QzafXsEz2Z9yPsppkfmWrR7btzcVP 22rZ0xcKgmJOx6qtoyQD95HRYtFLDK2UlHdDdWYk8wye83KtlyhPEF7aQFlNnJG5ZS7g+X5PRN0 rlLzdHTvqiq7BnvpUQ1bpyVBfpppJO/guVJQULg== X-Google-Smtp-Source: AGHT+IF61PUOxYopexvONqf7EeqGxcofDSZYfNicSgd0cvdI1gdvPurED0XAgonezp6ozKF6WcHIo+B+gfQ7euXDvTg= X-Received: by 2002:aa7:88c5:0:b0:70d:262e:7279 with SMTP id d2e1a72fcca58-70ecea01412mr6938042b3a.3.1722260268207; Mon, 29 Jul 2024 06:37:48 -0700 (PDT) MIME-Version: 1.0 References: <20240723233149.3226636-1-davidf@vimeo.com> <20240723233149.3226636-2-davidf@vimeo.com> In-Reply-To: From: David Finkel Date: Mon, 29 Jul 2024 09:37:37 -0400 Message-ID: Subject: Re: [PATCH 1/2] mm, memcg: cg2 memory{.swap,}.peak write handlers To: Tejun Heo Cc: Muchun Song , Roman Gushchin , Andrew Morton , core-services@vimeo.com, Jonathan Corbet , Michal Hocko , Shakeel Butt , Shuah Khan , Johannes Weiner , Zefan Li , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Waiman Long Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: A3DE91C000B X-Rspamd-Server: rspam01 X-Stat-Signature: i3fkp4j7dneryuogcgr7mbifkxj3fa3i X-HE-Tag: 1722260269-473827 X-HE-Meta: U2FsdGVkX19+Q5dC/9HI4h/bnYtxSLd7+RdRXAtVgSBR4IpEa/+YhSe1GU+WGcn+xOb6QryV4HjguLSF0+7GERpJmCJjq3PvcXk0bQu+T6QD0SKIXUC08rVYR/Q3SrJqNg6Y44m1EBCkPBC+YaMZammpkmWmY/q+6zkgQorgmT2H50ttLuKM5PFaw5+9wDTCk2mXv+eJ0gXwff0QDkv/R3c4hASUsg3AzJxnwERjTYYf32kturrlceqP27mJIwWwcII+k/Smnisc8xRMpgUjSOroVMLkUWmyGqiA9eMskwAQ7EI5ZiVB9ifCOmpI/RKNpGoJMkuwQVM7yA6fJEIEP2bpn0KCkNLspGGWHz1TBeQzBKQgHQ1k5V8TvSvZnikxpnxrCTqQj4cNAsUoR7UWl7D5kqacpAn8IZ5diqNzFL9lxzoYdPTwStMaQC4syk3BdaX/hPMqKeoqlkgVqg0byi3HlfqDAI4j1f7oS3Lwt4jzOODAJ/cT8TVeJ5Atk4gYUEGXhDAbO9F7OnS9kJlZnHd4brc5/rZnHCqzOF/HWGjeliDZahap3wceU3zWHqkrJEbFXZa9w9MEBvRW7LVw8+iQyY5ptSd4qXwLknBZQJueVTsJ6K5YGpgS28jZjzcts2jVK8ilGxkoan4AGk9Swwy8iIUwi98h+XeLO6RJFu9Pe+qxJXPa4N9AghosML0goR2WqLPFEYw+9aTZZ2OpuD/MfWztLuDhbZDgE+b71dkIpzB9nkW6W+2iYfTBGf3HbXoZiFtLRS9skMfO6VMJrvp/4RDYh5GNbS3a2aPcXo9rBwh2uWJGi72BZHpuoqyu9anZahMogc8e2HB9zhqcEkzZ1OsheWmkL9fY9VoDMKX0EFJ0NQ9uZINsWgSIjkJp8qlVAupWMkgEj+F6tAm2AdEVzfBZrmEfgAVfrjHnWMU2rS2NAQgwkaiWZmUmpIp/WWAQEGo6r8auNnTksA+ KRgxTukr sdnnM8mAZ2u4qX2sqSiW1+/jYlySc74PzNZQCa9/h7YRA+AJ59lakfOssotIzaxyPsoKCPCeP4727/rDi8WO2/ZbDXlAiajkW+VpDQbbA/Zh82PDQFDxhO6ryJyH8bc+7QNs+sKghf1TvHTgeN75j5+5ixbP51r/doc8CZYmRsQjbK07lCyN81k99lSVAobKh6SSmxIVwsL3xoO9hMUWicyEBOA5HFdNnK4ix X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Tejun, On Fri, Jul 26, 2024 at 4:22=E2=80=AFPM Tejun Heo wrote: > > Hello, David. > > On Tue, Jul 23, 2024 at 07:31:48PM -0400, David Finkel wrote: > ... > > + A write of the string "reset" to this file resets it to the > > + current memory usage for subsequent reads through the same > > + file descriptor. > > + Attempts to write any other non-empty string will return EINVAL > > + (modulo leading and trailing whitespace). > > Let's just please do any write. We don't want to add complex write semant= ics > to these files. Writing anything to reset these files is an established > pattern and I don't think we gain anything by making this more complicate= d. I still think something more limited is right here, but it seems that there's consensus that accepting all non-empty writes is the right option here, so I've removed the check. The next patchset will accept any (non-empty) write. > > Thanks. > > -- > tejun Thanks, --=20 David Finkel Senior Principal Software Engineer, Core Services