From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE4AC3DA70 for ; Tue, 30 Jul 2024 15:52:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C09496B0085; Tue, 30 Jul 2024 11:52:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB9336B0093; Tue, 30 Jul 2024 11:52:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA7146B0096; Tue, 30 Jul 2024 11:52:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8C26B6B0085 for ; Tue, 30 Jul 2024 11:52:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 30A32403CD for ; Tue, 30 Jul 2024 15:52:34 +0000 (UTC) X-FDA: 82396861428.23.F48FB76 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf23.hostedemail.com (Postfix) with ESMTP id 41EB5140016 for ; Tue, 30 Jul 2024 15:52:32 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=vimeo.com header.s=google header.b=UCg2JcMg; spf=pass (imf23.hostedemail.com: domain of davidf@vimeo.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=davidf@vimeo.com; dmarc=pass (policy=reject) header.from=vimeo.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722354697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rw8Qsqd/KZkDjyfWp80nFufRwrNoDRQN85CCZLcmUUU=; b=0E7kw8Iu4C5fCR0k/O2Zd8idYhhdOOwzXzEgiKw2uDxmmHbGOfCuY9Y+XIhdAdn1nem4Rm GPPn538D6/oluLVeLUGxDjjnxkiCiQMUi+8clxAv1BNaFZe0eelS8SLIlha7Ki5BjP695H m8YotN03QePugiW1szj8ofKOVmZXE/M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722354697; a=rsa-sha256; cv=none; b=khfb9MhnvkgJ5LgZ3jjImriPIC941AYKDKnPWUbmHF06ZJr/8bMbDy/K/AgEoCg978K6bO BdVJn7VNtKAEM3cn8JGAEDzJgfAZIZCIw3npCQIUMnFXSICs1f490ZI6zx7tYN4d6BqiYn slWdHzQ9hmNuyvCn92BuwL6Bn3GPzHA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=vimeo.com header.s=google header.b=UCg2JcMg; spf=pass (imf23.hostedemail.com: domain of davidf@vimeo.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=davidf@vimeo.com; dmarc=pass (policy=reject) header.from=vimeo.com Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-70d153fec2fso3656274b3a.1 for ; Tue, 30 Jul 2024 08:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vimeo.com; s=google; t=1722354751; x=1722959551; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rw8Qsqd/KZkDjyfWp80nFufRwrNoDRQN85CCZLcmUUU=; b=UCg2JcMg8vYOnq2FoT2LIc1qOZlMLuwNaOAtMd3BHgm7jrAcU4CpMz7J8zWZr/sboS fLKXSSfYHB/4DAakpdZbvUc7Sv1TI194NNKAz6D9C4lHSjNG7K0cIjwGlRl3KYI55VzO p7BLFg0tx93IW9+VyXd41W8LLPHwocDnGk85s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722354751; x=1722959551; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rw8Qsqd/KZkDjyfWp80nFufRwrNoDRQN85CCZLcmUUU=; b=XVt1xdDOGThVEjRDEZGfxS/Bg8rFssHFlK23HbFLhS/cF8x2y6WNcG54O+/d128Myy ANJ6qX89NCyBPNSD0s+sWsbFKXSwys6M7qF6ix+8cWR2USl47TCQI7AAcmKe+0nq1wj4 n5yS2j98bXYFMQEi1Fl1km0KKmz/CSCt1wWEfKodztiVE10eNTGALEoz+9HxTsMSKCpg /whnzqxcipnGmzy9nN7F6GC0KCWRjkmNwfE1ctioSnnmFkIqGYqxf1ZWX/CGTjSDo8xo TQo2wbKqKdChz5lcUvnAmeJ5bz6dfE2b9yrGRmQddwiwORPkrWPQVg0dtI2GCkvN+Pbk Qg/A== X-Forwarded-Encrypted: i=1; AJvYcCVL/3Yal8H8j/ZvipocvLND/6L9Oak5IAHwoKDN4rUHwCKs9FPdwIM+HQTMbKObjfmT+6RFNRymm9NM8a9V1v2q8B0= X-Gm-Message-State: AOJu0YwNCZ0dEacp1nQjXhMduD/bNAnlYGYnZZKPnAT0nyJQmT4PjRVF ZfumtPEGqvorzcxetImB4G5nuYfrAYr980BSRXCSUhXw7fbaiybscUvcfCLARSVwSRs1/sdtmIc tsTcjlGZxkDHoJEbamzzbqYmtBWi9O2lt7UZOKA== X-Google-Smtp-Source: AGHT+IG+hWn0qpzI+yyalb00iWHFGVyVmH4evfniZ+5SoF6jRo3s3Rz7MBI2RP6u3735TGwDrdJVwWS3SMyNdBUpnWc= X-Received: by 2002:a05:6a20:7fa4:b0:1be:e1e1:d5de with SMTP id adf61e73a8af0-1c4a12f7ec1mr14013708637.30.1722354750705; Tue, 30 Jul 2024 08:52:30 -0700 (PDT) MIME-Version: 1.0 References: <20240729143743.34236-1-davidf@vimeo.com> <20240729143743.34236-3-davidf@vimeo.com> In-Reply-To: From: David Finkel Date: Tue, 30 Jul 2024 11:52:19 -0400 Message-ID: Subject: Re: [PATCH v6 2/2] mm, memcg: cg2 memory{.swap,}.peak write tests To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Muchun Song , Tejun Heo , Roman Gushchin , Andrew Morton , core-services@vimeo.com, Jonathan Corbet , Michal Hocko , Shakeel Butt , Shuah Khan , Johannes Weiner , Zefan Li , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 41EB5140016 X-Stat-Signature: 1mdhhfws6rgwt6c8aujwb11pn5ffqicq X-HE-Tag: 1722354752-77015 X-HE-Meta: U2FsdGVkX18f+9I1UQH+k/CgaZ6VJWH6k5sbpz2qfc8+7U3e+NN+QbmPu4HefTlDpeKyLEuJ8gQwMXio9zFKvnElP+vtcrspJrKcC5Nvp1J0EoP7lxVENPE09VLdx/bGYGE1+mZd+cGGCEDwoSPezF/jEfmxSE7P+n9OMX7zbMtt8X3YdO2OeBmYLIqN1CHQxG/Mxrwwb7sCfJKdx/01FeAYGadr14alqfPCYozXFeUkLw16iG6kHRtxnHqwrUJGuGSdT6viZB2SGJnhMpRlLxHLUj//DxFURD2c8+feD0NzIQZfdieeTQSMQkwhMwQvjzK2cUy+crn6Kpb1DwNtaDMdfKcYvW1U3gFRVgvhuCEjQeqKPJsDwMJ0FXRxarAgtLkAXabJCOm45IqlBcyWEAUtNJ0dPw12pSaJaGCfDxQBN7vgOUJt8ZDU9s/5trakWMWEpFFCLjczQINb93Pgg+lgvH2+arJO9MMIBAJaUC8ha70c8NR4it2yTL4QGo4wUs46MEF22DN4USRDTAefIZNM96CaMIEVQkzX+qs8A5ytSFUQwL4C/RKx6BkanCyLLvqa01HeiNgmlhNU1502Umlqbt/aFk4rtx2cNd3+eDJ+auY//vZt+WwmairSdLfVYDhyCcbEuY8hYJEQGIy2sdoqmuKwOe/IpCeQH3KRh6xe3dwACp56qp7QrSGtRLuqtN2L/0CbuGhIoalSvs2NqS5spwkPBK/HybvGmidQb/uUnKAfifcjDs/J7MgsdHT3PzTWtQu2gj0Qbtymn/2pVo7AJlxW9il/Eu6LUsgC1p83cDTb7l7N7jAeVgOyVQTSIFh4Omz3Fov+rGn2wYRjUkNsvjtoUS0c3Zu/P0GkijjeuMbDH+YXTP9YRoYb95A2C6SYvM0E1zytFIbocPl+vOAKDznDpKGk/yqitLksUzzIQW43mIlwcUmiaez4cV0re9rIXJLnKZ1Ec7JWgys FEhouinA TFsnZXqnJHgWaoDcAfGSeGaB5bBjNwYBYqJkRafkKal42Pt/xdBJtlZfxpMRXSA998JPlL8+bPnAOdj80/DfNzoHUROynZVgsu4FlFL6jQSqAkkmkYb7sUR75eeeckvQZgjSIzQjGrMBWR19GAl2PqaSqgfUrzDjACwT8jwUEWcRpMskOuVitvs3tKlILLS2PB95NL0zethGxeX6xKjbxtFaXOBTr6KuMCwFtI4HHQkGqN+moJzIY7hL8Uw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks for checking! On Tue, Jul 30, 2024 at 11:46=E2=80=AFAM Michal Koutn=C3=BD wrote: > > Hello. > > On Mon, Jul 29, 2024 at 10:37:43AM GMT, David Finkel w= rote: > > Extend two existing tests to cover extracting memory usage through the > > newly mutable memory.peak and memory.swap.peak handlers. > > BTW do the tests pass for you? Yeah, my tests pass when running on top of an ext2 mount. At least one of the existing tests failed when running out of tmpfs, so I've been testing with an ext2 mount in UML. > > I gave it a try (v6.11-rc1+your patches) > > $ grep "not ok 2" -B30 test.strace > > ... > 315 15:19:13.990351 read(6, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0= \0\0\0\0\0\0\0\0\0\0\0"..., 4096) =3D 4096 > 315 15:19:13.994457 read(6, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0= \0\0\0\0\0\0\0\0\0\0\0"..., 4096) =3D 4096 > 315 15:19:13.998562 read(6, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0= \0\0\0\0\0\0\0\0\0\0\0"..., 4096) =3D 4096 > 315 15:19:13.998652 read(6, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0= \0\0\0\0\0\0\0\0\0\0\0"..., 4096) =3D 4096 > 315 15:19:14.002759 read(6, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0= \0\0\0\0\0\0\0\0\0\0\0"..., 4096) =3D 4096 > 315 15:19:14.006864 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.= current", O_RDONLY) =3D 7 > 315 15:19:14.006989 read(7, "270336\n", 127) =3D 7 > 315 15:19:14.011114 close(7) =3D 0 > 315 15:19:14.015262 close(6) =3D 0 > 315 15:19:14.015448 exit_group(-1) =3D ? > 315 15:19:14.019753 +++ exited with 255 +++ > 313 15:19:14.019820 <... wait4 resumed>[{WIFEXITED(s) && WEXITSTATUS(s)= =3D=3D 255}], 0, NULL) =3D 315 > 313 15:19:14.019878 --- SIGCHLD {si_signo=3DSIGCHLD, si_code=3DCLD_EXIT= ED, si_pid=3D315, si_uid=3D0, si_status=3D255, si_utime=3D1 /* 0.01 s */, - > 313 15:19:14.019926 close(3) =3D 0 > 313 15:19:14.020001 close(5) =3D 0 > 313 15:19:14.020072 close(4) =3D 0 > 313 15:19:14.024173 rmdir("/sys/fs/cgroup/memcg_test") =3D 0 > 313 15:19:14.028517 write(1, "not ok 2 test_memcg_current_peak"..., 33)= =3D 33 > > grep "^315 .*read.*4096" -c test.strace > 12800 > > Hopefully, unrelated to your changes. I ran this within initrd (rapido > image) so it may be an issue how rootfs pagecache is undercharged (due > to sharing?), instead of 50M, there's only ~256k. > > To verify, I also tried with memory.peak patch reverted, failing > differently: > > ... > 238 15:30:29.034623 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.= current", O_RDONLY) =3D 3 > 238 15:30:29.034766 read(3, "52801536\n", 127) =3D 9 > 238 15:30:29.038895 close(3) =3D 0 > 238 15:30:29.043048 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.= stat", O_RDONLY) =3D 3 > 238 15:30:29.043230 read(3, "anon 52436992\nfile 0\nkernel 1105"..., 40= 95) =3D 870 > 238 15:30:29.047379 close(3) =3D 0 > 238 15:30:29.051491 munmap(0x7f2473600000, 52432896) =3D 0 > 238 15:30:29.058516 exit_group(0) =3D ? > 238 15:30:29.062992 +++ exited with 0 +++ > 237 15:30:29.067054 <... wait4 resumed>[{WIFEXITED(s) && WEXITSTATUS(s)= =3D=3D 0}], 0, NULL) =3D 238 > 237 15:30:29.067136 --- SIGCHLD {si_signo=3DSIGCHLD, si_code=3DCLD_EXIT= ED, si_pid=3D238, si_uid=3D0, si_status=3D0, si_utime=3D1 /* 0.01 s */, si- > 237 15:30:29.067210 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.= peak", O_RDONLY) =3D 3 > 237 15:30:29.071349 read(3, "52805632\n", 127) =3D 9 > 237 15:30:29.075470 close(3) =3D 0 > 237 15:30:29.075562 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.= peak", O_RDWR|O_APPEND|O_CLOEXEC) =3D 3 > 237 15:30:29.079712 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.= peak", O_RDWR|O_APPEND|O_CLOEXEC) =3D 4 > 237 15:30:29.083848 openat(AT_FDCWD, "/sys/fs/cgroup/memcg_test/memory.= peak", O_RDWR|O_APPEND|O_CLOEXEC) =3D 5 > 237 15:30:29.083970 write(3, "reset\n\0", 7) =3D -1 EINVAL (Invalid arg= ument) > 237 15:30:29.088095 close(3) =3D 0 > 237 15:30:29.092209 close(4) =3D 0 > 237 15:30:29.092295 close(5) =3D 0 > 237 15:30:29.096398 close(-1) =3D -1 EBADF (Bad file descriptor= ) > 237 15:30:29.100497 rmdir("/sys/fs/cgroup/memcg_test") =3D 0 > 237 15:30:29.100760 write(1, "not ok 2 test_memcg_current_peak"..., 33)= =3D 33 > > This failure makes sense but it reminded me -- > could you please modify the test so that it checks write permission > of memory.peak and skips the reset testing on old(er) kernels? That'd be > in accordance with other cgroup selftest that maintain partial backwards > compatibility when possible. Sure, I'll add that to the tests in a bit. > > Thanks, > Michal --=20 David Finkel Senior Principal Software Engineer, Core Services