From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA4BC3DA4A for ; Mon, 29 Jul 2024 13:45:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAAD56B0095; Mon, 29 Jul 2024 09:45:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5AA16B009E; Mon, 29 Jul 2024 09:45:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C22516B009F; Mon, 29 Jul 2024 09:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A4F556B0095 for ; Mon, 29 Jul 2024 09:45:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D41CF1C15DC for ; Mon, 29 Jul 2024 13:45:33 +0000 (UTC) X-FDA: 82392912546.23.B33A897 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf15.hostedemail.com (Postfix) with ESMTP id F31D9A0011 for ; Mon, 29 Jul 2024 13:45:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=vimeo.com header.s=google header.b="cG/rf/WR"; dmarc=pass (policy=reject) header.from=vimeo.com; spf=pass (imf15.hostedemail.com: domain of davidf@vimeo.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=davidf@vimeo.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722260688; a=rsa-sha256; cv=none; b=GeKjkfF2C2ntHoXDI469HRvRyQLvJF+5jvGXOTtVCIdqfo6sJ99e/xwGrCse2PtdxM7gZZ tLhdaBG9MGQ6Thl92SZbyTwO2JzoM6HAfUqTAqpVpU1+CTjI1bJmUoDjdFRcYiElHsJHro 75NIDtc7q8W/D//aoUaFRUTsSwk+3vU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=vimeo.com header.s=google header.b="cG/rf/WR"; dmarc=pass (policy=reject) header.from=vimeo.com; spf=pass (imf15.hostedemail.com: domain of davidf@vimeo.com designates 209.85.160.48 as permitted sender) smtp.mailfrom=davidf@vimeo.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722260688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RvamCnhF7r32z4+iKhdiypORBTSaJg1fy8qu9w6+n+Q=; b=NesBLC0Rnpi2/FsKYu07oYP2mwogcBh4JbLTH+WolVghcJEtO8qkW2TG1P+WhMnHHBhk3T V5F9V8+PI8OdK1SA5r99rFGMYiiEY1wEr8EDKaQ4Ev0QrfxpLX0TqsUKqAlc+z3ZvILKXD Ng6Lp8wnv/pqlSXbPMDGhzvSMAZ3Yq0= Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-260e208e126so2146392fac.0 for ; Mon, 29 Jul 2024 06:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vimeo.com; s=google; t=1722260731; x=1722865531; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RvamCnhF7r32z4+iKhdiypORBTSaJg1fy8qu9w6+n+Q=; b=cG/rf/WRRY7GyjhSPuQDdeCQcoY4wRxmGCDbWsXAhk1j9j8u5hyNLtJqfvLEb5J6Jc 5/33rio/ohcJlWXUzBnrzLkcq0SD61jYkBzOpoxJHQD2EOzItFb/5ziJf6BHs4jWTFFS S+THus17Y/JYGLAZiTplVq1hr5wPQwLUKlj7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722260731; x=1722865531; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RvamCnhF7r32z4+iKhdiypORBTSaJg1fy8qu9w6+n+Q=; b=UicjU4aDumd2dcPbmOERDIAVpLZo9QshL0dQCwkTXXFGXqwLgj7xoKlY450zpOesG1 uVfnjT7jzveGBpbGC3RsxzyMh0vjI+mnelNm33vzDp0zTdo8qLRBIl6RKXQOs9PjHmZC vpx/MJD0gHiTdX0po40vq4D3DjRxDR/Y0eepNTmDYyvbsyscsvwkchFEnbmrSDnI159B FEcZgh99OebbTfKWVYKp6VmxrzqS5a6dESB3keO6JCdENKOkIIwW4nHhzVwKZvKrnNDm 5GDF2FQmL323Bcq88pLMZ+zf8hmB0daVbrgYFatNKPg+i07svyyFyuFw6CZWr0q6B71r OMaA== X-Forwarded-Encrypted: i=1; AJvYcCWfRQLqT/HlEn5oPyGFchSyQueUgr5NJrdMLIK7KHRzwfUElhqHYSMSiSCOQfkRIFYfYDwPAhlK8LIUuBLLL6qSCMA= X-Gm-Message-State: AOJu0YzJIKTPkOEfp+PLLmO8wpBjq0Eoff6xDj1qSh04xIcRSXhDnNsX jn9pTNz1k/p3xj4TMEBwW30Oe0yLF55ajCvIH9CQQ3Nf+10TupEHhbXdr3sjifJY3b5CtO0uaZ9 Kw7Vjs9EWQ8Xy35YfiuGqwoOClb7KfpajCJBs4Q== X-Google-Smtp-Source: AGHT+IEFP9e4qIdr7UC4mf6+Bt/3WALRELF0sMdPXc268DI1l6R7la56+gngTQsJwz1LeWuy0PGz8j8iM4PosZlpRlY= X-Received: by 2002:a05:6870:569e:b0:25e:b732:a913 with SMTP id 586e51a60fabf-267d4a4492amr8753349fac.0.1722260730750; Mon, 29 Jul 2024 06:45:30 -0700 (PDT) MIME-Version: 1.0 References: <20240728131824.51628ab73f6318fe62e85742@linux-foundation.org> In-Reply-To: From: David Finkel Date: Mon, 29 Jul 2024 09:45:19 -0400 Message-ID: Subject: Re: [akpm-mm:mm-unstable 36/78] test_memcontrol.c:201:6: warning: variable 'fd4_closed' is used uninitialized whenever 'if' condition is true To: Philip Li Cc: Andrew Morton , kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F31D9A0011 X-Stat-Signature: mrhgnw6kdtockmwngfy7hkfb5tneogh8 X-Rspam-User: X-HE-Tag: 1722260731-46410 X-HE-Meta: U2FsdGVkX19PSJfsEmP1tIVASMQ1zVEExSbv5urL0PPMcmBUhuqhD9Usgw7X36sv29qEyi2FwKtgzQH9GRZvQp0ivejQd8EcXX9W8551X0ylxnzOps6RrpducUCJKfXbir00owxTXNkacpfhLBHMYJuRpMNmv6+VWisom2IO5ODB0oAoyVtbzAsak4hzIOkuk4O8KmkdZhpNgN1tNkc7fzHw6qqx/C9vK/ltfHd748SbQgKWSsHv6qrqvgHQK9LEZn9gz0BNaChizLEA/lEH6OFoQFUeiaAIWpdXwErRex/J31IFPgcQksJpXKsCsgvrCC76nwrUzkX4jMGa67BAaWRaZYQmB6m4DtcqYpS2kqJcsWos7tmcYR3LrNFSD5P+nc6L3vU3j3WgxzlEI09ZtU1J665tXpkbzzfQbuy5bxXV2TFLJCHUA0uA7CvYbeeNY7XnJw1tYTP0RMyEKe5+o+yTABsdFcae+p5yJEF2QLiF/87of03EEJtdrJ40RBBmuTjzVnZowvR2k+QO1tK9X72z78d8998ONsXGI9O3ghevUMvUFea29XHJKQIYHpghu9oKOu37ZcV9YA3rogcZdL1SHCASCSSxJ+bPg0mkXFh9I/GkP0R5riOqevqQHyypU3XrdzdJHp3IWXqP5Ufxu3K8A0QzQnmYu4qrdolAedbgepN0N9VEVfsVyg4cQPJk+CyA7qF+WMiaKcYIok/0npovl2eiYn5s0rY1Ja4ENUk24FWJn/Px1m45l6IoiO14TiyIpzrpqqZ4ltCdZkCGMnWv9V+FU9QP/m1AC45Q/GbF2T2LpXVNibbEHGC5ZC2go1/BRNBUO6B4r4YX3ZFhVaPCfM06yjqf6nH1CwXGQQfUmClRyi1F8IKRYhnkJpKBrOZlFwZHYrY/62RiKXMCrdGBeXZSyJdxUuT7RbDDPK5fYpdB56CSKmi1FyQAFboGQx/B3RGd+UchvHrWApc VD/hSpkD OyKAYeq7GecBaigpk5mCX/cSVQfgHNgteyfjOFo1t7iqWvrNqmi+VKQAYj1H+TZeeHEzuNZAFe/OKD6WW9yp9Un59Y7VZOxG8V7Yf2Ruo8/0HuDabSFmCDq2q4/U7mGn+tLX8l3g4qhFKsUn1GmLpI98h+b6mGFqJOnZGBoqqscFqGAPBLRqPgobqf9vIM2xYLlbEOqDpQ9ZL3e4fFExwaHh/gF/JmM8I0zVNNT0KYLPzxOExVfLoMc+dMi+OyU3UAzgnhE+vfVvT+ZrtRBWT6VjuzeIhpso4vVcqpoUsqBBgDnrsxxIkKD50uIxB+17Mfm6Cd6gSSaJ8EiM6otpHGw5sPteM2iqw3g+c0l2VhzMezUX+w6NO4O2hNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.024740, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jul 28, 2024 at 10:21=E2=80=AFPM Philip Li wr= ote: > > On Sun, Jul 28, 2024 at 01:18:24PM -0700, Andrew Morton wrote: > > On Sun, 28 Jul 2024 11:58:47 +0800 kernel test robot wr= ote: > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git m= m-unstable > > > head: b39b3892d20a337489c55806f91af581474f3943 > > > commit: f2db5cca8182337f4ad485ebfd532b1a2d1c223a [36/78] mm, memcg: c= g2 memory{.swap,}.peak write tests > > > :::::: branch date: 2 days ago > > > :::::: commit date: 3 days ago > > > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project = 617a15a9eac96088ae5e9134248d8236e34b91b1) > > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/a= rchive/20240727/202407272301.bBC2CidR-lkp@intel.com/reproduce) > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new = version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/r/202407272301.bBC2CidR-lkp@intel.c= om/ > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> test_memcontrol.c:201:6: warning: variable 'fd4_closed' is used un= initialized whenever 'if' condition is true [-Wsometimes-uninitialized] > > > > um, > > > > bool fd2_closed =3D false, fd3_closed =3D false, fd4_closed =3D f= alse; > > > > fd4_closed cannot possibly be used uninitialized? > > One possible flow is early peak_fd fails to open and go to cleanup, then > in cleanup side, the variable like fd4_closed is directly used. Thanks for pointing that out! My next patchset will move that line to the top of the function. (Looks like the same issue is present for f2_closed and fd_3_closed) > > + if (peak_fd =3D=3D -1) > + goto cleanup; > + > + bool fd2_closed =3D false, fd3_closed =3D false, fd4_closed =3D f= alse; > + int peak_fd2 =3D cg_open(memcg, "memory.peak", O_RDWR | O_APPEND = | O_CLOEXEC); > + > ... > > cleanup: > + close(peak_fd); > + if (!fd2_closed) > + close(peak_fd2); > + if (!fd3_closed) > + close(peak_fd3); > + if (!fd4_closed) > + close(peak_fd4); > > > --=20 David Finkel Senior Principal Software Engineer, Core Services