From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ADBCE7718B for ; Fri, 27 Dec 2024 10:38:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 810596B007B; Fri, 27 Dec 2024 05:38:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BFF76B0082; Fri, 27 Dec 2024 05:38:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 686F66B0083; Fri, 27 Dec 2024 05:38:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4AB886B007B for ; Fri, 27 Dec 2024 05:38:07 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C7D434706A for ; Fri, 27 Dec 2024 10:38:06 +0000 (UTC) X-FDA: 82940388048.18.B679160 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf13.hostedemail.com (Postfix) with ESMTP id C07962000E for ; Fri, 27 Dec 2024 10:37:23 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SrwhJgdZ; spf=pass (imf13.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=ubizjak@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735295855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rit5793Z1jyJsC3PPwhCT5xVk4eQUf7+Uz6g8TD0Wa0=; b=CAphpOi4adS+wRcpOEhQtLCKPLWPMavhrozdNGpjTNANultJY8PHg+yQaI2vKoH/zTNDCH blfe3JDvYmU9C6OQGXzCm/G6DhhulvIPkvP3jwVe6mP2oztnsKMJGFX7hPVVaOvoJqmjf/ kfzLbIUpVlN7Y8bOSGEtqshCdmsr6Xw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SrwhJgdZ; spf=pass (imf13.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=ubizjak@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735295855; a=rsa-sha256; cv=none; b=1NP1Joi2n5KCQzaikMpmTcYD6Ga2ObGpVZi0s25eruHlXwm82wHCmCCT0b8iz1G3EkYyFZ iEplJxL5veuwWX9XpAda2VWlxMLPI9TvsKiRX+9DZSjaDZQKyaEmhtLdMRxkR1gUyeAgvM PIk2OeR70Y/aLGS28Co+CI/VjmjW9n0= Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-30037784fceso76264911fa.2 for ; Fri, 27 Dec 2024 02:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735295883; x=1735900683; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rit5793Z1jyJsC3PPwhCT5xVk4eQUf7+Uz6g8TD0Wa0=; b=SrwhJgdZ7RyWZ0d63DDFqJDh0cqBxBo5QxaH380OHj9Zcb3WVGrMgyugMIk87MEe3r sIGHHqcOYvR943jD586IrH7G13NskG+eBN8WfW0Sa5ZBr/aTkOne8uJR/z9pSxhHepoc 3qKGac05tSZUBuV3w98wceagFfL2hI7xqhJUARLhYOnuS0C4yopGpbQ6LLozjQGflfVX 2VMgbHkH2hfTP5q607Cz6zK1wU0GemUnInjbCEBi3OuKxAulmLORvS/QXPjaF8cCyC0h +GNWSxiOtiayKsjjz847mC/301KuTMSxnJuWCgGVRIuqYhjfKo8KelDO5aG9kNodAe4I yT6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735295883; x=1735900683; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rit5793Z1jyJsC3PPwhCT5xVk4eQUf7+Uz6g8TD0Wa0=; b=KAG6WV+Z05y8v0n9ZwFr/xcCq8ixGb4WLUUlLaRj8VQXg2lTIeg5g5UYdVubnN1cVu bMCD10Okd5OJzDJ68OERtxnw9ZrSIJPbFyC44OkB6dp3Yxf9qSCIqMR02Xr1j1d41Ba8 Jo7x7NqFnwiRw2cyDJVzBJLBh8rcKneLFXjTEELL1lE0e/r2xiSdADIOYaANawQh37Bq QhPR3yB5KAgGXkJWcGxzvOChD7sDvdWi03uQShwZroJJbjDIl5zcjOV+Ra1puGUM6Hzh Wo9iTo2MBT38idgNxEqHoOCJZG6N4DDE+Wgimyq7rn/ODkqbYpfTtgSQRCenVJ3nHIeb zqMw== X-Forwarded-Encrypted: i=1; AJvYcCUI1iBruwTcnBy+OsQ8WE9DJN1VojH/Sq93XEEz+IQCcNZcapRg2oXwFOrB98LLqZ7WLNZIs2D3VQ==@kvack.org X-Gm-Message-State: AOJu0YyoShJ/hXNjAkyTTm9y5JYk5E4HPRVJ7fvwvvhn6TV1tHBtHd+v Zcxp6joBXu9/R//xTRxkkvMZoUsl3kCgcS6r4lal2pVn7Sm8PSRwDcv3eJtg0ctKZkyiUSToc0g FVRrEnP7zk+GCaqThR5mrS+MfrAY= X-Gm-Gg: ASbGncvsFPCuZSt8wSbYD6a/HIJuVcrZQ0DZJb7TY0R0eJomPDUbepgxrT5JdJQEZOh 1Dx95AU4qhZWUJ1kF0PEuHXtwiCrr7tLk+fqIuw== X-Google-Smtp-Source: AGHT+IH6LR/WCER6maITXOiKqW1fY1IARUutGHuJbB33rrpi1TOnc0wKM08YIunc5j58j1H9IO/WMnM9cJKmjAigylA= X-Received: by 2002:a05:651c:4007:b0:2ff:d7cf:a6cb with SMTP id 38308e7fff4ca-304685506f3mr76367931fa.11.1735295882753; Fri, 27 Dec 2024 02:38:02 -0800 (PST) MIME-Version: 1.0 References: <20241227092311.3572500-1-guoweikang.kernel@gmail.com> In-Reply-To: <20241227092311.3572500-1-guoweikang.kernel@gmail.com> From: Uros Bizjak Date: Fri, 27 Dec 2024 11:37:55 +0100 Message-ID: Subject: Re: [PATCH] mm/kmemleak: Fix percpu memory leak detection failure To: Guo Weikang Cc: Catalin Marinas , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Stat-Signature: si53dkspp53eco5xecucrtrra5r1eifp X-Rspamd-Queue-Id: C07962000E X-Rspam-User: X-HE-Tag: 1735295843-672434 X-HE-Meta: U2FsdGVkX1+LklJLxtlMWkelVLxOiOZr79HpMmBTnUwTanW1kKkVh6PBO39Ad5Q0mOfchD8BwMVgcasG9fV4yQNrNGe6eWPzDPpFyZgeyQM4cELuHnVK7H2ttAvTBIWOZgvumPOfCXhQBtK/bovgeBOYzXhsbfCO9DQ2ywwvIKCNouSNLhE9WpGmEAzBbs0YFOKSyXUAqN2xQOPYJ9KXxDFYlKhk6NAPl4v/zR3FaYmWcf+gNxYKaLyGmOIlsT2l+EWphYJDKe/njEplEMNUv8HrAgbxjyXpPwsCAbpcI2K3hf1dy+b93OdA7925wzgf6iKx4pExUkTU25eBSJSkJsnGHo5oFSG6+0tYFpTYEw0XZQEhAfaRv+dzH37A+s5HMqIhUnOfQF989zGceOE90tm1x6h1WH86MoROk5kPrFBqt5xDNdmrb81FLojtn5s9EeIkqOKWaBwUTf2onaMpzY4l/OCyy64YqYVwH8FnX7lKaaRg3upe7WK3WnbQSbKA2PzrbChDOhYW1AOazGhDMgQaOdNDoYbE7ds4U3qz6fqyN6vbS58tqiAhsA53WifRONI7fLtW1MDlm8iZe2ydIt8/Qgje/8KD0eWIR7NNWq4US05oGKVxXct+nSFkhgv+W3tW5COm8zzw5V1Q6n3Q7lxNkXy28gdTfSNCCCR9Sd58uMzxUfhmSgS0TBMVLiNjA9iNcSmK9Tk9NQKFXTjjUwA/22iGDDj3cvllncv7T/dkwUpdJ4NxWw5AxjHTGODa5GRzrP3dLupBuTjgTGg8gBu1LaJhQ4kIJ8kXV+Jc+6pmyOJfBOsuS5soibmXX9csjuDxTnuluOFE702QP2USJBSYSrKSch3lpZKa3jCSF+y2E6jNXrEoPy2AorHRSWKlVdu3KJA2seA1hH0qHQu+GCrvCFBmPdpvNxzgzX2daik5Lq2Ei32zcp0co/M0rJqFc43dR02+VVvIfS5qq+4 jFkxyFAJ 1nk0eZjV0K0NUEMO7Z+SepmBcahyS4scn8xEwlaOxR5jp0l93DlWqJtF20i51VUIne9BWpQQikcTw//q9CJKPLy49OIbzPNF9la4IJnX4X1rx/2CxtubYEdvI3ap2dRMrddGndRL2XjLJvh7b6IDUwWVVvzklmaDIJuCi04nXIGZ3aqSFhU1K7EDXd9qZk4V8Vj8XMC3Dj/UqwTJ2lhTmcoGfc/zjymJcaiv0QR63Pw8tkWiS8+gKRYuSpo4U0Cl2ODzVMLy2tSJ9CdFl21mmJ6Al+0z78QPHyc4DliuwW7y26RqvGn7SXMzmYwl08tyGNQKR/uNiC1n76siQhEMoa3jDMW8KxPdHhEMvXAUJz6zEEW1wyrp+f8+biuhmHQeyjPM0p2jk5iu974nGqRCHEmKeoN6TLwrG9QWm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 27, 2024 at 10:23=E2=80=AFAM Guo Weikang wrote: > > kmemleak_alloc_percpu gives an incorrect min_count parameter, causing > percpu memory to be considered a gray object. > > Fixes: 8c8685928910 ("mm/kmemleak: use IS_ERR_PCPU() for pointer in the p= ercpu address space") > > Signed-off-by: Guo Weikang I don't know how 1 turned to 0, the change was definitely unintended. Acked-by: Uros Bizjak Thanks, Uros. > --- > mm/kmemleak.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index 238ab733fbea..982bb5ef3233 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -1093,7 +1093,7 @@ void __ref kmemleak_alloc_percpu(const void __percp= u *ptr, size_t size, > pr_debug("%s(0x%px, %zu)\n", __func__, ptr, size); > > if (kmemleak_enabled && ptr && !IS_ERR_PCPU(ptr)) > - create_object_percpu((__force unsigned long)ptr, size, 0,= gfp); > + create_object_percpu((__force unsigned long)ptr, size, 1,= gfp); > } > EXPORT_SYMBOL_GPL(kmemleak_alloc_percpu); > > -- > 2.25.1 >