From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA69C0218C for ; Mon, 27 Jan 2025 07:29:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AAC5280122; Mon, 27 Jan 2025 02:29:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 258D12800DA; Mon, 27 Jan 2025 02:29:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D426280122; Mon, 27 Jan 2025 02:29:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DFA172800DA for ; Mon, 27 Jan 2025 02:29:56 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8A27A1C9A6D for ; Mon, 27 Jan 2025 07:29:56 +0000 (UTC) X-FDA: 83052407592.11.8BC7272 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf21.hostedemail.com (Postfix) with ESMTP id 9C3AB1C0004 for ; Mon, 27 Jan 2025 07:29:54 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EesMAK6T; spf=pass (imf21.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=ubizjak@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737962994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nlFPUNZNmTT/fqJfoPzgiLYWVcF58U28m9n95TFQH30=; b=I/geBGgedIVIXVgortos+BE9ddIXUd+D2Cbbe2EIm3THg1eC6hXbWnNo4rpmrnsKz8rs/6 CpCi/MQORdvSVtLS6kXiPlYd/YrI7du9TqJ6Apjef/VMGzAasfFkWS9gKhxsEcPqG0QYS9 +jWsfib3r245BNd6aHIOt4d6rBtjwMQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737962994; a=rsa-sha256; cv=none; b=a8tt78ombmlBYEYqh7zVftBrhQkaQk3QioiR5S5V6MYZM896ajFVjl5Pg368/qB3ZvV5rI NnQYjddMway4cU2tjUEx11+bsC4+ycrqg+ob7MuWhKgFYWQxIG67LAfJIVraboMj9nCslJ 1C5KW3CBuq0qrO9DV2odQuicdfK0BFc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EesMAK6T; spf=pass (imf21.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=ubizjak@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-540254357c8so4092950e87.1 for ; Sun, 26 Jan 2025 23:29:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737962993; x=1738567793; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nlFPUNZNmTT/fqJfoPzgiLYWVcF58U28m9n95TFQH30=; b=EesMAK6TxZj7Jge3yjq5HI4i6Vnfw4t3a3ZcHK9n9axOS7FkmDA46qzG4yjVS527zA QCFNgt0xo8j3cq+zFVO+Tow9vPVfTLW23OET93KQUgUeidMqhlVhmH9VzRgjTvlYHRN7 Y7CbqgABr/Kgswhe5qfgLmvbjFv0m3z3CZf5B+NvRihXDBlgMcmqhsJGY7zypfxDgv3I uVztEQ4hLL5SiNgYPJvqWvIWSdET5hyt4iZPs6epOfvcSqEsagApH+M1VZ+yPiGHgZSn 5xAQfphxKMvT3pM4fBgw2VjPpqG6Z7qDG51cvOLAkrz13mEtUJBEOV8nbRwEn6WG/r9v Zmkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737962993; x=1738567793; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nlFPUNZNmTT/fqJfoPzgiLYWVcF58U28m9n95TFQH30=; b=rvis//cQRhMdoSqG8LprIhq92p5HbNoRjnsxDAKgS9cAVavBZvAMemEtaanQX+Le7y 9utAPGlHFf86ZARgdikiA/SxiCW81URbwqyJ7bel6ZaX7E9fe4F4fbUBXSFCgco6T110 PzLHnDn4GTe9tKTVPfRsAsMf1yNZ84nDP5opyNIf0HDvoWPPnGYE4xA1MXSIguCb4aH7 UXaMW2zqx2HXImwZNRWDA58LRsC6zUhg8l2mPhPQ8sZTzHFHbYKNEoyTv8RueNynhnDf KA7g5/0US2EmIc9oBwhRZ8QcE6w8w2F8pBABcQsVLlySxzZpIx0yuKgoWV4n41lyVJL5 LBAA== X-Forwarded-Encrypted: i=1; AJvYcCVAKZM5F3mT/8+1mofd2+YvAcMLMrVqScYlRRrTnSsuG+0eEnEzxzX3pWjZPLsbc1VfWpFD54vR0A==@kvack.org X-Gm-Message-State: AOJu0YzJuh1RRrOhNksvPxTXoP1nTFNS1T8QN1hwepB1N5gJ0jzrpp4f E5JkzMIDvWPEz5JsqL5ykDARLlhIj2u0yz1yZ8775asp67O5FQVPGz1J5vNPoDSDawdgnkWNgLM jIFDhuLOn4g3CoHV4tloXa+7HfcM= X-Gm-Gg: ASbGncu3yttE36l/NfI7ITsTt+dx7mRZbMjEro8sPxyxa/fUaSGqrmTYd+NBCAErTJU cNKbBPAdk5JjtwS7bc16tZzmd8U2VTYVeKZzGm59VWyRaWsLJG0wYMNCDRUPDZw== X-Google-Smtp-Source: AGHT+IFKHHu8z+BRAsAe3bUUE4EvZZl7P9+RhGruUxkCv3dxXmHBoJ33tcV5plsQfKIaFhj71TSBWxSDDBy23mwr9no= X-Received: by 2002:a05:6512:3409:b0:542:9883:266 with SMTP id 2adb3069b0e04-5439c27fa18mr14896481e87.37.1737962992436; Sun, 26 Jan 2025 23:29:52 -0800 (PST) MIME-Version: 1.0 References: <20250124162248.60104eec848619a187242392@linux-foundation.org> In-Reply-To: From: Uros Bizjak Date: Mon, 27 Jan 2025 08:29:40 +0100 X-Gm-Features: AWEUYZlxijuhNRbQvLSAWHRwXNj1eC2FNE9fRUjz6AWjy_FntumLUPkqMLz8cfI Message-ID: Subject: Re: [GIT PULL] MM updates for 6.14-rc1 To: Linus Torvalds Cc: Miguel Ojeda , Andrew Morton , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: o7azh5ueq7zri1qy5idrcu4wn3znwpm8 X-Rspamd-Queue-Id: 9C3AB1C0004 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737962994-703358 X-HE-Meta: U2FsdGVkX181OIFsI2pBKebwZHoL/Dm+LeuxR3sKCv1pfncjwpJqpA6UB1iCMTkSWX/wmoQGCY0/fDseRUAQ9CHjuhAan2EkeZNVVQn6+jlHBm0UXfwGDt3fG8GcIr62bQJUQBjzlRZozmhG94TGsfVMVH6ylQ92rpUxWNlIUBFSiYY1On0ZABaU4tBv/vgwyaNhm1u52SbbzUIaR+GwVFME4PinRwZeog8JqCzBzcegn/X0+oBeKZTlehDykdh7wUbiM8GJSO4XjWzvd5NT5DycrgY7biikA1G8+3/m6hN9QLSFk/YLVEIhtB5i3tCj4CsXoh9/JAjVObX4Jb3ru1fUCMNy+cZXqIu9uGyT9NnNW+bq8++tjNbP18a6M8bAL2C2PkK91ZTt96cK1msKtT6pakzz0dWxumza6rA1F7XdGaHOBahnkp5on/I+URdYme/KNPnJaY8VwkPdWk2vk1MT7jIzId9y7fIEVchzNuyw+LD4S6psEo/t9m1E+q1/bQJDwejkIzjTnyTl3Vwe38kWLPi0mlcYROMD7+XeInqOAMM2FfeQh3CoiPexxJNwE3ZWB5M4ssJyvuGQDPK8hEzGWNSwbRq8r5QbWDEHXcSVZg0+mLzY5zqSVatPwtKWRXI6YOPn8tHKmEYBc6kYKZ3Wkkfsr3M2LGfBbPMp4UJfwmENyxNe375q4BRNc8jsI521RaXe1bcQ47G9Tppw2Na8qCD1/PIZ4wU92Nnk/SnMjEhJ5lnE2CtW1DsCYt+vuIHF/5cQsmxm3w02DH0dNq74/ncIiTqD3QUPPcVs3X+YJ07yFioHPXWnufc2K7CZ683BXMj+nYk1mJNZnAF4cwZ0SZtmzwNwp1bCvgAVu/NHfylMqgXpToKL0UQdrCKShGk9UGZlJwBDQbg5oen0iOPuNbonPclm3TatU/PoeBKg/E591GablGxwrD/Vf2gcEcngJD99DRZO+pB9Z0E k6Jgn+a2 Xv3hlmkddvimLXQ+k914IUddu2lknnud2eVFyObSvLyGgv3RKzX9u/cdViNBYINFjRuHauNjxA4qyj4VeT1OmrTmDi5d7GtxAIMSAE4cptEjLxm1M1MP01UgLo0sYnGpmTHardcW8C4K35Zg8+DjuhUHoD+TW6KAXl5ljm72RSXiPFzHBRYg5cpVXdqBW1quZ6FsYXqGFTbMUHObuPhart5LBaIqejrSq6UR6rFzdiuCdKF4+toV8gqspzhyGOMKyQElyUEqTiR7THMNa5q7hkLX5RzwkCc7oFBpHUxHZXq8nUbBYqOxEfk/Hy6PIqUmzShIAUxUJtxCmLhFQMCck4WZaWyePP0B3DM5PFBqYSUms1KH0t+PjJa+NKkpPA4EGTlZ3nO6CpZs9LJuecCXjgUlqPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.035548, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 27, 2025 at 1:08=E2=80=AFAM Linus Torvalds wrote: > > On Sun, 26 Jan 2025 at 15:27, Uros Bizjak wrote: > > > > The detection is put in include/linux/compiler.h where we can > > consolidate checks for both compilers: > > No. Please. We have compiler-specific header files for a reason. > Exactly so that we do *not* need to have disgusting tests like > > #if ((defined(__GNUC__) && __GNUC__ >=3D 14) || \ > (defined(__clang__) && __clang_major__ >=3D 19)) && \ > !defined(__CHECKER__) > > and instead it should just be > > #define CC_HAS_TYPEOF_UNQUAL (__clang_major__ >=3D 19) > > in compiler-clang.h, and > > #define CC_HAS_TYPEOF_UNQUAL (__GNUC__ >=3D 14) > > in compiler-gcc.h. > > And then in the actual compiler.h, we could do > > #define USE_TYPEOF_UNQUAL (CC_HAS_TYPEOF_UNQUAL && !defined(__CHECKER__= )) > > and now the places that then want to use __typeof_unqual__ have a very > straightforward way to check if they should do so. Got it, I'll do it this way. Thanks, Uros.