From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B1BC0218D for ; Sun, 26 Jan 2025 23:27:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 665D4280111; Sun, 26 Jan 2025 18:27:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6155B280110; Sun, 26 Jan 2025 18:27:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DD4F280111; Sun, 26 Jan 2025 18:27:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2ED0B280110 for ; Sun, 26 Jan 2025 18:27:57 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D1BDA1A1E8D for ; Sun, 26 Jan 2025 23:27:56 +0000 (UTC) X-FDA: 83051192952.06.FDFFA45 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf21.hostedemail.com (Postfix) with ESMTP id EB3EA1C0003 for ; Sun, 26 Jan 2025 23:27:54 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IrDlTIzv; spf=pass (imf21.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=ubizjak@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737934075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3IRwCnv7W7pXatZi8FC19DBe9YIc5UlOSytWvb/DyOA=; b=zKm4k2Jxa3ogJyYdLBIkdgP1h688TkPOXwySEFT9//L9wXZVd1jgDVYsIkkOFirZOfBfX7 9jqfiwajvXNDcZATQbEtbFMS4FUCVL3IC6K3bb0fzNFtMkJAt1ehGKpB5R7nUidgg98+IV RWJHJuBXwlbyPny+Kqb/1M6tvpQYeRg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IrDlTIzv; spf=pass (imf21.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=ubizjak@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737934075; a=rsa-sha256; cv=none; b=jVDxx68H2NK0P3UtF/qmWV7QwtfUX54ID3oDQjO7TGofUc7pHz+ZzxA7Mk6WRVltJok5AO 3cw2iwhiy0oSz5qMoa16LdUOEz2KaAJJNBQ6f70/AweiBRiZ52ENkPmcMtnKiozX36bfm6 4pOD7S2p44x+cxn2lFar0LDl26P6Gjo= Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-30613802a59so42010821fa.0 for ; Sun, 26 Jan 2025 15:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737934073; x=1738538873; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3IRwCnv7W7pXatZi8FC19DBe9YIc5UlOSytWvb/DyOA=; b=IrDlTIzvFnIeHSwiwveO6LdefSA2ZS/EpI3nKzQm176D+jopRwkUmJQHLMo/mynDO0 vShrnZ54bYRAbAN8neg1I1c5poocXdmAwEpO9vZEM8w5yMqpQaNUwhXgTQF6bbt+UKNV if+k9fLwRiZOaJbjMU/KgN6ipejrNHJP6KQpZqDZx4Ow8c7f04zJ8d1X0s+EB0DQeK9J b5XrMxluxMrrEdcUOrzeUhGY/QXGYvHZtDSUkCITBQTle3uMmZNNthbBwrxrqV7ZbU8l HbcMa4WInUYdz1+TVlGC0QhZHVVyjm4fN78gRBNCVwtVh/Wu8JljMP1o8FC7AY2N9nJp mb+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737934073; x=1738538873; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3IRwCnv7W7pXatZi8FC19DBe9YIc5UlOSytWvb/DyOA=; b=JzZwKvoC6BoqhqgI9vbAXh99T399l4u26ZQTJ+5qLJ4v02EMz8BzoxusOJkR4p+73a H+kl5O9oNeusLxzXDbCjVFT3UhAUzJwDJUXwwn5e5qTIWccTNHuwuPtEOimdgba+QTjp iVJvUM3OF8TxN5JODp9XJe0QPxl5iA82PEZo15cRDFxldZSvFFn1BKKSREJMguYdMjnf HWgtM5iXgrzKgLBoWjzXzFffAucufTMVxxUhYpVeLb6ml7Cza8aPC/gL8WxXNWpQWBfT 0gydC53fx0vBGOmUU2bQ9g95byjPEFlkQx7RdlLv0vZc2QwRbqVDYdtFvMiqb0sx0K32 gVqw== X-Forwarded-Encrypted: i=1; AJvYcCU3lVjtOfLY1DFNYwNtHl/aAQFHjfdpOWANYZRm2KT+nvyG5re+oCbd3SKdNjNesDalt6XKiZnLJQ==@kvack.org X-Gm-Message-State: AOJu0YypZkL6HCkBC2tsrjkvZ40lGZoOWS21UcwqtV5EIsXkIbZw9dsG Ci5lQo8CrmpqEdC7EbcDG9R7VBAxX/GQJ+rGbl2XHG7/GlPXQSD0pRP1vMmy7W/n1qyI4EU7CtN hQYFSrotFnk+IEBGPWuQlqoSBrjc= X-Gm-Gg: ASbGncu3rgw78LVKbljtFdlEIkY43k2y6BiHBOJ5scoMf3t7NuL4SHE3njQMVMTJGou BFKPtQPOgLk5cyO+LbdhVOAN1xOSDi5mA0sSh9LrxR/rNW/82gSPoZwxszfDgRw== X-Google-Smtp-Source: AGHT+IF0hfD1QLAUjhJOhP9juTjaQr9SX7CyasHVYeczo0EabLdSjUt1Zl5DQQqqF9oE4KI8LdQ6wARPhaJUWq08VbM= X-Received: by 2002:a05:651c:501:b0:300:33b1:f0cc with SMTP id 38308e7fff4ca-3072cb3cd3fmr167929911fa.34.1737934072816; Sun, 26 Jan 2025 15:27:52 -0800 (PST) MIME-Version: 1.0 References: <20250124162248.60104eec848619a187242392@linux-foundation.org> In-Reply-To: From: Uros Bizjak Date: Mon, 27 Jan 2025 00:27:40 +0100 X-Gm-Features: AWEUYZldCS95-C_CY74lGUf-7ro2thZvXRcJtAU-V2rnBGmh4kdpc6IEIMF3_oY Message-ID: Subject: Re: [GIT PULL] MM updates for 6.14-rc1 To: Linus Torvalds Cc: Miguel Ojeda , Andrew Morton , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: multipart/mixed; boundary="0000000000000dc00d062ca44fc4" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EB3EA1C0003 X-Stat-Signature: ctfetokog58zypfy6aprsz5rnme6irqo X-Rspam-User: X-HE-Tag: 1737934074-866980 X-HE-Meta: U2FsdGVkX1+GTlEA4JrnPSQPAwsvglTudq2PNk6oYm9/GD47ztFAn2TlJKFADhYXiSvBNcKGXb/l5HmfYZB8FIrkHMjoSX5kSUNb5Xq9Av/zjj1h6vYMW70BCAaJIzMIuAVFEoiSWGrGkmL2Dy78yTsgiNNe0gQHFu/Z89DGRRywTzG6gFrBCE/nhGGrKJtwB9A+bok3/BgynBWvgkvHxFptrPPp57UiteVzaLi1j5PiVmQSQAWMTmv/iT1bAo2iCYNBVjhWEo2R+LqLZASdrRgtxVCYz0jCfBPgPNxBzL7m7GuP81yoGb1aop7VLPO4ukcsvL0LgtKpt+VXuim/YJLtG4EYxN8TTHCpNCwAtPOgiGtZQKZ3XyrOhZqDmerCmlJOjn6JoBEV2+5k7p0+5UYdf8bComHugR/2evRJC1sfprVR0vaLYDFuQ+ZYMVoRph/yyXSuXnHvSTlHhnLPYfSw3F3NCMrRTJwSypyWWOMz8jt5Ec/qat++8rWbq3XhWH9cq+hhkhtAva086yvahZ9ix1rc9y3B8OfMApOCpUABwdXEKu0HgjbzlE8Xh3AO6u+TZjAzwfsJr5Pw3QPN6vDuDtUXoSavAXE0Nj+P77VIMD37/MItY0mGWr5qCG0pRhIudta9ecR1MchfbvHqiwC5433hozWo6bQRdehu5wYXla/Ji2FodnSSlIaDGjT/DRcajSKZCdyzMq0bkuIFFAV546SyKpaIXp4fLFYmzO62ywueDBanyX/CDHzQdd6B7i6MiB+9zPxLlm587Jnr4WWr8ZP/xaBae+EKDKVGDRPXDtOvLzx7EPX4JeWXah7Nm9boC+swyZOImPAzoVxkgr2XQgl1qHXuAsCL6bEkR2gtnoxacMKRrDwP1E134QOF7qSJnphsyDdmtwzQW/+wPkknrWFTFjVsWjvVIVp7aoIExo0bW2B+HmEZM70JRvSU81QDHTUWYE78cIX/34x HoAj6Q1d 9VzGJK9E/K83IG4eSEZhV2wnJeKFZ8Xx4MsrYpKduw0aIWGOGgaxSAoOnwZsiPgihu9ZJC5z1BSiFv9Q6gaGIc3EyYAVnr7vPt78eQhf1HFNQtV3nJCnX66FeFrgfAJ+eemuGU1ZZ/8c2/fuMV0MwOoW1N/3lETeNEBjHG4Muqt4AdoFd+zau73eCf+LL3RcJEBpDdfkRTx5jo1g2X3in01uJ1CxqxMVvyKbiSMcgVkHKRfgzLecMtKsQcVEGxhAhy4dqkQjdx6tDgASTxEpEItQMA+QKyJ0/gFLJ6DFIkq08SU33ftktFmF4PIHVA7vQT0FWsl7EaG/KVFFl1XKX8jS/Rf++DODfL+yqZEA+Xu7MnTLVc4TqfiS6JO4l6mUznaGQ88dzqOMOlOzkxEpnssQaUjqx4Ps2fevMhhDWMulvrwcoTs43K4ictUrUs9/2Wz5FkB0eLQpDwVa51ZeTGIeFYYJrLJv+7g/2McBJHQwFFbZGsD6tFZDfGg9qnr4bXjg1cTzPXQ/tSpEvxvVd0zgALCjoe6FQJNw0AVsJFwPhLB2LGW58I8ZAEP7nJqa1inzkcQaA1Y1FMQzglfOkJHtgtRiynot3Tc+hhj8/bR4v2+Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000330, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --0000000000000dc00d062ca44fc4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jan 26, 2025 at 11:00=E2=80=AFPM Linus Torvalds wrote: > > On Sun, 26 Jan 2025 at 11:47, Uros Bizjak wrote: > > > > > #if __clang_major__ >=3D 19 > > > # define CC_HAS_TYPEOF_UNQUAL 1 > > > #endif > > > > It is available in gcc-14. > > Ok, let's take that approach, instead of messing with CONFIG_CC_HAS_xyz. Please find attached an incremental patch that implements the proposed appr= oach. The detection is put in include/linux/compiler.h where we can consolidate checks for both compilers: --cut here-- /* * Declare compiler support for __typeof_unqual__() operator. * * bindgen uses LLVM even if our C compiler is gcc, so we cannot * rely on the auto-detected CONFIG_CC_HAS_TYPEOF_UNQUAL. * * XXX: Remove test for __CHECKER__ once * sparse learns about __typeof_unqual__. */ #if ((defined(__GNUC__) && __GNUC__ >=3D 14) || \ (defined(__clang__) && __clang_major__ >=3D 19)) && \ !defined(__CHECKER__) # define CC_HAS_TYPEOF_UNQUAL 1 #endif /* * Define TYPEOF_UNQUAL() to use __typeof_unqual__() as typeof * operator when available, to return an unqualified type of the exp. */ #if defined(CC_HAS_TYPEOF_UNQUAL) # define TYPEOF_UNQUAL(exp) __typeof_unqual__(exp) #else # define TYPEOF_UNQUAL(exp) __typeof__(exp) #endif --cut here-- The above also consolidates checks for __CHECKER__, resulting in a much simpler compile check in arch/x86/include/percpu.h. I have tested the new patch series with a bunch of compilers, works as expected, but it is getting a bit late here. I'll resend the series tomorrow, after some more testing. Uros. --0000000000000dc00d062ca44fc4 Content-Type: text/plain; charset="US-ASCII"; name="p.diff.txt" Content-Disposition: attachment; filename="p.diff.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m6e92crf0 ZGlmZiAtLWdpdCBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL3BlcmNwdS5oIGIvYXJjaC94ODYvaW5j bHVkZS9hc20vcGVyY3B1LmgKaW5kZXggMWVmMDgyODllNjY3Li45ZjA4MzFhNWU3MTIgMTAwNjQ0 Ci0tLSBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL3BlcmNwdS5oCisrKyBiL2FyY2gveDg2L2luY2x1 ZGUvYXNtL3BlcmNwdS5oCkBAIC05NSwxMiArOTUsNyBAQAogCiAjZW5kaWYgLyogQ09ORklHX1NN UCAqLwogCi0vKgotICogWFhYOiBSZW1vdmUgdGVzdCBmb3IgX19DSEVDS0VSX18gb25jZQotICog c3BhcnNlIGxlYXJucyBhYm91dCBfX3R5cGVvZl91bnF1YWxfXy4KLSAqLwotI2lmIGRlZmluZWQo Q09ORklHX1VTRV9YODZfU0VHX1NVUFBPUlQpICYmIFwKLSAgICBkZWZpbmVkKENPTkZJR19DQ19I QVNfVFlQRU9GX1VOUVVBTCkgJiYgIWRlZmluZWQoX19DSEVDS0VSX18pCisjaWYgZGVmaW5lZChD T05GSUdfVVNFX1g4Nl9TRUdfU1VQUE9SVCkgJiYgZGVmaW5lZChDQ19IQVNfVFlQRU9GX1VOUVVB TCkKICMgZGVmaW5lIF9fbXlfY3B1X3R5cGUodmFyKQl0eXBlb2YodmFyKQogIyBkZWZpbmUgX19t eV9jcHVfcHRyKHB0cikJKHB0cikKICMgZGVmaW5lIF9fbXlfY3B1X3Zhcih2YXIpCSh2YXIpCmRp ZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2NvbXBpbGVyLmggYi9pbmNsdWRlL2xpbnV4L2NvbXBp bGVyLmgKaW5kZXggZWFjNTgwMjVlY2ZjLi43YTUyYmVhNGJhNzYgMTAwNjQ0Ci0tLSBhL2luY2x1 ZGUvbGludXgvY29tcGlsZXIuaAorKysgYi9pbmNsdWRlL2xpbnV4L2NvbXBpbGVyLmgKQEAgLTMx NCwxMyArMzE0LDI1IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCAqb2Zmc2V0X3RvX3B0cihjb25zdCBp bnQgKm9mZikKICNkZWZpbmUgcHJldmVudF90YWlsX2NhbGxfb3B0aW1pemF0aW9uKCkJbWIoKQog CiAvKgotICogRGVmaW5lIFRZUEVPRl9VTlFVQUwoKSB0byB1c2UgX190eXBlb2ZfdW5xdWFsX18o KSBhcyB0eXBlb2YKLSAqIG9wZXJhdG9yIHdoZW4gYXZhaWxhYmxlLCB0byByZXR1cm4gdW5xdWFs aWZpZWQgdHlwZSBvZiB0aGUgZXhwLgorICogRGVjbGFyZSBjb21waWxlciBzdXBwb3J0IGZvciBf X3R5cGVvZl91bnF1YWxfXygpIG9wZXJhdG9yLgorICoKKyAqIGJpbmRnZW4gdXNlcyBMTFZNIGV2 ZW4gaWYgb3VyIEMgY29tcGlsZXIgaXMgZ2NjLCBzbyB3ZSBjYW5ub3QKKyAqIHJlbHkgb24gdGhl IGF1dG8tZGV0ZWN0ZWQgQ09ORklHX0NDX0hBU19UWVBFT0ZfVU5RVUFMLgogICoKICAqIFhYWDog UmVtb3ZlIHRlc3QgZm9yIF9fQ0hFQ0tFUl9fIG9uY2UKICAqIHNwYXJzZSBsZWFybnMgYWJvdXQg X190eXBlb2ZfdW5xdWFsX18uCiAgKi8KLSNpZiBkZWZpbmVkKENPTkZJR19DQ19IQVNfVFlQRU9G X1VOUVVBTCkgJiYgIWRlZmluZWQoX19DSEVDS0VSX18pCisjaWYgKChkZWZpbmVkKF9fR05VQ19f KSAmJiBfX0dOVUNfXyA+PSAxNCkgfHwJCVwKKyAgICAgKGRlZmluZWQoX19jbGFuZ19fKSAmJiBf X2NsYW5nX21ham9yX18gPj0gMTkpKSAmJglcCisgICAgIWRlZmluZWQoX19DSEVDS0VSX18pCisj IGRlZmluZSBDQ19IQVNfVFlQRU9GX1VOUVVBTCAxCisjZW5kaWYKKworLyoKKyAqIERlZmluZSBU WVBFT0ZfVU5RVUFMKCkgdG8gdXNlIF9fdHlwZW9mX3VucXVhbF9fKCkgYXMgdHlwZW9mCisgKiBv cGVyYXRvciB3aGVuIGF2YWlsYWJsZSwgdG8gcmV0dXJuIGFuIHVucXVhbGlmaWVkIHR5cGUgb2Yg dGhlIGV4cC4KKyAqLworI2lmIGRlZmluZWQoQ0NfSEFTX1RZUEVPRl9VTlFVQUwpCiAjIGRlZmlu ZSBUWVBFT0ZfVU5RVUFMKGV4cCkgX190eXBlb2ZfdW5xdWFsX18oZXhwKQogI2Vsc2UKICMgZGVm aW5lIFRZUEVPRl9VTlFVQUwoZXhwKSBfX3R5cGVvZl9fKGV4cCkKZGlmZiAtLWdpdCBhL2luaXQv S2NvbmZpZyBiL2luaXQvS2NvbmZpZwppbmRleCBhMTUwN2I4NzE0ZTQuLjdmZTgyYTQ2ZTg4YyAx MDA2NDQKLS0tIGEvaW5pdC9LY29uZmlnCisrKyBiL2luaXQvS2NvbmZpZwpAQCAtODk3LDkgKzg5 Nyw2IEBAIGNvbmZpZyBBUkNIX1dBTlRfQkFUQ0hFRF9VTk1BUF9UTEJfRkxVU0gKIGNvbmZpZyBD Q19IQVNfSU5UMTI4CiAJZGVmX2Jvb2wgISQoY2Mtb3B0aW9uLCQobTY0LWZsYWcpIC1EX19TSVpF T0ZfSU5UMTI4X189MCkgJiYgNjRCSVQKIAotY29uZmlnIENDX0hBU19UWVBFT0ZfVU5RVUFMCi0J ZGVmX2Jvb2wgJChzdWNjZXNzLGVjaG8gJ2ludCBmb28gKGludCBhKSB7IF9fdHlwZW9mX3VucXVh bF9fKGEpIGIgPSBhOyByZXR1cm4gYjsgfScgfCAkKENDKSAteCBjIC0gLVMgLW8gL2Rldi9udWxs KQotCiBjb25maWcgQ0NfSU1QTElDSVRfRkFMTFRIUk9VR0gKIAlzdHJpbmcKIAlkZWZhdWx0ICIt V2ltcGxpY2l0LWZhbGx0aHJvdWdoPTUiIGlmIENDX0lTX0dDQyAmJiAkKGNjLW9wdGlvbiwtV2lt cGxpY2l0LWZhbGx0aHJvdWdoPTUpCg== --0000000000000dc00d062ca44fc4--