From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E53AC5AE59 for ; Thu, 5 Jun 2025 17:32:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 340286B00CC; Thu, 5 Jun 2025 13:32:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F0D86B00CD; Thu, 5 Jun 2025 13:32:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 207B06B00CE; Thu, 5 Jun 2025 13:32:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F2FAB6B00CC for ; Thu, 5 Jun 2025 13:31:59 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B2BA41A1156 for ; Thu, 5 Jun 2025 17:31:59 +0000 (UTC) X-FDA: 83522039958.27.338C808 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf01.hostedemail.com (Postfix) with ESMTP id BEE6940013 for ; Thu, 5 Jun 2025 17:31:57 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="JkOuh/tb"; spf=pass (imf01.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=ubizjak@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749144717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y8nWB/WLZe/CCeemauG5YdXkbxl5jf3QmnhrkUgxLHk=; b=mfrMYlDjHsEU/ke5oleBmuQygrpKwOIip3FQS8F0Fm6ydjmjIERIZAdR2k02rHVtRh2bj9 oagK8x97XkUdv1dgrYykF/t+qdKkX9z+TXq01yZWdpKHf7i/W8rxmx4Ul938VLfb+CyTZG 9VzNdYOvX+mV/jp8/ef0ecTDuQ2FPxA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="JkOuh/tb"; spf=pass (imf01.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=ubizjak@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749144717; a=rsa-sha256; cv=none; b=ajDp5f51V8Vbhc/1q//FwcgQW6csIeXSvDWY5guIYz21BxsivWNdYj4djfp8qp475iB+Ws /y0Re8s+RdkbmXLEyZPfX/zceQ1GDCY6M1F0h8fkEYCN02UTHw18q5iD20UtsUNqUdEYT0 +tj71xi/4cM+Rd75Y6Y8Wz5sH4arPHM= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-55351af2fc6so1598652e87.0 for ; Thu, 05 Jun 2025 10:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749144716; x=1749749516; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Y8nWB/WLZe/CCeemauG5YdXkbxl5jf3QmnhrkUgxLHk=; b=JkOuh/tb6XZeoyOCRTRlbAeJM4EmklELn8tlbkVnImX4MPhlfpo8uai6d640OX64M0 fBHZNmORSyv/cb6q5cKAt3vhdr0A+9VTY8hq3ZYfulaT+Fmx52cg9mnmZ4vsyCIXKfIZ DBj5k+jxK94bqPWXSgnQaXHWs5PItmaoxQIxAKw1i6rUwMTYv3BPLMeimmjipHh0P4m+ uQTZZ4+DjpJ/jiKCxO8/DXUkmGv1LmY+7QkS0VGKNcxna2R3K7NWmN5JcdCIsuIWHhRP wh8l3IFCNWq3svTQMr5SG7D0Nv0uNz+RbVRFdliPbsQq5jiINkzMyozN4SfrB7eOHiBM UjzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749144716; x=1749749516; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y8nWB/WLZe/CCeemauG5YdXkbxl5jf3QmnhrkUgxLHk=; b=p4YvM1XQqyAhNIF+N/PKexxunRTpde+v8LOF6VuDir2VEit2TKAY2BWCNgc/Xa1dQa RyKfJ+/kyW+FyTKHWHwyVhagU6MLUeq5Tf1o3DniA+neNxuXLA7tz8N4noB5OrogEJ7G pMY1lfAg3yB4NrRSOukWfjJPTzRmMo+1vcCwB03IrfSM5Og8ku3Wh2D7T4M/uBIORpDY f0uXYe/2oAg1BUuQuU8UcjQjb1/AF1FrVV/wEckOW6pfdfu4IH8his0CL83Zbx2Om1qp twG+ga7r8sC8Zv65Gr+NFtfu4rkMhmYrVgllq1JPJV2jy561xUU+Kqk7jAuuZdMe1/5v 9Knw== X-Forwarded-Encrypted: i=1; AJvYcCWZtlNiACApHVSzGVr8ztBXarzeJWvhO4kUzp5Rh8dJgQIbnITQk+DLoU0Gz1+DE96Idg6lOfV+yg==@kvack.org X-Gm-Message-State: AOJu0YxR6qZLVPvezctSk6XGINEx3AOnubKFXbnafjjV/KMkzX57icbf oLWW0gSexzXmbatw4+wmrgbXYZRb87dlMATTOiD6fCq63DwIv9P1da78UAbbvJSh0biXoLGJjx7 eT1O7tCOc1zQAGFuRpzrGcgnFjZWwavI= X-Gm-Gg: ASbGncso2caWXvE3H/LFRV6zLYNE1POOBdig2bKpFX6V8DRBLKH9HnzumAV0Zwtx2HH 93ruxMmEtP5DotIUXkKamO7sIQX2jfKjly0zqdKdn8Ehdu3jiweQzgBBlgWVLc3rEOFeTnC7IsG khROO4xFNc0UMIGiPziz9q+mCUhEtcWhjN X-Google-Smtp-Source: AGHT+IH6Ge5MBQj226ro/trJtTDJEKqfoxutgYQ+NLGhGSTlIr/XkGznsHM3XrTD7wIOs/Zk3MohR7asrPwdDTPC0QU= X-Received: by 2002:a05:651c:b0f:b0:32a:61cd:81f7 with SMTP id 38308e7fff4ca-32adfcc5e7amr721251fa.18.1749144715513; Thu, 05 Jun 2025 10:31:55 -0700 (PDT) MIME-Version: 1.0 References: <20250127160709.80604-1-ubizjak@gmail.com> <20250127160709.80604-7-ubizjak@gmail.com> <02c00acd-9518-4371-be2c-eb63e5d11d9c@kernel.org> In-Reply-To: From: Uros Bizjak Date: Thu, 5 Jun 2025 19:31:44 +0200 X-Gm-Features: AX0GCFueg9D52Q5ZKOUZZ4EHnuPhldYsmhABpjmPMClR-F5-yN8HoMwduFUUy98 Message-ID: Subject: Re: Large modules with 6.15 [was: [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers] To: Dave Hansen Cc: Jiri Slaby , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, Nadav Amit , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Brian Gerst , Peter Zijlstra , Shung-Hsi Yu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: BEE6940013 X-Stat-Signature: 4gxmo48m4kiebowt14pd3qy6po4jnrpg X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749144717-953468 X-HE-Meta: U2FsdGVkX19b1LHjLSTzKd03KS6jCdqskywgVRdzNcY6MPR61+6Vprd3bnpiktwUoB/Y8LSxpl4vTitdC20VIRy4oUEqFpVJKBjLKKyACXQ9B1TV1at+1pUVENzxbbK0FZHktAPkBERl4tXIFSvFCmyNbwHJGywpn/F+DDE6lYtYN8bUN1bjoFGtkWYKYQY/XetH3v6sjTxQWuq+2dC2qRgfTs1c5LA7lH8EBn/qlNPCDZ4eOICI60ofUq9zypEGrHfdol+BK5iTVnIR9VBBmHof9nns5w+onb4NV/B/HkCSrU+rIDKLgFlnUfTvdPUICQJg9mkR4W28QG+LXL1JMd0GQc8UH25Olr1ilWOnqjJv37JPwp3JZJ4p1W68x11jZpoejkVvX02GD02bolT9+9VFjLipamXuw3P8mKNgbQXbJ8750bXMUF7CcVqLII8lqKudpfYLUd19yx6XdnR1D39WVsR4tNn8uNFcZ4IcwpC6fjBJsHcctXtx/dSenLWqwml1mtA1lJkkcnCNqPwPU0D8XgVw1+gGjSPj3jBES6vRyeC68dCShMBJJmaWIGjNu3YkNtdz/92WTZIxqnwnF/5pPAqBklBUyGjApWDkTAiwGx8a/yzePjr8+Tns7JPfrvUjvkCODtyXu0GZo7hTM+tjgVdYY7OQRELIeMHz5As4ok7OmDaXBcr5PBaMR0bpFs2AzIPaJ6Jxj0gGpwYDy9PmnPhlqm2BBJCHCbjjcEGyUJ7yhblVU1ZOV87g4koZsIw+ziE7jMvzhnT+FqTQV/3OlPSF6C/sgDYRzYWmb3arWM6aELMLNo0YpVZ0XyPyfPZdgOs7eVBZ2IsIW24hS8T4/S7Pf5CUPRBWgWSHia66pMWmd3RkOMY3EG7YiIXPS5vA1/kvorjd4vIoSS52yHsGFBsZqGXRgaZ5FVnXd3hHnr4VAZIESltJVswJgvOxScbh5gEXDzMR/Q1yigs WtqJavqO vogVFKbUJWD7cLUNQtecZYjCKlElWcMe9pGxuPfkyvVS3CzoRwY5nRzRTJ38vtdqk/Eu7Zngy1qXOE9YKG6F5xs8VMv0Wp/WI/8T6ONH4kPm8HtmudrDpZICB9PpmBURiQclTwj/ufcmhxbY9bpeTMWEJOhlwlj9HyOBHKktXuLZr0Md0DbIclE8YXqC8DgcPspakeIeUMpgw+Ht69cmZqmKZ9VMq+ghZCVbcwUVdD23K4vlTuRpcbZinvcN2ueBXX97JitVXYQzDACAm5muj4JhI8qOqiez7URGp5/IcXMAFeDBvE7okZwk/9wrO0FJG8lL+7jTvDCKUlOLBq0cfY6hRQ5GBvPDmtjLecA3MPWXbMWTQeAAIZvQw8P0POhQCTjDLwdP1XM7y1uFZOcprYZ6+uhqAxd4WCYjlr/8fW8lVU8o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 5, 2025 at 7:15=E2=80=AFPM Dave Hansen = wrote: > > On 6/5/25 07:27, Jiri Slaby wrote: > > Reverting this gives me back to normal sizes. > > > > Any ideas? > > I don't see any reason not to revert it. The benefits weren't exactly > clear from the changelogs or cover letter. Enabling "various compiler > checks" doesn't exactly scream that this is critical to end users in > some way. > > The only question is if we revert just this last patch or the whole serie= s. > > Uros, is there an alternative to reverting? This functionality can easily be disabled in include/linux/compiler.h by not defining USE_TYPEOF_UNQUAL: #if CC_HAS_TYPEOF_UNQUAL && !defined(__CHECKER__) # define USE_TYPEOF_UNQUAL 1 #endif (support for typeof_unqual keyword is required to handle __seg_gs qualifiers), but ... ... the issue is reportedly fixed, please see [1], and ... ... you will disable much sought of feature, just ask tglx (and please read his rant at [2]): --q-- If the compiler people would have provided a way to utilize the anyway non-standard name space support in a useful way, I could have spared the time to bang my head agaist the wall simply because this would have failed to build in the first place long ago. That just makes me sad. --/q-- [1] https://lore.kernel.org/bpf/20250429161042.2069678-1-alan.maguire@oracl= e.com/ [2] https://lore.kernel.org/lkml/20240303235029.555787150@linutronix.de/ Uros.