From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4CAAE77191 for ; Fri, 27 Dec 2024 10:43:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10CE36B007B; Fri, 27 Dec 2024 05:43:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0967A6B0082; Fri, 27 Dec 2024 05:43:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E797D6B0083; Fri, 27 Dec 2024 05:43:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C37BE6B007B for ; Fri, 27 Dec 2024 05:43:00 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 83ADB1C7039 for ; Fri, 27 Dec 2024 10:43:00 +0000 (UTC) X-FDA: 82940399346.19.E826563 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf25.hostedemail.com (Postfix) with ESMTP id E309BA0009 for ; Fri, 27 Dec 2024 10:42:27 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="jK/vzTmU"; spf=pass (imf25.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=ubizjak@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735296149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U35GuBtYSL3uFr17EtfeLFFIX4fULzHtypAwHAbbnSU=; b=GrXWnLroxQBtuQ21KBBgjHRkEXzE2zm43jfeyhasPOLR4cGkOKzK2IUG3ZQV0i+cyGiLTZ EoPuofRZc5Qfdwfwv4jhYSXFzLgCe10d2i9qLPcaT7OqjDNg9z4HzvUwMniL6V0oqWulty ep2pr+rwnkagpEHZValgQo0+zx7Xxk0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="jK/vzTmU"; spf=pass (imf25.hostedemail.com: domain of ubizjak@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=ubizjak@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735296149; a=rsa-sha256; cv=none; b=lpJYeLfVmSQELBjvBJvFYArUy3EzrgFs9mn07WhwnXQQVueTH6GHoNq9kaDPJObWasTvWW rRIBIpA1P+8YMc+sKCE+KnAgNg7ffHUJ1LUHMyKFMuIE7jBIWwf3yhAvZOgCh1ew9eITJI ix9590KGagf13xcGmax+21NJG1PnIHU= Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-30033e07ef3so35576891fa.0 for ; Fri, 27 Dec 2024 02:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735296177; x=1735900977; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=U35GuBtYSL3uFr17EtfeLFFIX4fULzHtypAwHAbbnSU=; b=jK/vzTmUXd0J2YJ6JO8/3GNvt/q9+1ao2wYuA9qMULhboxJLfunBIcZrCXMihi8+6B UYLKb/mCZGaZydebTGDVjTbiXNRE6Y4nYwWhJfSsPxwQQuCBZaqdAmyAugtutH64USsu kHv89yiBZ444zMqIEs2r9j2vN8o8krKRBqopwwj668VKIE6Y17096rwW5BLA9ZpNRflQ c9hcc0aZ8EjLsnxiQ+u4b7Tb375ezxgIKSmfjg+isgj5+MmB9S+MUMkC0Xjn7X/6dxa4 swc9z60Kt9iTVbSOUeYNfc/JYINLZdYUDFjK01J1fymzm0piQPAWtaxeA3ju9K+sK0RB Ud0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735296177; x=1735900977; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U35GuBtYSL3uFr17EtfeLFFIX4fULzHtypAwHAbbnSU=; b=Dee+RwxS0m3QxCDXYYG3NFu5o+plotYXQEUsEOts3dP4/OlrNS6V9MidabExiHiDCZ cz2ZJr7kvpL64D4sc64rqPU0UUOVmS2UPHBO6wEvxljnj5xD2DN3c+ra0460HnOS5JCl CKC5J7chMtBCRteUnPN6mOWZDq1mrB/go1DU2tD6D4SmhlVtF/8KFfTxFSDwk8YcR9s7 D8APknOqueQbyK9hq3Dg8Y3oGNrDubjj21QHcYrd5XEH8vKHvGysqpqlNp/qrRtHmp+5 zXwRPqmPPAfKzwkrSaoZGgpRtlkbLo1JosQ3NQE4zOyYTCI/gHKpHUpGdoIv09jLUD9h ylJg== X-Forwarded-Encrypted: i=1; AJvYcCX/6OL+plKKEiPIkoBf6uosJ3NilGiFrAx5MCP4xgbMhDUh1dd3TqgyOsf9eECJninrMPMGnovfOA==@kvack.org X-Gm-Message-State: AOJu0Yw2yH8M4tGNAYEJVYa/YPGLlE7agyeI6b5PMHRQ3Q+uClVZUmNu aGtPcAjbWWJ+lPnuuAJV3ax0MDelIQ52Hc1V/j/XYLot7gBB3I4NgsIfbDjQjcd1IxVqyOScQnm 4u8Q/sNXfzRACF3lZJQDh5JuOXjc= X-Gm-Gg: ASbGncv/TFjNo5m0VBNq2VNnKu0E67DqW55TGNjAZpfrWPBwEVq0JOzk3PWkuXtl/jT cZU3UrCCPXO7X5JN6jyx7ohhljfW7snV8sZbpXQ== X-Google-Smtp-Source: AGHT+IFtKfE2dinA8K1VjDMf4o/lVSVXZ0AsG15YeY3ExPVjYg7VvadUf/CIT9TQgDfcBwTVIQj4BCZBhL5Gj5/YGE4= X-Received: by 2002:a2e:a781:0:b0:302:49b6:dfaf with SMTP id 38308e7fff4ca-30469c32aa2mr73032631fa.20.1735296176761; Fri, 27 Dec 2024 02:42:56 -0800 (PST) MIME-Version: 1.0 References: <20241227092311.3572500-1-guoweikang.kernel@gmail.com> In-Reply-To: From: Uros Bizjak Date: Fri, 27 Dec 2024 11:42:49 +0100 Message-ID: Subject: Re: [PATCH] mm/kmemleak: Fix percpu memory leak detection failure To: Guo Weikang Cc: Catalin Marinas , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Stat-Signature: khc1jez3d7ecr83m1zocx5rhiqf3dhtp X-Rspamd-Queue-Id: E309BA0009 X-Rspam-User: X-HE-Tag: 1735296147-181649 X-HE-Meta: U2FsdGVkX1/0SOtUPNudvrV6k0Ir2LH6k24MPlhdzDl8TJnz8IFtUqcZukyzajAu6LCYuxPH8b+4vHJ/G6r34VSfeZiPdCBi63osdjkb8C/dVMrrJvjoqUPMm4K4YfF/Zgr2I396jArpT90yTeb3MiYsS9W8L0UP7GwYa8mnaKH6LbMc5HIXrqKaP86x+2D9ZqRxQGwxb62Bgf9XlqkQjMC1qqcTmnR6Csw5Vu6gg68ySI/GU3vTa9FLEGywjJD3nc5lJLYmHju7U8SydkwCJQWUE4f0OycCjqdj60aCi0xLNdMyOWUc/wWdcYtgl1uaOKWjhpTnkiWDfy3EDVuADpB3AsrQdwndNF5/KBZR+kcjxg2m9iJyStkBJO63oO+cuQYm+nqfO+hBlQZ9VQzL4Fq6kqu+VkMkZlA2c73Gi5iEFfmKCHQ9Q0iwznY7r2bky0PEcuep28rRbhMSIWFEZccMiYkPlxj/qyQ5fEd53xIY0KjvhNrZ44+1t8Oi69KuHnIxwAUcXYRCIU+5r1Y1oYmntmBd8Z2VjOOJuUMilTxXOlBvNckHnkD2azaCeRmB+jSIU5AFf3nprx2ahYWZ6Y1O84NoVeCXMQ6zrZx48IZpyx2OX9OV1y0MYVkO3u/NRyfPheaWdtcHmZpL5nAKP6QlETTNBDhJFboELMEm81ldz+Mx+mmLjPgeU0lgOlLbKQMePf+twoBYgL22vB4rNVWYkRuDfnNOQh2CV5TX+kaZLU4X4z0JxSWEqBcztBu41DMKQEOqdKMcuzaI/8YjY1HZGsHmCzn8Uw9qB+XymE6ftQItEEcP48t9G8h4MeMa+tvu8/3BO9wGwIPwDedfeVt6mHMybNs4gmUBxL+HAY6Un0LRU6fOaXfZAivUMHKollvfqiJWeOhbM4OhYHqhudD3/WP2matjlnYne6/7UvxVzbvReAPhzAsyo1FfV7f54hh57uF8wg25dHTGYhd UkL3Y7u5 bMSxx4caosN0xSS47OA3hDKcyqAaXIM0VTZU6U2Ph94sTlr6onEDWSuobHvY4mJzvXQvXvWeFy305i4ldvsRgc9PppmY9iycRt7vFSVuCfieGnJWAGKSigkNXJR2YxL/1iDQ2QeR0O9TOCW8T8BxiEOpuhfZRW2xgixujrbOVR83yM0rv5fBRtsnYLmQcoE40LW94wXuTNAMCCuuNSRoq5i23VNv8lqV3tzZjSItimVelnH8rgZ3MKFUg9PIKh/JasEvHaWQm79+hu3VTmy1xRij/MRQN+jKCC4DruIqCOFAB3CzoMvaoqUVRYR/EXWKfisGpET+4Sexjsl6PgUjwcsobc8KN4P+5BxdHqtTY8OvOwQoOrpSzUKnH4oN8bJ4/hMD8NQwy0qWnjZrLNJRzLQGmAKV2BYjnLkMccu96dbmjCxNLP7gBzeWSAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 27, 2024 at 11:37=E2=80=AFAM Uros Bizjak wr= ote: > > On Fri, Dec 27, 2024 at 10:23=E2=80=AFAM Guo Weikang > wrote: > > > > kmemleak_alloc_percpu gives an incorrect min_count parameter, causing > > percpu memory to be considered a gray object. > > > > Fixes: 8c8685928910 ("mm/kmemleak: use IS_ERR_PCPU() for pointer in the= percpu address space") > > > > Signed-off-by: Guo Weikang > > I don't know how 1 turned to 0, the change was definitely unintended. Looking at the original patch at [1], it looks like a mismerge to me. [1] https://lore.kernel.org/all/20240818210235.33481-2-ubizjak@gmail.com/T/= #u Uros.