linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: Guo Weikang <guoweikang.kernel@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/kmemleak: Fix percpu memory leak detection failure
Date: Fri, 27 Dec 2024 11:42:49 +0100	[thread overview]
Message-ID: <CAFULd4Y7UshG1hk=H0nQKo=iPXVQYta-uWFQJvV1NjRudSavXw@mail.gmail.com> (raw)
In-Reply-To: <CAFULd4bzw-Lj4Hooc2VqGPRyAJf5WcyGSysz+vPaPhvO8ckvDA@mail.gmail.com>

On Fri, Dec 27, 2024 at 11:37 AM Uros Bizjak <ubizjak@gmail.com> wrote:
>
> On Fri, Dec 27, 2024 at 10:23 AM Guo Weikang
> <guoweikang.kernel@gmail.com> wrote:
> >
> > kmemleak_alloc_percpu gives an incorrect min_count parameter, causing
> > percpu memory to be considered a gray object.
> >
> > Fixes: 8c8685928910 ("mm/kmemleak: use IS_ERR_PCPU() for pointer in the percpu address space")
> >
> > Signed-off-by: Guo Weikang <guoweikang.kernel@gmail.com>
>
> I don't know how 1 turned to 0, the change was definitely unintended.

Looking at the original patch at [1], it looks like a mismerge to me.

[1] https://lore.kernel.org/all/20240818210235.33481-2-ubizjak@gmail.com/T/#u

Uros.


  reply	other threads:[~2024-12-27 10:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-27  9:23 Guo Weikang
2024-12-27 10:37 ` Uros Bizjak
2024-12-27 10:42   ` Uros Bizjak [this message]
2024-12-31 12:03     ` Catalin Marinas
2024-12-31 12:04 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFULd4Y7UshG1hk=H0nQKo=iPXVQYta-uWFQJvV1NjRudSavXw@mail.gmail.com' \
    --to=ubizjak@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=guoweikang.kernel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox