From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C4C9C25B10 for ; Mon, 6 May 2024 23:30:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6EA46B0083; Mon, 6 May 2024 19:30:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF6A96B0087; Mon, 6 May 2024 19:30:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C709D6B0088; Mon, 6 May 2024 19:30:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A30E76B0083 for ; Mon, 6 May 2024 19:30:45 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 570471C02AE for ; Mon, 6 May 2024 23:30:45 +0000 (UTC) X-FDA: 82089568050.02.8708ED2 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf04.hostedemail.com (Postfix) with ESMTP id 85E9240018 for ; Mon, 6 May 2024 23:30:42 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RKlzN3sK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of maskray@google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=maskray@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715038242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rday+enGpH1mUN4w1iIrCf7IG9Q6aF8QR6lBBrCyZ7g=; b=VB7y5g+dMn/LAFULuwVaS5fQXiDF7NvvyAVuEECCf4c456JbMa1zjAkf/FnINUbNxRp+AQ I9QK2IhUQDo12+BRfHETktk2owIggWzY5pkBymlisHKng/A5JNMZH6sDoQVTrUmLn57LD7 ByC55UrUaKzf4KTa1IvFIMPAx3MS7Jg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RKlzN3sK; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of maskray@google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=maskray@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715038242; a=rsa-sha256; cv=none; b=Kxllk9eMsJQsbXR4rQ0EDH8H+JbN6OgOrek+Jym9UXH1zlllB6vdBisdzI69mg+gJ84v5g 9TGBIbovFeKcWqafqdNnNUQUlWJZB1oS1JRQ/cNAo7/Jo2mxOTiEfeygBw3P++3zrZvnuc 6MGCQFfk6AwLeu20uQEcXGDH68XsT1s= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-572f6c56cdaso8479a12.0 for ; Mon, 06 May 2024 16:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715038241; x=1715643041; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rday+enGpH1mUN4w1iIrCf7IG9Q6aF8QR6lBBrCyZ7g=; b=RKlzN3sKZQFdrxQ6lQs14e8dMDfO3efXCRIzW9HN3ftLxb/OwBUkJg407xpKtnGF2b /bg8W5AU8/hZVjNFFQ73Bw8I2K0wOAQohBcPwi9aWll2zUkHPfLqhEEABn8u463UVN3F uZDxJzgQuyAEfSb10zLV6QEw4XqxrvQSgaHabTB+zxfoh6ykSp0wF5dDM9P0ZSb053JN G2DTmuoFFIhZUhSKqi8eIaSSSk6FMaSshjDkKpGfjhQrLB0Mld2jLMQHbsss5zTjUUQJ aFjsVH2GEZCn+4UHtg1D5YB87APauy3Ac3tTjuCLnxHCuP+XaknVcfHorqw3kuiPRXXL kB1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715038241; x=1715643041; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rday+enGpH1mUN4w1iIrCf7IG9Q6aF8QR6lBBrCyZ7g=; b=XPY+sJrIsEEBA/E7Zpu8ySKxmm2M2pPoAtsz57X5GpLuQovclb9VvAtJgAaZTln2bM XRUgLp7y5n81sGlNfm13BhluQawwhIaLsfPlFOuEUN73+6xoObX8lpeDslYgWdgsttcJ gJpL5KYMMzoX11HyVF5yeCOoJcUpkQ1Wkvgd7rgjw4jeJfLMS3LZ8cYs730MW7DvtOpG uJg+UOpAEirZnK6xK85B38Z/C6j0v0Skl5GF7q48H2Mo0wyv+YAFMS8AUFl/49oFyWev R75ra0PkuR332RaEGi5cUdj2+oXAZOkdAI691gjUAfYRpYrpmCejt/UryaRGlU3UQ9aj CvKg== X-Forwarded-Encrypted: i=1; AJvYcCW8B1eCcaNmJF1+q50O3qBVMFOf/nTgkN1fl/HcuX9O9ipTUj9Ko8CpwB7Uy5Qp9ZvezRFS+ao7NmAKNcpv/XJXD4E= X-Gm-Message-State: AOJu0Yxqfy0WO7uMqWu7/qE0Bq4oeqKjQ2aBsdrwjSv7LkeCUC93weCn 4hbt2nJik2cV9HpqS6+uoukiKskiP7NqT/YceVJf0X+kFrbjusEyXnkBpfUiQeHK8xFBUR9qlw3 6150ksZSSdnUCaws/EnkmODcOx5uymI00YhbI X-Google-Smtp-Source: AGHT+IFPtbSaAcsaOKbHp6npYdFSTUzqld8pO8i1uwvZe0pXCtMxJsE/ukQM7Zz7NLIcHgg7/XYVun1u85SF7+71r+g= X-Received: by 2002:aa7:d389:0:b0:572:554b:ec4f with SMTP id 4fb4d7f45d1cf-5731316c507mr37653a12.3.1715038240800; Mon, 06 May 2024 16:30:40 -0700 (PDT) MIME-Version: 1.0 References: <20240416152831.3199999-1-usama.anjum@collabora.com> <202404161027.63F4D4FDEB@keescook> In-Reply-To: <202404161027.63F4D4FDEB@keescook> From: Fangrui Song Date: Mon, 6 May 2024 16:30:27 -0700 Message-ID: Subject: Re: [PATCH v2] selftests: exec: make binaries position independent To: Kees Cook , Muhammad Usama Anjum Cc: Eric Biederman , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Andrew Morton , Yang Yingliang , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ckau5iqcktmrhso65m77uitpjge38ur1 X-Rspamd-Queue-Id: 85E9240018 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1715038242-605115 X-HE-Meta: U2FsdGVkX1+mY1Nbm/iWv4Qr7D4mtqbKK72UagLV1u7v1NiMx99GZtN9kjnkff8ULvTh272kRB0UzQZizi31WS1OSmsP+h9VgGCX3ACK9EeXo94q33hN0KFv4ZvENTDuMuQNt6U1ir2yS0Dd1RRJEa1LgCOEeEWilnJxEsn4dPuKuHYmLtluZgxuMIcv1GWESp95h8CKjVw/fBNh7HdzLdtQBazU+7lquwIrQSIpzXS/5lUxmegs65S7B4AGLt4T0Unw59feaTerH+viIA/rlR/hwiBovYWhOmAuepnvjbLcmGKu8q9SxQKrUWM1PyWunEDENS0vp7D200Uhfg0vaRhy79TGVATt7DaRKyV7qMDGUI+SYtf7mqQlK/4KvaviKf6DnqQftOkeeqXat7nPAEHN8yRGryZTnNWyKnFaiwCvqkHKPdZDp01jnLQGsO2Q6+y7pCltkmMivJqXJoJgF8XpzPf7AXBvMCPdjjZzKzzhs8jZp1Kms+zrshI1ixFAKVms14PRykzeUbYtCj5FNcq/7dHuvZfATVH2tGwt0qrLQEzSCM5gHYE38uwN8tw70hdaw+qe/L6shuLlo/UXps+pwAwu6emNI/d0S1qTkn6CAJMKZL+5K864ouyz+SWM4CTWG0A5T7Use4VUMHdhpNiNDDCT7fGiUgjnaSgVoDvVnPS4O2/E9rIslF6XqVUZAEHRqWLdMeisaikMjq6txvT4SypO+YggVy/Z1griGOcTcnY3jO2n5GMnEmIdJhPLCQAZDTcFUNIn1uyGQRCfk/upVvsbLcyePQP/fOWMCuDvfz8aDdKxauZanWaTzRI02MO6S8pCPsk1csWS9j+1jYNRN+DEfyYUBpHWjsanqzTtqFlF27gH9zPbChNYwUmouwZdXxWMEt+HzU2CgC8dH1mQDZD4sysp/8j/j+mEux2QTeIjY30lE2dHY2Y0KPBI7J5N7G9f2LxwCsP2HNj VmxGU6zt vk/iP3SaXX7P6p4BHVb39TnZdnhIVnFYXE6AO5cbne4ijuyJzF12ba253tbrxQDep8futxXx/YVLSRktGGalRlj5TM12Jsd91p5XQ+KAuy3BMMoWCe4f3DzN1PJYSg5UNoXvEe+zKxl8o/l7ulpCrGtZgUC6QR9A9qe6Ya2ooG0H2coEqsMevbZh7KL1+ZKOtayYFPCynpxLt4yY8OHijPPTXL+LkS0kyAnbvOWwkAC5AOr4GBtTUpOwFkI0TT/VkEzHNTPyuqC/yMwMJduMql7mtYLQPiZBxZYyGkU82aWgwGb20zqR14OxAM7ergXk63vxdIdTOmWK1ntdNfT+LoXwWuKz+7geqWKGBEx+Ir/znuHJ8fch0DsSp/kfCXsrUt+TdbBRCn7LsS1mWhCHZ+mtAZt7Ge4wbFH5bMxkPEIAXKt9RalWCzpkAB6sHzuQHGhFcnoDTH3kx37A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 10:28=E2=80=AFAM Kees Cook = wrote: > > On Tue, Apr 16, 2024 at 08:28:29PM +0500, Muhammad Usama Anjum wrote: > > The -static overrides the -pie and binaries aren't position independent > > anymore. Use -static-pie instead which would produce a static and > > position independent binary. This has been caught by clang's warnings: > > > > clang: warning: argument unused during compilation: '-pie' > > [-Wunused-command-line-argument] > > > > Tested with both gcc and clang after this change. > > > > Fixes: 4d1cd3b2c5c1 ("tools/testing/selftests/exec: fix link error") > > Signed-off-by: Muhammad Usama Anjum > > Thanks for this! > > Reviewed-by: Kees Cook > > -- > Kees Cook GCC versions before 8.1 do not support -static-pie, while https://www.kernel.org/doc/html/next/process/changes.html says the minimal version is GCC 5.1. Is this a problem? If not, and CFLAGS is guaranteed to include -fpie/-fpic/-fPIE/-fPIC (PIC), using -static-pie looks good to me. --=20 =E5=AE=8B=E6=96=B9=E7=9D=BF