linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard.weinberger@gmail.com>
To: Derek Robson <robsonde@gmail.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: fixed whitespace style errors in failslab.c
Date: Mon, 27 Apr 2015 09:44:14 +0200	[thread overview]
Message-ID: <CAFLxGvyYH4c+YKaRkgztXzLA9sPk+7fPYbdmxd=1528HE_Vb7A@mail.gmail.com> (raw)
In-Reply-To: <1430119993-7358-1-git-send-email-robsonde@gmail.com>

On Mon, Apr 27, 2015 at 9:33 AM, Derek Robson <robsonde@gmail.com> wrote:
> This patch fixes a white space issue found with checkpatch.pl in failslab.c
> ERROR: code indent should use tabs where possible
>
> Added a tab to replace the spaces to meet the preferred style.
>
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
>  mm/failslab.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Running checkpatch.pl against in-tree files is not really useful.
Especially if you "fix" only whitespace stuff.
Most maintainers agree that it is not worth the maintenance overhead
and the git history pollution.

Please stick to drivers/staging/ or fix real issues. :-)

-- 
Thanks,
//richard

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2015-04-27  7:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27  7:33 Derek Robson
2015-04-27  7:44 ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFLxGvyYH4c+YKaRkgztXzLA9sPk+7fPYbdmxd=1528HE_Vb7A@mail.gmail.com' \
    --to=richard.weinberger@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=robsonde@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox