From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC75C433FE for ; Mon, 7 Nov 2022 21:26:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9AD16B0071; Mon, 7 Nov 2022 16:26:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4B146B0073; Mon, 7 Nov 2022 16:26:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C12326B0074; Mon, 7 Nov 2022 16:26:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B17EF6B0071 for ; Mon, 7 Nov 2022 16:26:05 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6937F1C6843 for ; Mon, 7 Nov 2022 21:26:05 +0000 (UTC) X-FDA: 80107929090.05.0C9DD37 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 14A19100004 for ; Mon, 7 Nov 2022 21:26:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2FADE61338 for ; Mon, 7 Nov 2022 21:26:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91113C43148 for ; Mon, 7 Nov 2022 21:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667856362; bh=SwQyXyRosovtBDcr7GfPt6fsp4ng05oq/t3fG7dB68g=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ffvHIqojBVLH/R8RQOQEgXCeTITmfwvIoxefm2/kBiEz2OyLI9Io4TDxW06ogg/sN 3fWSVwLP7C1LXRhdThBd1UCmwrb62aNwnwPhsnjD194IsHOpRrxOtn/gP3z8BLEjEE 3a6gLv9bTBbYeKfi6puWXH9+gHFk4yKiM4mbbf1kJMaVXq4O7YS4IPezgSwqAiw6dg aWWwBH05mwWpElBiERd2AjzW1oA4IQ2N8kMYhhPV076879Sxylya1gjvFB6S75Ki6D YSxGBZQ+IsbaVRLSlTBJcnreOKfX2foV+YDEFOPtCI4Hb73C8fJ5KP2ecXZ+zVPCe3 Yxz5zRAEx0Q+g== Received: by mail-yb1-f169.google.com with SMTP id z192so15241208yba.0 for ; Mon, 07 Nov 2022 13:26:02 -0800 (PST) X-Gm-Message-State: ANoB5pn7XEQD0u1bC9mppn3aVop9J3slOCm0JiNeizO3TF/hui53gIgo cjQEEhwY/A/TJI4/lHxoWPlZL7V7R9D0Xhq+c08= X-Google-Smtp-Source: AA0mqf57IeLMapCs6BKe1PyHfS6JiZC8g/49BGtedtXgLWmUCCwX95DungbNLQq9eDdaj9K/AImhyOL53rs80CSF5uA= X-Received: by 2002:a25:2389:0:b0:6d8:7f81:edaf with SMTP id j131-20020a252389000000b006d87f81edafmr3849061ybj.443.1667856361598; Mon, 07 Nov 2022 13:26:01 -0800 (PST) MIME-Version: 1.0 References: <20221107161740.144456-1-david@redhat.com> <20221107161740.144456-20-david@redhat.com> In-Reply-To: <20221107161740.144456-20-david@redhat.com> From: Oded Gabbay Date: Mon, 7 Nov 2022 23:25:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC 19/19] habanalabs: remove FOLL_FORCE usage To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Lucas Stach , David Airlie , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667856364; a=rsa-sha256; cv=none; b=UjIDqr3JwlTndDfEJ3KjfOwg865CXx6rJI5RxE7Vqw44S/o7xT+fWpR0fFFhLzRfi6RT+G fDBxHpg3nKL0Ecjrku7sIB5EJVzyy5vd3kuiWCXElqqE2xD4RV3kyXZ03KPnVk8z8EkGVV Mmr/9aywedd3M8Xi0/nXo5rzxSvK1ug= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ffvHIqoj; spf=pass (imf14.hostedemail.com: domain of ogabbay@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ogabbay@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667856364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LZjiXUKF7GeG+TMZVO7Yb+tBaMiIUJ8KN3qkDcEDN4A=; b=XLLCEWUS1xAxLobWOccjbMEW8gufINQWAzs3vZOjny0JzOit7206vR5KN2jmP0i7VR8nMI ill7tQYScnJPaO9OJ4jhB1n4bLy6F0a/9K16QFrX9Wc8PGYMu8GvlF37PA18AX9gCdTDT4 m2Wbyle679UuO+Av4vvHMDwmP3RtUUc= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ffvHIqoj; spf=pass (imf14.hostedemail.com: domain of ogabbay@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ogabbay@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: yzgpgg1ijtw1e6f731bkcw4f3r3ctjg1 X-Rspamd-Queue-Id: 14A19100004 X-HE-Tag: 1667856363-515852 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 7, 2022 at 6:19 PM David Hildenbrand wrote: > > FOLL_FORCE is really only for debugger access. As we unpin the pinned pages > using unpin_user_pages_dirty_lock(true), the assumption is that all these > pages are writable. > > FOLL_FORCE in this case seems to be due to copy-and-past from other > drivers. Let's just remove it. > > Cc: Oded Gabbay > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Signed-off-by: David Hildenbrand > --- > drivers/misc/habanalabs/common/memory.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c > index ef28f3b37b93..e35cca96bbef 100644 > --- a/drivers/misc/habanalabs/common/memory.c > +++ b/drivers/misc/habanalabs/common/memory.c > @@ -2312,8 +2312,7 @@ static int get_user_memory(struct hl_device *hdev, u64 addr, u64 size, > if (!userptr->pages) > return -ENOMEM; > > - rc = pin_user_pages_fast(start, npages, > - FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM, > + rc = pin_user_pages_fast(start, npages, FOLL_WRITE | FOLL_LONGTERM, > userptr->pages); > > if (rc != npages) { > -- > 2.38.1 > > Acked-by: Oded Gabbay Thanks, Oded