From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 748B1EB64DD for ; Tue, 20 Jun 2023 07:34:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAECA8D0002; Tue, 20 Jun 2023 03:34:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5E218D0001; Tue, 20 Jun 2023 03:34:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4D9D8D0002; Tue, 20 Jun 2023 03:34:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A602E8D0001 for ; Tue, 20 Jun 2023 03:34:47 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7484280632 for ; Tue, 20 Jun 2023 07:34:47 +0000 (UTC) X-FDA: 80922314214.03.AF9D249 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 789FA40007 for ; Tue, 20 Jun 2023 07:34:45 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LJ32k4sI; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of ogabbay@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ogabbay@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687246485; a=rsa-sha256; cv=none; b=Xqr9+HS/93FubhmO3Ph1Kyo/SjvO3q3YkxXFzUzYdPCChLAbVKNgod8AAkyFeJr9Krp+vp B3JyeQ6ANyX3X2hRELz2h8WZSTbFpu0Cz6fAuzKWIf2v/dOvV68PYtaT+tDhx2mQlARcb8 HuT29DwtGhwULPrS60lzn8cnxggiwU8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LJ32k4sI; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of ogabbay@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ogabbay@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687246485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TbDjZp1GjSS8e7S76BoXi2n+LrS9fkKZEsxGlz+dwoI=; b=Bri5A2WOOwzu2tgMz7UH/5ddsH6ZS95SXAM3C0iYaLdJDbHoUXuIaIkgYl8bJnecnLQ7Ek f+9DvYHWJ3fWwNt/m23lqvxmB70rblYiq55OJMaZpXGik073WwPNnbzl56RIxpfbST+KY7 1vn2CYAN/IlUjVwCFSkMlLUyncy2Uww= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8431561041 for ; Tue, 20 Jun 2023 07:34:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59D09C433CD for ; Tue, 20 Jun 2023 07:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687246484; bh=x4bDx7j3zJPo8H1+HoyMmJ95wfLoimCtDNuaHTR7vGc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LJ32k4sITWRFtBWDLlr5Rq2XN6LHpbTj5I6Iss6pPs8sYAePnlfRkMV2WIV4UfkFC uJD0j+E4w0a2YvZQGw3a+9i7PzNAc49bz6L9WX1yMcl8iznNVyqUGQaJUTDo27zMWv NNOJP1Lk/3Y+7CSuflPI7S4cwhOHHPSo97NQLtXPo/CU4YGavtCTuDJtjJzpzDIvf8 8cE4WvKAE22FULUIspt69sqo011iUeJD3f6GHXwDCDJOO/kbWDof79WzBtULI527AZ VoLkfbxh797lZsgh/0TkOZNam9AfSmgpxgE3MsTgxY8gZUKLDDOun2o2tBQrF377dh fruysrJDc1g9w== Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-5728df0a7d9so33645527b3.1 for ; Tue, 20 Jun 2023 00:34:44 -0700 (PDT) X-Gm-Message-State: AC+VfDxGzB+miahDIbQQ891JQ3Qa30T5fxqBM9r8faReg4G6FzfVR6ML OfOXM1p9tofKwKqiqsHFOBC2/mV0WRmjN6zCwwo= X-Google-Smtp-Source: ACHHUZ6nt1vkY6cIKx9+/4bUFnQjhbMy8aHOW7xNwL8tzPMzbveQbjE9R8a8Nbt4TPn8xorqrMkdKylDP3/d4tqRQzw= X-Received: by 2002:a25:e786:0:b0:b9e:b9b4:bb12 with SMTP id e128-20020a25e786000000b00b9eb9b4bb12mr8461938ybh.48.1687246483175; Tue, 20 Jun 2023 00:34:43 -0700 (PDT) MIME-Version: 1.0 References: <20230620004217.4700-1-dakr@redhat.com> <2c92bae3-0003-3c53-8ef1-6e12e5413995@redhat.com> In-Reply-To: From: Oded Gabbay Date: Tue, 20 Jun 2023 10:34:16 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH drm-next v5 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI To: Dave Airlie Cc: Danilo Krummrich , Donald Robson , daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com, Liam.Howlett@oracle.com, matthew.brost@intel.com, boris.brezillon@collabora.com, alexdeucher@gmail.com, bagasdotme@gmail.com, willy@infradead.org, jason@jlekstrand.net, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 789FA40007 X-Stat-Signature: 9sd9o4nao9xkpaqnmxqyckjb3aadbtdm X-HE-Tag: 1687246485-509014 X-HE-Meta: U2FsdGVkX1/deehs07KFD3bCjaocMxADW2/tDSrfCajRYG+MTwnRjzOUOoPM+tFdiiNPBsxIBW1Ix1zwCmNCljkwIvYAQJrRFpshYk0Ax1YuazCSOFgN6qIjyjJJcKejORmpjjsF2/l1rTM8bSI5oNAX1yZ8SHoUrQb8pZzY3KuHj7garP7K9uuQUFCGS3CLXNVdjYnttvfYo+JVQxjRfdcva5hQmh7AegXCwl3qOz63TZC3xhuiTLmlyZauVGDj1+iStF/ZZXDXFMe8QL1XGhNB3IENqDq9JLIl+D9+tCcJV8wDbFE6tQ45JGJWp0cjMt5gx2An0ccw2LWN7Bhit4qqQQpm63xQcJcCvNWkGyApF9O3ayA7dyO/EK9cKlBZcH7tDer4j/yUveltscU4+NuxVRx4pgQeKYKD7nKNMawq2inmyFubR6KNmALXQjpUsP6TGxvh9rUWdJ63KnctwKyNdJXeoYBE/RaZElAt8QfYn/87emPSomKv7eUYZ0WKqURXX0whUIyDwExvKxA90V+1Sr/qEx4tCEFccFTmVYEnaQ6Nom/97aOr+I+OWBEjoKxspOMI6kptNzJtgLYdCR8UjvvgnffekaC+6qTvONF/1AHMfFZ0dxhOXK7B2+ICm+RSQDfReIer9k7J79RnbrxA2sXUTPHIYPA2qPrDqLo3eRzM2d+wHiJGpr2fu1QFJBXWe5VwmVWqvkuTTW1iDtiBODokn9WpVvQ5SbjIW/U/zHfQ39aYXr/wuyB2ynVmJheG9XTK/jiYg6UiYACrV9QrJ+gu08uUMYHFt2eKiM0reA49oAQFq0W6Vyx0J7ursUQhLsg1UgBdYFCsHZDoZ1H1Hmfm4Hexj92GA8BpNwvX0eF4gvwDVAgXpClcptznX1KW72KTuPvjtmeVvjBB+8fsfuqo/hrN+l6A6w/ofDG+K5M9R1G3GxHv8MTyDgADoedTbUYa1wR0uEC6TNx aOVTOHoV U/WKE5VN/8qJjQ9ysXZ8FXTa1jadAtaZKby8yzgMH9SmM5LdZ415ubQ9qKWWg74kdmnHYS6Qt3+uCFpXD8TOzQ5yfFeiy28rla3D5RcVSpCrwXkQ+qpEeDNDAYcJSohS9whRjfCILUV3KKQj6NkLOWRERT9KqitShm5YpwZCPH1QhQ6zMVMTlRVvUt8Y+kSsIwlksv48Kq3c5fEhCmGfzJzND06iliuWYw2utZTc/uR6w3xkQH0rXVRzTM3aQvRx3EPj/ssWsUfONKdTMPWENMUBjxHW7A3D/XtK5Qg7J9T3hUGHmBg87QuI+lFULVSsiN+BBijrK8u3guIoqrTCcnQ8MmpvDc6RsKcnRfo+cNmbq5CLs8rdp6xyfzuuGNIQtA3jwd/mIafO+kTuld7uZCFXbnzvagqfx1kSdmEVoHgM6JlXSXukb7Buy226MBeKBUL7Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 10:13=E2=80=AFAM Dave Airlie wr= ote: > > On Tue, 20 Jun 2023 at 17:06, Oded Gabbay wrote: > > > > On Tue, Jun 20, 2023 at 7:05=E2=80=AFAM Dave Airlie = wrote: > > > > > > Since this is feature is nouveau only currently and doesn't disturb > > > the current nouveau code paths, I'd like to try and get this work in > > > tree so other drivers can work from it. > > > > > > If there are any major objections to this, I'm happy to pull it back > > > out again, but I'd like to get some acks/rb in the next couple of day= s > > > in order to land some of it. > > > > > > Dave. > > > > > > > > > > > > > > forgot to add your email address to the patch series - sorry about = that. > > > > > > > > This series (v5) contains the Documentation changes you requested. > > > > > > > > - Danilo > > > > > > > > On 6/20/23 02:42, Danilo Krummrich wrote: > > > > > This patch series provides a new UAPI for the Nouveau driver in o= rder to > > > > > support Vulkan features, such as sparse bindings and sparse resid= ency. > > > > > > > > > > Furthermore, with the DRM GPUVA manager it provides a new DRM cor= e feature to > > > > > keep track of GPU virtual address (VA) mappings in a more generic= way. > > > > > > > > > > The DRM GPUVA manager is indented to help drivers implement users= pace-manageable > > > > > GPU VA spaces in reference to the Vulkan API. In order to achieve= this goal it > > > > > serves the following purposes in this context. > > > > > > > > > > 1) Provide infrastructure to track GPU VA allocations and ma= ppings, > > > > > making use of the maple_tree. > > > > > > > > > > 2) Generically connect GPU VA mappings to their backing buff= ers, in > > > > > particular DRM GEM objects. > > Will this manager be able to connect GPU VA mappings to host memory > > allocations (aka user pointers) ? > > > > I only skimmed over the uapi definitions, but from that quick glance I > > saw you can only pass a (gem) handle to the vm bind uapi. > > > > I think it is an important feature because you don't want to have two > > GPU VA managers running in your driver (if that's even possible). > > Maybe we should at least try to make sure the uapi is/will be > > compatible with such an extension. > > > > I think that would have to be a new uAPI entry point anyways, since > managing user ptrs is extra, but the uAPI is nouveau specific and > nouveau has no hostptr support as of now. > > The gpuva manager is kernel internal, I think adding host ptr tracking > is useful, but I don't think it's a blocker right now. > > One of the reasons I'd like to get this in the tree is to add things > like that instead of overloading this initial patchset with feature > creep. > > Dave. ok, that makes sense. Thanks, Oded