From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9EC6C433F5 for ; Thu, 10 Mar 2022 11:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 706168D0003; Thu, 10 Mar 2022 06:14:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B62A8D0001; Thu, 10 Mar 2022 06:14:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A4FE8D0003; Thu, 10 Mar 2022 06:14:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 4D4FE8D0001 for ; Thu, 10 Mar 2022 06:14:18 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EDE4922AC9 for ; Thu, 10 Mar 2022 11:14:17 +0000 (UTC) X-FDA: 79228217754.08.F63F08E Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf26.hostedemail.com (Postfix) with ESMTP id 68798140018 for ; Thu, 10 Mar 2022 11:14:17 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id u61so10120020ybi.11 for ; Thu, 10 Mar 2022 03:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3pJ+I2YdNs/yLkLBmuj/ECVh0Vo8H7W59XBvWovNF/w=; b=DTm9QGRf4V8etnToR2oxMCKXzh6s4jheFkE16EHIlg1Wj7kIx9Z3rejll7vRqy1YwH OBWSgwDFHbs1ECPVu5WczTtpj/WKDikPD4S2PR2VYSM+ftyjq//IF/9K+3o3s+l8MryJ NyRU5apXPEzjmPFX0yKW7aQnn+frc+gT5aHnTw7iE2hIJ5lg3x0nL7MwydKWhoBNLNlx s8ZB9k+TiVagYqoWq6lV4OJbDf0SKdtZeXNQZjCv9y+hJr778Keh24+J/QfrcGoQLUxN a1Ba7/m+dN7Ssy22Q236LVmXi/+3NuqNuNMTzACb7QcyaZnSo7f/jna7gfhaG0YnH7CX aTaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3pJ+I2YdNs/yLkLBmuj/ECVh0Vo8H7W59XBvWovNF/w=; b=hjOXq591fM6PvAHhPhVv3BrCCuwTPkj+VTJfcCZglvzptQJ6Gr0oaiaEnQONUBK7cO vL7taSq5ih+3tO4P6x4u0xArgQunlNfM2tQ01w9P0j1X1QAdv+Jf6H6fInFO9sXvdsnp HpZyRTW2h2jvhEJ9O8QnU1V8WtuuHbGVKl5MhNxkhl85lyAsq80lNoBz0iNtppcB8HI0 SdRhQKmcDhvqL8uJ8Eot4Rz3vGsSO7y87GIL1DaBrrdpFi+gvJqHodLhNXMlJsM3R6iy gu1bcM/q35LyEw452AHnpvgSf44BCNy+5gujd2FIKmBy6/82ome8iuDM7oou5vi9E/K4 D/zw== X-Gm-Message-State: AOAM530x+AiZzRg3+kLVNH60y2DfsUU0K4f5rADDNx13yY3rXtVx2xkE r+LRys6IXqqYeXp87hrV13R/YUJouNcN+2MJD9E= X-Google-Smtp-Source: ABdhPJzHxi5ApO77ILPXu9em9cQSGEgjoC9X8lo0uePx/MJNVIuNglcL9pX84nCqI/+OVJPXub1ClmfVLPlt+kzz27U= X-Received: by 2002:a25:cfc1:0:b0:629:15c3:e17 with SMTP id f184-20020a25cfc1000000b0062915c30e17mr3402014ybg.534.1646910856534; Thu, 10 Mar 2022 03:14:16 -0800 (PST) MIME-Version: 1.0 References: <20220308141437.144919-1-david@redhat.com> In-Reply-To: From: Oded Gabbay Date: Thu, 10 Mar 2022 13:13:49 +0200 Message-ID: Subject: Re: [PATCH v1 00/15] mm: COW fixes part 2: reliable GUP pins of anonymous pages To: David Hildenbrand Cc: Linus Torvalds , Linux Kernel Mailing List , Andrew Morton , Hugh Dickins , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Linux-MM , Khalid Aziz Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 68798140018 X-Stat-Signature: n1rkf5k1soicy7b67489ko9h8htecgg5 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DTm9QGRf; spf=pass (imf26.hostedemail.com: domain of oded.gabbay@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=oded.gabbay@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1646910857-253164 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 9, 2022 at 10:00 AM David Hildenbrand wrote: > > On 08.03.22 22:22, Linus Torvalds wrote: > > On Tue, Mar 8, 2022 at 6:14 AM David Hildenbrand wrote: > >> > >> This series fixes memory corruptions when a GUP pin (FOLL_PIN) was taken > >> on an anonymous page and COW logic fails to detect exclusivity of the page > >> to then replacing the anonymous page by a copy in the page table [...] > > > > From a cursory scan of the patches, this looks sane. > > Thanks for skimming over the patches that quickly! > > > > > I'm not sure what the next step should be, but I really would like the > > people who do a lot of pinning stuff to give it a good shake-down. > > Including both looking at the patches, but very much actually running > > it on whatever test-cases etc you people have. > > > > Please? I can take this patch-set and test it in our data-center with all the DL workloads we are running on Gaudi. David, Any chance you can prepare me a branch with your patch-set based on 5.17-rc7 ? I prefer to take a stable kernel and not 5.18-rc1 as this is going to run on hundreds of machines. Thanks, Oded > > My proposal would be to pull it into -next early after we have > v5.18-rc1. I expect some minor clashes with folio changes that should go > in in the next merge window, so I'll have to rebase+resend either way, > and I'm planning on thoroughly testing at least on s390x as well. > > We'd then have plenty of time to further review+test while in -next > until the v5.19 merge window opens up. > > By that time I should also have my selftests cleaned up and ready, and > part 3 ready to improve the situation for FOLL_GET|FOLL_WRITE until we > have the full FOLL_GET->FOLL_PIN conversion from John (I'll most > probably sent out an early RFC of part 3 soonish). So we *might* be able > to have everything fixed in v5.19. > > Last but not least, tools/cgroup/memcg_slabinfo.py as mentioned in patch > #10 still needs care due to the PG_slab reuse, but I consider that a > secondary concern (yet, it should be fixed and help from the Authors > would be appreciated ;) ). > > -- > Thanks, > > David / dhildenb >