From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C41FC05027 for ; Mon, 6 Feb 2023 06:17:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E96656B0073; Mon, 6 Feb 2023 01:17:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E466D6B0074; Mon, 6 Feb 2023 01:17:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D376D6B0075; Mon, 6 Feb 2023 01:17:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C5B466B0073 for ; Mon, 6 Feb 2023 01:17:20 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 98962140399 for ; Mon, 6 Feb 2023 06:17:20 +0000 (UTC) X-FDA: 80435859840.02.53ABFE9 Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by imf14.hostedemail.com (Postfix) with ESMTP id EBA16100011 for ; Mon, 6 Feb 2023 06:17:18 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="nLyqU/yl"; spf=pass (imf14.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.217.50 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675664239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+xiDdTXHz9kIw5NyDNxaV9yiFmJDYKUg0WvCnptXTRs=; b=jNV1/iWIhenQ58FSldKeYd5vF5xb9IdkKFr3x0HzM8KzIvyQHvZqZDL1phk7FJeENpwGtA e+W5Dvwt48eRLbaM+Mpz6+fbF5sxvH0ykdFB3KwXH1hcSAOLoRl5B8njFLAFoh4E70gvAT 819XesrxcCLWYnxP+H02pPDDoMuVFQk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b="nLyqU/yl"; spf=pass (imf14.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.217.50 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675664239; a=rsa-sha256; cv=none; b=1YWJEIUnBZTyNgnOsgaamoTR1RhPVKgFEifMscQjxg+K/b9nK2KBeuPBs7cHm/YTKKffyg 0ojT0mU1uHhw99BRNb9grqxXVuEjmhpMG/x2GkVuYxF531NwfAyyjs0x78OJWsKetInwOg zNcfH17/vykyndFjpTRv83kS9Y+4qds= Received: by mail-vs1-f50.google.com with SMTP id p10so11602933vsu.5 for ; Sun, 05 Feb 2023 22:17:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+xiDdTXHz9kIw5NyDNxaV9yiFmJDYKUg0WvCnptXTRs=; b=nLyqU/ylxVYAnUf1Vo8aIMOpW9ExvPm8ofwBiIWCzOvtnKdtDAPg4P7rggeEiTFkoX hSyeeM04zvkrX2x0fGp3hFnVVjeU2YE0nYv6yaSMtHAKyObnjqoR7IINadZ6zvMGLn2B mxPkB918/T7FKCm6ZPV7GI2CJM1TPnCKP/v16iWw73B+tq/+kvNj/3wi1wCnUh+oIVD/ 61FrPqItSs/IWJJLKWNcERkGvR5hNTD6Vj0Yd2pHLa/7tQYd8gBmiYhDctEddZqBUTzz MGw5H9tz90jLwltcLdc0HNcNIZIMtP7SDTsdE7oNZzETGW851TLUuRQ478V2JR4ksSoE Iqzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+xiDdTXHz9kIw5NyDNxaV9yiFmJDYKUg0WvCnptXTRs=; b=ifrQlMvioaCe44atgvAsDwEwBuRqa83jBlL38Yg2ilFBJdl5r7NyfwF7HTECt3Ap5I jBpZRoYlcQRSdd/PRoVS0rZOMbwOCTqfUIkrM1EMZZTZXcx4a7j3mo8zDR/6JnSlP2nA my15rUzRHjSQfbJ+/+JpkzAXFqyhqGNZdWWh36rXbM6oraQi/5gpF6+n8ry7TqbjFsH9 ni7yCi1JBgOJkzYuYROcQPQH3ErjZaevBsl+Yu+L4vcryo06STUKqoPtdJYFyRbV/Q6l D9KSNfOLqmA/kqz4WLnzT5BOPO8GeY7uir3Dw3Ab4TWRvnm/SGRQxzffVPwv51ujRTbb G8iw== X-Gm-Message-State: AO0yUKXwRKnUiRS5/ACR15CpzbaT7z/I3sxQTrSkW4rBFKXEs9yBntkk 7PLSeAarzryxbTvOtL1Rn33qYAen5WmQhDdrEoXvQQ== X-Google-Smtp-Source: AK7set8XMWe0KVmVR29XsCEVIh/R7FQFNTjo1vzmArB0lCeKTRvncByylG3QSkXNpTQc8KyXg0qXmPpbFmn5IjdNNF8= X-Received: by 2002:a67:ebc1:0:b0:3d0:d172:3a02 with SMTP id y1-20020a67ebc1000000b003d0d1723a02mr2755109vso.41.1675664238071; Sun, 05 Feb 2023 22:17:18 -0800 (PST) MIME-Version: 1.0 References: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com> <20230203-get_kernel_pages-v2-3-f1dc4af273f1@intel.com> In-Reply-To: <20230203-get_kernel_pages-v2-3-f1dc4af273f1@intel.com> From: Sumit Garg Date: Mon, 6 Feb 2023 11:47:07 +0530 Message-ID: Subject: Re: [PATCH v2 3/4] tee: Remove call to get_kernel_pages() To: Ira Weiny Cc: Andrew Morton , Al Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-mm@kvack.org, Jens Wiklander , "Fabio M. De Francesco" , John Hubbard , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EBA16100011 X-Stat-Signature: au1g5xoqyfwtzut9okkipdi6bwkbnpos X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675664238-155083 X-HE-Meta: U2FsdGVkX18DpW8waPwSFt8DUyBzSBz20tMY3zTILVQ+JTOi2vCICgLvfisH2OaapI6fwrTmMeL4Osfpy6QqaxHbYXLkRH/JtWorHktPZWFjrM2mwNjwXynnlNCGbz2fW8I+l5EQ33NkjNky9IlWa4uRAuF2D6F3WWPTERPj7VQFwEzCE+LuUX7HPbfyu8/XpT9YuArgbiZ96lYavKwM0Zu7c16Fdhb0Gzt/mrQKGXzucoM088sUSc/4WKiXCroY1Pig+SZT/GTYLldlfVvOEfJVUQx7ud1V/rehFMr1l9FjwIT/AXMGWWHbcZxKd9ZmltTIcUMkzCK8FvqVfBxuUb+o4kXjwly5mNG/t0gE7PAa9+eCQqs0UAJpGoIA2SYWd9dsnk4f5hlmYSTBemg19Apzn8OXl0dshvVbgvnFY/809mRWerGOzp1oCjb3uHQ85B0UAKqWQgG44onji4qhX3SH9dEhmVzcVPDS4kBtMF8ZVoQ6MQ+nWmiGoyEzSenAeFkeVtsRqAH5gAMFUZx49tghm+E1iWg+xmQMHC2LQk4+tshBS4b1wS+JHzpzs9sKf3lIXQM262IAiaEt9sRhJfyG2qX165oDHUXk0qTcoAp1gwlXN6O0lrNU7UdbkEDU/Bl3zKnfOp/1DmwLYKQ5MyixU3zd7ug+JbH+i7spuSQRmp6R7/9vw8JPeGEF0erKILFd7xVG3qfyAV9Jh9A/OuR+BriKl0Z3zP3Ib4xVPy0U111iJmN5IEZuOTRra6GXS4e/i4feJvhII22wrgjnJMLZR2H/4VQ31BolEUv99AV7L7Yb9TA6Vd4mHhP5Sfzk7QlR4iGe17xZLMXIlgfUtW+fLyLMazvl+X9G17KdAAnpUcU9uqLsTa8Df5Pi/8vKQEGC43/AkP/Do0I/lqoGZh0mBfjbrfPmh9GoCAbhb1e55veMFx7WKA1/l5C35VTHi9KK2pvRfYh0arMjWfg sALJtRzn osdFQV9RtZY9TlpAAij9niMt3hoVOuVehkB6qi96CDlfe695LHK0X5IHw3CrhEMluT5ePzlMQxtwKd3Vavftkkg+LVK+dYerZeQ7JImVN6+5Xq7SbxH0c4HiCWghoVoocP1lSX6KSM7SNI0rLfEumoH67jESlbqJgq/1gBIVOKHlBAlAmDTOAWjqNpZqlw95qWFAzqIb28r/wnPKTqmdxpuwehVOElYLdTg1/rjnZ3XjmxK+IKwbsi/ABlEPc54adB3uvR/rkATIVYEDlbPVmengZvKau7t6fxSTRZkXtL1lr+n+tQNTbh95ak/m21/tQyF5ekwMLLhqpB10uPFzlpuWOzWxcSuGn1QhN/GW86Dqx3nUunVZl5sXCktnVD7olwgLaQj0LwTruSW6QO9z6gM3RNCYO5Oh/8uml9j4S2NVC+/2USbtvijl5PsO75aK+SU9n/Gk/daAeZI6yd3cHTo2tuj039FCWIWQylJkPOCneLANEZtUUTgSWq13k3cuep1Or X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 4 Feb 2023 at 09:36, Ira Weiny wrote: > > The kernel pages used by shm_get_kernel_pages() are allocated using > GFP_KERNEL through the following call stack: > > trusted_instantiate() > trusted_payload_alloc() -> GFP_KERNEL > > tee_shm_register_kernel_buf() > register_shm_helper() > shm_get_kernel_pages() > > Where is one of: > > trusted_key_unseal() > trusted_key_get_random() > trusted_key_seal() > > Because the pages can't be from highmem get_kernel_pages() boils down to > a get_page() call. > > Remove the get_kernel_pages() call and open code the get_page(). > > In case a highmem page does slip through warn on once for a kmap'ed > address. > > Cc: Jens Wiklander > Cc: Al Viro > Cc: "Fabio M. De Francesco" > Cc: Christoph Hellwig > Cc: Linus Torvalds > Signed-off-by: Ira Weiny > > --- > Changes from v1: > Al/Christoph: Remove kiov altogether > --- > drivers/tee/tee_shm.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c > index 527a6eabc03e..b1c6231defad 100644 > --- a/drivers/tee/tee_shm.c > +++ b/drivers/tee/tee_shm.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include "tee_private.h" > > static void shm_put_kernel_pages(struct page **pages, size_t page_count) > @@ -24,26 +25,20 @@ static void shm_put_kernel_pages(struct page **pages, size_t page_count) > static int shm_get_kernel_pages(unsigned long start, size_t page_count, > struct page **pages) > { > - struct kvec *kiov; > + struct page *page; > size_t n; > - int rc; > > - if (WARN_ON_ONCE(is_vmalloc_addr((void *)start))) > + if (WARN_ON_ONCE(is_vmalloc_addr((void *)start) || > + is_kmap_addr((void *)start))) > return -EINVAL; > > - kiov = kcalloc(page_count, sizeof(*kiov), GFP_KERNEL); > - if (!kiov) > - return -ENOMEM; > - > + page = virt_to_page(start); > for (n = 0; n < page_count; n++) { > - kiov[n].iov_base = (void *)(start + n * PAGE_SIZE); > - kiov[n].iov_len = PAGE_SIZE; > + pages[n] = page + n; > + get_page(pages[n]); > } > > - rc = get_kernel_pages(kiov, page_count, 0, pages); > - kfree(kiov); > - > - return rc; > + return page_count; > } > > static void release_registered_pages(struct tee_shm *shm) > > -- > 2.39.1