From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BBBBC433F5 for ; Mon, 3 Oct 2022 06:57:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DF418E0001; Mon, 3 Oct 2022 02:57:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88D126B0073; Mon, 3 Oct 2022 02:57:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 754BC8E0001; Mon, 3 Oct 2022 02:57:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6220E6B0072 for ; Mon, 3 Oct 2022 02:57:20 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2DAB280B27 for ; Mon, 3 Oct 2022 06:57:20 +0000 (UTC) X-FDA: 79978731840.27.313DC48 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf04.hostedemail.com (Postfix) with ESMTP id C49254000B for ; Mon, 3 Oct 2022 06:57:19 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id lc7so20145627ejb.0 for ; Sun, 02 Oct 2022 23:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=/1Kjm+tlGvTFEl2ExNhozH8lcuXI6M+d4lR60oFBYPY=; b=AwzKwhX9x4Yjc9haniR/rahUAxhObz4WWpbKmDsQJFtYTWYjud6EIXN0a16X/ZAYyF 7qotqFzbCOP3Xvcc2ToRTpraOm1QEXGrpuw5hT0ffe9kK1T7eDAD9+1RmXFuytVmcfPK dprc9JqQL8M2obHbszNmRyoHq+7QBUUth9lVR/015GUp1OTjbQOfQaDYIK2uJKXnckU8 lzIWFvCKgXYp+pgmCGHAPfaLY2LQK2XJZyBjWcr+qWVvwksOnAtAwehpwiO7yHQrKKWN PtDzhSk/8v/0Y6Xbrrtd9FDPVPnL75559cLY7hefuYX3rpVpyWO3BO9tvBvuqWOAKhah OJMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=/1Kjm+tlGvTFEl2ExNhozH8lcuXI6M+d4lR60oFBYPY=; b=y3GU59ujVH7lXyRpa0lA6H+gKyhKky4FopgHpjN0rRsXwuxMG+NpRmn83HQJ0T7nRg zYJHPYY0w2oiRmBE9ETbFNcyj/rbgXmfM9yc11SCOHbMZSeF8aAKwaYehmqHsv62faQL +nWmu+a5xTL6zXoWcx7Y9nZKBvZmN3VmansqrRUnHQiTpiQmpGaAViV7r4zJYlmzGkGR GzS6LZWQPiqwZ7rOvaYpWo3dJpDdePZJU/u56/iodRbmD/exqSy4PagfrUudAD49g1DV jdrndd+2Z9zToDGRO0UrabnnfsDvn/V50L5d2r/BAjwGJ4EBqNWl9N9Pue2YBwPqAvKr oSbA== X-Gm-Message-State: ACrzQf1ENf040iAx/etSiYM0bUdXGi4gDD7tB3d9WUWyQUSzzv/bFizC u0d62qnqw3XmL7C3UeFV5Y5D6SuVb4leBRwwi7j+Rg== X-Google-Smtp-Source: AMsMyM5FQ+w+b43fu1d2E5z9n2EJdkuBjnXBhBiEEM6h0EjD1QSp1uuUgMt5/A/KCI9Ly/ibFGu516iRajZAjCiJmRw= X-Received: by 2002:a17:907:8a17:b0:782:6e72:7aba with SMTP id sc23-20020a1709078a1700b007826e727abamr14424481ejc.474.1664780238397; Sun, 02 Oct 2022 23:57:18 -0700 (PDT) MIME-Version: 1.0 References: <20221002002326.946620-1-ira.weiny@intel.com> <20221002002326.946620-3-ira.weiny@intel.com> In-Reply-To: <20221002002326.946620-3-ira.weiny@intel.com> From: Sumit Garg Date: Mon, 3 Oct 2022 12:27:07 +0530 Message-ID: Subject: Re: [PATCH 2/4] tee: Remove vmalloc page support To: ira.weiny@intel.com Cc: Jens Wiklander , Andrew Morton , Al Viro , "Fabio M. De Francesco" , Christoph Hellwig , Linus Torvalds , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Chang Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664780239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/1Kjm+tlGvTFEl2ExNhozH8lcuXI6M+d4lR60oFBYPY=; b=HsvjydRb9AnxWfgNyHqDEShcvnn45RAXs7ILGeWAceP+tzlM5qkraXQPlkk2Vh/A61Tf0h EAFqkHWCT75wq+bQa25Ykr4eMFTbRHNr/qah1sKD8Z0qbq0h7kSh1fCYE8hJYswoDwiPpT 9GSauGG0kaOjzHAFvuyQRPZCFOezdLs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=AwzKwhX9; spf=pass (imf04.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.218.43 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664780239; a=rsa-sha256; cv=none; b=als/E8Rq72/RnUzE9AcoIdN3Vql9pJm6aCP3mO2AlfAEw/hc/zNcxyQBPc/knafHjFeIUk yO3s4o7LyC/akVNQtMaSIH2giqA5q/8QZYWir893nWq4C720a9QUvf+dYUyXuz4uE6GwXm N0Nx6FIDAwGltKALLtLmCBHUJj/NAcw= X-Rspamd-Queue-Id: C49254000B Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=AwzKwhX9; spf=pass (imf04.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.218.43 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (policy=none) header.from=linaro.org X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: c9f3kp37dxcwd6nixpw9cam8ttrikbrk X-HE-Tag: 1664780239-372216 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: + Phil Hi Ira, On Sun, 2 Oct 2022 at 05:53, wrote: > > From: Ira Weiny > > The kernel pages used by shm_get_kernel_pages() are allocated using > GFP_KERNEL through the following call stack: > > trusted_instantiate() > trusted_payload_alloc() -> GFP_KERNEL > > tee_shm_register_kernel_buf() > register_shm_helper() > shm_get_kernel_pages() > > Where is one of: > > trusted_key_unseal() > trusted_key_get_random() > trusted_key_seal() > > Remove the vmalloc page support from shm_get_kernel_pages(). Replace > with a warn on once. > > Cc: Jens Wiklander > Cc: Al Viro > Cc: "Fabio M. De Francesco" > Cc: Christoph Hellwig > Cc: Linus Torvalds > Signed-off-by: Ira Weiny > > --- > Jens I went with the suggestion from Linus and Christoph and rejected > vmalloc addresses. I did not hear back from you regarding Linus' > question if the vmalloc page support was required by an up coming patch > set or not. So I assumed it was something out of tree. It looks like I wasn't CC'd to that conversation. IIRC, support for vmalloc addresses was added recently by Phil here [1]. So I would like to give him a chance if he is planning to post a corresponding kernel driver upstream. [1] https://lists.trustedfirmware.org/archives/list/op-tee@lists.trustedfirmware.org/thread/M7HI3P2M66V27SK35CGQRICZ7DJZ5J2W/ -Sumit > --- > drivers/tee/tee_shm.c | 36 ++++++++++++------------------------ > 1 file changed, 12 insertions(+), 24 deletions(-) > > diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c > index 27295bda3e0b..527a6eabc03e 100644 > --- a/drivers/tee/tee_shm.c > +++ b/drivers/tee/tee_shm.c > @@ -24,37 +24,25 @@ static void shm_put_kernel_pages(struct page **pages, size_t page_count) > static int shm_get_kernel_pages(unsigned long start, size_t page_count, > struct page **pages) > { > + struct kvec *kiov; > size_t n; > int rc; > > - if (is_vmalloc_addr((void *)start)) { > - struct page *page; > - > - for (n = 0; n < page_count; n++) { > - page = vmalloc_to_page((void *)(start + PAGE_SIZE * n)); > - if (!page) > - return -ENOMEM; > - > - get_page(page); > - pages[n] = page; > - } > - rc = page_count; > - } else { > - struct kvec *kiov; > - > - kiov = kcalloc(page_count, sizeof(*kiov), GFP_KERNEL); > - if (!kiov) > - return -ENOMEM; > + if (WARN_ON_ONCE(is_vmalloc_addr((void *)start))) > + return -EINVAL; > > - for (n = 0; n < page_count; n++) { > - kiov[n].iov_base = (void *)(start + n * PAGE_SIZE); > - kiov[n].iov_len = PAGE_SIZE; > - } > + kiov = kcalloc(page_count, sizeof(*kiov), GFP_KERNEL); > + if (!kiov) > + return -ENOMEM; > > - rc = get_kernel_pages(kiov, page_count, 0, pages); > - kfree(kiov); > + for (n = 0; n < page_count; n++) { > + kiov[n].iov_base = (void *)(start + n * PAGE_SIZE); > + kiov[n].iov_len = PAGE_SIZE; > } > > + rc = get_kernel_pages(kiov, page_count, 0, pages); > + kfree(kiov); > + > return rc; > } > > -- > 2.37.2 >