From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C096C64E8A for ; Thu, 3 Dec 2020 11:56:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C92752085B for ; Thu, 3 Dec 2020 11:56:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C92752085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 21AA16B005C; Thu, 3 Dec 2020 06:56:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C8C36B0070; Thu, 3 Dec 2020 06:56:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1076D6B006C; Thu, 3 Dec 2020 06:56:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id ED94E6B0074 for ; Thu, 3 Dec 2020 06:56:51 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B83B18249980 for ; Thu, 3 Dec 2020 11:56:51 +0000 (UTC) X-FDA: 77551819422.02.spot28_4a00d64273bb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 7BCFC10097AA1 for ; Thu, 3 Dec 2020 11:56:51 +0000 (UTC) X-HE-Tag: spot28_4a00d64273bb X-Filterd-Recvd-Size: 5183 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Dec 2020 11:56:50 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id u18so2290775lfd.9 for ; Thu, 03 Dec 2020 03:56:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bVF1+2F3uwYbhK8xPoQETKgtxYjX8ykg4ldE0W2Y9Gg=; b=cttH2Nx+HROca8aFKxet6zKYXoCHqSoBQwd71na4G6ZcuKbIi8sHRqqnEKFIWEQUra B0UREhHYsbQz+d384JUNBtqDrkyNv34/bItk8KvU1CvXfdsFubbwqlRYcheK3TKW1k0Z TZLPnbnvkDIzV7vL1IfGsuvagnmorOh3EECzEYvZbn5FkX58YQ7VvPGAtbSQHxso/ImY kx2Eky2+63Rhwbzac2TbAs7e9xeufsOasUqfpfQzdPsnpvMkQRkvtDVWZ8OmBnO4ZBBK GH2eGn7HRAwqKUdj7xmGNOxQweXy2A+IL8RVcSGASKLgpW9stwAQWjSsBmpnZCj+yrpT Xo1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bVF1+2F3uwYbhK8xPoQETKgtxYjX8ykg4ldE0W2Y9Gg=; b=M4eaq3L7WppYFI2NQ7qdjyoi8byMHTDQQndQfrFLzgNgiXwKLRx/bG+Ky3Mqvigi74 OkNEhkEDZeldo7GJl94PMGnqc6fKfrx8d3rU7L4j2H8xSpeDQ9Tj8nRmwW1msx4BZK/4 3YTV1sZfKq5W755uMk0YJzVXZPtMY4voo9W+Cz6ybNBAfChBIsLaXXk+d5hFTdaGzJtl mRiuTF6sN10cu2KH3oMPz5ZBeuZ+RKW/gAlqkdgXcC8mc1wpLB389kygkz7PC1lMaqHF 4rI3Nfi/ZIz6VoRXJFoPHGiZqICCBLpxfewWcoVtKwwn5zr3kTTPZys0yP4pX/n3aO4a +cBg== X-Gm-Message-State: AOAM5331YxmDRysaARyjdnZUbojfkDZVNsz7ENlVtdj+09jzJpieKpkk tQyuPx1omfu/79jEPJgjajbDR1/QyxaQgRvDxteRHQ== X-Google-Smtp-Source: ABdhPJwtqAwWblCe/w6lmroyLU7GyypS0YNbqMi+OT+wCXUu/mrOfwprdliy0PkrPUGSsWBqxliy4l0kzIpYN5wMYbU= X-Received: by 2002:a05:6512:358d:: with SMTP id m13mr1119780lfr.435.1606996609454; Thu, 03 Dec 2020 03:56:49 -0800 (PST) MIME-Version: 1.0 References: <202012031509.4O5ZoWNI-lkp@intel.com> <20201203113801.GB31188@willie-the-truck> In-Reply-To: <20201203113801.GB31188@willie-the-truck> From: Sumit Garg Date: Thu, 3 Dec 2020 17:26:38 +0530 Message-ID: Subject: Re: [linux-next:master 7808/9562] watchdog_hld.c:undefined reference to `hw_nmi_get_sample_period' To: Will Deacon Cc: kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 3 Dec 2020 at 17:08, Will Deacon wrote: > > On Thu, Dec 03, 2020 at 03:13:11PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 0eedceafd3a63fd082743c914853ef4b9247dbe6 > > commit: 367c820ef08082e68df8a3bc12e62393af21e4b5 [7808/9562] arm64: Enable perf events based hard lockup detector > > config: arm64-randconfig-r023-20201203 (attached as .config) > > compiler: aarch64-linux-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=367c820ef08082e68df8a3bc12e62393af21e4b5 > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout 367c820ef08082e68df8a3bc12e62393af21e4b5 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All errors (new ones prefixed by >>): > > > > aarch64-linux-ld: Unexpected GOT/PLT entries detected! > > aarch64-linux-ld: Unexpected run-time procedure linkages detected! > > aarch64-linux-ld: kernel/watchdog_hld.o: in function `hardlockup_detector_event_create': > > >> watchdog_hld.c:(.text+0x68): undefined reference to `hw_nmi_get_sample_period' > > Looks like the Kconfig dependencies aren't quite right here. > > Sumit -- what do you think about the fix below? > Thanks Will for fixing this, it looks good to me. -Sumit > Will > > --->8 > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 7d3440770b14..fe0d30a749b6 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -170,7 +170,7 @@ config ARM64 > select HAVE_NMI > select HAVE_PATA_PLATFORM > select HAVE_PERF_EVENTS > - select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI > + select HAVE_PERF_EVENTS_NMI if ARM64_PSEUDO_NMI && HW_PERF_EVENTS > select HAVE_HARDLOCKUP_DETECTOR_PERF if PERF_EVENTS && HAVE_PERF_EVENTS_NMI > select HAVE_PERF_REGS > select HAVE_PERF_USER_STACK_DUMP