From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 680A4C433FE for ; Mon, 3 Oct 2022 09:25:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B08B6B0072; Mon, 3 Oct 2022 05:25:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95FB16B0073; Mon, 3 Oct 2022 05:25:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 827478E0001; Mon, 3 Oct 2022 05:25:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6D4856B0072 for ; Mon, 3 Oct 2022 05:25:16 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 27C02120C20 for ; Mon, 3 Oct 2022 09:25:16 +0000 (UTC) X-FDA: 79979104632.22.9DCDB7E Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf23.hostedemail.com (Postfix) with ESMTP id A795B140011 for ; Mon, 3 Oct 2022 09:25:15 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id qx23so2714636ejb.11 for ; Mon, 03 Oct 2022 02:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=KH5kXMx1j/oTNNhZRKuODb/UQfipuwMsr2taHr2n3iI=; b=MmSSF88PGb0kNZlcZGhq52Bln8W5vNyi0KvF80KuX6npiDSOE7/4FnctaORCS+EP3Y 1OS/SRivnCENR642EbNLY3/UYA0kSouSO04VN9n8sbHHeD9bg3XZG1quagTYEeYMpqxo urQkf3hUQfleMBqJAZaDEtZqae74T+ZW8C3TabFy2V7r6TxjHMaknJFqCrCn02cmwsgQ osBKwqEn4oHbZbKqwXKc4GHi3JQTAqPwcVAArrF3EOXq4LWfXcrKIbO5qWA/Z7/Ob321 ArS5hBaNeR6PNBOMhcfmnKhSmUFIoWP43ohGlswMBLfh4foJE/cUVu3UfWLd+6ed7gkV EczA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=KH5kXMx1j/oTNNhZRKuODb/UQfipuwMsr2taHr2n3iI=; b=pyQfGw5QHmzPq8UagXQODoNt1HwW86EFmpbF3d95z0Mck18tvoJVMy3UE0b3Xfn6of WNQCx1RFAz3ZanDk8MfJH4kd08Qobk30o5chJsg0m8DkCd+Aug7Iu3U8oZOqI+cPhUgj owI6yDErZwAZnW1ZtDxqfryoUlOqN25DvLXPMMdranyHb05A3fxJajFB22FpWkta9B5t 1tJk2iQcGV6ISyr4YxzAcw67xlZvlKz8a3/buSK/LjxOlzD88wOwltOjZL4p2jp1eXyo gXGEWsQT8ZGkIu0dePSIUgMkyob3Uk6iKUOPMDNqcYEgBmK/jLqFftC+ByTN3HVP/TlM bBhw== X-Gm-Message-State: ACrzQf1q5hQ7CLx0kTIIihc8Wxjcub5LilW6vqOH6QX0Ce9tNXuwbd6q 93X/XHabns9MFYCJ4aKCMn2wYaQ3+P3p5271iR1ZSA== X-Google-Smtp-Source: AMsMyM6Q5krj64ZwrrjyF8pYM/58fjn7PE8pPyyPsvJWpsZaFJN1Vu02ABADXWgBqI4+3kYK5WRyxUmHsWFnHn8xRMc= X-Received: by 2002:a17:906:7304:b0:6ff:a76:5b09 with SMTP id di4-20020a170906730400b006ff0a765b09mr14178256ejc.193.1664789114197; Mon, 03 Oct 2022 02:25:14 -0700 (PDT) MIME-Version: 1.0 References: <20221002002326.946620-1-ira.weiny@intel.com> In-Reply-To: <20221002002326.946620-1-ira.weiny@intel.com> From: Sumit Garg Date: Mon, 3 Oct 2022 14:55:02 +0530 Message-ID: Subject: Re: [PATCH 0/4] Remove get_kernel_pages() To: ira.weiny@intel.com Cc: Jens Wiklander , Andrew Morton , "Fabio M. De Francesco" , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664789115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KH5kXMx1j/oTNNhZRKuODb/UQfipuwMsr2taHr2n3iI=; b=8rlPSmirGXJyYCCyT3ycRbQXv8YmA226jZulc1xU4zQ4mOGv/212MhU642IEbO4XVGCHz0 ZR2fS3khImCOBrwlSlKcRpPeJB7igY2eGu0aVf93577Ff0CrA2i+uqyYXV3tKEPbUxtkdp +cZ28u3d14UXC53OWNd9XvHYJ+gnOOI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=MmSSF88P; spf=pass (imf23.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.218.54 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664789115; a=rsa-sha256; cv=none; b=MoIARXOGziSssYJ8XNd7nBTh9EuKOaGjlEwu7XSXF4JrYN6zbh7DRZXFl4xaKR36o0NIfV oIzJ5tiihEpopQGMb2KV3zyoeupNl5HYoZfJCpB5dV2AibEs41aP1GXQURjTMeOdqGBg55 4SIYGpyx5i/GlxEK/UGN07ae8J5k53o= X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=MmSSF88P; spf=pass (imf23.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.218.54 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (policy=none) header.from=linaro.org X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A795B140011 X-Stat-Signature: pzins57fh139socwyxpuqfgabhk8nzws X-HE-Tag: 1664789115-978968 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Ira, On Sun, 2 Oct 2022 at 05:53, wrote: > > From: Ira Weiny > > get_kernel_pages() only had one caller [shm_get_kernel_pages()] which did not > need the functionality it provided. Furthermore, it called kmap_to_page() > which we are looking to removed. > > Alter shm_get_kernel_pages() to no longer call get_kernel_pages() and remove > get_kernel_pages(). Along the way it was noted that shm_get_kernel_pages() > does not have any need to support vmalloc'ed addresses either. Remove that > functionality to clean up the logic. > > This series also fixes and uses is_kmap_addr(). >From the above description, I am failing to see the motivation behind this change. Can you elaborate here? Also, since you are targeting to remove kmap_to_page(), is there any alternative way to support highmem for future TEE bus drivers? As I can see higmem being enabled for multiple Arm defconfigs [1] which can also support TEE (an example which already does it: arch/arm/configs/imx_v6_v7_defconfig). [1] git grep CONFIG_HIGHMEM arch/arm/ -Sumit > > Ira Weiny (4): > highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings > tee: Remove vmalloc page support > tee: Remove call to get_kernel_pages() > mm: Remove get_kernel_pages() > > drivers/tee/tee_shm.c | 41 ++++++++++++-------------------- > include/linux/highmem-internal.h | 5 +++- > include/linux/mm.h | 2 -- > mm/swap.c | 30 ----------------------- > 4 files changed, 19 insertions(+), 59 deletions(-) > > > base-commit: 274d7803837da78dfc911bcda0d593412676fc20 > -- > 2.37.2 >