From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30A6FC61DA4 for ; Mon, 6 Feb 2023 06:22:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89E826B0074; Mon, 6 Feb 2023 01:22:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84EA86B0075; Mon, 6 Feb 2023 01:22:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7161F6B0078; Mon, 6 Feb 2023 01:22:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5E0F46B0074 for ; Mon, 6 Feb 2023 01:22:58 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2B5C64052A for ; Mon, 6 Feb 2023 06:22:58 +0000 (UTC) X-FDA: 80435874036.20.479D14D Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by imf15.hostedemail.com (Postfix) with ESMTP id 7E32EA000D for ; Mon, 6 Feb 2023 06:22:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=uahW6+Yn; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf15.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.217.51 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675664575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ynrCrA1+knokV0dXoyzZReuKJceQqN5l3Tsi4apnR3Y=; b=l+lT3brVjNFzmOWNePRMJv1YYaaL1uQJfKEpnQBZSt4D+VhpRU2Md8I+VoPaIj8FGAja5j JPG5UcNuHsVyX/VbSLgK0vIhGChX+q7tgMcbBm/pTYNQB8QEihwfZ0Mp7tt0MNLcQpoSlz ht0xy+Kfc0x00S0/hcgLAwDJJ8OZgtI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=uahW6+Yn; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf15.hostedemail.com: domain of sumit.garg@linaro.org designates 209.85.217.51 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675664575; a=rsa-sha256; cv=none; b=teFxAueCbzggROQj0xXgPa9imQc+cTstVLNUhHsRW+2SIz26xg2IvcPO3gKJgI1D/7qNFT v7AXv30RJG2srowXZyZuHAaaShZWzHDhL5twwFLCxY9gunAGXwvvrqm2muK23vwJj+qUk7 eWEAKToT5ZGOktKvazLO7zGCKz8bDpE= Received: by mail-vs1-f51.google.com with SMTP id j7so11573525vsl.11 for ; Sun, 05 Feb 2023 22:22:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ynrCrA1+knokV0dXoyzZReuKJceQqN5l3Tsi4apnR3Y=; b=uahW6+YnhsfiMMFyR9frf6fGI/xz17H2d0nydFF8gvXJmd0WLchpwKE39XaDirMbnk w5hrvx/7xgjd8p34AvEQyKJyaoZVWIrDQAOgULTc9SgE3bWvi3ocZDdePBsKnQKUcZDE 0acxBfrh6WwI0dIJxTi6aL+2hlwuacTIAH+GIegXVx1BoABOvxlg27i/fZognfC+dsHd OyxMpd3/0FX2H+Y/CzGeGr86LgXlxleiQyj7a3voGXKHoJbDDLzo0h9ESQLcLmPlsqyq 21tXuel94sxAr08wrf96LMDxOwiJKMoaR5yz2IvSyJlPavteSYie3GGfj+UyBi4u+/ze t4vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ynrCrA1+knokV0dXoyzZReuKJceQqN5l3Tsi4apnR3Y=; b=8Pp6G2L8X5nkBXOXPSg2Zq8mYI9l0r9O9QjdKB9CMtcYKGrXngA6Tfswh4bW49cNw7 jQeG/2i4fVIVvNm5+qztZW27LBqi48pNiQKQiOaNere6SqY7EOQ9+9smBHmgLq/Tf4af ZayUYqe8QvPsayPuUq0Q1D0Sfdf1pMN0G4B2iUGLWHe2kro46XgWzOLAXOB4NhD+UBwH guKciHpk3poR2iYSO5z9Bz9R3T0+YwvBys7IAHKwRVVZij4SHGIer6F1bkQODHK3tvj4 2ULikkOH/++vR3CreHFTS9uv2mc2DNEdoXvfoZ9snIC6ycFyshlW7SSo5sxTQFu9i04v i5wA== X-Gm-Message-State: AO0yUKVP6XqFpWUYqHmxJKdeJCqbwgJwS6IkYQ+k1jYUi1VUEGy+SnSA pV5+tQZoO4I1obh6d7JBtm4W/p/kVwSH72+pBnDHdw== X-Google-Smtp-Source: AK7set/Else6edw9TgC+morr2lkXlm+Q1jjv3sTFx00yZIbme3IfsWPhIhz3bmsawg1Ju1IIuZBVQqTgruzBDFfLh5c= X-Received: by 2002:a05:6102:2378:b0:3ce:8835:de03 with SMTP id o24-20020a056102237800b003ce8835de03mr2728482vsa.50.1675664574674; Sun, 05 Feb 2023 22:22:54 -0800 (PST) MIME-Version: 1.0 References: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com> In-Reply-To: <20230203-get_kernel_pages-v2-0-f1dc4af273f1@intel.com> From: Sumit Garg Date: Mon, 6 Feb 2023 11:52:43 +0530 Message-ID: Subject: Re: [PATCH v2 0/4] Remove get_kernel_pages() To: Ira Weiny Cc: Andrew Morton , Al Viro , Christoph Hellwig , linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-mm@kvack.org, Jens Wiklander , "Fabio M. De Francesco" , John Hubbard , Matthew Wilcox , Thomas Gleixner , Linus Torvalds , Mel Gorman Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7E32EA000D X-Stat-Signature: qke64ak5a6kwws9sjmrxekpcx9mepy6z X-HE-Tag: 1675664575-13869 X-HE-Meta: U2FsdGVkX19xCXh4K+B17tLf/FV/hrd8TYghYLb9KItTl8g5OnUQuFs7V/nVL6mEOr3yl3/YIz/vLQMSuiSK+PwTmbs1ydBJJSMPV6xYatBN7BjECbFwEAZ/zIXkkdyWY/sRJk2UayU1AMQ0Gu4Y/qCotdsL+QTLDIvF9hDlwAOxUTslHqDnUVi6G5Kk5ElaX/zWDdrVDNVqsoaQZ7mUv9oyROxdo3yfBKkhe0AC0dI9fICbtLmgVxIWLnohlkstZO27J9c7lpy8PtuHOo5JtCLUJIksPph96+jJSXN22LriUGjUyW+lMSeyXY3IhBcE8K5T0+YIe03nPe9c3X16oaYHcCi/C0IAJV97CGk32Ch5nBfn71AZm4KQyocNwBLuNBWB9PdufV9X02I7b4OmWSBueEAL0R7WWm4klRIhme+JW5GMFbCNysCbVZPkoPkorK+pXQ82IOIUubPUJBybAOn2cI8grL46C9+DJvkphqATZzS3vbDX3TE5ZXkdjs9tRChqwiC2Z3Dz08Rm9MuF+vLzo1TRFIVYVcKERsiiJrwTfLD+bCAHg2hegQPj6cjlNezVXUXV3WQ3057J2aVKj4C1aN0WszdkAAywTslBnfq5I5xFlE2VPilOFWEs9AOV0ODWI1ztDUBnjI3V4WmAlHVxY0w/2FN6jg6RtLjb6gXfnhN1z+Wpk194sgBQs74TDbDaVViLrPyCVdab3r2X6rTz9U8S4rZDmHs+FA+M+0o6AMgO2DjcUMJD+P53fuw5Blkq+VeuPYAuuLFfmIitBfLJYyQkX5ZMx7V3tMgV1isYNSq36bDexSd+4pPAPsytHl3e4VOhW6f+5fCCriVANLiv2p00QwilhSuwNzBLXnjM9BRO8wh2ueqjsmZ47Ib2nKMIWHV0SY/DV4o6DHsnSeGWd4mXqO0wZ7mIZX9iyO6icryoBG+xfkzoTIkQs6LMtKyixypft42d3+hDse3 FjlvyINv 3BmUgdGNvDEiR2K5H14PlrW92fT2hHS9yToWUaXQ5Rmkc64uGcNqCc0Sh7Kboo+p35DKYINYG3lhQ3kgo6X1SdWsaJ4QN1DK1ny8VOTsY3zv0Xeta3AyvswERdgJHcFD2ojR/dJzfdy9sTFSu9a5uNoT/aUANNRq7sHyNX9Lh5l/pv60gjtSJu02L3THLlELKvOIYEd42I5HOjMZMwZtdnnZpPLqJK/2IzqrIXAMbFOxpn34gZ8CrLVtBsLvsyNWNIpPRbGHWU1Z/WMR4c3mhyo67BtCMPXK4PGlqVigb2eGsCDlOkhRwlIkYUZAGOPIUsQZpCDpIiedDQg66hVBn5Z7fws+C4t/RM1OHcG1+AOv46uRrt6mZlMpP5ZwCtSKbP2096qaEVwjlEpfBqz6wA1RxXbaqFTZ/oJnruVzv/xyUHQGFVROedLnNsnOfwGcX9nMb0HrFjcaFohHPLBOkjbkTRluvVAz9qEh8eVP2v0yKBxseUMlGiaE/uIgu14ew+694p5NqrsqeVIxxmrDGTV2NveYIfq/+isol7r8JFNmRO/9JcYWHjmhvub3NQS3GB0faMr5RAOmTClLah6di6tc7nqfBu7U3GtdBNkaPNtMGwM9yiun9znFjjl2bG0UjULinBh8gg9qLFAgajRiJJgLHmLbHboW3V0h03rqNZKVL/6vTPjuovrEtsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 4 Feb 2023 at 09:36, Ira Weiny wrote: > > Sumit, > > I did not see a follow up on this series per your last email.[1] I'd like to > move forward with getting rid of kmap_to_page(). So Hopefully this can land > and you can build on this rather than the other way around? Apologies Ira for keeping you waiting. Actually I was fully involved with other high priority work with my upstream review backlog increasing. So I wasn't able to devote time to this work. Sure I will rebase my work on top of your changes. -Sumit > > All, > > Al Viro found[2] that kmap_to_page() is broken. But not only is it broken, it > presents confusion over how highmem should be used because kmap() and friends > should not be used for 'long term' mappings. > > get_kernel_pages() is a caller of kmap_to_page(). It only has one caller > [shm_get_kernel_pages()] which does not need the functionality. > > Alter shm_get_kernel_pages() to no longer call get_kernel_pages() and remove > get_kernel_pages(). Along the way it was noted that shm_get_kernel_pages() > does not have any need to support vmalloc'ed addresses either. Remove that > functionality to clean up the logic. > > This series also fixes is_kmap_addr() and uses it to ensure no kmap addresses > slip in later. > > [1] https://lore.kernel.org/all/CAFA6WYMqEVDVW-ifoh-V9ni1zntYdes8adQKf2XXAUpqdaW53w@mail.gmail.com/ > [2] https://lore.kernel.org/lkml/YzSSl1ItVlARDvG3@ZenIV > > To: Sumit Garg > To: Andrew Morton > Cc: "Al Viro" > Cc: "Christoph Hellwig" > Cc: linux-kernel@vger.kernel.org > Cc: op-tee@lists.trustedfirmware.org > Cc: linux-mm@kvack.org > Cc: Jens Wiklander > Cc: "Fabio M. De Francesco" > Signed-off-by: Ira Weiny > > --- > Changes in v2: > - Al Viro: Avoid allocating the kiov. > - Sumit: Update cover letter to clarify the motivation behind removing > get_kernel_pages() > - Link to v1: https://lore.kernel.org/r/20221002002326.946620-1-ira.weiny@intel.com > > --- > Ira Weiny (4): > highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings > tee: Remove vmalloc page support > tee: Remove call to get_kernel_pages() > mm: Remove get_kernel_pages() > > drivers/tee/tee_shm.c | 37 ++++++++++--------------------------- > include/linux/highmem-internal.h | 5 ++++- > include/linux/mm.h | 2 -- > mm/swap.c | 30 ------------------------------ > 4 files changed, 14 insertions(+), 60 deletions(-) > --- > base-commit: 0136d86b78522bbd5755f8194c97a987f0586ba5 > change-id: 20230203-get_kernel_pages-199342cfba79 > > Best regards, > -- > Ira Weiny