From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>, Jeff Layton <jlayton@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Chuck Lever III <chuck.lever@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Kuniyuki Iwashima <kuniyu@amazon.com>
Subject: Re: [PATCH net-next v9 16/16] unix: Convert udp_sendpage() to use MSG_SPLICE_PAGES
Date: Fri, 19 May 2023 18:09:31 -0400 [thread overview]
Message-ID: <CAF=yD-J8KGX5gjGBK6OO2SuoVa8s07Cm-oKxwmvBmRXY7XscBQ@mail.gmail.com> (raw)
In-Reply-To: <20230518130713.1515729-17-dhowells@redhat.com>
On Thu, May 18, 2023 at 9:08 AM David Howells <dhowells@redhat.com> wrote:
>
> Convert unix_stream_sendpage() to use sendmsg() with MSG_SPLICE_PAGES
> rather than directly splicing in the pages itself.
>
> This allows ->sendpage() to be replaced by something that can handle
> multiple multipage folios in a single transaction.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: "David S. Miller" <davem@davemloft.net>
> cc: Eric Dumazet <edumazet@google.com>
> cc: Jakub Kicinski <kuba@kernel.org>
> cc: Paolo Abeni <pabeni@redhat.com>
> cc: Kuniyuki Iwashima <kuniyu@amazon.com>
> cc: Jens Axboe <axboe@kernel.dk>
> cc: Matthew Wilcox <willy@infradead.org>
> cc: netdev@vger.kernel.org
tiny nit: subject s/udp_sendpage/unix_stream_sendpage/
no other comments on this patch series from me
next prev parent reply other threads:[~2023-05-19 22:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 13:06 [PATCH net-next v9 00/16] splice, net: Replace sendpage with sendmsg(MSG_SPLICE_PAGES), part 1 David Howells
2023-05-18 13:06 ` [PATCH net-next v9 01/16] net: Declare MSG_SPLICE_PAGES internal sendmsg() flag David Howells
2023-05-18 13:06 ` [PATCH net-next v9 02/16] net: Pass max frags into skb_append_pagefrags() David Howells
2023-05-18 13:07 ` [PATCH net-next v9 03/16] net: Add a function to splice pages into an skbuff for MSG_SPLICE_PAGES David Howells
2023-05-18 13:07 ` [PATCH net-next v9 04/16] tcp: Support MSG_SPLICE_PAGES David Howells
2023-05-18 13:07 ` [PATCH net-next v9 05/16] tcp: Convert do_tcp_sendpages() to use MSG_SPLICE_PAGES David Howells
2023-05-18 13:07 ` [PATCH net-next v9 06/16] tcp_bpf: Inline do_tcp_sendpages as it's now a wrapper around tcp_sendmsg David Howells
2023-05-18 13:07 ` [PATCH net-next v9 07/16] espintcp: Inline do_tcp_sendpages() David Howells
2023-05-18 13:07 ` [PATCH net-next v9 08/16] tls: " David Howells
2023-05-18 13:07 ` [PATCH net-next v9 09/16] siw: " David Howells
2023-05-18 13:07 ` [PATCH net-next v9 10/16] tcp: Fold do_tcp_sendpages() into tcp_sendpage_locked() David Howells
2023-05-18 13:07 ` [PATCH net-next v9 11/16] ip, udp: Support MSG_SPLICE_PAGES David Howells
2023-05-18 13:07 ` [PATCH net-next v9 12/16] ip6, udp6: " David Howells
2023-05-18 13:07 ` [PATCH net-next v9 13/16] udp: Convert udp_sendpage() to use MSG_SPLICE_PAGES David Howells
2023-05-18 13:07 ` [PATCH net-next v9 14/16] ip: Remove ip_append_page() David Howells
2023-05-18 13:07 ` [PATCH net-next v9 15/16] af_unix: Support MSG_SPLICE_PAGES David Howells
2023-05-18 13:07 ` [PATCH net-next v9 16/16] unix: Convert udp_sendpage() to use MSG_SPLICE_PAGES David Howells
2023-05-19 22:09 ` Willem de Bruijn [this message]
2023-05-19 22:29 ` David Howells
2023-05-19 22:37 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-J8KGX5gjGBK6OO2SuoVa8s07Cm-oKxwmvBmRXY7XscBQ@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hch@infradead.org \
--cc=jlayton@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox