From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB17C61D9A for ; Wed, 22 Nov 2023 05:20:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EF986B055B; Wed, 22 Nov 2023 00:20:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A08C6B055C; Wed, 22 Nov 2023 00:20:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED9EF6B055D; Wed, 22 Nov 2023 00:20:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DEA0E6B055B for ; Wed, 22 Nov 2023 00:20:30 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B8F094056E for ; Wed, 22 Nov 2023 05:20:30 +0000 (UTC) X-FDA: 81484439820.24.4EBD4D0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id AB7AA40003 for ; Wed, 22 Nov 2023 05:20:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IK3Ltsik; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of chrisl@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700630428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A897xTqXJCJOAkSNXy7RtDlxqRa8sbWyq/4+MQQL3NU=; b=OiGDbOqnCoTVG+FrRNHQdezBay4X6Ygfpmv6t3WIjWavMkpHWdKUa7OVtiKSiecaxqn7rJ Xd8T+sqK29sRCqOjTEhchmVAqOew6+tgnreSQKbpjnhAwRD9p4h0CA2F8hV0+gBX1A3kVf 0Q7auKOCGYE88nXzIylJPWQ9UPS1d7A= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IK3Ltsik; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of chrisl@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700630428; a=rsa-sha256; cv=none; b=mwguJpDyT+ylFvtUwsKXuVcRnJW8wDbkLpUgJ5Up4KW0P5KpYjsrCb1R7gYxE0saRwb2Vq NYUbqCwjnA/9aeLWaZMvHNSz2VB54IA9/1F+zToAYPYPxvULCAnsUF0vizPxwGWVlFNPDF Ou2KYS0/eaApBFdxKwrsWnEa3QSe8W8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 42409B82534 for ; Wed, 22 Nov 2023 05:20:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 983DFC433C8 for ; Wed, 22 Nov 2023 05:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700630426; bh=TBbRhfDoqJI+ymRHmhoyHUYl0HTJGIfk3dxv/NU20Ms=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IK3LtsikP1BRvwrCEda6kuTq9O8soo75WIIUOk2Fz9xXUoexs5vP6NjzjW+PhPPvA DNmXbdqCUFHGfiVSS+c0O/cu3DrW8VyOei0MpCAf8J98XFpQPrfk2yx5OohGJd7oRr z7CqSaIUtco5hW6OHfK5ZnuHK+u2k8c44bFPucZGl1SEklO4VqRy3aVcrGy5JfSqMk 7SD4fkIzzNynOylUShKy5l5/7WHJCnMqoKGISmy8qec2U5lpHQcI2IJT5hoTdmxBSV FthKfY3MFdfmRyBYFd9hbwkQuXC25YW8BmnECgbRdvV9bw8sUEzuWj991pq0CKueCH D8dCqUJqWVRVA== Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-28398d6c9f3so4376708a91.0 for ; Tue, 21 Nov 2023 21:20:26 -0800 (PST) X-Gm-Message-State: AOJu0Yy9AMCABuNAVWxvwqmgLI/2Y8ZZu3lTGGveNj/aLhc4/bdmTdCW 8pBMl/urfsq0T2njhcmPhbH9aeoJGfpa2lYTIIVq5A== X-Google-Smtp-Source: AGHT+IFcrF1HMAPcEcdg3CE9b/rONhKC5c1o9etFhSEOQC2ujUcKF7+jI+/KXApiAMAt48bunhDMoHWEhQ9XY7eC6QM= X-Received: by 2002:a17:90a:6349:b0:280:65ed:df9 with SMTP id v9-20020a17090a634900b0028065ed0df9mr1378521pjs.31.1700630426038; Tue, 21 Nov 2023 21:20:26 -0800 (PST) MIME-Version: 1.0 References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-23-ryncsn@gmail.com> In-Reply-To: <20231119194740.94101-23-ryncsn@gmail.com> From: Chris Li Date: Tue, 21 Nov 2023 21:20:14 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 22/24] swap: make swap_cluster_readahead static To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: w9wibh3pznyi7e5teeb76kuxaxfg179w X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AB7AA40003 X-HE-Tag: 1700630428-883675 X-HE-Meta: U2FsdGVkX19p373LmiXWjIofpfJceGxJQSX1/Z3T4WMhwSTvFr69cIbd23pAU2TkluPeRo4ABKMCyyDmouKlsaY1vHDMHapJGIu9s7EjSDNUyH0B1aqsB0mchWX6Njyn3SYPh2JWj4YsyRHDjDbKDCQ0CVUR9kDCLJXn3ZdAYOkk2znp0ANtWinBp6L/PDQycrq45Busa1Eur6JebVIk8O4aTPbTP0BxHF1TPNbFIvi2AXT2QBOsnBlSHTDAkgcCdztiwFK1wgWM8m+6/e5Xfec3hdM5tSrxKboAE90KFkpUp+kkFReLKCFRI/Epi5LLJACJQM8dA96HgF7hM1t7569sfYEtjbG0vbdgUC4emRwMRm3K5bLrkXXlJXovbKFa6zu58bZ9qUFK1whUS6BdlpsGffC0WXiVBMjPb7UATH6TDM2bUTtRgvS9Y5blWo/9iqndgvMdHmeiIG+TWovEh/IWDo36rEyOmbrw8FJOeswLEkPJXm1cnjcGdY55FCczPah5L7KBDeJdaZoydLZW/UY9nHK9vkYI/JtQGcmx7NyZ8itWc5OmHrjBX1ZbBUdOYGE/7XIV5e5c8omr1CJdxyGDsu71de5g9Zug0y/NctZCScAhkI3wR7dCZC5c/vjC8XeD5W5YJVy7fvZorWQTX3r6vETu0MJGjxOt/oow1SixMUBlAW/xrbUYb0zWlsHBYAi2iVhfeOvQv/IflD2hHL6OTZY0wB+Cvgw/RjNkULIKNP7dK+mPXMPfHbo0nhfWyLxq43w2BjO2wu1T7hJ19qufSBmoDYm0B/ldOMSiHLMkcAN8jCNfL3K0VCx6/1ZqgNW8z0GuLJldkb+320jhM7W3SNx80JAjiBVdRgmFHaqpbsTihXn1R5HqPEhYwJXletiwBt0n6qqFnj6ulYfGYtVyLad1+3w+5popSwouqaQPYKTG1l7mKU+b4sWbQ2+NLpksKTKW2OjwaajYM+w rPR39PAf T9VfK7z6p9okbwBGeQxYcL1Qedd/0J9+1wzR7s5g2oUzMg2hXY0qhY2TZgNpShoTs1eyZdyqCoIDv/FqN2ozADZRtL4FDvirFee71ULt3dq2hseOx3MIWSMrFkiRpoHZV6ruA6UjfPJ+NfEz6/sK5JB2KrGV7X4tXj0C32Ez2qmiqDwaU8IcYrodrhvkimF3U6T7Nq2W6humeXWBt75eqjQIwJCibWui3AWCBNZPckQpcuDnT0QB0Qa0wiHawcgjbjmOS8ccOjpKoUinzHYMzJShT3gL7W/PTyiYw7C+cZ0cH18szlsUj3YQrZ3Cq3q5nGAoh8WmHeiLAtucjS/aJAD7Zeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kairui, On Sun, Nov 19, 2023 at 11:49=E2=80=AFAM Kairui Song wro= te: > > From: Kairui Song > > Now there is no caller outside the same file, make it static. Seems to me too trivial/low value to justify as a standalone patch. Chris > > Signed-off-by: Kairui Song > --- > mm/swap.h | 8 -------- > mm/swap_state.c | 4 ++-- > 2 files changed, 2 insertions(+), 10 deletions(-) > > diff --git a/mm/swap.h b/mm/swap.h > index 4402970547e7..795a25df87da 100644 > --- a/mm/swap.h > +++ b/mm/swap.h > @@ -56,8 +56,6 @@ struct page *read_swap_cache_async(swp_entry_t entry, g= fp_t gfp_mask, > struct page *__read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask, > struct mempolicy *mpol, pgoff_t ilx, > bool *new_page_allocated); > -struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t flag, > - struct mempolicy *mpol, pgoff_t ilx); > struct page *swapin_readahead(swp_entry_t entry, gfp_t flag, > struct vm_fault *vmf, enum swap_cache_resul= t *result); > struct page *swapin_page_non_fault(swp_entry_t entry, gfp_t gfp_mask, > @@ -93,12 +91,6 @@ static inline void show_swap_cache_info(void) > { > } > > -static inline struct page *swap_cluster_readahead(swp_entry_t entry, > - gfp_t gfp_mask, struct mempolicy *mpol, pgoff_t i= lx) > -{ > - return NULL; > -} > - > static inline struct page *swapin_readahead(swp_entry_t swp, gfp_t gfp_m= ask, > struct vm_fault *vmf, enum swap_cache_result *res= ult) > { > diff --git a/mm/swap_state.c b/mm/swap_state.c > index 0433a2586c6d..b377e55cb850 100644 > --- a/mm/swap_state.c > +++ b/mm/swap_state.c > @@ -627,8 +627,8 @@ static unsigned long swapin_nr_pages(unsigned long of= fset) > * are used for every page of the readahead: neighbouring pages on swap > * are fairly likely to have been swapped out from the same node. > */ > -struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t gfp_mask, > - struct mempolicy *mpol, pgoff_t ilx) > +static struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t gfp_= mask, > + struct mempolicy *mpol, pgoff_= t ilx) > { > struct page *page; > unsigned long entry_offset =3D swp_offset(entry); > -- > 2.42.0 > >