From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6B6C2BB3F for ; Mon, 20 Nov 2023 05:31:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88F386B0323; Mon, 20 Nov 2023 00:31:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83FDC6B0368; Mon, 20 Nov 2023 00:31:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 706DA6B0397; Mon, 20 Nov 2023 00:31:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6310B6B0323 for ; Mon, 20 Nov 2023 00:31:46 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 312D240584 for ; Mon, 20 Nov 2023 05:31:46 +0000 (UTC) X-FDA: 81477210612.03.AB4C213 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 53C75A0017 for ; Mon, 20 Nov 2023 05:31:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UaoYNlRz; spf=pass (imf25.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700458304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g5FZt8nMm2x6QmUACZ0vv+9RumrjGcpro+qBhqOkWtk=; b=6XkNx1xFD7k2AmdQIdYKq4dCe8IeOJAsGoY4fBIKElhqrRPL+T4so+g1wuC7PRPXvJpiAc f7BXXwX3TS9QGHEBN9ODbFbMU0xDCsL+i6c0kMkeA+DYtWDijKbfAO4/ARMb3lS42VdJ7A cM8D8zB62WJO6tIPov/QAIrOepqOBTU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700458304; a=rsa-sha256; cv=none; b=jZ6YvGkELIhk6C+VsQBDb62Km8NzNvfxaPrHHfTLpqfNviHTWvpICqdeFTLci69FOIGFwe NzG4VXevlxM29tZD0hgjG5O+mLokCfrV/TDYd0CaglqxDLm3SHYpkgNRgLNHghVY9ozmIM 9hrfTpHWyPc08tCH1CbWy/JhGLAE0Og= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UaoYNlRz; spf=pass (imf25.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 08C3060DC1 for ; Mon, 20 Nov 2023 05:31:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 185B8C433C8 for ; Mon, 20 Nov 2023 05:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700458302; bh=1HCXqGJ6ZcQ5roM42J7RYsG2FK1b3wyTgpAEboIgJzQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=UaoYNlRzyIugLZng/SrmTERrWhDTm06T0kBvHPARO3bdxonthfjVD7UnooClmF4uh 0x/qnZ3ZKN2Q3PEIB9GhnHrhkTC5cNLxw8FxnzyZPjjACxBxRhROaQIDyz8GS0ijFX gKwhElXcrSdxnNOPpMAwDzihaZ9wt/Rbg+//yigy9Ns54aeortl3rn4Imo9DzKVxaJ JJdkq7swFGNqJwEtw9eKgIVZSwmxzzSMjMxGFoy7GKne98RQSBXuL/lDamCDIeoKNt P3RIAx8jstLTRL3qAka5M4B7ieedVN8TSjlB8ixc7cTOG5pIm1nbRVOAubamJZvbfn u6tgSfxJt726Q== Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2802e5ae23bso3471069a91.2 for ; Sun, 19 Nov 2023 21:31:42 -0800 (PST) X-Gm-Message-State: AOJu0YyjT1Kf2IWLlhQklIPlopaB6mCnXyMT+xh/4lJebYtSTD3nVdpy 0XR0S/xh8hFAk1Gx2u3Vr97wnjiS75FE9g9kguXYcA== X-Google-Smtp-Source: AGHT+IF+XyiqZDNFegJbF4H2atN+mxdh7CHnI7jFVewEGcVXqFUXIuHD8DirvFwkqD5rEH5aJzxSTDVTBFKyfU6tZQw= X-Received: by 2002:a17:90b:1a8a:b0:27d:f711:112e with SMTP id ng10-20020a17090b1a8a00b0027df711112emr8007586pjb.45.1700458301569; Sun, 19 Nov 2023 21:31:41 -0800 (PST) MIME-Version: 1.0 References: <20231113130601.3350915-1-hezhongkun.hzk@bytedance.com> <8734x1cdtr.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <8734x1cdtr.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Chris Li Date: Sun, 19 Nov 2023 21:31:30 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm:zswap: fix zswap entry reclamation failure in two scenarios To: "Huang, Ying" Cc: Yosry Ahmed , Zhongkun He , Andrew Morton , Johannes Weiner , Nhat Pham , Seth Jennings , Dan Streetman , Vitaly Wool , linux-mm , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: t713i1jud3owiw1kqmef794gycmefqtg X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 53C75A0017 X-Rspam-User: X-HE-Tag: 1700458304-292159 X-HE-Meta: U2FsdGVkX1+1RNyGIgeU0feIAK+DXUsEWDkY+Jg9IPIphHPRkUdThy3byr/zQ+/0O2oNCKYs8UFH4yBvvUVBJJNbMKLu0pT4/j/K1E85qm8pyz7OhTVRzfk+q+RRo7jEXUm0/J/pAWjgJfwDlkHknz1tf0p8rZPd01lgDPpXcqPrL+fl9u//1ikccAIvLzSbxBOFIEmD/Rf5/1UwCS1HcwjlHVJbD7IPdDhXVm9WB14oK2RYxll2TwQ8aaqJqVSH9Jzcp4/U3Lrm1McV/5J1H8X0RElRZUApSy6ArFf6rd8mdyF/k9PgyJ5kzIBFbRIrdr735IGOHNl2jqh47T335ySVWPvthk2fuU5zIyIiiiUaMNEiNH9KPNzS0JLFXWmXPqWXEvXT94DOALzxZHkUKzi2sYwECdw5gpltpnlEH59Yss/prC97/PS6ikQgRdabvKbn8SUe/f398wUsM1nDIKpMyQubTDAJsHsV1P4B+XkwFpAGKc2BuLm7s8eKsGvLghV/cvnhFSLtEUhupylQK1At+v3e9MlyKNFdTdkVgt3uz7HUvzy3QowFqQ37AY1Z6grCHYtepXJVhGg26ZhmHdSGqSh/UZowpozvJe7YHHrdRpXdkeNozkz7fwNeNcoN5/GHGrsyToJTd/GjgRBRrazMvcW82WBpdA38UTfbuEJla1D0O7K9vHoCgDeLUnC/OlLdaqcSTdEoNMmGNdWwYopDNjc82cbTVl5XUQgO7ERerwQJ+mtz0VkH8BqT2gheM7dLnWajLkZ7iW6RYycCun4aHfQRbsVn5cduQsdinCetvjo0Ln/NEltldCg2c1kYu88+rXg/5h3ypl2MCoz+/yKAZeRlpinTSp4CAM39lgcd5cKKO5bq1gLVpVvhIaAODwOnaVjljdHYH9aN7h53jitqcINbxQ4hhxcAvO1tPDTZh4LdwPiiLSPUV9XH7jjVJBs6VQsUvqv8/M491Sq 6neXD03+ S9nV6HbK1BIs5E6ToZ79MlxMZmh8D6RPVcPx0Kf9BFB6d6DXPwPAQkw7vTej4qbkFzUuC4Hx3N/sPA5cvjeTfpW5ZBHg+bFzWhbIqS8Ufu+v41FujNSGeWtIo3+XxzAb6XtM+3dWxzfixSzK/lhc/CKHO0kK9CMXYe58Qv3GS5Mqa0C0/f9P6yKOPxVuby+OswwG4fhaiRaAFR2TwYDyJI2w8YrXs1fqdyo2IWs4ITBUBF4qxjZ8flTVspudcroBeyeYKOJuXzQMCOLY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Nov 19, 2023 at 7:20=E2=80=AFPM Huang, Ying = wrote: > > Chris Li writes: > > > On Thu, Nov 16, 2023 at 12:19=E2=80=AFPM Yosry Ahmed wrote: > > That will cancel the batching effect on the swap slot free, making the > > common case for swapping faults take longer to complete, righ? > > If I recall correctly, the uncharge is the expensive part of the swap > > slot free operation. > > I just want to figure out what we are trading off against. This is not > > one side wins all situations. > > Per my understanding, we don't batch memcg uncharging in > swap_entry_free() now. Although it's possible and may improve > performance. swap_entry_free() does not do batching, it is at the caller level. I just checked. The batching is done in free_swap_slot() is still using swap slot cache and batching. It uses swapcache_free_entries() to batch free the swap_slots. That is where the uncharge happens per my understanding. Chris