From: Chris Li <chrisl@kernel.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Vlastimil Babka <vbabka@suse.cz>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,
Charan Teja Kalla <quic_charante@quicinc.com>,
shikemeng@huaweicloud.com, kasong@tencent.com,
nphamcs@gmail.com, bhe@redhat.com, baohua@kernel.org,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [RFC PATCH 1/6] mm/mmap: Move exit_mmap() trace point
Date: Thu, 21 Aug 2025 14:12:51 -0700 [thread overview]
Message-ID: <CAF8kJuPs4FBQ3x8Z_ME3vjwJHaAtHeE8jmn9pBqz8cau72e_+w@mail.gmail.com> (raw)
In-Reply-To: <20250815191031.3769540-2-Liam.Howlett@oracle.com>
Acked-by: Chris Li <chrisl@kernel.org>
Chris
Chris
On Fri, Aug 15, 2025 at 12:11 PM Liam R. Howlett
<Liam.Howlett@oracle.com> wrote:
>
> Move the trace point later in the function so that it is not skipped in
> the event of a failed fork.
>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> mm/mmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 7306253cc3b57..c4c315b480af7 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -1310,9 +1310,9 @@ void exit_mmap(struct mm_struct *mm)
>
> BUG_ON(count != mm->map_count);
>
> - trace_exit_mmap(mm);
> destroy:
> __mt_destroy(&mm->mm_mt);
> + trace_exit_mmap(mm);
> mmap_write_unlock(mm);
> vm_unacct_memory(nr_accounted);
> }
> --
> 2.47.2
>
>
next prev parent reply other threads:[~2025-08-21 21:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 19:10 [RFC PATCH 0/6] Remove XA_ZERO from error recovery of Liam R. Howlett
2025-08-15 19:10 ` [RFC PATCH 1/6] mm/mmap: Move exit_mmap() trace point Liam R. Howlett
2025-08-19 18:27 ` Lorenzo Stoakes
2025-08-21 21:12 ` Chris Li [this message]
2025-08-15 19:10 ` [RFC PATCH 2/6] mm/mmap: Abstract vma clean up from exit_mmap() Liam R. Howlett
2025-08-19 18:38 ` Lorenzo Stoakes
2025-09-03 19:56 ` Liam R. Howlett
2025-09-04 15:21 ` Lorenzo Stoakes
2025-08-15 19:10 ` [RFC PATCH 3/6] mm/vma: Add limits to unmap_region() for vmas Liam R. Howlett
2025-08-19 18:48 ` Lorenzo Stoakes
2025-09-03 19:57 ` Liam R. Howlett
2025-09-04 15:23 ` Lorenzo Stoakes
2025-08-15 19:10 ` [RFC PATCH 4/6] mm/memory: Add tree limit to free_pgtables() Liam R. Howlett
2025-08-18 15:36 ` Lorenzo Stoakes
2025-08-18 15:54 ` Liam R. Howlett
2025-08-19 19:14 ` Lorenzo Stoakes
2025-09-03 20:19 ` Liam R. Howlett
2025-09-04 10:20 ` David Hildenbrand
2025-09-04 15:36 ` Lorenzo Stoakes
2025-09-09 17:19 ` Liam R. Howlett
2025-09-04 15:33 ` Lorenzo Stoakes
2025-08-15 19:10 ` [RFC PATCH 5/6] mm/vma: Add page table limit to unmap_region() Liam R. Howlett
2025-08-19 19:27 ` Lorenzo Stoakes
2025-08-15 19:10 ` [RFC PATCH 6/6] mm: Change dup_mmap() recovery Liam R. Howlett
2025-08-18 15:12 ` Lorenzo Stoakes
2025-08-18 15:29 ` Lorenzo Stoakes
2025-08-19 20:33 ` Lorenzo Stoakes
2025-09-04 0:13 ` Liam R. Howlett
2025-09-04 15:40 ` Lorenzo Stoakes
2025-08-15 19:49 ` [RFC PATCH 0/6] Remove XA_ZERO from error recovery of Jann Horn
2025-08-18 15:48 ` Liam R. Howlett
2025-08-18 9:44 ` David Hildenbrand
2025-08-18 14:26 ` Charan Teja Kalla
2025-08-18 14:54 ` Liam R. Howlett
2025-08-18 15:47 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF8kJuPs4FBQ3x8Z_ME3vjwJHaAtHeE8jmn9pBqz8cau72e_+w@mail.gmail.com \
--to=chrisl@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=bhe@redhat.com \
--cc=david@redhat.com \
--cc=jannh@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maple-tree@lists.infradead.org \
--cc=mhocko@suse.com \
--cc=nphamcs@gmail.com \
--cc=pfalcato@suse.de \
--cc=quic_charante@quicinc.com \
--cc=rppt@kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox