From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB10FC47422 for ; Fri, 26 Jan 2024 23:22:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C2AC6B0087; Fri, 26 Jan 2024 18:22:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74CA86B0088; Fri, 26 Jan 2024 18:22:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C52E6B008A; Fri, 26 Jan 2024 18:22:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 47B6B6B0087 for ; Fri, 26 Jan 2024 18:22:20 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E11EC40FD2 for ; Fri, 26 Jan 2024 23:22:19 +0000 (UTC) X-FDA: 81723037998.05.44DE147 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 9CFC420009 for ; Fri, 26 Jan 2024 23:22:17 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Xp5aYTgt; spf=pass (imf13.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706311338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AxSgMEs9EbfmmonEW6Cjwu9SvoSyTzjiNNE+vfTOPKM=; b=2IWzE7EyrZVWQPGpVkNyz2/I/s3nC+46IE3hx/zD6bk6FuKa+L5n3WhUgIf4ISiZoYJnr3 HziPKzAdByQ3BJhH4OKpD+YEe0bwfSps3ZGlxgNwBCtyeb6jSF4zD26nfXtnt+usX10cjv ehCEPzerJ4fvSNlc03aJ48HcmINNXSw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706311338; a=rsa-sha256; cv=none; b=ydZV5C/7cGLda9VKW7kx5Zy7VemLiLXQjk09XpH8N878juuF75wkfG2VTkQzzdQSExO42Y a9PejHUABsRuAC7dR5NAm+JG9wm9UTa4K0yGjrqVTLfnh3AFOdugY/a03OcKo1h7HBPKCZ ezlh9eyWX7A3asmeI/HSsITJsvFVXXU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Xp5aYTgt; spf=pass (imf13.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 874B0CE37EC for ; Fri, 26 Jan 2024 23:22:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3DB1C43399 for ; Fri, 26 Jan 2024 23:22:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706311333; bh=b2arGmKMK+liWpR+Ih+bOXkfi45YnJqpve4R/L7zdlU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Xp5aYTgt+F9ZfykTSVpwbkaLjWAaDqpoA1t1jVQ7/kFXBQXt/10CvO1JpxZDsQfJa bWMCMU7rMaHFWHxXIKdYAHgyR12304G+DU3EzooGzrZIQHuZI73fXXtJiAFdDX1ode iQ9MgCUNZK4SQOeguiWxd0EUgJYy9jcXZZOHWE7mlI5Ih9w7Skhzm0ucrcdEjvHT9C C5XZ/M2isO9cqdeQBUftvs8SvWaeWGLCD85yv4qTZsEIzatA3shstdzSam92nY2z7Z mXEKWAa293ptW1o+MbHIa56+FrPriKDN8ifdVGqeDlokGd4NG6t8wOJa4KnhzcYU8D mS184HO0kUVtA== Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-362a24b13d7so1595205ab.2 for ; Fri, 26 Jan 2024 15:22:13 -0800 (PST) X-Gm-Message-State: AOJu0Yyg3CIyROf5uLbngi/6qPCeow8WA1ON11etJMAV2vCxv2MCw9gl OsEJwYT1WRdH4CKg0lR2YAVNtkRMKgVavDb0owGktsBSxtr3mP9wq9PafviZtP24oXx0nlgS/IV LdthgFtA8cNBy75QgHPUOf6XUViEbEIqPGsBO X-Google-Smtp-Source: AGHT+IH1DsCrw815RmtRcucCScHq0lo1AgpoBFxYkaH6VQFWi2h4seiB5QaOx6GG+y/KaOGKFnSxVRTDzHtqHhqvqU0= X-Received: by 2002:a92:a30d:0:b0:361:8ced:91be with SMTP id a13-20020a92a30d000000b003618ced91bemr605310ili.12.1706311333098; Fri, 26 Jan 2024 15:22:13 -0800 (PST) MIME-Version: 1.0 References: <20231025144546.577640-1-ryan.roberts@arm.com> <20240118111036.72641-1-21cnbao@gmail.com> <20240118111036.72641-4-21cnbao@gmail.com> In-Reply-To: <20240118111036.72641-4-21cnbao@gmail.com> From: Chris Li Date: Fri, 26 Jan 2024 15:22:02 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC 3/6] mm: swap: make should_try_to_free_swap() support large-folio To: Barry Song <21cnbao@gmail.com> Cc: ryan.roberts@arm.com, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.com, shy828301@gmail.com, wangkefeng.wang@huawei.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yuzhao@google.com, surenb@google.com, steven.price@arm.com, Chuanhua Han , Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9CFC420009 X-Rspam-User: X-Stat-Signature: on5x3cj8so9qoourg9tc6z7tibg314zw X-Rspamd-Server: rspam03 X-HE-Tag: 1706311337-578241 X-HE-Meta: U2FsdGVkX19GK0t/0YMhcQuDS2huONSxpU8mYsM9ZJt3eJvRuxQr0GPH9kXKKfo6839e5Nsil85tqxGljSNpOjhwL5jR3YKY0fcK6fVLcf7eLhWR7hhmAVVlWAPhk2QwCfIxDUV7oPYt2nrKWZTUKiR3ixb6aXibzW9HCOMapXXA9+mtwEEnt4BCVYVyaWW26WmyteAJcLXA9PbgDF38r9+ZDWkAPve0rlPkrQpWFVqCsrU6nKXnDB5s8d3/yqoHSrtKKl/56q/Gi45NG5y7oyc23Aji8ZNBqrg0Nr0i2NKKL/sRHw8rf2IQ9W/BqbZKEEZ+ltFdQB3CpohoaUEnYL+6B1w0crvbJWNSaWn3TAzcF1R6U4/sdZDShuJMMEZgIgBu5w9SqA4iIpOlp1Gq/RGIP4vHwHWGCvpR9slRrJ+TMjDjpJ2h1+HCM96ZfL6fjtyPPvyw9vFDlo9NkKh3FjQuNXMqeXFvPkti690DDEli95XJC/XNPg4dtklaDix87a24Ll+2vsoIxYuBpNxok8E+ysrJXOo6th3bieACegHaGBP369RYUtJB0SUqPEPwMahvH5vE4fGo5xiZv8nVYx0SfIucpD4jMEf5OkbW4aOqnvgkMJ5vvSExze/JrWOta2kwT9oEcjWzJ6ahDUTuV3aycGz9wzw41vEuZ94EdsF+GXlkoS3AvTXqk6mVegnbF4ifRc3arQ08kdQ5KNY3BGrkeQTFfFsc+E+gWpMvaLopALpiZSNrbydJO+PvLqinXpCujqr+LhZEvtUTx+meJry50CFCNCJh7i87oqa77d9sfmis8QYYpR980Qjb5H5PocfnRk2X4Tx8Y1xTy/5ixqAHOrKpzLtwFgCILssU364P0RWKHYEtXB8u3k+p9DqGRSxLB7yi0M3h84qzEaSzK+KTBCmsbQ5vAmoYFa790v5aKeR+gCvhr2QJz0U2d91IOsQQq+MjE7qcLDicLlw kwa3J75i 6ks5qcRjSbARTuIxIeXlV6mltwXdK4jprQxuLbGmXoFr+pcqsGgMA3EHQZSPR5ZXUr9UOUFmdN7JcVhSaSfrGmfSalmm67YTQ81qII24FGJsickhXZcnFy0ntVriCmBTbRK5BocSmQ1fD241JD25KDM0gietFSJ51s8vkTW9wKMFopCX9Ee946x20QfXx2DMvBiWg+DqX3NQSuM7dt02hvwPsw537IPXChvEk5C0yAQAvskKwlOPy8lDrI5ZW+TDD0NxBgJV95WIHRN9yL15WswhFBM31fyxfD8vU8u7+ji3VuWCic0HjqHib+HZRvJBL7HGArJly+egyByN1hgdGuEn/w34kxyhFrbMUdo0iAZR8JElWvCyQM8hOxmxrbRTAYNW9aNGoXsMmOs0hJ9/vDDWRCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Acked-by: Chris Li Chris On Thu, Jan 18, 2024 at 3:11=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrot= e: > > From: Chuanhua Han > > should_try_to_free_swap() works with an assumption that swap-in is always= done > at normal page granularity, aka, folio_nr_pages =3D 1. To support large f= olio > swap-in, this patch removes the assumption. > > Signed-off-by: Chuanhua Han > Co-developed-by: Barry Song > Signed-off-by: Barry Song > --- > mm/memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 7e1f4849463a..f61a48929ba7 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3714,7 +3714,7 @@ static inline bool should_try_to_free_swap(struct f= olio *folio, > * reference only in case it's likely that we'll be the exlusive = user. > */ > return (fault_flags & FAULT_FLAG_WRITE) && !folio_test_ksm(folio)= && > - folio_ref_count(folio) =3D=3D 2; > + folio_ref_count(folio) =3D=3D (1 + folio_nr_pages(folio))= ; > } > > static vm_fault_t pte_marker_clear(struct vm_fault *vmf) > -- > 2.34.1 > >