From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F29A7C0015E for ; Tue, 15 Aug 2023 22:22:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05BCD940032; Tue, 15 Aug 2023 18:22:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00C338D0001; Tue, 15 Aug 2023 18:22:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E16A8940032; Tue, 15 Aug 2023 18:22:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CE4818D0001 for ; Tue, 15 Aug 2023 18:22:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8AC03C0DDB for ; Tue, 15 Aug 2023 22:22:48 +0000 (UTC) X-FDA: 81127764816.01.3B29E03 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id A79DC40006 for ; Tue, 15 Aug 2023 22:22:45 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T+x0AExM; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692138165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yzmPLJEKpxHogK00aWZnECIdKr4SKXSA2raz+0+uJFo=; b=r0s6HW/tjg3oGc/XpPC+p5xsmoidXrUlVPVA/6VlHwu/M1IDRAT7qptbR8uBn1mgZUbUcT s4TmlgVfmlOCe84Z0rtMhZucA116ZaXXR4MrlBBFDGYpDlRy0FYc5dAq4//3L9QtJUCWO/ oX5+2KxyGKlak210RIx+p8Z4tI0VyuY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T+x0AExM; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692138165; a=rsa-sha256; cv=none; b=e78shgRPo9J3B755U2XH/aLIOoFJ4gg0RSB8buq2rFc+5mxwcSqhaSxDOtFepT5C/8k9jc yZZrR8u4qSm2qBnNbqW+I7m5uoHBfXEBCkfYAM9a8eqcfkN6X6mgH5Z67eBjpw/nLZGMWj pX5rSe4SdHRHsh9lxDtz48VlzR6Ma9M= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7F92E6586E for ; Tue, 15 Aug 2023 22:22:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4D19C433C9 for ; Tue, 15 Aug 2023 22:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692138163; bh=kQSBRWBi8w3NAxb3/o0euE/FrGaiNTPbDxNlP/LaNTw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=T+x0AExMTGuhaCnbNNIZrNPCbPSkZVzKUX51iKYw7LBxASyPBZDj6oQFY+yJfA+Sf lliX17zYNC5gA5KKkneS45IwT+QAE1eqqrtAVTq+U4c9EGd85q7YPWwBp7jh2ShUw6 BhDkuDG5qCYDh1Eq5MNzyZmMYNOFNBzAPnUfXGEZYFReI1LE+NRpUBG1thDqQqhLuC M2/pMRdWSci/F/pLMmdP+uQyHq6WGeOaxlK9XX6NNspCZ3gZNEfk4N3Qj9LCu/Buv7 iinpn8RhwUjacs5JZWevz47sQGlcVJLudZvAEd62na90Xqp6O8EGnITbx/TYeNolvd quf39bVUn6h3Q== Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-26b67b38b61so1282297a91.0 for ; Tue, 15 Aug 2023 15:22:43 -0700 (PDT) X-Gm-Message-State: AOJu0Ywu8KUzaBgzMLKn9D1qXfWSK9fjly6BeE5d2seaf7nP3h3fyCS+ Iay4B1fuy8+E1RWPG2srmj06/w7sog1j1VFTyMss1w== X-Google-Smtp-Source: AGHT+IF/dNJIIMvQuyTVMacyW9rpsylu/NyFQjBApDOSZmkpoRerh1lTCFDCtM0Li1lLVAIPNjaolCN28HdhuyYF/iU= X-Received: by 2002:a17:90a:ea8f:b0:268:5c3b:6f28 with SMTP id h15-20020a17090aea8f00b002685c3b6f28mr10500439pjz.19.1692138163234; Tue, 15 Aug 2023 15:22:43 -0700 (PDT) MIME-Version: 1.0 References: <20230620194644.3142384-1-yosryahmed@google.com> <20230811141920.2f9bab6f21ab635ff1bd63ac@linux-foundation.org> In-Reply-To: From: Chris Li Date: Tue, 15 Aug 2023 15:22:32 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] mm: zswap: multiple zpools support To: Yosry Ahmed Cc: Andrew Morton , Nhat Pham , Konrad Rzeszutek Wilk , Seth Jennings , Dan Streetman , Vitaly Wool , Johannes Weiner , Domenico Cerasuolo , Yu Zhao , linux-mm@kvack.org, LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A79DC40006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 66wk1pgq9khzhpzbh8k1tbj7xewi3e7u X-HE-Tag: 1692138165-43679 X-HE-Meta: U2FsdGVkX18EdVUSh6sp6auTNnyTe61ba1thLwMP8vi1sxy55Fs1Do2lijqCvM5qPoEUuw8fkjjNjTcWSJFPjtefI2IMbrPUQ84XP7EkFDFVWOkgi8o+ZT6+YyoWyghx3tGb8kRTMROU7Eb0qqj/Dgl98rw3WtQbqkTPBgzRkt2V7rNvAZFZ4mB3N2al/Ldvw4ebsfEXppguR/UG0KkIDYYUddGWLgoH+vHUZ0oiE6lSv5h0EUAJrKaVlDdzozlGgOOScoxQ7A6uw8FUxwInx2sc99mcLnzA681yV/hT9dkK8OeNY1TkSR2QzficDbvCeyuiYrDio6Bp9ksv9OdYKWh/RnJ5CO60aKqVvFkl7spBXvn6yBZHQFM/PLJyCCi9uFR6I1kK3Yypfd21gCqbPeMF96nGq7BAwCq4W9/Ydj7DOx7sXjptvpfn/MjaEM9/8YqGMAR5nT6UVKJ5GHuKm/ugtjxajqb/hn3fGnSlZzC0dgzNdfNmrJcwt1+UlI/005C4abz2Zc/cwT2m5PV21X98RPjatPkCRoBJQUbvcG3UnOryUHsS/SGX5lh1kfiptaL5f/JAp5lF1+UiP3zXe/FNQoj94C/PUQ3aeuFE0iCKdkVdkQ1sz/M3UCn1tcXBz63a3BopOh9MC5ifzSyDK1kOnnWJkhZ/u2Pm1TfXfi8zNWoim0zoLFghrpyMqpKF8+lqAgBJ1k2yLqoqRc64A4pY6Bxhe7AtceuBWznFWGBFvEuK45r6f0IL+tFXhEp3uDRd0l1jWwIOjj7SFNIapwWE1qa6EYSX5tKffy2tiIoHeOWVpeti/ERlhjyxNM2pe9oAZEvv2iphn2R4HhWLdXn7t/hpV2aGAJd+K8FoT/1BFNxGNSON3+5+/v4tqrJhIMeNV9glH8fVAWeghQBBdQF+JLbJ5y/PK7c3OyPdggkIitv04EjVxPoJTHqqzzJ5cv4tasKqDuBIqQ91leU lsMkGr5y W0ouLmn5iZ74Gcr/ix+qEhOJvFWyADdnqD54E9bN63pTbr5GtimNdvsHO+FgC7yOgmCazX+KjiJf3QZi4ObavfktizNP96qEVKPpPRGUGeRVzvjWV8hVpnWialYnU1YrzYe/qgblC9IsboSfBATmBlZQuYwaJl4zoFhZlxMf7c/67Nn3OsJlIyJL4gTaKho+IQz+YTBEPmlZtXZHBss7BClycjlTjEkwRrjxPRO/UaMpzIx6N+qZh1F/KzV3Aem7/mm6XGPuAc//+ofKlS48Y3gwcqWQSgGG9MTQXZGGVMMEer7ksvOcxafiNpGss44NbVSxwv0qDzJJTr+qUEk385RhQ0m/h0EBISQx+tLmVleQnoTWwy4AKbgiKUhY/sl2w4jsHhduG/RzBEvnNZ7qvssmKIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yosry, On Fri, Aug 11, 2023 at 4:21=E2=80=AFPM Yosry Ahmed = wrote: > > On Fri, Aug 11, 2023 at 2:19=E2=80=AFPM Andrew Morton wrote: > > > > On Thu, 13 Jul 2023 03:35:25 -0700 Yosry Ahmed = wrote: > > > > > > > > > > I'm experimenting with some other zswap changes - if I have > > > > extra cycles and resources I'll try to apply this patch and see how= the > > > > numbers play out. > > > > > > That would be amazing. Looking forward to any numbers you can dig :) > > > > So this patch seems stuck. I can keep it in mm.git until the fog > > clears, but would prefer not to. Can we please revisit and decide on a > > way forward? > > Johannes did not like a config option so I proposed it here as a > constant (like SWAP_CLUSTER_MAX and others we have). This is a value > that we have been using in our data centers for almost a decade, so it I dug up the previous V1 discussion and this V3 discussion thread. It seems obvious having multiple pools having locking contention advantage. The number does not lie. However the number of pools is hard to decide at compile time. Regarding the per CPU pool. That might work well for a small number of CPUs= . When the system has many CPUs e.g. a few hundreds of CPUs. It means having hundreds of pools which is a bad idea. How about just setting it as a run time value(size/bits) and can only change pool (size/bits) when zswap does not have any active stores. Chris > has seen a ton of testing. I was hoping Johannes would get time to > take a look, or Nhat would get time to test it out, but neither of > these things happen. > > I obviously want it to be merged, but hopefully someone will chime in her= e :) >