From: Chris Li <chrisl@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Barry Song <21cnbao@gmail.com>, SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Chengming Zhou <chengming.zhou@linux.dev>,
Johannes Weiner <hannes@cmpxchg.org>,
Nhat Pham <nphamcs@gmail.com>,
Yosry Ahmed <yosry.ahmed@linux.dev>,
kernel-team@meta.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Takero Funaki <flintglass@gmail.com>,
David Hildenbrand <david@redhat.com>,
Baoquan He <bhe@redhat.com>, Kairui Song <kasong@tencent.com>
Subject: Re: [PATCH v4] mm/zswap: store <PAGE_SIZE compression failed page as-is
Date: Thu, 21 Aug 2025 13:42:11 -0700 [thread overview]
Message-ID: <CAF8kJuOJsZ2RbvFedfKADVqa0TUrkO-ceqrtaMXgiHAS0V19hw@mail.gmail.com> (raw)
In-Reply-To: <aKVbqi6wd3Spz-TM@gondor.apana.org.au>
On Tue, Aug 19, 2025 at 10:23 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Tue, Aug 19, 2025 at 10:20:45PM -0700, Chris Li wrote:
> >
> > In that case it is fair game for the caller to check for the error
> > other than -ENOSPC. If the return value is -EINPROGRESS during
> > synchronous crypto compression, it is a bug. We are not encouraged to
> > use WARN_ON, then having an error count to check that something truly
> > unlikely but possible to happen is better than folding it into
> > incompressible and pretend the error never happened. At least we can
> > know such an error case happened.
>
> Sure warning on -EINPROGRESS is fine. But every other non-zero
> return value should be treated as incompressible.
Ack.
Thanks for the feedback.
Chris
next prev parent reply other threads:[~2025-08-21 20:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 19:34 SeongJae Park
2025-08-20 1:13 ` Barry Song
2025-08-20 1:20 ` Herbert Xu
2025-08-20 1:34 ` Barry Song
2025-08-20 1:37 ` Herbert Xu
2025-08-20 17:32 ` Nhat Pham
2025-08-21 10:27 ` Barry Song
2025-08-21 16:42 ` SeongJae Park
2025-08-21 20:49 ` Chris Li
2025-08-21 21:36 ` SeongJae Park
2025-08-22 0:48 ` Barry Song
2025-08-22 5:54 ` Herbert Xu
2025-08-22 7:30 ` Barry Song
2025-08-22 16:44 ` SeongJae Park
2025-08-20 5:07 ` Chris Li
2025-08-20 5:10 ` Herbert Xu
2025-08-20 5:20 ` Chris Li
2025-08-20 5:22 ` Herbert Xu
2025-08-21 20:42 ` Chris Li [this message]
2025-08-20 4:55 ` Chris Li
2025-08-20 4:49 ` Chris Li
2025-08-21 16:17 ` SeongJae Park
2025-08-21 21:21 ` Chris Li
2025-08-21 21:41 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF8kJuOJsZ2RbvFedfKADVqa0TUrkO-ceqrtaMXgiHAS0V19hw@mail.gmail.com \
--to=chrisl@kernel.org \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=chengming.zhou@linux.dev \
--cc=david@redhat.com \
--cc=flintglass@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=kasong@tencent.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sj@kernel.org \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox