From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB85BC10DCE for ; Wed, 6 Dec 2023 00:16:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E1516B007D; Tue, 5 Dec 2023 19:16:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 691956B007E; Tue, 5 Dec 2023 19:16:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 532A56B0080; Tue, 5 Dec 2023 19:16:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3FCE56B007D for ; Tue, 5 Dec 2023 19:16:55 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 101D412031D for ; Wed, 6 Dec 2023 00:16:55 +0000 (UTC) X-FDA: 81534477990.09.2F53EBC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 97ECE80017 for ; Wed, 6 Dec 2023 00:16:52 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cUXTiceL; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701821813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dtZqkid3feyfKyKf8mD8J3TwSzuVvrMi++piNsMQqGs=; b=Vy6dyLTASfVGh+QyeimYiw8YdUva8tU20t2mQ4WCtwjmYaOFauB/ZfmGy3Dn9gEgpW7BmO vvoTl0N7yJtaocwawHuzyRYqP+hXyfCBpEWNGVP8pg0pqLH5NvAoSS8NI6gAO5aA+vtLzi 6bxXAnhcMeDRZSb7n2PHvHj7UvQ9Z84= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cUXTiceL; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701821813; a=rsa-sha256; cv=none; b=3fJG36dnBHl0imSepeF68l+gYxZ6S8lyAX9/YD58T8tJvvezUTffgHzdnn1vwqSEFahu15 Z1LnQVyJidmy8zhDZeZYD0gGf5pFEzlwKP7T4/r6sOZYlIdfOaiI2D9uIHmgi41JNjzKOb d1f2ZoT1b2pnlkace62YqfZEvCKy3OY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0AFE6CE1BA9 for ; Wed, 6 Dec 2023 00:16:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2EA5C433B9 for ; Wed, 6 Dec 2023 00:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701821807; bh=KB2h573VWm7p5NE2V/A12yXhGDfVWtxxezLZetMV8EM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=cUXTiceLGbO5lenVZeMmlWo7vqYqauEDVukhkO+OIlX+n3D42i2bqWUcnBqozO6XU 7IYf1+ps/u/H1NiaE1OiWxZClyIV0+4Mjt2tGYpp7HDv7XaISi5Bb5HawwLkSr+9oR mACXKjaqBM/BVenr6cTyV8yRm2/huC+WqGIPZ+tw18vxO00rGeYH+AkfNAMJgghTOP XVDhFG1NZcX6nmt2DMcc6llm9CyDnGxUxOXs8WKNXyppSxGNsnm+iu5FM9oXPv61SD JeLXq5kDsXM+mFp7IOElJukd2Lp8AO81UTP/jHUaJxxPa2I9tdKWdf7Ur4JWAC1Dcz SXhHQ+u/HinLA== Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1d076ebf79cso20385155ad.1 for ; Tue, 05 Dec 2023 16:16:47 -0800 (PST) X-Gm-Message-State: AOJu0YxCvNpoKG1uig6HRkll9tL7A7XBMY5uwH13/zCn+qLnJKhY3foh OxGHyNzgJhDknK6Q8c5R2EReeEV7wf0ghJPrFTd2eg== X-Google-Smtp-Source: AGHT+IHu5BtCSU0pVaHo7hstQQoCt4LP6AEcx7PGgCpGRGvVdybIR+82gCeElLUDiOxMjsGNu7AQ9eX7JuRo5PsoG5A= X-Received: by 2002:a17:90a:19d6:b0:286:f166:679f with SMTP id 22-20020a17090a19d600b00286f166679fmr91628pjj.49.1701821806793; Tue, 05 Dec 2023 16:16:46 -0800 (PST) MIME-Version: 1.0 References: <20231130194023.4102148-1-nphamcs@gmail.com> <20231130194023.4102148-3-nphamcs@gmail.com> In-Reply-To: From: Chris Li Date: Tue, 5 Dec 2023 16:16:35 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 2/6] memcontrol: implement mem_cgroup_tryget_online() To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 97ECE80017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: j4te3octsuhmoytrnrik7sy8a7zub7yd X-HE-Tag: 1701821812-153831 X-HE-Meta: U2FsdGVkX1/q4MYTtCeiC9FdDefIFC9botWxmYsr1aH8WrdEHF1FhRWqnEYcUBwNsR/bZO7wyb1A+4UvqiigijjsOZmsuD99BV3FsAklA+owA8gn7t3IiTmGFDWM0byIHO3fbM4YSjie5T1UQPks9zNp//UPAl7fyI2bil6dsw9kQ24ECpzvJw0RXZIh62+ad5eGFooPxytJUvdyf/uzJwZEEbMqW/JYo36JrlxPRvoXDfg43yvDjSw6WTzeprkq83Dmxreyo5GvsGIkch2BE1ZjaWv6WV/TQ8008TvQ3BvQmf4fXymL6UmdSObGXwEgPnRxQKVYc62teej9Mobe38npxikwOOdZVw4ax6yKjKKG5yTJ+/n2Zux+VSsAWituonRe4V+QlCbyXegkkrr1LiyzzK5c6GBty7hZJw2z05v6wVGnFhozdrx8wahUiRGpbqd+oBdUlnRBgmK1EVXmM9P4QR6iVlxpdHdlBandLoWhrE39jbTowV5acJHFWlC3YPTMVciQJsUf8mVwXaPqDKDqvJMVxwirEVAn4eU4nXdQzQGQwnDBd/s/TxC2La9z16zfVIGVPbfTEhdO19ssokJwS5gX1Ca3qd898gGqGsXAuutt7nl/kGAhsXl20xQkTh7OPJIKLcUvi32Q5DAtPsHjwgeoMxw7XJaIwO0oxcw88sAht94rLJ+o5+5ZBfdlbyEIJs5L/p5AWc+jT2nxjrQr+uJtdhwp/Y9uQ0jQKfM7Q8PksCbMi24CoVHXx/JmfA8yZ1eYef3efbSJZWXr9exdwC5cyc9sOv3HKy3pzoYevCr0cX+xH4hUs2Oj27dGTddW9gYbE6IEJednwjLmPbXrOLIAH3e8YUF7yqsVTKmvwl+QCUzDlY1N+Ze8NT9LcHjow3prdQIZYTUHCO5Mbhmanlpp5oev7Sn7R2txKPrddNIvYkDyRTK1ddhs6fnbYoAyESra5gQKsAiFDCU 0LBlK7pM uQJmr9mEtlicsOyAQgGtxIF4kZGdhdSYU/2zAkBR8PEKnIU92+u06iYhsuK+Oo3tXQruRQGlqY/DFHKF+ScEAPJ28AvHYK5ivpJN/uknHFwaBrs+YLlLkgagd93V9gDHfQsFvnLFuma0wHMs4QI6/g5OQ5pCOZJ4oyxudyD+7LPzNVJp2A6zEhPwD9E6seFoHI7/8J2Lu7FtBOKSyv6Kp8ZwubQKApWBsRbSF2cEcfexaqRKtyJ9fxLhZmoj/XOnUcr8y2ARUFaSkM+FvhBJQvCbwDZ/HOBiA0vTI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 4, 2023 at 5:39=E2=80=AFPM Nhat Pham wrote: > > > > memcg as a candidate for the global limit reclaim. > > > > Very minor nitpick. This patch can fold with the later patch that uses > > it. That makes the review easier, no need to cross reference different > > patches. It will also make it harder to introduce API that nobody > > uses. > > I don't have a strong preference one way or the other :) Probably not > worth the churn tho. Squashing a patch is very easy. If you are refreshing a new series, it is worthwhile to do it. I notice on the other thread Yosry pointed out you did not use the function "mem_cgroup_tryget_online" in patch 3, that is exactly the situation my suggestion is trying to prevent. If you don't have a strong preference, it sounds like you should squash it. Chris > > > > > Chris > > > > > > > > Signed-off-by: Nhat Pham > > > --- > > > include/linux/memcontrol.h | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > > > index 7bdcf3020d7a..2bd7d14ace78 100644 > > > --- a/include/linux/memcontrol.h > > > +++ b/include/linux/memcontrol.h > > > @@ -821,6 +821,11 @@ static inline bool mem_cgroup_tryget(struct mem_= cgroup *memcg) > > > return !memcg || css_tryget(&memcg->css); > > > } > > > > > > +static inline bool mem_cgroup_tryget_online(struct mem_cgroup *memcg= ) > > > +{ > > > + return !memcg || css_tryget_online(&memcg->css); > > > +} > > > + > > > static inline void mem_cgroup_put(struct mem_cgroup *memcg) > > > { > > > if (memcg) > > > @@ -1349,6 +1354,11 @@ static inline bool mem_cgroup_tryget(struct me= m_cgroup *memcg) > > > return true; > > > } > > > > > > +static inline bool mem_cgroup_tryget_online(struct mem_cgroup *memcg= ) > > > +{ > > > + return true; > > > +} > > > + > > > static inline void mem_cgroup_put(struct mem_cgroup *memcg) > > > { > > > } > > > -- > > > 2.34.1 > > > >