From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93486C4332F for ; Tue, 12 Dec 2023 21:32:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CF4B6B03B3; Tue, 12 Dec 2023 16:32:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 256A36B03B4; Tue, 12 Dec 2023 16:32:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D1806B03B5; Tue, 12 Dec 2023 16:32:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E74916B03B3 for ; Tue, 12 Dec 2023 16:32:43 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B98E18097C for ; Tue, 12 Dec 2023 21:32:43 +0000 (UTC) X-FDA: 81559465806.28.BBBC90C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id A706C80018 for ; Tue, 12 Dec 2023 21:32:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iurCXjmM; spf=pass (imf02.hostedemail.com: domain of chrisl@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702416761; a=rsa-sha256; cv=none; b=K/bksKPhyxXdFEBHq9i7gZY4zByyAFA1NLRhNvLLniLJirEPgajJajE5+mgHYAHxHONAKz mIOlxizDDCwYdVeHXPN0XrRHMK91pbn9IBvrAmwdKvaijrdebXYozGGsSSGVjijaIbi/6h j1DidCklnvVpLVmvzRQ6NR9F0rdgnhQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iurCXjmM; spf=pass (imf02.hostedemail.com: domain of chrisl@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702416761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4L2LJb/M15SMHnS/E79/939MX48WMYq9e+QYyCDB9nI=; b=LQRawYQ+RNc5o+QpECWlRc/MC6LJMwiG6oSYD2r8ToE0nz3E/Hx4FCq8p2JDebyWx24eBb v8XT4Zh0SCCT8sTNKNN8W5RNF6yHvmcSS5qNb42eo2RZzqqKHstRozViy4OsNZTFygoI/G F/ZDYhcT0HZ56u6X/igLKVjCcG54NZ0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id E3718B818C7 for ; Tue, 12 Dec 2023 21:32:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4143EC433CA for ; Tue, 12 Dec 2023 21:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702416759; bh=mfEW7Jo7qwzsMBHWmcox+E4i/5RV7VxXJqvDtAte4Y4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iurCXjmMTiNWcT6JXNwQ2WjwtRQu0gEcGPsFUjV39XCd8Mq/xT0qR0gFDZmPn2kx4 p69HydF5iz89VyCEhjoGRL/3ttSjdVJl2GEE7zoGGN5BWHD0LDKTgyJ+rsSiACKgY4 9pFPkOscKtqapzzG9GqUuqJwPy1Di2rjZszdd4ao4X8JI9HT9JsChTUG+iLTMhcI+i 7ZmbSejEBVcGEDQ0P81NFJCTmdb2T9q4iantr9pLcyoc6xusyeLCAa72iHAuZCaiyZ l/VBjc36HCU+sDESkHfm6XA3QSeSi/NJuicozbREArV2NmLrTyloTAAeIfOrtXHELT JbmJJ8j3OEukQ== Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-28ade227850so274682a91.2 for ; Tue, 12 Dec 2023 13:32:39 -0800 (PST) X-Gm-Message-State: AOJu0YyMELqysAEkH7aqeCrRSfGnnWH8IIme1PqcJG94rgJVNVIKFwTa 7SIkLRV9ZMPBFKLcAcs8bVeG/G6rgmJSqom5rYWgiA== X-Google-Smtp-Source: AGHT+IGlVCqZJncPdqqBPXo0+sqvyKBlHQlD1C+GbTv+WgaSKSNQbps5gPlwHn8M31pDWV1qZTMqmVQodyQZH8b40zE= X-Received: by 2002:a17:90b:fcd:b0:28a:beae:454a with SMTP id gd13-20020a17090b0fcd00b0028abeae454amr1348327pjb.25.1702416758683; Tue, 12 Dec 2023 13:32:38 -0800 (PST) MIME-Version: 1.0 References: <20231211140419.1298178-1-schatzberg.dan@gmail.com> <20231211140419.1298178-2-schatzberg.dan@gmail.com> In-Reply-To: From: Chris Li Date: Tue, 12 Dec 2023 13:32:27 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 1/1] mm: add swapiness= arg to memory.reclaim To: Dan Schatzberg Cc: Yosry Ahmed , Johannes Weiner , Roman Gushchin , Huan Yang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Tejun Heo , Zefan Li , Jonathan Corbet , Michal Hocko , Shakeel Butt , Muchun Song , Andrew Morton , David Hildenbrand , Matthew Wilcox , Kefeng Wang , "Vishal Moola (Oracle)" , Yue Zhao , Hugh Dickins Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A706C80018 X-Stat-Signature: ymimrohmanxwan79ywqugzdhoxfu6qos X-Rspam-User: X-HE-Tag: 1702416761-952722 X-HE-Meta: U2FsdGVkX1+1qyBl1+90SPDR+iOzuiWJWmbaSVlSiTZJfMLwwA5/zYXQKbr/rgYn7JdDY9TavZUyXXEWSU0oVEklqtLBqpxL0Y2Snj+nQuldPa3LwoQ25MKaXn5Kh35Zb5i57KMQqzh9oy8cCAtWcMEP/CVqwCCnhwu9+3X+AXLrCuse6NMAnCtIIupY5CcGxeqyjql6cgHBTfr1ZDmeipp3Z79gECjHVQSJE6tHSKwSwkxqnfO+TQe0ZQ4iK9JjZzPkILIANDg0/+zI2TRYrLG+r58XJce8XYNTHd2dktCJeh5NajCtug76fQ0QMA6xi3ckAgN32n9yCpPhPi7fDZoNwNw+oB/jUZ5rhlulZttyTj67pnZ6PBMDskZO7YPOOqexhTWpMz8lDsLYGnbvMsWGqiXCysmZ31RcocEobUf9pQ//ar1BA/R6gU8FDFVykgYjXGAX6OVe9kgOLwc8rpyoKLxH3pxgw7FolDsxuyOdtXrtSrOIBY/jXvHWHfnxhssd/rYTDk6svRp2Xmo2k6LopimvExiYSafciwcvzW85mo89c2qe5rhZc6jFZ34gjhtX4khpvsQINwJjqXjiRCRrBBzglDPOZ6hNrOQKmgwNJ8RBBQip2NE2UBlFgjUj6eE5oHnziqbi6wfnovI2ymMjTBAMqWmc6zwM8aeNSXv3XqY88kXbYvx9fzfDF+sxYUuPv8HZg82wswJgmVvI+9vWCFvRMiQtEP9L24UGuXveXAKuMEy2RzT/pbLaMGwoKCH7RWtT7ckYOLmHwiihx5Xa9u/KdhKg0bYy9oIJNpKh9+otFpzG5M8x+PGXlQXM5RPb246HvwWRRYmc7ZdIRK2kORMiy6QmoHZac4VWI+jPDBTBnMhc5vis7lSlR9yO2rTWBGPBj+BRH4USxVqVEj54azcHRGpXXV21z+mjls2XZK8uJRW9j10N7KIG8B2S3ceN5Qojk6kI1h0Zo9c I1YEKgpQ qpPXhEZOSdmYJo2124Amvqo2HahrdcgpmWX+iueFFO20wXddZrILE2vyYs+tv+1MZbDdV+cwace8PR+uyVTQ04zqrA1hguI15qFdzvcDQmNd1n31O0MF7RfjaZRfwCgtWk8bwuvZb5unkCjywHb1qfZgJnY2I46JVkN69PTBPDAXzG8XuFEIm1i+AyZcY4MvYTKkW3lQDez0/5RkihHEa4CSj0pqu54dVgjTVU8ce29sU+nSEj0AWB74YaFWNh1qZWgP2Fbc7qpnLrjhedw1O6JLTJkLf1/RPtzIbdDL9VwkHx/x0bG59Sn1DIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Dan, On Tue, Dec 12, 2023 at 1:27=E2=80=AFPM Dan Schatzberg wrote: > > > > + while ((start =3D strsep(&buf, " ")) !=3D NULL) { > > > + if (!strlen(start)) > > > + continue; > > > + switch (match_token(start, if_tokens, args)) { > > > + case MEMORY_RECLAIM_SWAPPINESS: > > > + if (match_int(&args[0], &swappiness)) > > > + return -EINVAL; > > > + if (swappiness < 0 || swappiness > 200) > > > > I am not a fan of extending the hardcoded 0 and 200 values, and now > > the new -1 value. Maybe it's time to create constants for the min and > > max swappiness values instead of hardcoding them everywhere? This can > > be a separate preparatory patch. Then, -1 (or any invalid value) can > > also be added as a constant with a useful name, instead of passing -1 > > to all other callers. > > > > This should make the code a little bit more readable and easier to exte= nd. > > I'm not sure I understand the concern. This check just validates that > the swappiness value inputted is between 0 and 200 (inclusive) > otherwise the interface returns -EINVAL. Are you just concerned that > these constants are not named explicitly so they can be reused > elsewhere in the code? > I think the concern is why 200? Why not 400 or 600? The user might write bigger values and expect the reclaim to work with those values. If there is some hard coded limit enforced somewhere else so writing more than 200 does not make sense. It would be nice to have those other places reference this limit as well. Thus give 200 a name and use it in other places of the code as well. Chris