From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEBB4C48BF6 for ; Sat, 24 Feb 2024 16:53:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFA956B0095; Sat, 24 Feb 2024 11:53:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA95D6B0098; Sat, 24 Feb 2024 11:53:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B712F6B009A; Sat, 24 Feb 2024 11:53:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A7B556B0095 for ; Sat, 24 Feb 2024 11:53:17 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 429C51C051C for ; Sat, 24 Feb 2024 16:53:17 +0000 (UTC) X-FDA: 81827292834.07.BAC5783 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf08.hostedemail.com (Postfix) with ESMTP id B1A1B16000D for ; Sat, 24 Feb 2024 16:53:14 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FAXqseTh; spf=pass (imf08.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708793595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1JZYNGUcitxoyD6IcCn3skEKrW3NQ+X9kthXt70/kl0=; b=8AuoMmu4mBnfWcSlFMrsOHDdLP8LgDvNt7qK79+AmVLhpcIL9lXJKCyLbsvW5wz3T9vywj FowAavYnnOxO7BZzumnzNUulvqs0+gCN16dUlGrd+ymhS4eVE+dtgYjr2p+H/Zcr/sL9TX /ay1if4+NLVD40i03RnRXUM8VtyY+8U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708793595; a=rsa-sha256; cv=none; b=aj9pHYs97cJH2whnldOMJ1cLFYurHcY8eCkSiyRWTlfs9SB3eaCDKgMFt7ZW8U+zd0f8Ur zJ2QCofTIUhXm93rvH+jhc+0GuBNRtyUPn7bdxCRRC61BoK70rGh0+NC3RpuKNJT5c9qLP PWXN3YW6xrXKsuGET20b6QfGPZ4TnYU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FAXqseTh; spf=pass (imf08.hostedemail.com: domain of chrisl@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 53EE0CE0C4F for ; Sat, 24 Feb 2024 16:53:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9299AC433B1 for ; Sat, 24 Feb 2024 16:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708793590; bh=Tfm5vL4QfZKNlU2j8c6/gIq0W0rievB9CY/7Swb9hPA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FAXqseTh5vYvdvl8IWFawUCV7PpiFA1YomIqeokjSNEnbKYU47a5CzoeX6Gc7oCkv RmUqbA8Y7leZTzdDisDqBIy0N7kDQ1XLGW5hQCrSkBeYfuhdYKfDvSQsZHCo8Peeba a7trVps5PO/7nMTXE80SpdMosncxeKP82UqlQseKvnPkPBkfylMyeE9i0dSmCzY3BM xIJh/IofhbBOhSA97EZJ4FxLVY9XXY7TRzKAXm2HehwSnqn/a9w7WHVjVcbjHaDmsT ES+cE9cC0bkBCyRXSigBzZ9yVtihE9STOKfggmu+YKvZux7szU+6o7NYDsxqEmg0ZE UvaC0Z+omtuCg== Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7bed9fb159fso73516739f.1 for ; Sat, 24 Feb 2024 08:53:10 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUGq1VxHW/746YxfjyjGZg+Zj37F+F/AJWORq3buFeByryJME+LOY17A+47mvLlZG2iynrldOmCi/Jz/MvDtvevVQw= X-Gm-Message-State: AOJu0YzGK8xGefJ26U08vjvxtwJ7mrQrI6lD8PBUWuAgeXn2NrnNkzw+ iGznh7ES0v1rwRgj1vdu+3OHc/rVzVna68hsGVtf6U5oCDcWbe/AlkVnIz/1pVVrUFvYmtGTnsN yMah/+0R/+FM23o3gU25FIJcpIwHzcWQxAwCw X-Google-Smtp-Source: AGHT+IET/vQwF9sNTEZtiDwCGllyEYJS5225ocQgvaHlCzNjk/1CUgLtTdfYdNes+92RKN878GTYPqLQjt9oyH+bxHY= X-Received: by 2002:a92:ce4e:0:b0:364:21b0:6050 with SMTP id a14-20020a92ce4e000000b0036421b06050mr3242498ilr.6.1708793589855; Sat, 24 Feb 2024 08:53:09 -0800 (PST) MIME-Version: 1.0 References: <20240222081135.173040-1-21cnbao@gmail.com> <20240222081135.173040-2-21cnbao@gmail.com> In-Reply-To: <20240222081135.173040-2-21cnbao@gmail.com> From: Chris Li Date: Sat, 24 Feb 2024 08:52:57 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 1/2] crypto: introduce: acomp_is_async to expose if comp drivers might sleep To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, davem@davemloft.net, hannes@cmpxchg.org, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, yosryahmed@google.com, zhouchengming@bytedance.com, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B1A1B16000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: e3nhhu3i6syhzjundwbq1bgbcn1ucfax X-HE-Tag: 1708793594-336082 X-HE-Meta: U2FsdGVkX1+lVAkCfc6MND5S+NJ8YQ2T2B15YWPMmrg7mN5sPu7u/iMpriZ7oh/2vzoZKS5NpiWRUrtQuh1XHUmpXqkI6aqi57h1jDjTt9PMxRb8qbq6HK6JH9F9nQn/NUIt31iH9u/1oLE7pWoTNOQ2urlX9CYyMJEWRai7sB9arAytlK3KM/mCe8aYyYcdMltOZybmLlEbGpuAtkjYBi0GqzG9BvYtkX2fJRO+2fUqfYZw3sR5FZ+8h2PHHkqd5m/lVZz7HuBnjiLBRj7iFeaThb5zRQicNosyzW254LZaVCSbHWrSWOyQ7fgp4yrNciXqBKtUaNP546WuDCo3vs/LEa5y9VSdBBN1IoGdZex2F0Rd5sDL+0419eGUddP/RvC2e08cBKwFTDuW6HsM+rnbJDQmU8UQEXRMTJYFRxG10XbL/9jfy8ZT1X7RL0ZV13pcNhUCt5fWKcwK0J1KBWRN0pQXQUt6N9GsJ+8lKt1ZQ9gKZmVBdz3d4fY1U/KrouXgFQh/RM6wMLQw3o8+2TcNLPX/IFPWj7OexZRJKQ7FXwxvoc+4VVSK7LPKa1eUnIfBLh8hnKCyno6quBYZn/4seiDa9JTN1Zj8aM4Cftv/8xnPsdHYfzmbmAD98OQylyaiL/kIsp437DeZ6478+ZVqyq67Blh78jfqwTPCjYBRcRClHCsNDwNCdC+KVRcW0YGPcZUMbg5mlVM+AM/d3zA+D6vE1/ocwra7pEyQ9kpZgm/D0Xb+eAERymy3j8Wnj8gX1RMoZWtAD86NkOCe2qEcenS9iHtAQAWy46Z1Jw1BU/toEPT88kJEr6DboZaLX9kE8KaVg50WiLZfPcEuM31WVPZBAAu9dQbaFShTDr5oYHeZD9dYsIFORhZ2Oj8DZsiG1mVlNMDZiwr0iy8xl+bkkgoWxjaDGGhgzkskXew3PDa+uJ7occdyAMsCo9n7tDVCy2z+uBTnUMDNBAY QBK6JAlg k4VnKN7s6b1MecPqGp6+A1pJvCwOiJzLTGQRCjWH/Ig23DaNGujtu0kcCkzzl1ZgTF/dFuXlL3YT6t7OcIZDMtIuqWxp4HLBFo9MZyKXOSXWTRB3fpC53nKd0zBGbw+djAmWvaUakB5kpQU9Fqu/j4w5Xh7+9vBEv+xFFPCtcCiKWo0+wu+KXp8kFijXbZKZbrUAkC2JPvmImZlt2iN9cDuxu0rr2sTcbH8+hmMJwJvAn8G2HuXH4J/58xFMIGVvEVyGiaZPRpNvtrFPyGr17kzFJQH3eIRfdtm1nEa3waQFIBPGu0Ndn4pniphq8+avt+IJxzb4jzYm6GzsxwAQQ9l7yiJvc7NTpphRXGj08ZETKVlwhu53G/cd13uP4V9/WNhSgjGOp8WjfZC7wq6xP/YOXTnVauSTAMN3182tHoJ4uv3yXBw6+y5dRNmbjXSacFbMifa+rFkQXEHyABCksHtNSog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 22, 2024 at 12:12=E2=80=AFAM Barry Song <21cnbao@gmail.com> wro= te: > > From: Barry Song > > acomp's users might want to know if acomp is really async to > optimize themselves. One typical user which can benefit from > exposed async stat is zswap. > > In zswap, zsmalloc is the most commonly used allocator for > (and perhaps the only one). For zsmalloc, we cannot sleep > while we map the compressed memory, so we copy it to a > temporary buffer. By knowing the alg won't sleep can help > zswap to avoid the need for a buffer. This shows noticeable > improvement in load/store latency of zswap. > > Signed-off-by: Barry Song > Acked-by: Herbert Xu Acked-by: Chris Li Chris > --- > include/crypto/acompress.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h > index 574cffc90730..80e243611fe2 100644 > --- a/include/crypto/acompress.h > +++ b/include/crypto/acompress.h > @@ -160,6 +160,12 @@ static inline void acomp_request_set_tfm(struct acom= p_req *req, > req->base.tfm =3D crypto_acomp_tfm(tfm); > } > > +static inline bool acomp_is_async(struct crypto_acomp *tfm) > +{ > + return crypto_comp_alg_common(tfm)->base.cra_flags & > + CRYPTO_ALG_ASYNC; > +} > + > static inline struct crypto_acomp *crypto_acomp_reqtfm(struct acomp_req = *req) > { > return __crypto_acomp_tfm(req->base.tfm); > -- > 2.34.1 >