From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ECAECF9C69 for ; Tue, 24 Sep 2024 18:05:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FFBB6B00AD; Tue, 24 Sep 2024 14:05:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AFA36B00AE; Tue, 24 Sep 2024 14:05:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84FFF6B00AF; Tue, 24 Sep 2024 14:05:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 685276B00AD for ; Tue, 24 Sep 2024 14:05:35 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0FB70A015D for ; Tue, 24 Sep 2024 18:05:35 +0000 (UTC) X-FDA: 82600409430.03.891989A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf22.hostedemail.com (Postfix) with ESMTP id 209DEC0023 for ; Tue, 24 Sep 2024 18:05:32 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aLpzZ3q1; spf=pass (imf22.hostedemail.com: domain of chrisl@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727201073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dilpxwrUtMokSMDB6KG7CQ+34MigRbcrQUmQoPnnqa0=; b=tFuY+Leu2w/5uOJZ48YWklsfWe+FobU7IFR4vFIO0IUGnPOJ/e9nKE9ghzuViEuxtqYkkm KNCkJbqaDCGyj6kCsjml33v5tDavd8hzrkt++1eByRVyrtQCOSaWq8DioDG5lWH9qUD9wz V3Ac9l9JXyvkBDoE1IGei1G2aTlUtLE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aLpzZ3q1; spf=pass (imf22.hostedemail.com: domain of chrisl@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727201073; a=rsa-sha256; cv=none; b=5xaKbSMiHQv+m7PKw/fIE0O2SV3wlqaCaRKFeO4W9s2UPVR+hyf5KZOf3piRT11QIvw1uY 5V2BBoiAxgvM4dWHf2RnCDSt3mxmIE9z1SyzLRUljAHF0QtUbOnZ7/No2ILo+sesRD5RsD 8+Gy7K8RDeamwoUKDaWpETrkkIOSw/k= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 377A5A43801 for ; Tue, 24 Sep 2024 18:05:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2F1AC4CEC4 for ; Tue, 24 Sep 2024 18:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727201131; bh=IoL0K7SoAmIEnbpyrBb6nLNcf+yUtu86/h/QkT1f2Pg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=aLpzZ3q1efpvQnA3KWSkCU+clRzSZ23zg7bJ1W3jZxOjmDwcpv+URv/nwy55MKyS8 g4x6OsXXhlytjBqZ93s3q1blDfK2zhy16kw4qnIeTUqiJyB4nAZ3Pj8PCaEzlPKWGp Qiedm9ZCKyIE0vJ/bjVFEUmXmUguRczO59u3L38Pq3w/pQXX/ANAU0H040ScMqIlRL /CLAfw8VpawA91Of8bK2m3jQFGXaC3ZW+SbFrUdgNmhcM/CQpuVmD4IbLaOZU1+3f3 VQv5e6FYm64mtNDNgRt7PYV36MVJ++ULTF0EtvDrCZbqjNUkH1Pd4IKv9j5ywsmW1k jFMD86nHj+DXw== Received: by mail-il1-f182.google.com with SMTP id e9e14a558f8ab-3a045f08fd6so20265ab.0 for ; Tue, 24 Sep 2024 11:05:31 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU4qyj3RQo1dcPTBv2DhYSaj/VBQu6IFKoWI1pvcTbNJ9nPmqKDYPyq7Rz6KXPReCPwcHRf0GWgBA==@kvack.org X-Gm-Message-State: AOJu0YxIwKdup7GeB7TLE64ztgwG7pnH64Khm6rGPT08nLjtOlpZ97lm l9r7/rVfs7DRt6Einog3AZRI6HeLMR9pmtXYaSBHA118284iJNIrWqJwzboSxyCDcF2zDp5wImq a2EtPyiVZjDDhFBAWjpEcbZ8qBfmg+04M5Y21 X-Google-Smtp-Source: AGHT+IGs2BTudAGVHjmlsME4YVTNJeCt8bYbLI+hDkSJuedrUBVqX1EPis2ENWKJDS4YM5hMDAJfifODYye8uoCiz3E= X-Received: by 2002:a92:c244:0:b0:39a:f5a7:50ef with SMTP id e9e14a558f8ab-3a26e2c5696mr222005ab.4.1727201130844; Tue, 24 Sep 2024 11:05:30 -0700 (PDT) MIME-Version: 1.0 References: <20240911025600.3681789-1-senozhatsky@chromium.org> <20240917013021.868769-1-senozhatsky@chromium.org> In-Reply-To: From: Chris Li Date: Tue, 24 Sep 2024 11:05:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2] zram: free secondary algorithms names To: Sergey Senozhatsky Cc: Andrew Morton , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm , Kairui Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 209DEC0023 X-Stat-Signature: fdrfu74e9yfztgjpzra5f379dwi9c8om X-HE-Tag: 1727201132-493818 X-HE-Meta: U2FsdGVkX1/kMd0B4mRDEvsFEBFTSk3jJYlWWgTH9CDDvhA3+0Sgo4QNnkRoHX41AQ4H4Cl/Csz2+LlLojeEcpJtGhwdjrSLpF/Q+puaNrVIzMV1RlVynUKke85XgAcXP7EqTNIzW4IMdohKw1RPSNj2cLxDd55SP1Gqo+a6cSWBBExd8RoHb3qb0ISBN2yqPNU0u1Il1Jp9OR7ba+EvIvA6kjHRh/WIbgyGlRtwhIxq21sNKg0EAwpJFq7RJrL5skvYV1IUTNDCMByR4UFwmUaBrbxMrogI591q8Kb3wRV932lso16t7fbeEOp7HdKdIuSkGZZ5Q9DWjBVMS5H/Y6ylDTPVp3xVz4HQ+gcJ909rQ0zRTXweMgaZubY/FTWMcV1r0FUUOaKeUXOGpN/vvuQnc5+NYpL865f+sygHNSzl7cKNo2vZGE2F1EAMpXujchxVrLBksmM7W4LaiZgmcaUFnW2c0EhYGjWqT4fkt5FFt7U7ji0MHIgqS4kxnRlGeGv9xd845088Scb5eoYuxYcho0CkUQ3dVme9tXIYq+bhNzbVcXNQ1nmjiq87vCLmb1nXWC45TKxDIOETORhlczQ2u3iTTnsbNrun8gVWFj/ihqbHJ7cUmVpaBFGsgfnPYtPOz/YfaDu6LoPW0n9cSpjPldb34PXNOG2sjpihAcEB0x3f3AYwJura3sP7scWICL6uJl+QP5UMNg6Z3BuQE3sTyANXp6dS1fi1FkQECG1l0Lqk3pJcPZrg+k48/HVOm0J5Iw1H0b2MBStY59a/ymK3TVAAdsBj9vU8lAmqmU2OE2OU199dq4ooLksUdk2RnwS/PUqsDYjQf+Bf7+6x2a2kAn9ANtwX3jzSknVupKx+TuwhPx9WX+wGO51EMKLXO7+yThDdSYZWipOnKtTzAUOvH/q6jW+F3C4dBsRNZ7epRoADImIViIaD/0RWI7k3wuXt/DuYn/oxGslolO1 xBzoblYI Q6aeiNchOR254ibfRINjJGksM6YUv1R3OXzSN+LLNa1y/3rvUAisdL//rbmiUYI/TZMvdm5omhA84hOycoLi5J4ai2Hw/MB82u9oXwzUOHJlU0Tyzojtp3xjklnC0nZsXDN4WRNDOMgIFg85KlC/5Ho4icykQWwSDQ2MmiB6pBGjVL69sIq1YysvE40LQjmpml0gKIgprKWX5X/hwCvLYfVyy2aUZkIbbG8F1JrGwAst+nP1FKe59Aklvi+kWiHyzrawc9jo+uMJT3XsIwC24cKdBh1d1Vr4K16PPS3cz2GX54dqIKbBhauddf2c51FftqmSGwx4JfNNr8zuNEOe2rMbOXdTiUppeWgp1qnnfyQjC/djw8XdNKRXEsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 8:52=E2=80=AFAM Chris Li wrot= e: > > Hi Sergey, > > On Tue, Sep 24, 2024 at 8:36=E2=80=AFAM Chris Li wrot= e: > > > > Hi Sergey, > > > > The current mm-unstable is breaking my swap stress test again. While th= ere seems to be multiple bad commits that cause it. I have bisected into th= is commit causing kernel warning and followed by BUG(). > > > > [ 56.630032] zswap: loaded using pool lzo/zsmalloc > > [ 56.718027] zram0: detected capacity change from 16777216 to 0 > > [ 56.725492] zram: Removed device: zram0 > > [ 56.740125] ------------[ cut here ]------------ > > [ 56.744616] WARNING: CPU: 2 PID: 1894 at mm/slub.c:4556 free_large_k= malloc+0x4d/0x80 > > [ 56.745119] Modules linked in: > > [ 56.749551] CPU: 2 UID: 0 PID: 1894 Comm: zram-generator Tainted: G = S 6.11.0-rc6+ #33 > > [ 56.750129] Tainted: [S]=3DCPU_OUT_OF_SPEC > > [ 56.750908] Hardware name: HP ProLiant DL360 Gen9/ProLiant DL360 Gen= 9, BIOS P89 09/21/2023 > > [ 56.751354] RIP: 0010:free_large_kmalloc+0x4d/0x80 > > [ 56.756120] Code: 00 10 00 00 48 d3 e0 f7 d8 81 e2 c0 00 00 00 75 2f= 89 c6 48 89 df e8 82 ff ff ff f0 ff 4b 34 0f 85 e > > 9 7d f5 00 e9 eb 7d f5 00 <0f> 0b 80 3d a8 f3 9b 02 00 0f 84 bd 7d f5 0= 0 b8 00 f0 ff ff eb d1 > > [ 56.761370] RSP: 0018:ffffaeaaa3657b20 EFLAGS: 00010246 > > [ 56.761676] RAX: 0057ffffc0002000 RBX: ffffece0c1f40e80 RCX: 0000000= 08040003f > > [ 56.766293] RDX: ffffece0c1f40e88 RSI: ffffffff9a03a131 RDI: ffffece= 0c1f40e80 > > [ 56.770931] RBP: 0000000000200000 R08: ffff95571d256480 R09: 0000000= 08040003f > > [ 56.775540] R10: 000000008040003f R11: 000000000000032c R12: 0000000= 000200000 > > [ 56.780212] R13: ffff953787c71e40 R14: 0000000000000047 R15: ffff953= 79b2e3e20 > > [ 56.784943] FS: 00007fb0f1d58bc0(0000) GS:ffff95567ed00000(0000) kn= lGS:0000000000000000 > > [ 56.785403] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > [ 56.789937] CR2: 00007f35b6449050 CR3: 00000001112ac006 CR4: 0000000= 0001706f0 > > [ 56.794784] Call Trace: > > [ 56.794941] > > [ 56.799377] ? free_large_kmalloc+0x4d/0x80 > > [ 56.799598] ? __warn.cold+0x8e/0xe8 > > [ 56.799842] ? free_large_kmalloc+0x4d/0x80 > > [ 56.800065] ? report_bug+0xff/0x140 > > [ 56.800296] ? handle_bug+0x3c/0x80 > > [ 56.804703] ? exc_invalid_op+0x17/0x70 > > [ 56.804912] ? asm_exc_invalid_op+0x1a/0x20 > > [ 56.805132] ? free_large_kmalloc+0x4d/0x80 > > [ 56.805344] zram_destroy_comps+0x32/0x70 > > [ 56.805568] zram_reset_device+0x102/0x190 > > [ 56.805812] reset_store+0xa6/0x110 > > [ 56.810207] kernfs_fop_write_iter+0x141/0x1f0 > > [ 56.814689] vfs_write+0x294/0x460 > > [ 56.819106] ksys_write+0x6d/0xf0 > > [ 56.823550] do_syscall_64+0x82/0x160 > > [ 56.823827] ? __pfx_kfree_link+0x10/0x10 > > [ 56.824051] ? do_sys_openat2+0x9c/0xe0 > > [ 56.824263] ? __handle_mm_fault+0xb34/0xfb0 > > [ 56.828752] ? syscall_exit_to_user_mode+0x10/0x220 > > [ 56.833220] ? do_syscall_64+0x8e/0x160 > > [ 56.833429] ? __count_memcg_events+0x77/0x130 > > [ 56.838021] ? count_memcg_events.constprop.0+0x1a/0x30 > > [ 56.838318] ? handle_mm_fault+0x1bb/0x2c0 > > [ 56.838542] ? do_user_addr_fault+0x55a/0x7b0 > > [ 56.843014] ? exc_page_fault+0x7e/0x180 > > [ 56.843228] entry_SYSCALL_64_after_hwframe+0x76/0x7e > > [ 56.843831] RIP: 0033:0x7fb0f1f7a984 > > [ 56.844045] Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84= 00 00 00 00 00 f3 0f 1e fa 80 3d c5 06 0e 00 00 7 > > 4 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 8= 9 e5 48 83 ec 20 48 89 > > [ 56.849247] RSP: 002b:00007ffc7db8fde8 EFLAGS: 00000202 ORIG_RAX: 00= 00000000000001 > > [ 56.853889] RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007fb= 0f1f7a984 > > [ 56.858482] RDX: 0000000000000001 RSI: 0000560df4e4ea65 RDI: 0000000= 000000004 > > [ 56.863154] RBP: 0000000000000004 R08: 0000560e0e417010 R09: 0000000= 000000007 > > [ 56.867794] R10: 00000000000001b6 R11: 0000000000000202 R12: 7ffffff= fffffffff > > [ 56.872980] R13: 00007fb0f1f7a970 R14: 0000560df4e4ea65 R15: 0000560= df4e71bd0 > > [ 56.878043] > > [ 56.878555] ---[ end trace 0000000000000000 ]--- > > [ 56.883420] object pointer: 0x00000000f38e5ae7 > > [ 56.888235] BUG: Bad page state in process zram-generator pfn:407d0= 3a > > [ 56.889026] page: refcount:0 mapcount:0 mapping:0000000000000000 ind= ex:0x0 pfn:0x407d03a > > [ 56.889877] flags: 0x57ffffc0002000(reserved|node=3D1|zone=3D2|lastc= pupid=3D0x1fffff) > > [ 56.894915] raw: 0057ffffc0002000 ffffece0c1f40e88 ffffece0c1f40e88 = 0000000000000000 > > [ 56.895771] raw: 0000000000000000 0000000000000000 00000000ffffffff = 0000000000000000 > > [ 56.896562] page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) se= t > > [ 56.897332] Modules linked in: > > [ 56.902165] CPU: 2 UID: 0 PID: 1894 Comm: zram-generator Tainted: G = S W 6.11.0-rc6+ #33 > > [ 56.903155] Tainted: [S]=3DCPU_OUT_OF_SPEC, [W]=3DWARN > > [ 56.908082] Hardware name: HP ProLiant DL360 Gen9/ProLiant DL360 Gen= 9, BIOS P89 09/21/2023 > > [ 56.908918] Call Trace: > > [ 56.909484] > > [ 56.914148] dump_stack_lvl+0x5d/0x80 > > [ 56.914747] bad_page.cold+0x7a/0x91 > > [ 56.915318] free_unref_page+0x344/0x520 > > [ 56.915975] zram_destroy_comps+0x32/0x70 > > [ 56.916452] zram_reset_device+0x102/0x190 > > [ 56.917057] reset_store+0xa6/0x110 > > [ 56.921874] kernfs_fop_write_iter+0x141/0x1f0 > > [ 56.926685] vfs_write+0x294/0x460 > > [ 56.931385] ksys_write+0x6d/0xf0 > > [ 56.936087] do_syscall_64+0x82/0x160 > > [ 56.936656] ? __pfx_kfree_link+0x10/0x10 > > [ 56.937257] ? do_sys_openat2+0x9c/0xe0 > > [ 56.937810] ? __handle_mm_fault+0xb34/0xfb0 > > [ 56.942593] ? syscall_exit_to_user_mode+0x10/0x220 > > [ 56.947362] ? do_syscall_64+0x8e/0x160 > > [ 56.947974] ? __count_memcg_events+0x77/0x130 > > [ 56.952762] ? count_memcg_events.constprop.0+0x1a/0x30 > > [ 56.953356] ? handle_mm_fault+0x1bb/0x2c0 > > [ 56.953937] ? do_user_addr_fault+0x55a/0x7b0 > > [ 56.958999] ? exc_page_fault+0x7e/0x180 > > [ 56.959523] entry_SYSCALL_64_after_hwframe+0x76/0x7e > > [ 56.960163] RIP: 0033:0x7fb0f1f7a984 > > [ 56.960731] Code: c7 00 16 00 00 00 b8 ff ff ff ff c3 66 2e 0f 1f 84= 00 00 00 00 00 f3 0f 1e fa 80 3d c5 06 0e 00 00 7 > > 4 13 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 54 c3 0f 1f 00 55 48 8= 9 e5 48 83 ec 20 48 89 > > [ 56.966840] RSP: 002b:00007ffc7db8fde8 EFLAGS: 00000202 ORIG_RAX: 00= 00000000000001 > > [ 56.971903] RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007fb= 0f1f7a984 > > [ 56.976953] RDX: 0000000000000001 RSI: 0000560df4e4ea65 RDI: 0000000= 000000004 > > [ 56.981946] RBP: 0000000000000004 R08: 0000560e0e417010 R09: 0000000= 000000007 > > [ 56.986980] R10: 00000000000001b6 R11: 0000000000000202 R12: 7ffffff= fffffffff > > [ 56.991985] R13: 00007fb0f1f7a970 R14: 0000560df4e4ea65 R15: 0000560= df4e71bd0 > > [ 56.996963] > > [ 56.997533] Disabling lock debugging due to kernel taint > > [ 57.037759] zram: Added device: zram0 > > [ 57.088669] zram: Added device: zram1 > > [ 57.249105] zram0: detected capacity change from 0 to 6553600 > > [ 57.320547] zram1: detected capacity change from 0 to 40960000 > > [ 57.443012] Adding 3276796k swap on /dev/zram0. Priority:100 extent= s:1 across:3276796k SS > > [ 57.470295] Adding 20479996k swap on /dev/zram1. Priority:0 extents= :1 across:20479996k SS > > > > Here is the bisect log: > > > > $ git bisect log > > # bad: [684826f8271ad97580b138b9ffd462005e470b99] zram: free secondary = algorithms names > > # good: [2cacbdfdee65b18f9952620e762eab043d71b564] mm: swap: add a adap= tive full cluster cache reclaim > > git bisect start 'mm-stable' 'HEAD' > > # good: [9bfbaa5e44c52422a046ce291469c8ebeb6c475d] mm/damon: move kunit= tests to tests/ subdirectory with _kunit suffix > > git bisect good 9bfbaa5e44c52422a046ce291469c8ebeb6c475d > > # good: [1e673c8cf7f9c1156f615b7c00f224a8110070da] zram: add dictionary= support to lz4hc > > git bisect good 1e673c8cf7f9c1156f615b7c00f224a8110070da > > # good: [3c8e44c9b369b3d422516b3f2bf47a6e3c61d1ea] mm: mark special bit= s for huge pfn mappings when inject > > git bisect good 3c8e44c9b369b3d422516b3f2bf47a6e3c61d1ea > > # good: [f9e54c3a2f5b79ecc57c7bc7d0d3521e461a2101] vfio/pci: implement = huge_fault support > > git bisect good f9e54c3a2f5b79ecc57c7bc7d0d3521e461a2101 > > # good: [659c55ef981bb63355a65ffc3b3b5cad562b806a] mm/vma: return the e= xact errno in vms_gather_munmap_vmas() > > git bisect good 659c55ef981bb63355a65ffc3b3b5cad562b806a > > # good: [325efb16da2c840e165d9b620fec8049d4d664cc] mm: add nr argument = in mem_cgroup_swapin_uncharge_swap() helper to support large folios > > git bisect good 325efb16da2c840e165d9b620fec8049d4d664cc > > # good: [ed8d5b0ce1d738e13c60d6b1a901a56d832e5070] Revert "uprobes: use= vm_special_mapping close() functionality" > > git bisect good ed8d5b0ce1d738e13c60d6b1a901a56d832e5070 > > # good: [2abbcc099ec60844ca7c15214ab12955d3c11e68] uprobes: turn xol_ar= ea->pages[2] into xol_area->page > > git bisect good 2abbcc099ec60844ca7c15214ab12955d3c11e68 > > # first bad commit: [684826f8271ad97580b138b9ffd462005e470b99] zram: fr= ee secondary algorithms names > > > > Sergey told me there is a fix on the way: > > https://lore.kernel.org/all/20240923164843.1117010-1-andrej.skvortzov@g= mail.com/ > > Confirm the fix in the above thread to fix the kernel oops for me. > > Tested-by: Chris Li Sorry I have to withdraw that Tested-by. Turns out the initial warning and oops disappear, the swap stress test got oom killed. I should have waited for the test to complete before sending out emails. Will report more detail of the oom kill in that email thread. Chris > > > Chris > > > > On Mon, Sep 16, 2024 at 6:30=E2=80=AFPM Sergey Senozhatsky wrote: > >> > >> We need to kfree() secondary algorithms names when reset > >> zram device that had multi-streams, otherwise we leak memory. > >> > >> Fixes: 001d92735701 ("zram: add recompression algorithm sysfs knob") > >> Signed-off-by: Sergey Senozhatsky > >> --- > >> drivers/block/zram/zram_drv.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_d= rv.c > >> index f8206ba6cbbb..c3d245617083 100644 > >> --- a/drivers/block/zram/zram_drv.c > >> +++ b/drivers/block/zram/zram_drv.c > >> @@ -2115,6 +2115,11 @@ static void zram_destroy_comps(struct zram *zra= m) > >> zram->num_active_comps--; > >> } > >> > >> + for (prio =3D ZRAM_SECONDARY_COMP; prio < ZRAM_MAX_COMPS; prio= ++) { > >> + kfree(zram->comp_algs[prio]); > >> + zram->comp_algs[prio] =3D NULL; > >> + } > >> + > >> zram_comp_params_reset(zram); > >> } > >> > >> -- > >> 2.46.0.662.g92d0881bb0-goog > >> > >>