From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1024C27C44 for ; Wed, 29 May 2024 00:51:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED7406B0095; Tue, 28 May 2024 20:51:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5FFF6B00C0; Tue, 28 May 2024 20:51:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D01856B00C2; Tue, 28 May 2024 20:51:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B00A36B0095 for ; Tue, 28 May 2024 20:51:08 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 520F612078C for ; Wed, 29 May 2024 00:51:08 +0000 (UTC) X-FDA: 82169604216.01.6503D66 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 74354100016 for ; Wed, 29 May 2024 00:51:05 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FlgqGMPt; spf=pass (imf05.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716943865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gy8VhrOPTD74KbeD1d1aJlIrKyZX7ap3ToPIt6RxUqc=; b=VoI2iJlHYsQxWKJSBZ+bUrv7uVNR2xzHF6GYoiI9HED5h3O/1K/e09vPhyVCQr7jnyE3J4 kYYOXQQENZnqxuz7FmW0Bc8Kg8RIGbxa74bZe7j7Z7CCLIZ4dpS0JOQ/DmV5spsAC+Ubm/ GaLFeFKN6kSH/FuyndLt/Rdj/A+YCLw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FlgqGMPt; spf=pass (imf05.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716943865; a=rsa-sha256; cv=none; b=UZmc6J9B0xPAMS2/l3tJ3zaU3IEjWWlZKlJjWfsKOjum+vTUPbaBu0y7Z/QH4VYxoAvrsH phl1KCEU90/Q65duKuFVz+2eTcZta3SYTqm3H2UuyUe1N9mRD07qOiL5447lg4I0OzeCfg TcAzNIvBEMI1SXpathGz7fOpOloOEfI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5626362660 for ; Wed, 29 May 2024 00:51:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 008F1C32782 for ; Wed, 29 May 2024 00:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716943864; bh=+pWlSZoqw64YXEzXVNhuJ9yIm/GIMMuyBwrK/e0NMeY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FlgqGMPtQqHOPDHecsp8EBKaTdhdv9cRUrYagS6y/hQClOeozYoo5srrAxM8EO5oa c8ZFk8Kp5Jaz3Sg8y670BEQWBTFfEmQdgUQkreMOLZWTlNT96a/OZGRmLuZe0VBfTw qM/vzVs6n8BdHv5nNv/yPfafNodXs49+7umxdvumTLLpecwhmWFv5fBX+dD0MZ8aXj Z/Y4Mn1ek+SiSi55yie+LLlRPGn7JSPfLTxYWy5J3pq9BC68b3qXgfmiNEuJaUOOiF n3CZuLkmb/T5YGPtw2f9Dop19AVq4k1pFoV7rmNZml7bEjWBWlhIYLBo6ge1YrxLV8 irMMcylxgN3fA== Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-36da84df7adso1126735ab.1 for ; Tue, 28 May 2024 17:51:03 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXE3WZRhUlu+XHF5vvjWaOwrMMSBM+cQW9blIoprjZnme86/cski5W+I5iFHfGdaHuRpKtmVLbsowD0/Zrtik7JdLE= X-Gm-Message-State: AOJu0Yw1LO5LK2TL/tNgzStwXDQzu4et/DUQT7dAOGg/Et5TCal41D/U CDr4jom0lxm1pZIz4SS1j4FY5l2b+5oat6TUCmW6bhWh01mIE5jKr3V6fkyIF13yr5pDkN4U4MZ S6xMzIBudFeYO+oYuiTkhrtACrCVvlzZZGr8e X-Google-Smtp-Source: AGHT+IGogOvO07nZBdXAJJ3KWhwNuMCm9vKIy/R9kjeTHH3LTcJ3Fuc5R93FIU5owSelUtZBZtnVta4x9u28iThR9e0= X-Received: by 2002:a05:6e02:1d09:b0:373:8d04:28a4 with SMTP id e9e14a558f8ab-374737150b6mr5970915ab.13.1716943863281; Tue, 28 May 2024 17:51:03 -0700 (PDT) MIME-Version: 1.0 References: <20240524-swap-allocator-v1-0-47861b423b26@kernel.org> <20240524-swap-allocator-v1-1-47861b423b26@kernel.org> In-Reply-To: From: Chris Li Date: Tue, 28 May 2024 17:50:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] mm: swap: swap cluster switch to double link list To: Kairui Song Cc: Andrew Morton , Ryan Roberts , "Huang, Ying" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 74354100016 X-Stat-Signature: 7yhkqu5ytqhftohm8s35enzfebja5hdi X-HE-Tag: 1716943865-873930 X-HE-Meta: U2FsdGVkX193F2qpsJfhCNpqz6pSO6FYz2sUY7rXN2tAzRJffaQsVTr7qun0CzVAGIkql/kn04cduxM5LBHmXl/FHG3cUviQaTt0UWErEdnaMaXQZwnRv7yBsizHAqYAmrO8qB7XfuMoowFIYlLUarbb1bEMK9JQIYtM1VgAPZd0rIX23m4mndjc0G25aFWxceTBecJLQ693rbFTjkp6ZXFUpN4yMIlZwtTWhLOqM5E2jBIe2ZJwW+SXPZEWCOHNEmBlp1EoY0k6XRNKVhN9yW/5bDzHFi8wtojXafVfSEFTuJZp876rjFZVKeSo6mjdiRsPicAkoSYbbQwajfQNZfzSMxPaPi4jy8ZWGaYKYAtuhABJDqQIeKLxoqRHlz2gUe+84z83kq/5pAUx9VfUdKYqt5YxK/r78vDyhsrt/TomQbR4lAZnjeh2++gdr6LQgF/c0wtYgZPtAEooTj0GOltlQlHNUoZwGc9DXsOmbe/K1KFac0zNC2Wm+B+TxN+E182bWCLKwMQHE29zVT1c3uL0bHQ3Rf3IxmbqK3XAnJcIXManbNxCkyLyXn3WeFuuYuo9KPlK0onwiEf78vFMImkC+ATe8LF8HyArGIkf7yF+zTVtLAUhxK6uR8oUsLXmGsTIWN2xo0g2JLlAV+xsGVU5esyC9YesjWQ8DUCjK2QkPwu893KJ5GUMhkpdh8mckS/ULwvFilEzP+12E4fidcppROQrwpgxwobQx6usJUzMwh/JJsPFThrvOHaUygIIEj8tvhCKDBk84UQeQ4KF8bG/caiQNybE+ZMEVk9ebLUJeRB5EBsHu67wygvRb3BHhSA+7CWq3i9rUxhrnrnZ3SUR4uDZWThZoeYrOSZzrdP9Nh+n46iOVoBh3BnaZtFenUFrWrjhSbfy1esZOiW/Tev5PTC/8WGaRkbzti9t6iLZ5AAYJ6ieZvSZ/LTUvr7tb5OVoeRt6QC+kbYqDjE dyBzeZMs KlAgtAOjqg8eepifsaRsNKWgN8cjh5K7qqw2ZOhRctchgPn3X8RM1n0SolEMqS+KUZztRF2x7O/pwYzU/OM1/xPRHinafFGX2U7b/mQSfaCbijpL6J9fkO1Xgnyt3N+v7CmlrUZZS14vncbPRHaIrPJd+fmONsRRPV2Qhgmdd1DD0EGtlSYZnFPC9CFGmV1QoSJHWgbYySYDx10lPDWzzjMwIeWFs1yC4ggvdpCPxGGXkwQk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 3:27=E2=80=AFPM Chris Li wrot= e: > > > @@ -670,7 +562,8 @@ static bool scan_swap_map_try_ssd_cluster(struct = swap_info_struct *si, > > > goto new_cluster; > > > } else > > > return false; > > > - } > > > + } else > > > + ci =3D si->cluster_info + tmp; > > > > This "else ci =3D ..." seems wrong, tmp is not an array index, and not > > needed either. > > Yes, there is a bug there, pointed out by OPPO as well. It should be > ci =3D si->cluster_info + (tmp/ SWAPFILE_CLUSTER); > > "tmp" is needed because "tmp" or " cluster->next[order]" keep track of > the current cluster allocation offset, > in the per cpu cluster struct. Hi Kairui, Actually, you are right, the "ci" is not used here. That is why that ci out of bound error does not trigger kernel OOPS. We can delete that else line completely. Chris