From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79DC2C07D5A for ; Mon, 27 Nov 2023 08:23:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 018516B031E; Mon, 27 Nov 2023 03:23:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE27F6B031F; Mon, 27 Nov 2023 03:23:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5CA56B0320; Mon, 27 Nov 2023 03:23:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C57266B031E for ; Mon, 27 Nov 2023 03:23:13 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9E2291A0156 for ; Mon, 27 Nov 2023 08:23:13 +0000 (UTC) X-FDA: 81503044266.26.D0C3E1F Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf21.hostedemail.com (Postfix) with ESMTP id DC63D1C001C for ; Mon, 27 Nov 2023 08:23:11 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NtG3DRak; spf=pass (imf21.hostedemail.com: domain of chriscli@google.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=chriscli@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701073391; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ULlkC8JeamsZgVSVjUJ5qxYE4uUQ1UkdpEJhpvbLANc=; b=jO5wafPT68zSFIw+Opcmhyvkh1nlTUB7vyIAqPCkhVpS6CcfFEF9gM+hvk5KmENjxEQ8J+ j/jT3Q+BhQpVjfChOFeS1AFm8qa4zCoC+3KH+PoTgXQPwQ8KRK8N0JYwiMatod/7BVfNrq jPCY80Br9ZNUsGukOWYGhEM3n9I3X2Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701073391; a=rsa-sha256; cv=none; b=4S6W/+lXsYkFDgGOzPkfRD3JZH+gDpZv1VgU3UkyjdKF3OhcM3dXT//T0AibQrBtMaVYXb SY2YQSzlO2mR9IgDxk76NFPExhJVKgw/JqpuH5wgDL78BgkGBpVeavFjLcp4FF2EwtfdUz ax/qc9PJ1psCUHWUkKLtDt6vKCM+Rzw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=NtG3DRak; spf=pass (imf21.hostedemail.com: domain of chriscli@google.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=chriscli@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6cd97c135e8so73180b3a.0 for ; Mon, 27 Nov 2023 00:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701073391; x=1701678191; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ULlkC8JeamsZgVSVjUJ5qxYE4uUQ1UkdpEJhpvbLANc=; b=NtG3DRakrG4+jlo7VWpEXUITCn4l2cl8BdNnpZsLJI4D4Ae7jkr6S42ZsLjvJdmVrw y4MmMy5IfiA388IqwRl8SevtDXIPRoX0OQ5V0sioZe8lejZcRuij6OAs5z10FvUwqamr e477zRYjpJPI8GouexaNGQswXvz+iuL2MATwHLO81LK575oEQ90Nfyt4D5v0dO64ykb6 gMTDGmVKDDeCeH7qBy/710cLynEhnCTx6r5tSUn9MN4HihfIxeQQAzSLrqQeeICq49YL C1sasYDp+hTVgt1a7rSb+kX8n+Qai/GzlfOZ+pO4rKTqvlbQQ9BdFl/rJU+vCvPVoLl8 Op+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701073391; x=1701678191; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ULlkC8JeamsZgVSVjUJ5qxYE4uUQ1UkdpEJhpvbLANc=; b=rc4HaZjcOM9NafxJGlWdgpvnGGEP+9jGvpBGTPR/rpsHYEkRiBx6zu5hby59ESPXzw Bn5roATS6WGhT69Uzu6lr7YceiEakNEoqHFTZn2jwM5hE5yMUN3aSnnKJaNwJAaxjpSj r6WxEFOT+5JFt1CCbh80rdx/LBUZo4uk8Qzw5sZQWxTvys+40L5Rd65kcN0MuhK1AK9e rk4rQtrxM6gprTUu1ZhGQMzpz2EfoVPTlS/LREqnP0BajOMpxPjCfDPiZbzx/qZuT5yX DdZ0jpT4DqgCOXeCEVHMjv7U4R9KPGwXy0KBtspTxBHfU7tMH42NlHx45tiTe9HSOz9P jrFw== X-Gm-Message-State: AOJu0YzwIZaNQtZ18YGCMY3xO/r/GlAC9F0p3+6x4SfP9IJoEMx7trJB tsrglNcijnps8ASNp2VE75qGbIMN8pBnk3TqjJub8A== X-Google-Smtp-Source: AGHT+IF9MFHVFZI6yPj+j7dmHYEfs1Pq2gwHX935HK8wVmKGF44F2bvPSIae1YEPsc09bOt/TgIa/vve+Itf6gwpywU= X-Received: by 2002:a05:6a20:144b:b0:18c:382e:48fe with SMTP id a11-20020a056a20144b00b0018c382e48femr7511796pzi.15.1701073390581; Mon, 27 Nov 2023 00:23:10 -0800 (PST) MIME-Version: 1.0 References: <20231121090624.1814733-1-liushixin2@huawei.com> <32fe518a-e962-14ae-badc-719390386db9@huawei.com> <87msv58068.fsf@yhuang6-desk2.ccr.corp.intel.com> <87h6l77wl5.fsf@yhuang6-desk2.ccr.corp.intel.com> <87bkbf7gz6.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <87bkbf7gz6.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Chris Li Date: Mon, 27 Nov 2023 00:22:59 -0800 Message-ID: Subject: Re: [PATCH v10] mm: vmscan: try to reclaim swapcache pages if no swap space To: "Huang, Ying" Cc: Michal Hocko , Yosry Ahmed , Liu Shixin , Yu Zhao , Andrew Morton , Sachin Sant , Johannes Weiner , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DC63D1C001C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: dh5ubd3gk3zmmjiazds68y9bksugk3jx X-HE-Tag: 1701073391-754428 X-HE-Meta: U2FsdGVkX192avuo9AYj1TB0IApNUOdOWacCgLWhl0waNTvx+z47LuMxOTkH43N5/d/Vsd1SBnFcVXuiWc9YsboGHnZB4s5F51TpxZhp8YeIfb8SFPqH36DKH8X5L40l7agGEhGC8AXtfAOapyA1dxKnFoCnqLdRSdCs47DjBdoi7Dp8suURqyL39dQNtUOxDf+qbiLYhQGcPZZMPyaCazhH4sne09e/p/3o44hnH1jQ1v2LUdYriPmQ0JM3yxqo9QHzs5eCyHuVyZiv9q0rWK7O0KF2lLSKz059xnaOR5nwCulsrc2awnw0/klLn8461Px3yTXgEiRd6uOj4psvRRXuRM3o0b2Nu0SE8qPgxJYnEwZczvUPZFUVU9OI7HjQ0lVn6Ec4qlSbJZyZt19Ds5nPs4NpEzWLUeyorDr2++lEXNcTPWkcpT4hxpjvILklppRuNh3EtjpIErKwz+LjgpaLm0GzyPeWuWYgNCUmIsRyoRamr2qQFL0rY8U2pf30jGr4K1l7Yub+Y5IgNeBnUQMjNiqz/2yHOjazTCE5fUIT4ihBf4xIczaFguYHLbCc5IuscX1pSst00Zx+aI2smWXQpu5xbpALq/GPFgcc1dkhZf40r0ME/COW+9Zf2K2bj/EYDibn/dPa5+0yoOZ4BoLn4eljMbAhqj5tNQhoiisWBrhzjJphduOkLdw8nVgmwLOY0j1rKBgYU+40SVIDCxeBTg2frCxivUkU7ef4zZ4j1tiUfUVeM11YJJjiQ+Fz25kGLp5UONBjIOYsdNz0yZShZGELFRdmGlDUfpWTrx5luZDWot6h+p2WVS0GVKwCl0nfs6V7Y+AQkUoih4uWx9vuAGiXk/8uk3WVVpf5AaavuTVRnh/tzgxWg8andsRL4mkHaDDNBny0BCpT6FVcMsS5H8EwlQG/fN3Vb0Ianu1Rn3vOaBjUlxEetEjO3gDm9Pws+jnY8HSo4r4hzaH 3QdHK6Je Bw6jUDwY8/GOxXRrNQvkPu0ZSYHGD9AyHmhpFULJ4aV72PEi49CNOIfQi51l+HBNBermOeyOxaDjyX7vHelkPFCYFxZSdclqC+/TZhAnljNT9LBP6I64Doy+tcSK0aq+cLZObiPnW+O4VNaKWTZxDzQhnVB2e0eYNjk+D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 27, 2023 at 12:14=E2=80=AFAM Huang, Ying = wrote: > > I agree with Ying that anonymous pages typically have different page > > access patterns than file pages, so we might want to treat them > > differently to reclaim them effectively. > > One random idea: > > How about we put the anonymous page in a swap cache in a different LRU > > than the rest of the anonymous pages. Then shrinking against those > > pages in the swap cache would be more effective.Instead of having > > [anon, file] LRU, now we have [anon not in swap cache, anon in swap > > cache, file] LRU > > I don't think that it is necessary. The patch is only for a special use > case. Where the swap device is used up while some pages are in swap > cache. The patch will kill performance, but it is used to avoid OOM > only, not to improve performance. Per my understanding, we will not use > up swap device space in most cases. This may be true for ZRAM, but will > we keep pages in swap cache for long when we use ZRAM? I ask the question regarding how many pages can be freed by this patch in this email thread as well, but haven't got the answer from the author yet. That is one important aspect to evaluate how valuable is that patch. Regarding running out of swap space. That is a good point, in server workload we don't typically run out of swap device space anyway. Android uses ZRAM, the story might be different. Adding Minchan here. Chris