From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D15D9C61D90 for ; Tue, 21 Nov 2023 19:09:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49E656B0141; Tue, 21 Nov 2023 14:09:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 450A86B0489; Tue, 21 Nov 2023 14:09:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33DB96B04B5; Tue, 21 Nov 2023 14:09:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 258036B0141 for ; Tue, 21 Nov 2023 14:09:15 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EFFC18039C for ; Tue, 21 Nov 2023 19:09:14 +0000 (UTC) X-FDA: 81482899428.18.B316188 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id DCAC140022 for ; Tue, 21 Nov 2023 19:09:12 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NUWLqa7v; spf=pass (imf01.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700593753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wQqDKRQjn6844OW3n/w7wb8sy0SLbW225b2srtOadSo=; b=ZKlHMKZdAqfHtuo+u4KoCvNwOvW/qU4NF51TsB0lQDs4+V9MEsVmbQDToSL8joG2Csqww7 tgqrD1xGaKq2Z8kCfosnK9Sr2nUu+VzjsKVFYI8S1OGYh03PySxufcBx7x6Su5VwsPeQtN XfoFFAn7CI+DFzH6XiDwTAeQ+t+8ut8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700593753; a=rsa-sha256; cv=none; b=OzkDtRhkqSjJSxZ9sRasAHjvRGhIXNglQVNuHwLzxRyYDNN2p1jrUMh1/e6YR4/Pvor27O UzeDLq/JKcA8ycYfa1GbFtowIS8km2RYAgdJe06WYEyUSziojaFPGelHLHejfmVpSjBYOu xUBvcM1hhSPKywqQagHJ5UtxLYGGPOU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NUWLqa7v; spf=pass (imf01.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D0B6C619A9 for ; Tue, 21 Nov 2023 19:09:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E02AEC433B8 for ; Tue, 21 Nov 2023 19:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700593750; bh=wQqDKRQjn6844OW3n/w7wb8sy0SLbW225b2srtOadSo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NUWLqa7v+2j3nV+bLsLlh32x/ALDzR6vH10qIoPInc9D6inlfOJfxvBdWJoDUbuyx jIvLr/HyGhi5gRoR3DDS0pRkJEXGxmx1VSw623O1/JtOFMepexsuTrTcRXFubK062J IZ6e5431FxsSvMSzx5moVXMJQldVIKkJkOHD9ZXgJt2g/bW11cunZnGdmUEZHN+C8s TFRT79j9BHj7jlzz2SVwtsJgiNolv4/YQW93PdZVVakHJaulYfvvDODhtZ+4USU7Pi unpb6yB42BPGseKUQCr/aPSJSjvJwBcLAdHY2kcG5foFAc9c5dUcOnnXGYtuHWbo6R OUr3+ndvV0luA== Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5bdbe2de25fso4533147a12.3 for ; Tue, 21 Nov 2023 11:09:10 -0800 (PST) X-Gm-Message-State: AOJu0YwOf5AUz1oDf8TraOVT47XwPSGrjAgPsmtJXBAA8c7lk/JF9OBY uZHog9tBb20hF3O1RNiOAF7GA/U3D+AHClr3M+Y2UQ== X-Google-Smtp-Source: AGHT+IFj6T6qFwD847PxtZzKZN0ToGw/PjQQlEJhOLHFQIM/P89jcN/ZWDs7l4ENV/joAGnZgLeRSADwaWkhZ9aimOw= X-Received: by 2002:a17:90b:1d92:b0:27d:5964:4ee6 with SMTP id pf18-20020a17090b1d9200b0027d59644ee6mr163589pjb.2.1700593750122; Tue, 21 Nov 2023 11:09:10 -0800 (PST) MIME-Version: 1.0 References: <20231115172344.4155593-1-nphamcs@gmail.com> In-Reply-To: From: Chris Li Date: Tue, 21 Nov 2023 11:08:59 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5] zswap: memcontrol: implement zswap writeback disabling To: Nhat Pham Cc: Yosry Ahmed , Andrew Morton , tj@kernel.org, lizefan.x@bytedance.com, Johannes Weiner , Domenico Cerasuolo , Seth Jennings , Dan Streetman , Vitaly Wool , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Hugh Dickins , corbet@lwn.net, Konrad Rzeszutek Wilk , senozhatsky@chromium.org, rppt@kernel.org, linux-mm , kernel-team@meta.com, LKML , linux-doc@vger.kernel.org, david@ixit.cz, Minchan Kim , Kairui Song , Zhongkun He Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: psqrrbxxzxjnsdwbuk9sr7pbbj7mip3p X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DCAC140022 X-Rspam-User: X-HE-Tag: 1700593752-213320 X-HE-Meta: U2FsdGVkX18FyuB+zQgx7pzL2jh4Jjg6Ne2MT9/VJk5HuGITKsX3kYGDB9YK0/0L/UCE9supEZnjIdk3hogGR8tUvBDw1/FYeovbK/401FtPsbBrjYbF+TsUrgaJm6K30jZP73C3huxsqQ+Sx2IGJ4KN3JpU/N9dRcEW36o5NUbWiCTSmnbIfdf35mPyoptL5SxuX99xXc1kMAK7ea9kUXJcl2Pmg/dhS0F6262lvmg2MSbaBwbEnLDhEfXG0fRLZyImM3ZzNaVPonDP3TQjIQxj5A+3EOnKP+KaL1msaocqEpB0rrgSy4zZLm6q0W+mXBI9BwM0Nt6osfIWlB2ung9L+uWc0CzPg38E+F5f8jFZZYLqrEPeWXgw6CaoaNGAJjpjanKEVy79Lw+3X6K4EFipiVCXrRGdm+VY50R1pdRiL2d4CIlJVfmn5Mwox13oVVuB/CMrxVFT2rQLWyje/y9VDzBveQI1RjSb/2LLxojC2Q42WYWzVrA9MOyKckiGU8ypoFJfccZFoONpdAlcQjlEKlmK/Ri6Rvb12zERN8EM92LUKOi85nnWrwxM112X81Wc7vocNXAYW294AnpIgN0GZIp/9EgEavn671fgZNnVjTVtieVr9tB3S6A0jnGY5k2/7BIGMAI3ANX6rwzDSkOwrOBBajPXu4ZPYvg9B0gxgDaii5RLHPY7tNDwjUXvW95oiEl/RVM6X/uJKQ3dG7uVpdQUGr0261hglbZDbgAeta/Xa0bkjcw2Fb/tw9ijhkTeZIx2MDocjMLS+c4+ZeQvzutWp44bXh2Mp06XesgBTQieS1Il7VqHMjtFhhf9A/odBGr09wbfeTrGPws2n7XrFvZhBxXUxiZ92NAdD99MfAXfcGAqR3eQ6VY7ETxnBWatWG4nVs/ldechY0CJOMNh1gd66VC5wby9YZjwK5IG8Ged9iSgk/ebHN24nMQuG5v0BcPggcDWuaQg+4J kYlqHJoP mpr+XK45xt20OXH9APBTyo0iA/kKCy4BvO1z2SCfnwNZISPwARdxzUiqIIL/AOE14nucBEjXnTtMGVmkD/sWRRZI1KHFgr6JvvMnTTXKXs5c9iV5ZTD4sOWNzbUNr2BmWFk7lrY9V8nNgL44RmypqEyLCRL5xQKxzTGyAqEa1NS6Zs513NI06if+wOgXWGLZPHCNvxFr5+yg17Z1GzJSWEvhnAk0Auslot5IMRm5EHsL1cna06Uj6//voiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 21, 2023 at 10:13=E2=80=AFAM Nhat Pham wrot= e: > > Hi Chris! > > Thanks for the patch. Would you mind if I spend some time staring > at the suggestion again and testing it some more? Of course, by all means. That is just the minimal version to be functional compatible with your zswap.writeback. I might consider a follow up patch to add "no_zswap" and "none" to convert the SSD only swapfile, which can't be expressed by zswap.writeback. That should cover all 4 combinations of zswap and swap files without creating a custom swap tiers list. "all": zswap + swapfile "zswap": zswap only "no_zswap": swapfile only. "none": no swap. All keyword names are open to suggestions. > > If everything is good, I'll squash this patch with the original version, > (keeping you as a co-developer of the final patch of course), and > update the documentation before re-sending everything as v6. Great! > > Anyway, have a nice Thanksgiving break everyone! Thanks for > taking the time to review my patch and discuss the API with me! My pleasure to discuss the swap with you. We should do the online "swap meet" and invite other developers who are interested in the swap area as well. Chris