From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF76FCF9C6C for ; Wed, 25 Sep 2024 04:04:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 161C96B0092; Wed, 25 Sep 2024 00:04:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1126B6B0095; Wed, 25 Sep 2024 00:04:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1BB26B0096; Wed, 25 Sep 2024 00:04:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D310E6B0092 for ; Wed, 25 Sep 2024 00:04:26 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 777EEC0821 for ; Wed, 25 Sep 2024 04:04:26 +0000 (UTC) X-FDA: 82601918532.29.047E7EE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 728D9180004 for ; Wed, 25 Sep 2024 04:04:24 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nA88GzKs; spf=pass (imf24.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727237029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6AHU3Fl5gOSKj/T76A1Pj8W7ti/9gC0jCXTN3jdHN70=; b=tVkFkc05V47HCEYobx/I90BjqPH0/x4JGJsYAi+QFUB2v9GU7uXnHI1cYmIq1Me8f4Djab RHEeUomPmkGJvj/63FAJfvB2osfS8wsUjv8NO27O5CRE+lihZu+DyG4+tctPkuxh81LkJx QC+9KZEaO2eapXScTcmU0pJ5Ipwb37E= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nA88GzKs; spf=pass (imf24.hostedemail.com: domain of chrisl@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727237029; a=rsa-sha256; cv=none; b=hG/c5a5kQ+1Mr38hCoO6038v4Z8/Zg1LSeShTbHZfJlWOIRQsUStmraeSzNQ0KCkFl+XjC Kw/U6KtiU8IKC7UPHMlgbnsusPklhl3FlbMaTgq6SgdskrpjimPxtNuk6LoW3pppO3pkTu xz12kSVT4eBKw4MMBVPmcrs1fJO/kug= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 71DD25C5CB6 for ; Wed, 25 Sep 2024 04:04:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17592C4CECE for ; Wed, 25 Sep 2024 04:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727237063; bh=p6aXdQCsCQDb+qv4Oe0hGSlkljpbIyMoGX6UwtO7y4I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nA88GzKs5XmLWrndPrDBLIlm2YKSyzxjfTMeUcwyCTPPvNIylFyR9KPMoFnsRigln N5p5eiokmbwRNFB8e1m7FQtXltuKRfr6os8y9ARhe/aWfV6h/haikvrl4Vnew+Ouoa LYkNp9zgCqUA1VhD86WOVRzQRxKTrhSFhCkV6HIezFfP8yxytc51u8eyJWw4/FVgOQ FAcE5YV6H8NBTr+d4cd7x4TMq1Ptr874yhL8hO36EixErjyAzRw+6C+IlpFukgHbx5 t1fHJ134zbPhaxJNFyuegXX2IdAnkA0bWqp+3dBgXajEbIxKGZEb4XX+N2N9pDrXJ1 juJlN63g8Fiqg== Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-3a0cb892c6aso188135ab.0 for ; Tue, 24 Sep 2024 21:04:23 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCW0K8Em+TAGn9qaPH8HWxBAUGST+UxVXl0FixZHbuTC6kopNEow5jiS9zxd0S7skbPpEXgMMyZQ5Q==@kvack.org X-Gm-Message-State: AOJu0Yw91OnCgxBmzQav+Rlr0OVRAIzSaGxK5zThqnvDE6c6nv4vzPSF 1WRESimy5AZ2zjVpNjpSvW75xRQ0H8dTexRH5uloKZNDMBGxPLv9UZJdcRJ7SYLxU2MLyQLH62j aKQzH051QLiIkhWmU8v9h9I6qumvgTqsaWUB6 X-Google-Smtp-Source: AGHT+IELrtiyu4mKIo4xDH5TOC5IAATMzMKE7/IoB9tmPJ03N/88XGcxL4jb93lXI1QLJzXHw4dM7zmW4R0m7d9um7c= X-Received: by 2002:a05:6e02:1fec:b0:376:3026:9dfc with SMTP id e9e14a558f8ab-3a2703e74f4mr1275375ab.24.1727237062258; Tue, 24 Sep 2024 21:04:22 -0700 (PDT) MIME-Version: 1.0 References: <20240923164843.1117010-1-andrej.skvortzov@gmail.com> <20240924014241.GH38742@google.com> <20240925003718.GA11458@google.com> In-Reply-To: <20240925003718.GA11458@google.com> From: Chris Li Date: Tue, 24 Sep 2024 21:04:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] zram: don't free statically defined names To: Sergey Senozhatsky Cc: Venkat Rao Bagalkote , Andrew Morton , Andrey Skvortsov , Minchan Kim , Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, stable@vger.kernel.org, Sachin Sant , linux-mm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: pe1hxhi7kuyenypdsaf68auedpedgibo X-Rspamd-Queue-Id: 728D9180004 X-Rspamd-Server: rspam11 X-HE-Tag: 1727237064-106700 X-HE-Meta: U2FsdGVkX18FcTMKah27LTiv1u4wmLj3VZvxLI8yYvLjPKOLx1St4VaypIx1F0OQThDf6w5I1ZUwegXtk4roQ/NxoeZc3OADaTLx9SWSyzaLDmAdwxsstUaaZUnOFSL3dQOIBWhOIu0//xHkpgWXifuGKi7fqXEa8v92Odbe7uu4IYIt/ByxmjmtbHFU/q7OyuQuWnuPCEmXdOqncPMAXbU72q25Uod/NRNGLPyfHw+cWGhcaV8jW3MqrSoxg/m0/mnLDAT5aCkx1an3TLr8SOkQpRt4uSxnMUDRgXRoTuUjKKQlDRw4sAWW/W9ybAdxrmhx0NDouHAkUdLa1HeWWaP1pVEHA/riYMg/gaBH8GI9NxMhdBb57/h82BnavWQBrJMHAh9l83FsmS6AE6ZjWMDhJuBXQ0f3FZ6eDF8/2s6PE5po3mITBXjsrk52EMbDKXJo4ZvvKQh73Q8cwk29ROTG3zHoAZKYQXFhx34dCFNHjgZVRUKvWxCx0PE2qUfA1wUTnMCLMBzyKT5Kh7o04jsph1M846u5MeHfRLEx7o9veQ5BddTHxuus8oXS9txf8GIvNzVRfmLLxsaNzz3bO3KvV6hr62VXPEpG5QZ5dxZt5PS73DiFnws5or2pb0miD7r4f+4pPXVzQIZtKdoPd2jkg7OdMRRdeSoO+9YYSSpPM8pgDFBwDBsQJhR2zIitCXLCTsH43BBPGmLAV1i5MgDZfQJMrtAk2d70lDpdXL10mGPMjKgUSKiin8uOxgPG+m5OJb3ZERIEpUnqvkIdNtsPRy6wErhrcinrtE7U34g+50jy01CaqzxGqTMn1rH5tkhzyfUnS2PJjt9o8QDrEBkx3dnyqZdermYjt0PWnGDC9Q9giE2vxiS+M6PZ+5351kcvHoxEvKS/Viim1axjn1i/WosCcKAJqrAkvxvnwve7IJOukrO6F2dSJc/zhcpjN2Aq2MFBuhiMuCZk6qy PO64wuiE 98T2VeOsRNtqfTuPfP9UjKaGOixWlEXwIXx06x72IOMf/C5ZMtjsx05Df1gRUpMfNC0yRGVd6sYXSRmyVV8rb8u8Kdq5CCxtcZdVyaPspQdzpvYg04gRAEsXcP8U9/YaC6RpvepdioDhBrZHJBziMkstosqKfty78ZeRoX7c5JAeC9OTrmmXNB+N26xgDR/LuCOhXm6ALBhoAuDZUH2ayjdzToG+etZHKET0Es4JJTf+nSzNIBg4MLUKhJbmOqOFKGazKkQJ/TdMkbHJ1rfzmzqzDtK7yDMEb48OV/X3vXC8g2DLLRlTpXCBoi+27BZIq2KnuN2JeYFXco1oKjhMJbJIq0JpJqswGYtTWeySoO89gxix9xsqlUgBqB/TRCbzRB4Zq46vC8N370lxWby/wQr7fZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 5:37=E2=80=AFPM Sergey Senozhatsky wrote: > > On (24/09/24 11:29), Chris Li wrote: > > On Tue, Sep 24, 2024 at 8:56=E2=80=AFAM Chris Li wr= ote: > [..] > > Given the merge window is closing. I suggest just reverting this > > change. As it is the fix also causing regression in the swap stress > > test for me. It is possible that is my test setup issue, but reverting > > sounds the safe bet. > > The patch in question is just a kfree() call that is only executed > during zram reset and that fixes tiny memory leaks when zram is > configured with alternative (re-compression) streams. I cannot > imagine how that can have any impact on runtime, that makes no > sense to me, I'm not sure that revert is justified here. > After some discussion with Sergey, we have more progress on understanding the swap stress test regression. One of the triggering conditions is I don't have zram lz4 config enabled, (the config option name has changed) and the test script tries to set lz4 on zram and fails. It will fall back to the lzo. Anyway, if I have zram lz4 configured, my stress test can pass with the fix. Still I don't understand why disabling lz4 config can trigger it. Need to dig more. Agree that we don't need to revert this. Chris