From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F3ECF648B for ; Fri, 27 Sep 2024 22:59:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF40A6B0095; Fri, 27 Sep 2024 18:59:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B54CB6B00BE; Fri, 27 Sep 2024 18:59:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F5B26B0096; Fri, 27 Sep 2024 18:59:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7EEFC6B0150 for ; Fri, 27 Sep 2024 18:59:29 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ECAE040F66 for ; Fri, 27 Sep 2024 22:59:28 +0000 (UTC) X-FDA: 82612036416.14.5607157 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id 1FB5EC0009 for ; Fri, 27 Sep 2024 22:59:25 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=O4Qx81rf; spf=pass (imf28.hostedemail.com: domain of chrisl@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727477803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A9bCF2GcDjbgL3HPiba2MwWGYcfQbLgjAo1rZ93ZkJA=; b=ljNs7lf50BrQ5tbFRnpjsfQI6Bt3VdFpllcPflGYJ8uuJ+OpBy5sEAmGKjbaoLdv6syk0B 0570IZVxB3DtGoZBhR45AvL3AULPNWrg1f/SodtsowoNld5t99MfePM9l2vBzhUuXEtbN+ t+q3HfJlJ2dMMbzbxJMaBPg/S0W9jBs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=O4Qx81rf; spf=pass (imf28.hostedemail.com: domain of chrisl@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=chrisl@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727477803; a=rsa-sha256; cv=none; b=JXy1ppobN1rjru+JbSWGKy14DOoMgB9sU3HWdHWrYuAoJSqa+7mkzp9YEKtQ1sOoZ0KGPt Y9wGCnm5WFSrXllZri7b/aR44khwXDAuGXsUmtjEBefmJTYAQ04DjKku5BhHVf64RQ5S4P sKr9ixXnoLzeazIfkDpKIBSWcvShsyM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 25096A45AD5 for ; Fri, 27 Sep 2024 22:59:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04604C4CEC9 for ; Fri, 27 Sep 2024 22:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727477965; bh=RETDblGo7fJm9ykfdR5QC0amdMsWUTecNy67KvQxBgo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=O4Qx81rfrfy7QCHveW2a1LP7n8JIzgcxH4F4PqF8SwFe/FUcZdbgMlRF4rjU95Yr4 uNlT8qIuA3+xKei5eJ2jOk1lCjKPZa60yjWimVEPsNBnpKITRyDzoWIiP/EL9CAGES wW4u+7UkcfuzXqEIAVwHEFQ6IUwDHssjRL+RWXEAg3npRaBudmYpXeIvs7A/BmqISo b7VoGDi8JSOiBzlGFderzWZ/RMSb1TjRfirIgoXezEd6N/YAzTi+oy44AtMOtWVmCd lOSDpWAJeQUIhrspOBM/cOAuv0WX6c4wEYtRChPOj2N+f25oerwXA8q5cPXfdjRVuD v4A0jGs4tjQ7Q== Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-3a0cb892c6aso95825ab.0 for ; Fri, 27 Sep 2024 15:59:24 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVXoS5U9uzKdbAAeC3nCOeSa57eFaVq/fX4eBaXJNa3gt1feA7582QIw4Va7cgsnb6C3yAf2wjsww==@kvack.org X-Gm-Message-State: AOJu0YzRaU5yl2ydpjOwSrkqd0uDDONV7J1aujyuewCoSOT556xEZ2Ck icgJJt1aXXJw+Rz8jSRqpprS8a3T/fzN+lIBgBDvzXUVMTQetvEbROzbP+1BTjluzHj7RWqlgVO logD720id+kgRQTeILOTXJ8eeDh63husPYejo X-Google-Smtp-Source: AGHT+IFsEwYg450S3NeKQn6xBQFs4856zgRTrSXHV+euzXNZKECEPNG2NCRcHPEkRwrNy63oW9OieWa6BqbUgzGKprw= X-Received: by 2002:a05:6e02:218c:b0:3a0:9b7c:7885 with SMTP id e9e14a558f8ab-3a34bd82af0mr1249545ab.22.1727477964236; Fri, 27 Sep 2024 15:59:24 -0700 (PDT) MIME-Version: 1.0 References: <20240923164843.1117010-1-andrej.skvortzov@gmail.com> <20240924014241.GH38742@google.com> <20240925003718.GA11458@google.com> In-Reply-To: From: Chris Li Date: Fri, 27 Sep 2024 15:59:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] zram: don't free statically defined names To: Sergey Senozhatsky Cc: Venkat Rao Bagalkote , Andrew Morton , Andrey Skvortsov , Minchan Kim , Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, stable@vger.kernel.org, Sachin Sant , linux-mm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1FB5EC0009 X-Stat-Signature: zh8xj1hks41iyhwp4fwg53iruix4a3fs X-Rspam-User: X-HE-Tag: 1727477965-2874 X-HE-Meta: U2FsdGVkX1/nIp09W0yXWjpNjRk0CAoG3gQmv/aT0RQOuNKX6jYMfY9+bQWoL6QICvDKTftIrzt1fMm2cEEAojBBwlClfhJqJlNNnbw/mJkDtTdvqmxMtxMYCnQ9efDuYG0ECX2LeG3Ed9eFUkTU9rcUmn/wuSAFV2B9jkiL2doBNSgCibs3wAqse6liqiJIZ6TB/T7vbluj7Rot/h9VtLxdgmUr55aJcNFON4YMVw2AI+0ICnioPHFZVai39eaaqLTOefenUI7LGRhRxVrJF5MrWDHPY/jQQvl3HkeRis9pbVeuVR3nAYsS/kmGZc56iQBqunWQWqWdDG5roBVSWOiioTTuEKrqJ0+VtOv8OpBhQ7Po/UzfR1wwhMVii3ilqhAi799LNA57drVFm32T0h7jdIsYTMQVoQVm+yEqVC8Iaw+qLKvvJiVxc8Y53fAVbsr9MNWA5V7Q//ublCqm1TCjJexPSjZ3UaKQRwDfUABSpG/GHoBAJf6phUhCxHChOMM9nWq+yTHBpvffFGCUvjHr3QnzRFL4Yqy+AjtCu8mKb82XU+af4nmjWLe9Xpy5/Q5QL+n22UpFfxcJGg6FMclDAhL5SCAWXqTZ/4fylwNUql2/5ZBMCajs+xGtvF+cYaDsDtf/84VyEhVph9wygYWLJ3Qax4+JFMAdUIvsiHml4ifFwgpt18xeta8J2QCJxrshCavyVtCvjZgkFNl706AJjMKEdpf0EmzN3Z5etTmO5JljTel2VsifhYvjvMmzEM7lY/YTOQd/x4C7IADf0K0IgGZCFe6/OFAXVDT3hwTIqIYY6o0Plj78wmcOsWm3tcaJjMJkw66YlLsLiy3lQN9F7gCsuZwB++y54cQMXRQ/EbjRaMtApeB3rhtdaym1CYjm5PzwNjLlxK6lXeysH4YaReDw10H1LHucRib4I0FDjcqZhKrPDZWsdUG4WIrqW3ykGJ69RFj4sWtd54M 6duPmj6h 5bFOTgeRVuuttlnG0iwJV7rcAMdNLZr4YYnIlxa3Gu1OwZba93kvsTZOpp8x01vuTPThfloBzQtj+8Bv9DRNl338o0iqKoT55h9YHg4Wk6e49uSDD2p4WUhGG//16a7IDWDN+XpgLYJFm+4PAIs+Uaaq3cPFVpW5Bm4r9/KZBL6HDfSYFaKwe+aVe4bg+7bLasOgLeoO6/cUX7oAXBc8HX7OLHhQaaWkD57h3q1+MK6M1bmWp7vPIo0nH/VEVhjfeGxWfWrtD2C8KPGM9wAlXBqbtPUt+gFwTAEDWm0t/rRKO7zhPZd024T1DKX1qp7ZxcdcSdImDgCpWoa2sSX9zgiyfZebo1bGb0FKn+c1utv9cwJ6keiJrWVK+G6RS10Z/tASo/Q9/hhFBBUoJ4u2BwsB8lA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 9:04=E2=80=AFPM Chris Li wrote: > > On Tue, Sep 24, 2024 at 5:37=E2=80=AFPM Sergey Senozhatsky > wrote: > > > > On (24/09/24 11:29), Chris Li wrote: > > > On Tue, Sep 24, 2024 at 8:56=E2=80=AFAM Chris Li = wrote: > > [..] > > > Given the merge window is closing. I suggest just reverting this > > > change. As it is the fix also causing regression in the swap stress > > > test for me. It is possible that is my test setup issue, but revertin= g > > > sounds the safe bet. > > > > The patch in question is just a kfree() call that is only executed > > during zram reset and that fixes tiny memory leaks when zram is > > configured with alternative (re-compression) streams. I cannot > > imagine how that can have any impact on runtime, that makes no > > sense to me, I'm not sure that revert is justified here. > > > After some discussion with Sergey, we have more progress on > understanding the swap stress test regression. > One of the triggering conditions is I don't have zram lz4 config > enabled, (the config option name has changed) and the test script > tries to set lz4 on zram and fails. It will fall back to the lzo. > Anyway, if I have zram lz4 configured, my stress test can pass with > the fix. Still I don't understand why disabling lz4 config can trigger > it. Need to dig more. > > Agree that we don't need to revert this. Turns out that my oom kill is a false alarm. After some debug discussion with Sergey, I confirm the fix works. The cause of the oom kill is because my bisect script did not apply one of the known fix patches after applying Andrey Skvortsov's fix in this thread. Sorry about the confusion I created. Feel free to add: Tested-by: Chris Li Hi Andrew, FYI, the tip of current mm-stable abf2050f51fdca0fd146388f83cddd95a57a008d is failing my swap stress test, missing the fix in this email thread. Adding this fix 486fd58af7ac1098b68370b1d4d9f94a2a1c7124 to mm-stable will make mm-stable pass the stress test. Current tip of mm-unstable 66af62407e82647ec5b44462dc29d50ba03fdb22 is passing my swap stress test fine. Chris