From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB61C0015E for ; Tue, 15 Aug 2023 23:00:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC2AC940034; Tue, 15 Aug 2023 19:00:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B71988D0001; Tue, 15 Aug 2023 19:00:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1232940034; Tue, 15 Aug 2023 19:00:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8C5B28D0001 for ; Tue, 15 Aug 2023 19:00:03 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4C1D1A0199 for ; Tue, 15 Aug 2023 23:00:03 +0000 (UTC) X-FDA: 81127858686.10.1A95787 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf10.hostedemail.com (Postfix) with ESMTP id 8125DC0016 for ; Tue, 15 Aug 2023 23:00:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=hT6pWaQX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of chriscli@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=chriscli@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692140401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7cMcDZ8u4QXqlKEKuadKRcWWAH9liLNOPn0kivqsMbQ=; b=mIZfA2G1+ukU+OZAzidbryYOxkN7stYb4qR3ky7RZ4Hn8JVCxjjx4Z5TA2u2iOpWbM241Y udf8dyukJmbH0b4AEhxkD5h7NhBXODfkaPe2XBMO/JTTl8ZqscH/GZ+O+8dWCNZi27R0H4 aBD1bttCEYOGunZzTUShelUeDZyYRTg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=hT6pWaQX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of chriscli@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=chriscli@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692140401; a=rsa-sha256; cv=none; b=ROo4AIzIx5wRT9IfBvTjUJsvOKn8mzzWUMCcCe7qgUzWm+LaWqvQkzfcYw25xyAU8AVK67 UkiLZ6ivWIRxAYn4SN4yi2vYv5O0vSwe3GCyZLS52htZoVPqfJYG/azk6ek8H8R6r1fXGM KYwl1ygNxtrjqFsR7riCwemM8UzjUq4= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1bdaeb0f29aso32025435ad.2 for ; Tue, 15 Aug 2023 16:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692140400; x=1692745200; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7cMcDZ8u4QXqlKEKuadKRcWWAH9liLNOPn0kivqsMbQ=; b=hT6pWaQXflgGvi4PKJEzKA9fyAUFUWmgipUYHnKxzjcwxNNrCXpfPE3EQRmkHzQ+8Z QW4A2dzuG88ENL6MFNGTME4ffjI12q7p/9in21baCwnL3nYMXpgWk9yJsHCYBQNv9hos cluwFSxQkjhBgs2EDGxN0a3SP5KfEYuov22Qy6caF1YW7en/PQOJuXO8YuY6eW8DCec+ IcPbzJ4jQ4U1R8up04AEIUPzPgE2JGOipmiXBtDgvS9AWjrGfzYcxvodnYOvWWZRQ6oz SSLdaSESf98Ckyk/3md9aJHOD0lvm2PiUH+ZrS3YGTYe592/g48ddAk1Npu0/xjJOe4y 9F3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692140400; x=1692745200; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7cMcDZ8u4QXqlKEKuadKRcWWAH9liLNOPn0kivqsMbQ=; b=No2C2zCpettyPbNAbLVdhroXQ9Ewf27H7e/i/JZwOi+697WZKfKCmTPkGtSmEPuhzl wlTu1n3jwZW0ZwRU6p2ctIOn1SNiOJ+e8LsFhMdFyC2dkXuGK5I4mKl3szifGGAFObyk i+OKIEJwIKMln33INK3ZMx0QZtx/dF3WHjqywLCGAnQx0eaNdH1FMBWTGXOpvRUV3Ukc kOWzfoixAaFrYkXlWCfqbKhqTynqPplE7K8JzkH+6+17linrtnDZdMLO1EXGvhKGD4US bNoj+RuwbrZMLaZ06tEf+Ft+Q4MB7PvflahqW5r9SPZduH9Xp7ZYqP6FJ+EW8fbErATv mbew== X-Gm-Message-State: AOJu0Yx83QYCD3hWyT5uaOn1Qplk1zd3bVPXyIzURSeaiIAcqh71My6m Ltyw4lQyzwKEc6EpHgH+xSPxSItBha9ndu3LR5bxVg== X-Google-Smtp-Source: AGHT+IG1hoYNPfeMlPFtFc094g+68RVzeeOzOIred3Tbx17HYLf2pJJeKElhEI8OAJKD0W7Qhu3s0CJHhla+3WYZoAo= X-Received: by 2002:a17:90a:f686:b0:268:c5c7:f7ed with SMTP id cl6-20020a17090af68600b00268c5c7f7edmr4628pjb.30.1692140400076; Tue, 15 Aug 2023 16:00:00 -0700 (PDT) MIME-Version: 1.0 References: <20230620194644.3142384-1-yosryahmed@google.com> <20230811141920.2f9bab6f21ab635ff1bd63ac@linux-foundation.org> In-Reply-To: From: Chris Li Date: Tue, 15 Aug 2023 15:59:48 -0700 Message-ID: Subject: Re: [PATCH v3] mm: zswap: multiple zpools support To: Yosry Ahmed Cc: Andrew Morton , Nhat Pham , Konrad Rzeszutek Wilk , Seth Jennings , Dan Streetman , Vitaly Wool , Johannes Weiner , Domenico Cerasuolo , Yu Zhao , linux-mm@kvack.org, LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8125DC0016 X-Stat-Signature: cbdbfi9xzxto1f6ynmrgnogwtqtq9dff X-HE-Tag: 1692140401-166032 X-HE-Meta: U2FsdGVkX1+9w+RQrRjRsCVgm+sSbvjMUE1JLACeXxzuSd6URJUU9vPsWuciR9w5XWdsaPgdWHPbkh9aoyrjax9razyUb+yFJVEP7qIlZfEkiIsimeS6/LsGQ+nPuJgnOMKVzz7MbOfo6jWT9mybjlWANRj2JrDPVNiNEzQSady82WbLdMl/wqhYm0aGERTE+nFMPTJfN7JAurs6RPRRYkLiyyqVic9owHlG9Kw6FIySJ7tdxQ6C5YSswASeo9Ns9Kk118qR7biqqm9/uw6kX3w8chakULle+7OYo9uLsBelvbt536DV4e/wvXs1iMuS2oZQVvZRqcwtsbaLQ4f4J5SBU3fAIs43C+vpZBjxDWxNyeqD31b7+NQd6qZpJagDCNxgzEcfH2tZ80DwgpamlnBK+9A3fKEN+NiFG6hBQLrfORs6fUCbha6TNc33WNCYwrzjbaa2XpFPadFq4vl48EXrBnNojNOeZ3gvY9EgB6odeALhdCuxImKUQmk8+dH3+JPc0tBTivLJ9OA4eEgrQYj7godyhhWVP7FZpmdQ2P7ID1ZM2KfcLZml8ROuE9KpE7f3UQ9lGQwZ3SL3QiYxixFt0Hjseo0d1H03l0ymq4by5utZK2v2xs1nTU5GYNraaqoGibem8f5wrQhg8XU9n4hGpPP+UkTiF8bvIWP5CDh4IjMKD6yBxOMQ8hPQiBpVu/PQlbaSZ4jKuj72FGb5xkWxt2gdtLOE8qUVV8u49oT3wQ+iaZCI+NXW0GY33fFrj7EzH54f/XvkWIriHvaedhoQH0+D0ECgEFAL5a1w/R0eEFtQPHyOttWodxTfIGorEowCB1PGcpnEAlA3MENZv+pwBVDJ5Gc/o9P/3G6CZLoQovnjrYwmSIPS4iWlPQxcq/tucI7+suSdWbaxugX43F0tZ6D35TJUqkhx2Q7ZN9G4vD+k7RAaYrRaunU7L9VxcjYg8kAMHJRyGIwFC59 qeZ0b4+h ca7Ylfv6UnG0Bs/mc6yE8y8PfH2ni5ZuUkum+9CTQ5alPb2JDoAU9ldjHdF9qJy7Zd5C8fEMY5ZfBhLusBjnzvKMWKieGSflHLqAH8i3nq0xd8Fb1J/A/D9iM7YoGhcGpJEy71BrYCWX9oqsRPdgUe7PLqxHixDVsKPwRkVeIEg9fg3zHnVrOHLL8riqUc3O4KkqRo5ToxDaG36ADbobkgZ9FWXliP8b3rpRXEijrobCjmP4XS7lDuSVezh7yamHX53VdIBaeZDbbcPfe/ZHJmYJXRN7bdcMqFoTKZRxsbArLI3hjWhCaoCrelg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yosry, Sure. Ack-by: Chris Li (Google) Chris On Tue, Aug 15, 2023 at 3:30=E2=80=AFPM Yosry Ahmed = wrote: > > I was hoping we can add the basic support here for multiple zpools, > and then later, if needed, extend to support runtime dynamic tuning. > Adding this will introduce more complexity as we will need to lock all > trees and make sure there is no activity and alloc/free zpools. If a > limitation for compile-time constant is observed we can do that, > otherwise let's keep it simple and incremental for now. > > FWIW, we have been running with 32 zpools in Google's fleet for ~a > decade now and it seems to work well for various workloads and machine > configurations. > > > > > Chris > > > > > has seen a ton of testing. I was hoping Johannes would get time to > > > take a look, or Nhat would get time to test it out, but neither of > > > these things happen. > > > > > > I obviously want it to be merged, but hopefully someone will chime in= here :) > > > >